@agent-native/core 0.173.2-nightly-20260825163448 → 0.174.0

package/corpus/README.md

@@ -31,4 +31,4 @@ rg -n "defineAction|useActionQuery" node_modules/@agent-native/core/corpus
 
 ## Generated Counts
 
-- template files: 8611
+- template files: 8614

package/corpus/templates/factory/AGENTS.md

@@ -63,7 +63,7 @@ decisions, feedback, agent runs, and provider audit records.
 | `get-factory-automation-health` | Inspect scheduler heartbeat and last error. |
 | `suggest-factory-rules` | Mine feedback into proposals. |
 | `reconcile-triage-run` | Persist callback/provider reconciliation. |
-| `list-factories` / `get-factory-graph` | Inspect definitions, versions, and metrics. |
+| `list-factories` / `get-factory-graph` / `delete-factory` | Inspect Factory definitions, versions, and metrics, or permanently delete a user-created Factory after exact-name confirmation. A committed delete whose follow-up read cannot confirm the row is gone returns `verified:false`, not a failed deletion. |
 | `create-factory` | Create a factory from `/new-factory` with optional sources. |
 | `save-factory-graph` | Create/version a graph with inspected `expectedGraphVersion`; never starts provider work. |
 | graph history actions | Factory graph version history. |

package/corpus/templates/factory/actions/babysit-agent-native-pull-request.ts

@@ -8,7 +8,9 @@ import { triageItems } from "../server/db/schema.js";
 import { DEFAULT_FACTORY_ID } from "../server/factory-graph/store.js";
 import {
   factoryIdSchema,
+  factoryStillPresent,
   readTriageConfigRow,
+  requireExistingFactory,
 } from "../server/lib/factory-scope.js";
 import { requireFactoryAutomation } from "../server/lib/require-factory-automation.js";
 import {
@@ -68,21 +70,34 @@ async function updateBabysitMetadata(
   const db = getDb();
   const item = (
     await db
-      .select({ metadataJson: triageItems.metadataJson })
+      .select({
+        metadataJson: triageItems.metadataJson,
+        factoryId: triageItems.factoryId,
+      })
       .from(triageItems)
       .where(and(eq(triageItems.id, itemId), eq(triageItems.orgId, orgId)))
       .limit(1)
   )[0];
   if (!item) throw new Error("Factory item disappeared during PR babysitting.");
+  const factoryId = item.factoryId ?? DEFAULT_FACTORY_ID;
   const metadata = parseTriageMetadata(item.metadataJson);
   Object.assign(metadata, patch);
-  await db
-    .update(triageItems)
-    .set({
-      metadataJson: serializeTriageMetadata(metadata),
-      updatedAt: new Date().toISOString(),
-    })
-    .where(and(eq(triageItems.id, itemId), eq(triageItems.orgId, orgId)));
+  await db.transaction(async (tx) => {
+    await tx
+      .update(triageItems)
+      .set({
+        metadataJson: serializeTriageMetadata(metadata),
+        updatedAt: new Date().toISOString(),
+      })
+      .where(
+        and(
+          eq(triageItems.id, itemId),
+          eq(triageItems.orgId, orgId),
+          factoryStillPresent(tx as unknown as typeof db, orgId, factoryId),
+        ),
+      );
+    await requireExistingFactory(tx as unknown as typeof db, orgId, factoryId);
+  });
 }
 
 export default defineAction({

package/corpus/templates/factory/actions/delete-factory.ts

@@ -0,0 +1,174 @@
+import { defineAction } from "@agent-native/core/action";
+import { and, eq } from "drizzle-orm";
+import { z } from "zod";
+
+import { getDb } from "../server/db/index.js";
+import {
+  factoryAuditEvents,
+  factoryComments,
+  factoryDefinitions,
+  factoryGraphVersions,
+  triageConfig,
+  triageDecisions,
+  triageFeedback,
+  triageItems,
+  triageRules,
+  triageRuns,
+} from "../server/db/schema.js";
+import {
+  DEFAULT_FACTORY_ID,
+  readFactoryDefinition,
+} from "../server/factory-graph/store.js";
+import { resolveEnabledAutomationsFromSavedConfig } from "../server/lib/factory-automation-plan.js";
+import {
+  factoryIdSchema,
+  readTriageConfigRow,
+} from "../server/lib/factory-scope.js";
+import {
+  requireWorkspaceMember,
+  workspaceMemberIdentityFromContext,
+} from "../server/lib/require-workspace-member.js";
+import {
+  ensureFactoryAutomations,
+  removeFactoryAutomationResources,
+} from "../server/plugins/factory-scheduler-job.js";
+
+export default defineAction({
+  description:
+    "Permanently delete a user-created Factory and all Factory-owned graph versions, comments, observations, rules, decisions, runs, feedback, audit events, settings, and scheduled automations. The default product-feedback Factory cannot be deleted. Requires the Factory's exact current name as confirmation; provider work already in progress is not cancelled. When the delete commits but the follow-up read cannot confirm the Factory is gone, the action returns ok with verified:false instead of reporting a failed deletion.",
+  schema: z.object({
+    factoryId: factoryIdSchema,
+    confirmName: z.string().trim().min(1).max(120),
+  }),
+  http: { method: "DELETE" },
+  needsApproval: true,
+  run: async ({ factoryId, confirmName }, context) => {
+    const { userEmail, orgId } = await requireWorkspaceMember(
+      workspaceMemberIdentityFromContext(context),
+    );
+    if (factoryId === DEFAULT_FACTORY_ID) {
+      throw new Error("The default Factory cannot be deleted.");
+    }
+
+    const factory = await readFactoryDefinition(orgId, factoryId);
+    if (!factory) throw new Error("Factory not found.");
+    if (confirmName !== factory.name) {
+      throw new Error("Factory name confirmation does not match.");
+    }
+
+    const config = await readTriageConfigRow(getDb(), orgId, factoryId);
+    const enabledNames = resolveEnabledAutomationsFromSavedConfig({
+      pollingEnabled: config?.pollingEnabled ?? 0,
+      githubPollingEnabled: config?.githubPollingEnabled ?? 0,
+      sentryPollingEnabled: config?.sentryPollingEnabled ?? 0,
+      slackChannelId: config?.slackChannelId,
+      repository: config?.repository,
+      sentryOrgSlug: config?.sentryOrgSlug,
+      sentryProjectSlug: config?.sentryProjectSlug,
+    });
+
+    const db = getDb();
+    try {
+      // Remove schedules before SQL so no new run can start; restore both if
+      // either step fails so a partial cleanup cannot disable a surviving Factory.
+      await removeFactoryAutomationResources(orgId, factoryId);
+      await db.transaction(async (tx) => {
+        const deleted = await tx
+          .delete(factoryDefinitions)
+          .where(
+            and(
+              eq(factoryDefinitions.id, factoryId),
+              eq(factoryDefinitions.orgId, orgId),
+              eq(factoryDefinitions.name, confirmName),
+            ),
+          )
+          .returning({ id: factoryDefinitions.id });
+        if (deleted.length === 0) {
+          const existing = (
+            await tx
+              .select({ name: factoryDefinitions.name })
+              .from(factoryDefinitions)
+              .where(
+                and(
+                  eq(factoryDefinitions.id, factoryId),
+                  eq(factoryDefinitions.orgId, orgId),
+                ),
+              )
+              .limit(1)
+          )[0];
+          if (existing) {
+            throw new Error(
+              "Factory changed before deletion. Confirm its current name and try again.",
+            );
+          }
+        }
+
+        const scopedTables = [
+          factoryComments,
+          factoryGraphVersions,
+          factoryAuditEvents,
+          triageFeedback,
+          triageDecisions,
+          triageRuns,
+          triageRules,
+          triageItems,
+          triageConfig,
+        ] as const;
+        for (const table of scopedTables) {
+          await tx
+            .delete(table)
+            .where(and(eq(table.orgId, orgId), eq(table.factoryId, factoryId)));
+        }
+      });
+    } catch (error) {
+      try {
+        await ensureFactoryAutomations(userEmail, orgId, factoryId, {
+          enabledNames,
+        });
+      } catch (repairError) {
+        throw new Error(
+          `Factory deletion failed and its automations could not be restored. Deletion error: ${
+            error instanceof Error ? error.message : String(error)
+          }. Restore error: ${
+            repairError instanceof Error
+              ? repairError.message
+              : String(repairError)
+          }.`,
+        );
+      }
+      throw error;
+    }
+
+    let remaining: Awaited<ReturnType<typeof readFactoryDefinition>>;
+    try {
+      remaining = await readFactoryDefinition(orgId, factoryId);
+    } catch (error) {
+      return {
+        ok: true,
+        factoryId,
+        name: factory.name,
+        verified: false,
+        verificationError:
+          error instanceof Error ? error.message : String(error),
+      };
+    }
+    if (remaining) {
+      try {
+        await ensureFactoryAutomations(userEmail, orgId, factoryId, {
+          enabledNames,
+        });
+      } catch (repairError) {
+        throw new Error(
+          `Factory still exists and its automations could not be restored. Restore error: ${
+            repairError instanceof Error
+              ? repairError.message
+              : String(repairError)
+          }.`,
+        );
+      }
+      throw new Error("Factory deletion could not be verified.");
+    }
+
+    return { ok: true, factoryId, name: factory.name, verified: true };
+  },
+});

package/corpus/templates/factory/actions/govern-agent-native-pull-request.ts

@@ -16,6 +16,7 @@ import {
   orgFactoryRunFilter,
   orgFactoryScopedItemWhere,
   readTriageConfigRow,
+  requireExistingFactory,
 } from "../server/lib/factory-scope.js";
 import { requireFactoryAutomation } from "../server/lib/require-factory-automation.js";
 import {
@@ -343,28 +344,35 @@ export default defineAction({
         itemId,
         snapshot.headSha,
       );
-      await getDb()
-        .insert(triageDecisions)
-        .values({
-          id: decisionId,
-          itemId,
-          ruleId: null,
-          mode: "automation",
-          outcome: governance.autoMerge
-            ? "auto_merge"
-            : governance.autoApprove
-              ? "auto_approve"
-              : "needs_manual",
-          reason: `${reason} ${governance.reason}`.trim(),
-          guardResultsJson: JSON.stringify(governance.guardResults),
-          model: "factory-pr-governance",
-          promptVersion: 1,
-          createdAt: new Date().toISOString(),
-          ownerEmail: userEmail,
+      await getDb().transaction(async (tx) => {
+        await tx
+          .insert(triageDecisions)
+          .values({
+            id: decisionId,
+            itemId,
+            ruleId: null,
+            mode: "automation",
+            outcome: governance.autoMerge
+              ? "auto_merge"
+              : governance.autoApprove
+                ? "auto_approve"
+                : "needs_manual",
+            reason: `${reason} ${governance.reason}`.trim(),
+            guardResultsJson: JSON.stringify(governance.guardResults),
+            model: "factory-pr-governance",
+            promptVersion: 1,
+            createdAt: new Date().toISOString(),
+            ownerEmail: userEmail,
+            orgId,
+            factoryId,
+          })
+          .onConflictDoNothing();
+        await requireExistingFactory(
+          tx as unknown as ReturnType<typeof getDb>,
           orgId,
           factoryId,
-        })
-        .onConflictDoNothing();
+        );
+      });
     }
 
     if (!governance.autoApprove) {

package/corpus/templates/factory/actions/poll-github-sources.ts

@@ -8,6 +8,7 @@ import { repairFactoryAutomationsFromConfig } from "../server/lib/factory-automa
 import {
   factoryIdSchema,
   readTriageConfigRow,
+  requireExistingFactory,
 } from "../server/lib/factory-scope.js";
 import { requireFactoryAutomation } from "../server/lib/require-factory-automation.js";
 import {
@@ -239,6 +240,11 @@ export default defineAction({
           });
         pullRequestCount += 1;
       }
+      await requireExistingFactory(
+        tx as unknown as ReturnType<typeof getDb>,
+        orgId,
+        factoryId,
+      );
     });
 
     if (issues.length === 0 && pullRequests.length === 0) {

package/corpus/templates/factory/actions/poll-sentry-errors.ts

@@ -7,7 +7,9 @@ import { triageConfig, triageItems } from "../server/db/schema.js";
 import { repairFactoryAutomationsFromConfig } from "../server/lib/factory-automation-repair.js";
 import {
   factoryIdSchema,
+  factoryStillPresent,
   readTriageConfigRow,
+  requireExistingFactory,
   triageConfigUpdateRowId,
 } from "../server/lib/factory-scope.js";
 import { requireFactoryAutomation } from "../server/lib/require-factory-automation.js";
@@ -177,8 +179,21 @@ export default defineAction({
           updatedAt: now,
         })
         .where(
-          and(eq(triageConfig.id, configRowId), eq(triageConfig.orgId, orgId)),
+          and(
+            eq(triageConfig.id, configRowId),
+            eq(triageConfig.orgId, orgId),
+            factoryStillPresent(
+              tx as unknown as ReturnType<typeof getDb>,
+              orgId,
+              factoryId,
+            ),
+          ),
         );
+      await requireExistingFactory(
+        tx as unknown as ReturnType<typeof getDb>,
+        orgId,
+        factoryId,
+      );
     });
 
     if (observedIssues.length === 0) {

package/corpus/templates/factory/actions/poll-slack-channel.ts

@@ -7,7 +7,9 @@ import { triageConfig, triageItems } from "../server/db/schema.js";
 import { repairFactoryAutomationsFromConfig } from "../server/lib/factory-automation-repair.js";
 import {
   factoryIdSchema,
+  factoryStillPresent,
   readTriageConfigRow,
+  requireExistingFactory,
   triageConfigUpdateRowId,
 } from "../server/lib/factory-scope.js";
 import { requireFactoryAutomation } from "../server/lib/require-factory-automation.js";
@@ -159,9 +161,19 @@ export default defineAction({
             and(
               eq(triageConfig.id, configRowId),
               eq(triageConfig.orgId, orgId),
+              factoryStillPresent(
+                tx as unknown as ReturnType<typeof getDb>,
+                orgId,
+                factoryId,
+              ),
             ),
           );
       }
+      await requireExistingFactory(
+        tx as unknown as ReturnType<typeof getDb>,
+        orgId,
+        factoryId,
+      );
     });
 
     if (result.envelopes.length === 0) {

package/corpus/templates/factory/actions/start-builder-for-item.ts

@@ -10,10 +10,12 @@ import {
 } from "../server/db/schema.js";
 import {
   DEFAULT_FACTORY_ID,
+  factoryStillPresent,
   orgFactoryItemFilter,
   orgFactoryRunFilter,
+  readTriageConfigRow,
+  requireExistingFactory,
 } from "../server/lib/factory-scope.js";
-import { readTriageConfigRow } from "../server/lib/factory-scope.js";
 import { requireFactoryAutomation } from "../server/lib/require-factory-automation.js";
 import {
   requireWorkspaceMember,
@@ -28,7 +30,10 @@ import {
   serializeTriageMetadata,
 } from "../server/triage/metadata.js";
 import { detectOwnerOwnedArea } from "../server/triage/pr-policy.js";
-import { createSlackReader } from "../server/triage/slack-client.js";
+import {
+  createSlackReader,
+  isAgentNativeSlackUserName,
+} from "../server/triage/slack-client.js";
 
 /** Slack notifies only with `<@USERID>`. Plaintext @handles do not ping anyone. */
 const REPLY_INSTRUCTION =
@@ -421,10 +426,23 @@ export default defineAction({
       },
     );
     if (blocked) {
-      await db
-        .update(triageItems)
-        .set({ status: "needs_manual", updatedAt: new Date().toISOString() })
-        .where(and(eq(triageItems.id, itemId), eq(triageItems.orgId, orgId)));
+      await db.transaction(async (tx) => {
+        await tx
+          .update(triageItems)
+          .set({ status: "needs_manual", updatedAt: new Date().toISOString() })
+          .where(
+            and(
+              eq(triageItems.id, itemId),
+              eq(triageItems.orgId, orgId),
+              factoryStillPresent(tx as unknown as typeof db, orgId, factoryId),
+            ),
+          );
+        await requireExistingFactory(
+          tx as unknown as typeof db,
+          orgId,
+          factoryId,
+        );
+      });
       return {
         ok: true,
         started: false,
@@ -459,44 +477,57 @@ export default defineAction({
       };
     }
 
-    if (retryableSlackRun) {
-      await db
-        .update(triageRuns)
-        .set({
+    await db.transaction(async (tx) => {
+      if (retryableSlackRun) {
+        await tx
+          .update(triageRuns)
+          .set({
+            status: "submitted",
+            error: null,
+            completedAt: null,
+            heartbeatAt: now,
+            dispatchAttempts: (existing.dispatchAttempts ?? 0) + 1,
+          })
+          .where(
+            and(
+              eq(triageRuns.id, runId),
+              eq(triageRuns.orgId, orgId),
+              factoryStillPresent(tx as unknown as typeof db, orgId, factoryId),
+            ),
+          );
+      } else {
+        await tx.insert(triageRuns).values({
+          id: runId,
+          itemId,
+          source: item.source,
+          provider: isSlack ? "bot-tag" : "builder-http",
+          dedupeKey,
+          approvalEmail: null,
           status: "submitted",
-          error: null,
-          completedAt: null,
+          progressLogJson: JSON.stringify([
+            {
+              at: now,
+              state: "submitted",
+              reason: `Factory automation ${context?.automation?.triggerName ?? "unknown"} recorded a clear bug.`,
+            },
+          ]),
+          dispatchAttempts: 1,
+          needsContinuation: 0,
+          startedAt: now,
           heartbeatAt: now,
-          dispatchAttempts: (existing.dispatchAttempts ?? 0) + 1,
-        })
-        .where(and(eq(triageRuns.id, runId), eq(triageRuns.orgId, orgId)));
-    } else {
-      await db.insert(triageRuns).values({
-        id: runId,
-        itemId,
-        source: item.source,
-        provider: isSlack ? "bot-tag" : "builder-http",
-        dedupeKey,
-        approvalEmail: null,
-        status: "submitted",
-        progressLogJson: JSON.stringify([
-          {
-            at: now,
-            state: "submitted",
-            reason: `Factory automation ${context?.automation?.triggerName ?? "unknown"} recorded a clear bug.`,
-          },
-        ]),
-        dispatchAttempts: 1,
-        needsContinuation: 0,
-        startedAt: now,
-        heartbeatAt: now,
-        completedAt: null,
-        error: null,
-        ownerEmail: item.ownerEmail,
+          completedAt: null,
+          error: null,
+          ownerEmail: item.ownerEmail,
+          orgId,
+          factoryId: item.factoryId ?? DEFAULT_FACTORY_ID,
+        });
+      }
+      await requireExistingFactory(
+        tx as unknown as typeof db,
         orgId,
-        factoryId: item.factoryId ?? DEFAULT_FACTORY_ID,
-      });
-    }
+        factoryId,
+      );
+    });
 
     try {
       if (isSlack) {
@@ -603,7 +634,8 @@ export default defineAction({
           const hasAgentNativeDisposition = feedbackThread.messages.some(
             (message) =>
               (message.user === agentNative.userId ||
-                message.username?.trim().toLowerCase() === "agent-native") &&
+                (message.username != null &&
+                  isAgentNativeSlackUserName(message.username))) &&
               /^(Fixed|In progress|Clarification needed):/i.test(
                 message.text.trim(),
               ),