@agent-native/core 0.164.15 → 0.164.18

package/corpus/templates/content/package.json

@@ -35,6 +35,7 @@
     "@tiptap/core": "catalog:",
     "@tiptap/extension-blockquote": "catalog:",
     "@tiptap/extension-bubble-menu": "catalog:",
+    "@tiptap/extension-code": "3.30.1",
     "@tiptap/extension-code-block-lowlight": "catalog:",
     "@tiptap/extension-collaboration": "catalog:",
     "@tiptap/extension-collaboration-caret": "catalog:",

package/corpus/templates/content/shared/nfm.ts

@@ -363,8 +363,13 @@ function serializeInlineNode(node: PMNode): string {
     const a = span?.attrs || {};
     const underlined =
       a.underline === "true" || a.underline === true || plainUnderline;
+    const foregroundColor =
+      isColor(a.color) && !a.color.endsWith("_bg") ? a.color : null;
+    const backgroundColor =
+      isColor(a.bgColor) && a.bgColor.endsWith("_bg") ? a.bgColor : null;
     const attrStr = serializeAttrs([
-      ["color", a.color || a.bgColor || null],
+      ["color", foregroundColor || backgroundColor],
+      ["bg_color", foregroundColor ? backgroundColor : null],
       ["underline", underlined ? "true" : null],
     ]);
     if (attrStr) out = `<span${attrStr}>${out}</span>`;
@@ -397,9 +402,15 @@ function addMark(nodes: PMNode[], mark: PMMark): void {
 function mergeSpanMark(nodes: PMNode[], attrs: Record<string, string>): void {
   const color = attrs.color;
   const isBg = color ? color.endsWith("_bg") : false;
+  const explicitBackground = attrs.bg_color;
   const spanAttrs: Record<string, any> = {
-    color: color && !isBg ? color : null,
-    bgColor: color && isBg ? color : null,
+    color: isColor(color) && !isBg ? color : null,
+    bgColor:
+      isColor(explicitBackground) && explicitBackground.endsWith("_bg")
+        ? explicitBackground
+        : isColor(color) && isBg
+          ? color
+          : null,
     underline: attrs.underline === "true" ? "true" : null,
     href: attrs.href || null,
     attrsJson: "{}",

package/corpus/templates/factory/AGENTS.md

@@ -21,21 +21,22 @@ decisions, feedback, agent runs, and provider audit records.
   reconciliation is not success; preserve typed failure or
   `reconciliation_required` state.
 - Deduplicate by Factory item and rule/run identity, not provider comment ID.
-- Use the generic Slack adapter: clear-bug automations add 👀 and tag
-  `@builder.io`, ask Builder to run `/address-feedback`, and group repeated
-  reports into one Builder thread; GitHub/Sentry clear bugs use the Builder run
-  API. Clips, Design, and Content stay owner-managed outside autonomous
-  dispatch and PR governance.
-- PR governance follows `review-prs`: verify current BuilderIO membership and
-  the complete diff/review/check evidence, never approve external or
-  unverified authors, and keep ultra-scary security, auth, tenant-isolation,
-  secrets, data-loss, execution, payment, and deployment risks manual. The
-  verified internal-author evidence does not waive ordinary failed or
-  unresolved checks or feedback; those gates remain required and their exact
-  states must stay visible. It never waives membership or the ultra-scary
-  gate.
-  Product/UX ownership still needs the verified owner, with the documented Sid
-  exception. Auto-merge also requires a verified Factory Builder run.
+- Slack clear bugs go through `start-builder-for-item` (👀 and a Slack user
+  mention for `/address-feedback`); never post Slack messages or `@handles`.
+  Group repeats into one Builder thread. GitHub/Sentry use the Builder run
+  API. Follow `review-latest-feedback` for full-thread evidence, existing
+  reaction and owner checks, answered-clarification priority, one-question
+  clarification limits, durable rechecks, and the required `@agent-native`
+  disposition after every actionable 👀. Clips, Design, and Content stay
+  owner-managed outside autonomous dispatch and PR governance.
+- PR governance follows `review-prs`: verify BuilderIO membership and complete
+  diff/review/check evidence; skip drafts/current approvals and never approve
+  external authors. Keep ultra-scary security, auth, tenant-isolation,
+  secrets, data-loss, execution, payment, and deployment risks manual.
+  Verified members may pass ordinary uncertain checks or review feedback, but
+  record exact states and never call them clean. Apply the Alice/Content,
+  Nick/Slides, Enzo/Factory, Sid/Design, and docs-only exceptions only after
+  membership and the ultra-scary gate. Never auto-merge.
 - Graph edits create immutable blueprint versions. AI proposes with `source=ai`;
   a person reviews and publishes through the same action surface.
 - Provider credentials belong to Dispatch/shared workspace integrations, never
@@ -45,10 +46,10 @@ decisions, feedback, agent runs, and provider audit records.
 
 ## Application state
 
-- `navigation.view` is `factory` or `agents`; `factoryId`, `factoryTab`,
-  `factoryAuditRunId`, `factoryNodeId`, and `factoryEdgeId` hold the selected
-  Factory context. Read `view-screen` before explaining a route, changing the
-  selected Factory, or answering about the `/agents` inventory.
+- `navigation.view` is `factory`, `agents`, or `factory-settings`.
+  Observation settings are workspace-scoped at `/factory-settings`.
+  `factoryId`, `factoryTab`, `factoryAuditRunId`, `factoryNodeId`, and
+  `factoryEdgeId` hold Factory context. Read `view-screen` first.
 
 ## Action contract
 
@@ -80,17 +81,11 @@ decisions, feedback, agent runs, and provider audit records.
 | `import-agent` / `import-agent-pack` / `list-agent-pack` | Import profiles or agent packs. |
 | `start-workspace-app-creation` | Promote an agent and its pack into an app handoff. |
 
-Rules start in shadow mode; hard guards always apply. Organization automations
-execute stored prompts, and every external mutation needs a durable run,
-idempotency key, and provider confirmation. The legacy observer ends once org
-automations are seeded. Use the visual editor for graph changes and agent chat
+Rules start in shadow mode; hard guards apply. Organization automations use
+stored prompts; external mutations require durable, idempotent runs and
+provider confirmation. Use the visual editor for graph changes and agent chat
 for proposals; persist complete graphs with `save-factory-graph`. Change rules
-through triage rule actions, never graph JSON.
-
-The Slack, GitHub, and Sentry pollers are bounded ingestion adapters for the
-legacy default triage queue. They do not define the complete tool surface.
-Interactive and scheduled agents may discover additional connected provider or
-MCP tools through the shared workspace context.
+through triage actions, never graph JSON.
 
 ## Source Changes
 

package/corpus/templates/factory/actions/get-slack-feedback-context.ts

@@ -2,7 +2,6 @@ import { defineAction } from "@agent-native/core/action";
 import { and, eq } from "drizzle-orm";
 import { z } from "zod";
 
-import type { SlackMessage } from "../server/connectors/slack.js";
 import { getDb } from "../server/db/index.js";
 import { triageConfig, triageItems } from "../server/db/schema.js";
 import {
@@ -12,8 +11,6 @@ import {
 import { recordFactoryAudit } from "../server/triage/audit.js";
 import { createSlackReader } from "../server/triage/slack-client.js";
 
-const MAX_THREAD_PAGES = 5;
-
 export default defineAction({
   description:
     "Read the bounded full Slack thread for one Factory feedback item. Use this before deciding whether a report is a clear bug; unreadable or truncated context is not a green light.",
@@ -46,31 +43,11 @@ export default defineAction({
     const workspace =
       config?.slackWorkspace === "secondary" ? "secondary" : "primary";
     const slack = createSlackReader({ ownerEmail: userEmail, orgId });
-    const messages: SlackMessage[] = [];
-    let cursor: string | undefined;
-    let hasMore = false;
-    for (let page = 0; page < MAX_THREAD_PAGES; page += 1) {
-      const result = await slack.getThread(
-        workspace,
-        item.channelId,
-        item.threadTs,
-        100,
-        cursor,
-      );
-      messages.push(...result.messages);
-      if (result.has_more && !result.next_cursor) {
-        throw new Error(
-          "Slack thread pagination is incomplete because the provider omitted its next cursor.",
-        );
-      }
-      if (!result.has_more) {
-        hasMore = false;
-        break;
-      }
-      hasMore = page === MAX_THREAD_PAGES - 1;
-      if (hasMore) break;
-      cursor = result.next_cursor;
-    }
+    const { messages, hasMore } = await slack.getCompleteThread(
+      workspace,
+      item.channelId,
+      item.threadTs,
+    );
 
     await recordFactoryAudit(
       context,
@@ -100,10 +77,13 @@ export default defineAction({
       coverage: hasMore ? "partial" : "complete",
       messages: messages.map((message) => ({
         user: message.user ?? message.username ?? message.bot_id ?? null,
+        username: message.username ?? null,
+        botId: message.bot_id ?? null,
         text: message.text,
         ts: message.ts,
         threadTs: message.thread_ts ?? item.threadTs,
         replyCount: message.reply_count ?? 0,
+        reactions: message.reactions ?? [],
       })),
     };
   },

package/corpus/templates/factory/actions/get-triage-config.ts

@@ -33,6 +33,7 @@ export default defineAction({
         slackWorkspace: "primary",
         slackChannelId: null,
         slackChannelName: null,
+        builderSlackUserId: null,
         pollingEnabled: false,
         lastSlackTs: null,
         slackHistoryCursor: null,

package/corpus/templates/factory/actions/govern-agent-native-pull-request.ts

@@ -24,7 +24,10 @@ import {
   serializeTriageMetadata,
 } from "../server/triage/metadata.js";
 import { reconcileBabysitState } from "../server/triage/pr-babysit.js";
-import { decidePullRequestGovernance } from "../server/triage/pr-policy.js";
+import {
+  decidePullRequestGovernance,
+  hasCurrentPullRequestApproval,
+} from "../server/triage/pr-policy.js";
 
 function repositoryRef(value: string): { owner: string; repo: string } {
   const match = /^([^/\s]+)\/([^/\s]+)$/.exec(value.trim());
@@ -103,7 +106,7 @@ async function hasVerifiedFactoryRun(input: {
 
 export default defineAction({
   description:
-    "Govern one agent-native pull request after fetching bounded GitHub and ai-services evidence. Auto-approve only clear internal bug fixes with clean CI and handled review feedback; auto-merge only the verified Factory Builder flow. Clips, Design, and Content are always owner-managed.",
+    "Govern one agent-native pull request after fetching bounded GitHub and ai-services evidence. Auto-approve only under the current review-prs membership, owner, evidence, and ultra-scary gates. Never auto-merge. Clips, Design, and Content feedback remains owner-managed while their verified PR-owner exceptions still apply.",
   schema: z.object({
     repo: z.string().trim().min(1).max(256),
     pullRequestNumber: z.number().int().positive(),
@@ -167,6 +170,24 @@ export default defineAction({
       repository,
       pullRequestNumber,
     );
+    if (pullRequest.state !== "open" || pullRequest.draft) {
+      if (itemId) {
+        await getDb()
+          .update(triageItems)
+          .set({
+            status: "pr_observed",
+            updatedAt: new Date().toISOString(),
+          })
+          .where(and(eq(triageItems.id, itemId), eq(triageItems.orgId, orgId)));
+      }
+      return {
+        ok: true,
+        action: "skipped",
+        reason: pullRequest.draft
+          ? "Pull request is a draft and is excluded before evidence review."
+          : "Pull request is not open and is excluded before evidence review.",
+      };
+    }
     const privateKey = await resolveConnectorSecret(
       "BUILDER_PRIVATE_KEY",
       userEmail,
@@ -186,6 +207,38 @@ export default defineAction({
         `PR evidence is stale: GitHub reports ${pullRequest.headSha}, ai-services reports ${snapshot.headSha}.`,
       );
     }
+    if (hasCurrentPullRequestApproval(snapshot.reviews)) {
+      await recordFactoryAudit(
+        context,
+        { userEmail, orgId },
+        {
+          action: "govern-agent-native-pull-request",
+          kind: "governance",
+          status: "skipped",
+          itemId: itemId ?? null,
+          source: "github",
+          sourceUrl: pullRequest.htmlUrl,
+          summary:
+            "Skipped the pull request because it already has a current non-dismissed approval.",
+          details: { repo, pullRequestNumber },
+        },
+      );
+      if (itemId) {
+        await getDb()
+          .update(triageItems)
+          .set({
+            status: "pr_observed",
+            updatedAt: new Date().toISOString(),
+          })
+          .where(and(eq(triageItems.id, itemId), eq(triageItems.orgId, orgId)));
+      }
+      return {
+        ok: true,
+        action: "skipped",
+        reason:
+          "Pull request already has a current non-dismissed approval; no duplicate review was created.",
+      };
+    }
 
     const checksPassed =
       snapshot.coverage === "complete" &&
@@ -254,6 +307,7 @@ export default defineAction({
           reviewFeedbackHandled,
           autoApprove: governance.autoApprove,
           autoMerge: governance.autoMerge,
+          ownerException: governance.ownerException,
           ownerOwnedArea: governance.ownerOwnedArea ?? null,
           guardResults: governance.guardResults,
         },
@@ -341,7 +395,9 @@ export default defineAction({
         const approval = await github.approvePullRequest(
           repository,
           pullRequestNumber,
-          "Factory auto-approved: clear internal bug fix with passing CI and handled review feedback.",
+          governance.ownerException
+            ? `Factory auto-approved under the verified ${governance.ownerException} owner exception; ordinary check and review states remain recorded.`
+            : "Factory auto-approved under verified BuilderIO membership; ordinary check and review states remain recorded.",
         );
         approvalUrl = approval.htmlUrl;
         metadata.autoApprovedAt = new Date().toISOString();
@@ -361,61 +417,13 @@ export default defineAction({
         await github.approvePullRequest(
           repository,
           pullRequestNumber,
-          "Factory auto-approved: clear internal bug fix with passing CI and handled review feedback.",
+          governance.ownerException
+            ? `Factory auto-approved under the verified ${governance.ownerException} owner exception; ordinary check and review states remain recorded.`
+            : "Factory auto-approved under verified BuilderIO membership; ordinary check and review states remain recorded.",
         )
       ).htmlUrl;
     }
 
-    if (!governance.autoMerge) {
-      await recordFactoryAudit(
-        context,
-        { userEmail, orgId },
-        {
-          action: "govern-agent-native-pull-request",
-          kind: "external_action",
-          itemId: itemId ?? null,
-          source: "github",
-          sourceUrl: approvalUrl,
-          summary: "Approved the pull request after governance checks passed.",
-          details: { repo, pullRequestNumber, approvalUrl },
-        },
-      );
-      return {
-        ok: true,
-        action: "approved",
-        approvalUrl,
-        checksPassed,
-        reviewFeedbackHandled,
-      };
-    }
-
-    const merge = await github.mergePullRequest(
-      repository,
-      pullRequestNumber,
-      `Merge Factory bug fix #${pullRequestNumber}`,
-      snapshot.headSha,
-    );
-    if (itemId) {
-      const item = (
-        await getDb()
-          .select({ metadataJson: triageItems.metadataJson })
-          .from(triageItems)
-          .where(and(eq(triageItems.id, itemId), eq(triageItems.orgId, orgId)))
-          .limit(1)
-      )[0];
-      if (!item) throw new Error("Factory item disappeared after PR merge.");
-      const metadata = parseTriageMetadata(item.metadataJson);
-      metadata.autoMergedAt = new Date().toISOString();
-      metadata.mergeSha = merge.sha;
-      await getDb()
-        .update(triageItems)
-        .set({
-          metadataJson: serializeTriageMetadata(metadata),
-          status: "merged",
-          updatedAt: new Date().toISOString(),
-        })
-        .where(and(eq(triageItems.id, itemId), eq(triageItems.orgId, orgId)));
-    }
     await recordFactoryAudit(
       context,
       { userEmail, orgId },
@@ -424,16 +432,16 @@ export default defineAction({
         kind: "external_action",
         itemId: itemId ?? null,
         source: "github",
-        sourceUrl: pullRequest.htmlUrl,
-        summary: "Merged the pull request after governance checks passed.",
-        details: { repo, pullRequestNumber, approvalUrl, mergeSha: merge.sha },
+        sourceUrl: approvalUrl,
+        summary:
+          "Approved the pull request under the current review-prs policy.",
+        details: { repo, pullRequestNumber, approvalUrl },
       },
     );
     return {
       ok: true,
-      action: "merged",
+      action: "approved",
       approvalUrl,
-      mergeSha: merge.sha,
       checksPassed,
       reviewFeedbackHandled,
     };

package/corpus/templates/factory/actions/list-triage-items.ts

@@ -30,7 +30,12 @@ export default defineAction({
       workspaceMemberIdentityFromContext(context),
     );
     const db = getDb();
-    const reviewStatuses = source === "github" ? ["pr_observed"] : ["received"];
+    const reviewStatuses =
+      source === "github"
+        ? ["pr_observed"]
+        : source === "slack"
+          ? ["received", "automation_started", "evidence_ready"]
+          : ["received"];
     const items = await db
       .select()
       .from(triageItems)

package/corpus/templates/factory/actions/reconcile-triage-run.ts

@@ -20,7 +20,13 @@ import {
 
 const reviewSchema = z.object({
   author: z.string(),
-  state: z.enum(["approved", "changes_requested", "commented", "pending"]),
+  state: z.enum([
+    "approved",
+    "changes_requested",
+    "commented",
+    "pending",
+    "dismissed",
+  ]),
   observedAt: z.string().datetime(),
 });
 const checkSchema = z.object({

package/corpus/templates/factory/actions/save-triage-config.ts

@@ -13,11 +13,19 @@ const workspaceSchema = z.enum(["primary", "secondary"]);
 
 export default defineAction({
   description:
-    "Save Factory automation alert settings. Provider credentials live in shared workspace integrations; legacy source routing metadata is preserved for the default observer adapters.",
+    "Save Factory observation and automation alert settings. Provider credentials live in shared workspace integrations; source routing metadata including the Builder Slack member id is stored on Factory config.",
   schema: z.object({
     slackWorkspace: workspaceSchema.optional(),
-    slackChannelId: z.string().trim().min(1).max(128).optional(),
+    slackChannelId: z.string().trim().max(128).optional(),
     slackChannelName: z.string().trim().max(200).optional(),
+    builderSlackUserId: z
+      .string()
+      .trim()
+      .max(32)
+      .refine((value) => value === "" || /^[UW][A-Z0-9]+$/i.test(value), {
+        message: "Builder Slack member id must look like U01234567.",
+      })
+      .optional(),
     pollingEnabled: z.boolean().optional(),
     githubPollingEnabled: z.boolean().optional(),
     sentryPollingEnabled: z.boolean().optional(),
@@ -26,7 +34,9 @@ export default defineAction({
     sentryEnvironment: z.string().trim().max(200).optional(),
     repository: z.string().trim().max(256).optional(),
     automationFailureAlertsEnabled: z.boolean().optional(),
-    automationFailureAlertEmail: z.string().trim().email().optional(),
+    automationFailureAlertEmail: z
+      .union([z.string().trim().email(), z.literal("")])
+      .optional(),
   }),
   http: { method: "POST" },
   run: async (
@@ -34,6 +44,7 @@ export default defineAction({
       slackWorkspace,
       slackChannelId,
       slackChannelName,
+      builderSlackUserId,
       pollingEnabled,
       githubPollingEnabled,
       sentryPollingEnabled,
@@ -72,6 +83,12 @@ export default defineAction({
       slackChannelName,
       existing?.slackChannelName,
     );
+    const persistedBuilderSlackUserId = persistText(
+      builderSlackUserId === undefined
+        ? undefined
+        : builderSlackUserId.toUpperCase(),
+      existing?.builderSlackUserId,
+    );
     const persistedRepository = persistText(repository, existing?.repository);
     const persistedSentryOrgSlug = persistText(
       sentryOrgSlug,
@@ -109,10 +126,10 @@ export default defineAction({
         : automationFailureAlertsEnabled
           ? 1
           : 0;
-    const persistedAutomationFailureAlertEmail =
-      automationFailureAlertEmail ??
-      existing?.automationFailureAlertEmail ??
-      null;
+    const persistedAutomationFailureAlertEmail = persistText(
+      automationFailureAlertEmail,
+      existing?.automationFailureAlertEmail,
+    );
     await db
       .insert(triageConfig)
       .values({
@@ -120,6 +137,7 @@ export default defineAction({
         slackWorkspace: persistedSlackWorkspace,
         slackChannelId: persistedSlackChannelId,
         slackChannelName: persistedSlackChannelName,
+        builderSlackUserId: persistedBuilderSlackUserId,
         pollingEnabled: persistedPollingEnabled,
         githubPollingEnabled: persistedGithubPollingEnabled,
         sentryPollingEnabled: persistedSentryPollingEnabled,
@@ -140,6 +158,7 @@ export default defineAction({
           slackWorkspace: persistedSlackWorkspace,
           slackChannelId: persistedSlackChannelId,
           slackChannelName: persistedSlackChannelName,
+          builderSlackUserId: persistedBuilderSlackUserId,
           pollingEnabled: persistedPollingEnabled,
           githubPollingEnabled: persistedGithubPollingEnabled,
           sentryPollingEnabled: persistedSentryPollingEnabled,
@@ -160,6 +179,7 @@ export default defineAction({
       githubPollingEnabled: persistedGithubPollingEnabled === 1,
       sentryPollingEnabled: persistedSentryPollingEnabled === 1,
       slackChannelId: persistedSlackChannelId,
+      builderSlackUserId: persistedBuilderSlackUserId,
       automationFailureAlertsEnabled:
         persistedAutomationFailureAlertsEnabled === 1,
       automationFailureAlertEmail: persistedAutomationFailureAlertEmail,