@agent-native/core 0.164.12 → 0.164.17

package/corpus/templates/factory/server/plugins/factory-scheduler-job.ts

@@ -16,6 +16,15 @@ import { and, eq, isNull, lt, ne, or } from "drizzle-orm";
 
 import { getDb } from "../db/index.js";
 import { triageConfig } from "../db/schema.js";
+import {
+  repairSlackFeedbackPrompt,
+  SLACK_HANDOFF_INSTRUCTION,
+  SLACK_MENTION_GUARD,
+} from "../lib/slack-feedback-prompt.js";
+import {
+  syncManagedReviewSkillAlignment,
+  type FactoryAutomationName,
+} from "../triage/review-skill-alignment.js";
 
 const LEGACY_JOB_PATH = "jobs/factory-observation-scheduler.md";
 const DEFAULT_SLACK_CHANNEL_ID = "C0ATH3CCZT4";
@@ -165,8 +174,7 @@ type AutomationSeed = {
   body: string;
 };
 
-const FACTORY_DEFAULT_MODEL =
-  process.env.FACTORY_AUTOMATION_MODEL?.trim() || "gpt-5.6-luna";
+const FACTORY_DEFAULT_MODEL = "gpt-5.6-luna";
 const FACTORY_DEFAULT_MAX_ITERATIONS = 32;
 const FACTORY_DEFAULT_MAX_RUN_INPUT_TOKENS = 1_000_000;
 const SKIP_RECORD_GUARD =
@@ -220,13 +228,9 @@ The action adds 👀 to every grouped Slack thread but posts one Builder reply i
 the representative thread. Do not start one Builder thread per duplicate.
 Separate reports only when their failure modes, surfaces, or owners differ.
 
-The Builder reply must tag @builder.io with the dot and tell it to run
-/address-feedback. It must point Builder to the relevant repository skills,
-the representative source, every related source, and the need to fix the
-underlying boundary across the whole cluster. Never add the reaction or tag
-Builder for owner-managed Clips, Design, or Content work, or for a non-bug
-report.
-After classifying each processed item, call start-builder-for-item with clearBug true or false and a short evidence-grounded reason so the skip or dispatch is recorded.
+${SLACK_HANDOFF_INSTRUCTION}
+${SKIP_RECORD_GUARD}
+${SLACK_MENTION_GUARD}
 
 Keep each run bounded. Preserve action errors and do not claim a Builder reply,
 PR, merge, or fix unless an action returned that state.
@@ -322,21 +326,23 @@ clear bug fix or has product or UX implications. Avoid duplicate review noise
 when no commit, review, comment, or check result changed. Call
 govern-agent-native-pull-request with the item id, repository, pull request
 number, clearBug, productUxImplications, and a short reason. The action fetches
-fresh CI and review evidence before approving or merging. For a verified
-current BuilderIO member, the internal-author exception means ordinary failed,
-pending, skipped, or unknown checks and unresolved ordinary feedback do not by
-themselves block approval; record their exact states and never call them clean.
-The exception does not waive membership, ownership, or the ultra-scary gate.
-
-Only auto-merge when the PR proves its Factory origin by retaining the Factory
-item id or source link in the PR description, or by using the Factory branch
-name. A normal open PR must never be treated as a Builder-triggered run.
-
-Never auto-approve or auto-merge Clips, Design, or Content PRs. Those apps are
-fully owned by their product owners. Auto-merge is limited to PRs with a
-verified Factory Builder run; all other PRs can at most pass the approval
-policy. Do not call GitHub write actions directly or claim a merge unless the
-governance action confirms it.
+fresh CI and review evidence before approving. For a verified current BuilderIO
+member, the internal-author exception means ordinary failed, pending, skipped,
+or unknown checks and unresolved ordinary feedback do not by themselves block
+approval; record their exact states and never call them clean. Apply the
+verified Alice/Content, Nick/Slides, Enzo/Factory-specific, Sid/Design, and
+docs-only owner exceptions from review-prs only after membership and an
+explicit ultra-scary assessment. Those exceptions do not waive membership,
+external-author, or ultra-scary gates.
+
+Never auto-merge. Approval is the only GitHub write this workflow may request;
+a normal open PR must never be treated as a Builder-triggered run.
+
+Never auto-dispatch Clips, Design, or Content feedback. Those apps remain
+fully owned by their product owners for feedback work, while the verified
+PR-owner exceptions still apply to their own scoped PRs. Do not call GitHub
+write actions directly or claim an approval unless the governance action
+confirms it.
 `,
   },
   {
@@ -439,6 +445,10 @@ function automationContent(
   orgId: string,
   seed: AutomationSeed,
 ): string {
+  const body = syncManagedReviewSkillAlignment(
+    seed.body.trim(),
+    seed.name as FactoryAutomationName,
+  );
   return `---
 schedule: "${seed.schedule}"
 ${seed.timezone ? `timezone: ${seed.timezone}\n` : ""}enabled: true
@@ -452,7 +462,7 @@ model: ${seed.model}
 maxIterations: ${seed.maxIterations}
 maxRunInputTokens: ${seed.maxRunInputTokens}
 ---
-${seed.body.trim()}
+${body.trim()}
 `;
 }
 
@@ -535,6 +545,13 @@ async function ensureOrganizationAutomations(
       ) {
         repaired = `${repaired.trimEnd()}\n\n${SKIP_RECORD_GUARD}\n`;
       }
+      repaired = syncManagedReviewSkillAlignment(
+        repaired,
+        seed.name as FactoryAutomationName,
+      );
+      if (seed.name === "factory-slack-feedback") {
+        repaired = repairSlackFeedbackPrompt(repaired);
+      }
       if (repaired === existing.content) return;
 
       const updated = await resourcePutIfCurrent({
@@ -579,6 +596,7 @@ async function ensureDefaultTriageConfig(
     slackWorkspace: "primary",
     slackChannelId: DEFAULT_SLACK_CHANNEL_ID,
     slackChannelName: DEFAULT_SLACK_CHANNEL_NAME,
+    builderSlackUserId: null,
     pollingEnabled: 1,
     githubPollingEnabled: defaultGithubPollingEnabled(),
     sentryPollingEnabled: 0,

package/corpus/templates/factory/server/triage/ai-services-git.ts

@@ -173,6 +173,8 @@ function normalizeReviewState(
       return "changes_requested";
     case "PENDING":
       return "pending";
+    case "DISMISSED":
+      return "dismissed";
     default:
       return "commented";
   }

package/corpus/templates/factory/server/triage/pr-monitor.ts

@@ -4,7 +4,8 @@ export type PullRequestReviewState =
   | "approved"
   | "changes_requested"
   | "commented"
-  | "pending";
+  | "pending"
+  | "dismissed";
 
 export interface PullRequestReviewObservation {
   author: string;

package/corpus/templates/factory/server/triage/pr-policy.ts

@@ -2,6 +2,13 @@ import type { GuardResult } from "./contracts.js";
 
 export type OwnerOwnedArea = "clips" | "design" | "content";
 
+export type PullRequestOwnerException =
+  | "alice-content"
+  | "nick-slides"
+  | "enzo-factory"
+  | "sid-design"
+  | "docs-only";
+
 export interface PullRequestGovernanceInput {
   author: string;
   repository: string;
@@ -19,6 +26,7 @@ export interface PullRequestGovernanceInput {
 
 export interface PullRequestGovernanceDecision {
   ownerOwnedArea: OwnerOwnedArea | null;
+  ownerException: PullRequestOwnerException | null;
   autoApprove: boolean;
   autoMerge: boolean;
   reason: string;
@@ -69,6 +77,11 @@ export function decidePullRequestGovernance(
     input.summary,
     ...input.changedFiles,
   ]);
+  const ultraScary = isUltraScaryChange(input.changedFiles);
+  const ownerException = detectPullRequestOwnerException(input);
+  const verifiedOwnerException =
+    input.internalBuilderMember && !ultraScary ? ownerException : null;
+  const internalEvidenceException = input.internalBuilderMember;
   const gates: GuardResult[] = [
     {
       code: "identity",
@@ -79,17 +92,27 @@ export function decidePullRequestGovernance(
     },
     {
       code: "unknown_change",
-      passed: input.clearBug,
-      reason: input.clearBug
-        ? "The automation classified this as a clear bug with a concrete failure signal."
-        : "The automation did not establish a clear bug; product requests and guesses stay manual.",
+      passed: input.clearBug || verifiedOwnerException !== null,
+      reason:
+        input.clearBug || verifiedOwnerException !== null
+          ? "The automation classified this as a clear bug with a concrete failure signal."
+          : "The automation did not establish a clear bug; product requests and guesses stay manual.",
     },
     {
       code: "security",
-      passed: input.checksPassed,
+      passed: !ultraScary,
+      reason: ultraScary
+        ? "Security-sensitive auth, tenant-isolation, execution, payment, or deployment changes always require manual review."
+        : "The changed paths do not match the ultra-scary manual-review categories.",
+    },
+    {
+      code: "security",
+      passed: internalEvidenceException || input.checksPassed,
       reason: input.checksPassed
         ? "All observed CI checks passed."
-        : "CI is failing, cancelled, pending, or unavailable.",
+        : internalEvidenceException
+          ? "CI is failing, cancelled, pending, or unavailable; the verified internal-author exception does not treat that state as clean."
+          : "CI is failing, cancelled, pending, or unavailable.",
     },
     {
       code: "unknown_change",
@@ -100,21 +123,26 @@ export function decidePullRequestGovernance(
     },
     {
       code: "unknown_change",
-      passed: input.reviewFeedbackHandled,
+      passed: internalEvidenceException || input.reviewFeedbackHandled,
       reason: input.reviewFeedbackHandled
         ? "All observed review feedback is fixed, resolved, replied to, or outdated."
-        : "Review feedback is unanswered, unresolved, truncated, or otherwise unknown.",
+        : internalEvidenceException
+          ? "Review feedback is unanswered, unresolved, truncated, or otherwise unknown; the verified internal-author exception does not treat that state as clean."
+          : "Review feedback is unanswered, unresolved, truncated, or otherwise unknown.",
     },
   ];
 
-  if (ownerOwnedArea) {
+  if (
+    ownerOwnedArea &&
+    !ownerExceptionCoversArea(verifiedOwnerException, ownerOwnedArea)
+  ) {
     gates.push({
       code: "owner_owned",
       passed: false,
       reason: `${ownerOwnedArea} is owner-managed and is never auto-approved, auto-merged, or dispatched by this Factory.`,
     });
   }
-  if (input.productUxImplications) {
+  if (input.productUxImplications && verifiedOwnerException === null) {
     gates.push({
       code: "unknown_change",
       passed: false,
@@ -124,21 +152,171 @@ export function decidePullRequestGovernance(
 
   const baseEligible = gates.every((gate) => gate.passed);
   const autoApprove = baseEligible;
-  const autoMerge = baseEligible && input.factoryTriggered;
-  const reason = autoMerge
-    ? "Clear internal bug fix, all CI and review gates are clean, and the PR came from the Factory Builder flow."
-    : autoApprove
-      ? "Clear internal bug fix with clean CI and review gates; approval is safe to automate."
-      : gates
-          .filter((gate) => !gate.passed)
-          .map((gate) => gate.reason)
-          .join(" ");
+  const autoMerge = false;
+  const reason = autoApprove
+    ? verifiedOwnerException
+      ? `Verified ${verifiedOwnerException} owner exception; approval is safe to automate while ordinary check and review states remain recorded.`
+      : "Clear internal bug fix with verified membership; approval is safe to automate while ordinary check and review states remain recorded."
+    : gates
+        .filter((gate) => !gate.passed)
+        .map((gate) => gate.reason)
+        .join(" ");
 
   return {
     ownerOwnedArea,
+    ownerException: verifiedOwnerException,
     autoApprove,
     autoMerge,
     reason,
     guardResults: gates,
   };
 }
+
+export function detectPullRequestOwnerException(
+  input: Pick<PullRequestGovernanceInput, "author" | "changedFiles">,
+): PullRequestOwnerException | null {
+  const author = input.author.trim().toLowerCase();
+  const changedFiles = input.changedFiles.map(normalizePath);
+
+  if (author === "3mdistal" && isAppScoped(changedFiles, "content", true)) {
+    return "alice-content";
+  }
+  if (author === "nkoech123" && isAppScoped(changedFiles, "slides", true)) {
+    return "nick-slides";
+  }
+  if (author === "enzoames" && isFactoryScoped(changedFiles)) {
+    return "enzo-factory";
+  }
+  if (author === "sidmohanty11" && isAppScoped(changedFiles, "design", true)) {
+    return "sid-design";
+  }
+  if (
+    (author === "kapunahelewong" || author === "bwreid") &&
+    isDocsOnly(changedFiles)
+  ) {
+    return "docs-only";
+  }
+  return null;
+}
+
+export function hasCurrentPullRequestApproval(
+  reviews: readonly {
+    author: string;
+    state: string;
+    observedAt: string;
+  }[],
+): boolean {
+  const latestByAuthor = new Map<
+    string,
+    { state: string; observedAt: string; order: number }
+  >();
+  reviews.forEach((review, order) => {
+    const author = review.author.trim().toLowerCase();
+    if (!author) return;
+    const previous = latestByAuthor.get(author);
+    if (
+      !previous ||
+      Date.parse(review.observedAt) > Date.parse(previous.observedAt) ||
+      (review.observedAt === previous.observedAt && order > previous.order)
+    ) {
+      latestByAuthor.set(author, {
+        state: review.state,
+        observedAt: review.observedAt,
+        order,
+      });
+    }
+  });
+  return [...latestByAuthor.values()].some(
+    (review) => review.state === "approved",
+  );
+}
+
+export function isDocsOnly(changedFiles: readonly string[]): boolean {
+  return (
+    changedFiles.length > 0 &&
+    changedFiles.every((file) => {
+      const normalized = normalizePath(file);
+      return (
+        normalized.startsWith("docs/") ||
+        normalized.startsWith("packages/docs/") ||
+        normalized.startsWith("packages/core/docs/") ||
+        normalized.startsWith(".agents/skills/") ||
+        normalized.endsWith("/agents.md") ||
+        normalized.endsWith("/claude.md") ||
+        normalized === "agents.md" ||
+        normalized === "claude.md" ||
+        (normalized.startsWith(".changeset/") && normalized.endsWith(".md")) ||
+        (normalized.endsWith(".mdx") &&
+          (normalized.startsWith("docs/") ||
+            normalized.startsWith(".agents/skills/") ||
+            normalized.includes("/docs/")))
+      );
+    })
+  );
+}
+
+export function isUltraScaryChange(changedFiles: readonly string[]): boolean {
+  return changedFiles.some((file) => {
+    const normalized = normalizePath(file);
+    return (
+      normalized.startsWith(".github/workflows/") ||
+      /(^|\/)(auth|authentication|identity|credentials?|secrets?|sessions?|permissions?|tenant|tenants|isolation|security|execution|sandbox|payments?|billing|deploy|deployment|netlify|publish|release|migrations?)(\/|[-_.]|$)/.test(
+        normalized,
+      )
+    );
+  });
+}
+
+function ownerExceptionCoversArea(
+  exception: PullRequestOwnerException | null,
+  area: OwnerOwnedArea,
+): boolean {
+  return (
+    (exception === "alice-content" && area === "content") ||
+    (exception === "sid-design" && area === "design")
+  );
+}
+
+function isAppScoped(
+  changedFiles: readonly string[],
+  app: "content" | "slides" | "design",
+  allowSharedSupport: boolean,
+): boolean {
+  const appPrefix = `templates/${app}/`;
+  const hasAppPath = changedFiles.some((file) => file.startsWith(appPrefix));
+  if (!hasAppPath) return false;
+  return changedFiles.every(
+    (file) =>
+      file.startsWith(appPrefix) ||
+      (allowSharedSupport && isSharedSupportPath(file)) ||
+      isChangeset(file),
+  );
+}
+
+function isFactoryScoped(changedFiles: readonly string[]): boolean {
+  const hasFactoryPath = changedFiles.some((file) =>
+    file.startsWith("templates/factory/"),
+  );
+  return (
+    hasFactoryPath &&
+    changedFiles.every(
+      (file) => file.startsWith("templates/factory/") || isChangeset(file),
+    )
+  );
+}
+
+function isSharedSupportPath(file: string): boolean {
+  return (
+    file.startsWith("packages/core/") ||
+    file.startsWith("packages/desktop-app/") ||
+    file.startsWith("packages/code-agents-ui/")
+  );
+}
+
+function isChangeset(file: string): boolean {
+  return file.startsWith(".changeset/") && file.endsWith(".md");
+}
+
+function normalizePath(file: string): string {
+  return file.trim().split("\\").join("/").toLowerCase();
+}

package/corpus/templates/factory/server/triage/review-skill-alignment.ts

@@ -0,0 +1,127 @@
+const ALIGNMENT_START = "<!-- factory-skill-alignment:start -->";
+const ALIGNMENT_END = "<!-- factory-skill-alignment:end -->";
+
+const FEEDBACK_ALIGNMENT = `## Current review-latest-feedback contract
+
+The repository's \`.agents/skills/review-latest-feedback/SKILL.md\` is
+authoritative. Re-read it in the Builder worktree before acting. Its current
+contract is evidence-first and reply-producing:
+
+- Recheck answered clarifications and open In progress ownership before newer
+  work. Keep the newest unhandled item as the cursor, read older duplicates
+  into one verified cluster, and leave an auditable disposition for every
+  inspected Slack, GitHub issue, and Sentry item.
+- Read the complete parent/thread, reactions, attachments, linked artifacts,
+  and newer follow-ups before asking anything or dispatching. An unavailable
+  source is unavailable evidence, never a no-results result.
+- Keep one specific unanswered clarification per thread. Re-read the whole
+  thread when the requested detail is answered, try the fix first, and use the
+  task-scoped clarification ledger with a stable scheduler identity for
+  recurring rechecks. Do not claim scheduled coverage without stable durable
+  state.
+- Check the existing Slack 👀 marker and owner before any write. Preserve an
+  existing marker; if reactions cannot be read, do not guess or add one. Do
+  not react to or dispatch Design UX/interaction work (Sid) or any Content
+  work (Alice); record the owner instead.
+- For an actionable repo-owned Slack item with no existing marker, 👀 is the
+  first external write. Every parent this run marks must later receive a
+  verified @agent-native Fixed, In progress, or Clarification needed reply;
+  an eye, forward, generic acknowledgement, or another person's reply is not
+  a disposition. Group only genuinely repeated symptoms and dispatch one
+  Builder thread for the cluster.
+- Choose the smallest owning seam: local regression for one symptom, shared
+  contract for repeated cross-surface evidence, discovery/action wiring for a
+  missing capability, and release/deployment diagnosis for source-versus-live
+  mismatches. Do not turn one report into a global prompt rule.
+- Keep source-tested, built, published/deployed, and observed-live evidence
+  separate. Do not claim a fix, PR, reply, or deployment without confirmation
+  from the relevant action or runtime evidence.
+
+After classifying every processed item, call \`start-builder-for-item\` with
+\`clearBug: true\` or \`false\` and a concise evidence-grounded reason so every
+skip or dispatch is recorded.`;
+
+const PR_ALIGNMENT = `## Current review-prs contract
+
+The repository's \`.agents/skills/review-prs/SKILL.md\` is authoritative.
+Before selecting work, ignore drafts and pull requests with a current,
+non-dismissed APPROVED review, including bot approvals; do not inspect or
+recap those excluded items. For every remaining PR, read the complete title,
+body, links, changed-file diff (including generated and migration files), all
+review summaries/comments/replies, actual check conclusions, and ownership
+boundary. Verify current BuilderIO organization membership through GitHub's
+organization API - never infer it from a name, association, branch, email, or
+bot label.
+
+Never approve external or unverified authors. The internal-author exception
+allows ordinary failed, pending, skipped, or unknown checks and ordinary
+unresolved feedback for a verified BuilderIO member; record those exact states
+and never call them clean. The ultra-scary gate always remains manual for auth,
+permissions, tenant isolation, secrets, destructive data loss or migrations,
+remote code execution, SSRF, payments, deployment, or unexplained dependency
+and infrastructure risk.
+
+The verified owner exceptions are current and must be applied only after
+membership and the ultra-scary assessment: Alice (\`3mdistal\`) for Content,
+Nick (\`NKoech123\`) for Slides, Enzo (\`enzoames\`) for Factory-specific PRs,
+and Sid (\`sidmohanty11\`) for Design. Alice and Nick may include supporting
+shared framework/Desktop plumbing required by their app feature. The docs-only
+exception applies to \`kapunahelewong\` and Wes (\`bwreid\`) only when every
+changed file is documentation, localization, docs navigation/redirect, or a
+docs-specific test. These exceptions cover ordinary UX/refactor/check/review
+gates but never membership, external-author, or ultra-scary gates.
+
+Approve only when the remaining standard evidence supports a clear,
+repo-owned, narrow root-cause change with unambiguous scope. Approval is a
+trust decision only - never auto-merge. Never claim ignored checks or feedback
+are resolved, and record one concise disposition for every PR that entered the
+evidence sweep.`;
+
+export type FactoryAutomationName =
+  | "factory-slack-feedback"
+  | "factory-sentry-errors"
+  | "factory-github-issues"
+  | "factory-pr-governance"
+  | "factory-pr-babysit";
+
+export function managedReviewSkillAlignment(
+  name: FactoryAutomationName,
+): string | undefined {
+  if (
+    name === "factory-slack-feedback" ||
+    name === "factory-sentry-errors" ||
+    name === "factory-github-issues"
+  ) {
+    return FEEDBACK_ALIGNMENT;
+  }
+  if (name === "factory-pr-governance") return PR_ALIGNMENT;
+  return undefined;
+}
+
+export function syncManagedReviewSkillAlignment(
+  content: string,
+  name: FactoryAutomationName,
+): string {
+  const alignment = managedReviewSkillAlignment(name);
+  if (!alignment) return content;
+
+  const block = `${ALIGNMENT_START}\n${alignment.trim()}\n${ALIGNMENT_END}`;
+  const existingBlock = new RegExp(
+    `${escapeRegExp(ALIGNMENT_START)}[\\s\\S]*?${escapeRegExp(ALIGNMENT_END)}`,
+  );
+  if (existingBlock.test(content)) {
+    return content.replace(existingBlock, block);
+  }
+  return `${content.trimEnd()}\n\n${block}\n`;
+}
+
+export function managedReviewSkillAlignmentMarkers(): {
+  start: string;
+  end: string;
+} {
+  return { start: ALIGNMENT_START, end: ALIGNMENT_END };
+}
+
+function escapeRegExp(value: string): string {
+  return value.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+}