@agent-native/core 0.161.10 → 0.161.14

package/corpus/README.md

@@ -31,4 +31,4 @@ rg -n "defineAction|useActionQuery" node_modules/@agent-native/core/corpus
 
 ## Generated Counts
 
-- template files: 8301
+- template files: 8309

package/corpus/templates/analytics/actions/clear-selected-dashboard-object.ts

@@ -0,0 +1,71 @@
+import { defineAction } from "@agent-native/core";
+import {
+  appStateKeyForBrowserTab,
+  compareAndSetAppState,
+  getCurrentRequestBrowserTabId,
+  readAppState,
+} from "@agent-native/core/application-state";
+import { z } from "zod";
+
+const SELECTED_OBJECT_STATE_KEY = "selected-object";
+const SELECTED_OBJECT_SOURCE_FIELD = "__agentNativeSelectedObjectSource";
+
+function selectedDashboardId(value: Record<string, unknown>): string | null {
+  const id =
+    value.type === "dashboard"
+      ? value.id
+      : value.type === "dashboard-panel"
+        ? value.dashboardId
+        : null;
+  return typeof id === "string" ? id : null;
+}
+
+export default defineAction({
+  agentTool: false,
+  description:
+    "Clear the current browser tab's Analytics dashboard selection when it still belongs to that tab.",
+  schema: z.object({
+    browserTabId: z
+      .string()
+      .regex(/^[A-Za-z0-9_-]{1,96}$/)
+      .optional(),
+    dashboardId: z.string().min(1).optional(),
+    expectedSelection: z.record(z.string(), z.unknown()).optional(),
+    source: z.string().min(1).max(96),
+  }),
+  run: async ({ browserTabId, dashboardId, expectedSelection, source }) => {
+    const effectiveBrowserTabId =
+      browserTabId ?? getCurrentRequestBrowserTabId();
+    const scopedStateKey = appStateKeyForBrowserTab(
+      SELECTED_OBJECT_STATE_KEY,
+      effectiveBrowserTabId,
+    );
+    const tabCurrent =
+      scopedStateKey === SELECTED_OBJECT_STATE_KEY
+        ? null
+        : await readAppState(scopedStateKey);
+    const globalCurrent =
+      !effectiveBrowserTabId || !tabCurrent
+        ? await readAppState(SELECTED_OBJECT_STATE_KEY)
+        : null;
+    const current = tabCurrent ?? globalCurrent;
+    const stateKey = tabCurrent ? scopedStateKey : SELECTED_OBJECT_STATE_KEY;
+    if (!current || current[SELECTED_OBJECT_SOURCE_FIELD] !== source) {
+      return { cleared: false };
+    }
+
+    const currentDashboardId = selectedDashboardId(current);
+    if (!currentDashboardId) return { cleared: false };
+    if (dashboardId && currentDashboardId !== dashboardId) {
+      return { cleared: false };
+    }
+
+    return {
+      cleared: await compareAndSetAppState(
+        stateKey,
+        expectedSelection ?? current,
+        null,
+      ),
+    };
+  },
+});

package/corpus/templates/analytics/actions/view-screen.ts

@@ -24,6 +24,35 @@ import { getMonitor, listMonitors } from "../server/lib/uptime-monitors.js";
 
 const SESSION_FILTER_KEYS = new Set(["range", "app", "q"]);
 const REPLAY_RANGES = new Set(["24h", "7d", "30d", "90d", "all"]);
+const DASHBOARD_PATH_RE = /^\/(?:adhoc|dashboards)\/([^/]+)\/?$/;
+
+function dashboardIdFromPathname(pathname: string): string | null {
+  const match = pathname.match(DASHBOARD_PATH_RE);
+  if (!match) return null;
+  try {
+    return decodeURIComponent(match[1]);
+  } catch {
+    return match[1];
+  }
+}
+
+function normalizedDashboardId(value: unknown): string | null {
+  if (typeof value !== "string" || value.length === 0) return null;
+  try {
+    return decodeURIComponent(value);
+  } catch {
+    return value;
+  }
+}
+
+function isAskPathname(pathname: string): boolean {
+  return (
+    pathname === "" ||
+    pathname === "/" ||
+    pathname === "/ask" ||
+    pathname === "/overview"
+  );
+}
 
 export default defineAction({
   description:
@@ -38,10 +67,47 @@ export default defineAction({
       search?: string;
       searchParams?: Record<string, string>;
     } | null;
-    const selectedObject = await readAppStateForCurrentTab("selected-object");
+    const rawNav = navigation as any;
+    const pathname = typeof url?.pathname === "string" ? url.pathname : "";
+    const hasAuthoritativePathname = pathname.length > 0;
+    const pathnameDashboardId = hasAuthoritativePathname
+      ? dashboardIdFromPathname(pathname)
+      : null;
+    const navigationDashboardId = normalizedDashboardId(rawNav?.dashboardId);
+    // The URL is authoritative during route transitions in both directions.
+    // A stale Ask navigation object must not hide the dashboard selection or
+    // trigger Ask-only behavior after the URL has moved to a dashboard.
+    const isAskView = hasAuthoritativePathname
+      ? isAskPathname(pathname)
+      : rawNav?.view === "ask";
+    const hasStaleAskNavigation =
+      hasAuthoritativePathname && !isAskView && rawNav?.view === "ask";
+    const hasStaleDashboardNavigation =
+      hasAuthoritativePathname &&
+      rawNav?.view === "adhoc" &&
+      (pathnameDashboardId === null ||
+        navigationDashboardId !== pathnameDashboardId);
+    const effectiveNavigation = isAskView
+      ? { view: "ask" }
+      : pathnameDashboardId !== null
+        ? {
+            ...(rawNav?.view === "adhoc" &&
+            navigationDashboardId === pathnameDashboardId
+              ? rawNav
+              : {}),
+            view: "adhoc",
+            dashboardId: pathnameDashboardId,
+          }
+        : hasStaleAskNavigation || hasStaleDashboardNavigation
+          ? null
+          : navigation;
+    const nav = effectiveNavigation as any;
+    const selectedObject = isAskView
+      ? null
+      : await readAppStateForCurrentTab("selected-object");
 
     const screen: Record<string, unknown> = {};
-    if (navigation) screen.navigation = navigation;
+    if (effectiveNavigation) screen.navigation = effectiveNavigation;
     if (url?.pathname) screen.pathname = url.pathname;
     if (selectedObject) screen.selectedObject = selectedObject;
 
@@ -65,8 +131,6 @@ export default defineAction({
       }
     }
 
-    const nav = navigation as any;
-
     if (nav?.view === "adhoc" && nav?.dashboardId) {
       try {
         const orgId = getRequestOrgId() || null;

package/corpus/templates/analytics/app/hooks/use-dashboard-chat-context.ts

@@ -5,13 +5,13 @@ import {
   type AgentSidebarStateChangeDetail,
   useAgentChatContext,
 } from "@agent-native/core/client/agent-chat";
-import {
-  deleteClientAppState,
-  readClientAppState,
-  setClientAppState,
-} from "@agent-native/core/client/hooks";
-import { useCallback, useEffect, useState } from "react";
+import { setClientAppState } from "@agent-native/core/client/hooks";
+import { useCallback, useEffect, useRef, useState } from "react";
 
+import {
+  clearSelectedDashboardObjectIfOwned,
+  type SelectedDashboardObject,
+} from "@/lib/selected-object";
 import { TAB_ID } from "@/lib/tab-id";
 
 const DASHBOARD_CONTEXT_KEY = "analytics-selected-dashboard";
@@ -80,28 +80,6 @@ function dashboardContext(
   return lines.join("\n");
 }
 
-async function deleteSelectedObjectIfOwned(dashboardId: string) {
-  try {
-    const current = await readClientAppState<Record<string, unknown>>(
-      SELECTED_OBJECT_STATE_KEY,
-    );
-    if (current?.[SELECTED_OBJECT_SOURCE_FIELD] !== TAB_ID) return;
-    const selectedDashboardId =
-      current.type === "dashboard"
-        ? current.id
-        : current.type === "dashboard-panel"
-          ? current.dashboardId
-          : null;
-    if (selectedDashboardId !== dashboardId) return;
-    await deleteClientAppState(SELECTED_OBJECT_STATE_KEY, {
-      keepalive: true,
-      requestSource: TAB_ID,
-    });
-  } catch {
-    // Best effort only; avoid clearing another tab's selected object on errors.
-  }
-}
-
 function panelSelectionMarker(dashboardId: string, panelId: string): string {
   return `Analytics panel selection: dashboard=${encodeURIComponent(
     dashboardId,
@@ -153,6 +131,7 @@ export function useDashboardChatContext(
       ? panelSelection.panelId
       : null;
   const hasSelectedPanel = selectedPanelId !== null;
+  const publishedSelectionRef = useRef<SelectedDashboardObject | null>(null);
 
   const selectPanelForChat = useCallback(
     (
@@ -179,6 +158,20 @@ export function useDashboardChatContext(
           ? "Inspect this panel with get-sql-dashboard (includeConfig: true) before changing it, then use mutate-dashboard for edits."
           : "Inspect the linked Explorer config before changing this chart.",
       ].filter(Boolean);
+      const selection: SelectedDashboardObject = {
+        type: "dashboard-panel",
+        dashboardId: id,
+        dashboardKind: kind,
+        dashboardTitle: displayDashboardTitle,
+        panelId: panel.panelId,
+        panelTitle: displayPanelTitle,
+        panelKind: panel.panelKind,
+        chartType: panel.chartType || undefined,
+        source: panel.source || undefined,
+        configId: panel.configId || undefined,
+        extensionId: panel.extensionId || undefined,
+        [SELECTED_OBJECT_SOURCE_FIELD]: TAB_ID,
+      };
 
       // The panel context occupies one stable composer slot, so selecting a
       // different panel replaces the prior chip instead of accumulating chips.
@@ -189,27 +182,11 @@ export function useDashboardChatContext(
         openSidebar: options.openSidebar === true,
         focus: options.focus ?? false,
       });
-      setClientAppState(
-        SELECTED_OBJECT_STATE_KEY,
-        {
-          type: "dashboard-panel",
-          dashboardId: id,
-          dashboardKind: kind,
-          dashboardTitle: displayDashboardTitle,
-          panelId: panel.panelId,
-          panelTitle: displayPanelTitle,
-          panelKind: panel.panelKind,
-          chartType: panel.chartType || undefined,
-          source: panel.source || undefined,
-          configId: panel.configId || undefined,
-          extensionId: panel.extensionId || undefined,
-          [SELECTED_OBJECT_SOURCE_FIELD]: TAB_ID,
-        },
-        {
-          keepalive: true,
-          requestSource: TAB_ID,
-        },
-      ).catch(() => {});
+      setClientAppState(SELECTED_OBJECT_STATE_KEY, selection, {
+        keepalive: true,
+        requestSource: TAB_ID,
+      }).catch(() => {});
+      publishedSelectionRef.current = selection;
     },
     [id, isAgentSidebarOpen, kind, title],
   );
@@ -261,23 +238,21 @@ export function useDashboardChatContext(
   useEffect(() => {
     if (!id || hasSelectedPanel) return;
     const displayTitle = title?.trim() || id;
+    const selection: SelectedDashboardObject = {
+      type: "dashboard",
+      id,
+      kind,
+      title: displayTitle,
+      panelCount,
+      canEdit,
+      [SELECTED_OBJECT_SOURCE_FIELD]: TAB_ID,
+    };
     const timer = setTimeout(() => {
-      setClientAppState(
-        SELECTED_OBJECT_STATE_KEY,
-        {
-          type: "dashboard",
-          id,
-          kind,
-          title: displayTitle,
-          panelCount,
-          canEdit,
-          [SELECTED_OBJECT_SOURCE_FIELD]: TAB_ID,
-        },
-        {
-          keepalive: true,
-          requestSource: TAB_ID,
-        },
-      ).catch(() => {});
+      setClientAppState(SELECTED_OBJECT_STATE_KEY, selection, {
+        keepalive: true,
+        requestSource: TAB_ID,
+      }).catch(() => {});
+      publishedSelectionRef.current = selection;
     }, CONTEXT_PUBLISH_DELAY_MS);
     return () => clearTimeout(timer);
   }, [canEdit, hasSelectedPanel, id, kind, panelCount, title]);
@@ -293,7 +268,7 @@ export function useDashboardChatContext(
         key: DASHBOARD_PANEL_CONTEXT_KEY,
         openSidebar: false,
       });
-      deleteSelectedObjectIfOwned(id);
+      clearSelectedDashboardObjectIfOwned(publishedSelectionRef.current);
     };
   }, [id]);
 

package/corpus/templates/analytics/app/lib/selected-object.ts

@@ -0,0 +1,53 @@
+import { readClientAppState } from "@agent-native/core/client/application-state";
+import { callAction } from "@agent-native/core/client/hooks";
+
+import { TAB_ID } from "@/lib/tab-id";
+
+export type SelectedDashboardObject = Record<string, unknown>;
+
+export async function readSelectedDashboardObject(): Promise<SelectedDashboardObject | null> {
+  try {
+    const value =
+      await readClientAppState<SelectedDashboardObject>("selected-object");
+    return value && typeof value === "object" && !Array.isArray(value)
+      ? value
+      : null;
+    // A browser-side selection probe: "could not read" and "nothing selected"
+    // drive the same UI, and throwing breaks route transitions.
+    // coercion-ok: unreadable selection and no selection render identically
+  } catch {
+    return null;
+  }
+}
+
+/**
+ * Clear this tab's dashboard selection without touching another tab's state.
+ * The action validates the tab marker and deletes with a compare-and-set so a
+ * route transition cannot erase a newer selection after the read.
+ */
+export async function clearSelectedDashboardObjectIfOwned(
+  dashboardIdOrSelection?: string | SelectedDashboardObject | null,
+): Promise<void> {
+  const dashboardId =
+    typeof dashboardIdOrSelection === "string"
+      ? dashboardIdOrSelection
+      : undefined;
+  const expectedSelection =
+    dashboardIdOrSelection && typeof dashboardIdOrSelection === "object"
+      ? dashboardIdOrSelection
+      : undefined;
+
+  if (!dashboardId && !expectedSelection) return;
+
+  try {
+    await callAction("clear-selected-dashboard-object", {
+      ...(dashboardId ? { dashboardId } : {}),
+      ...(expectedSelection ? { expectedSelection } : {}),
+      browserTabId: TAB_ID,
+      source: TAB_ID,
+    });
+  } catch {
+    // coercion-ok: best-effort cleanup must not break Ask navigation when state APIs fail.
+    // Best effort only; stale context is safer than clearing another tab's state.
+  }
+}

package/corpus/templates/analytics/app/pages/Ask.tsx

@@ -7,6 +7,10 @@ import { CreativeContextComposerChip } from "@agent-native/creative-context/clie
 import { useEffect, useMemo } from "react";
 
 import { ANALYTICS_CHAT_STORAGE_KEY } from "@/lib/chat-handoff";
+import {
+  clearSelectedDashboardObjectIfOwned,
+  readSelectedDashboardObject,
+} from "@/lib/selected-object";
 import { TAB_ID } from "@/lib/tab-id";
 
 const DASHBOARD_CONTEXT_KEYS = new Set([
@@ -31,6 +35,23 @@ export default function AskPage() {
     }
   }, [removeChatContextItem, staleDashboardContextKey]);
 
+  useEffect(() => {
+    let mounted = true;
+    const pathnameAtMount = window.location.pathname;
+
+    void readSelectedDashboardObject().then((selection) => {
+      // If the user already navigated away, this Ask instance no longer owns
+      // cleanup. The action also CASes the captured selection, covering a
+      // selection change that happens after this read but before the write.
+      if (!mounted || window.location.pathname !== pathnameAtMount) return;
+      if (selection) void clearSelectedDashboardObjectIfOwned(selection);
+    });
+
+    return () => {
+      mounted = false;
+    };
+  }, []);
+
   return (
     <div className="analytics-ask-page flex h-full min-h-0 flex-col bg-background">
       <AgentChatSurface

package/corpus/templates/analytics/changelog/2026-08-18-ask-no-stale-dashboard-context.md

@@ -0,0 +1,6 @@
+---
+type: fixed
+date: 2026-08-18
+---
+
+Analytics no longer carries a previous dashboard into a new Ask chat.

package/corpus/templates/calendar/app/root.tsx

@@ -202,6 +202,13 @@ function isPublicBookingPath(pathname: string): boolean {
   );
 }
 
+function isAgentNativeDesktop(): boolean {
+  return (
+    typeof navigator !== "undefined" &&
+    /AgentNativeDesktop/i.test(navigator.userAgent)
+  );
+}
+
 function AppContent() {
   const [cmdkOpen, setCmdkOpen] = useState(false);
   const navigate = useNavigate();
@@ -249,11 +256,12 @@ export default function Root() {
     createAgentNativeQueryClient({
       defaultOptions: {
         queries: {
-          // Calendar aggressively refetches on focus because external
-          // calendar events can change without a DB sync event (e.g. Google
-          // Calendar webhooks with a processing delay).
+          // Chrome gets one focus refresh because external calendar events can
+          // change without a DB sync event (e.g. delayed Google webhooks).
+          // Desktop already has the shell's focus-aware DB sync, and repeated
+          // webview focus events otherwise duplicate the events request.
           // request-storm-allow: one user-driven focus refresh for provider data.
-          refetchOnWindowFocus: true,
+          refetchOnWindowFocus: !isAgentNativeDesktop(),
           // Flat retry: calendar data fetches don't need the auth-aware
           // retry function — auth errors surface through the booking flow.
           retry: 1,

package/corpus/templates/calendar/changelog/2026-08-18-calendar-stays-responsive-in-the-desktop-app-without-focus-t.md

@@ -0,0 +1,6 @@
+---
+type: fixed
+date: 2026-08-18
+---
+
+Calendar stays responsive in the desktop app without focus-triggered reloads

package/corpus/templates/clips/app/components/library/recording-card.tsx

@@ -14,7 +14,7 @@ import {
   IconAlertTriangle,
   IconExternalLink,
 } from "@tabler/icons-react";
-import { useCallback, useMemo, useState } from "react";
+import { useCallback, useMemo, useRef, useState } from "react";
 import { Link } from "react-router";
 
 import { AgentViewCount } from "@/components/player/recording-views-badge";
@@ -94,6 +94,8 @@ export function RecordingCard({
   const t = useT();
   const { formatDate, formatRelativeTime } = useFormatters();
   const [hovered, setHovered] = useState(false);
+  const [menuOpen, setMenuOpen] = useState(false);
+  const pendingTrashRef = useRef(false);
 
   const duration = useMemo(
     () => formatDuration(recording.durationMs),
@@ -185,6 +187,11 @@ export function RecordingCard({
     attemptOpenDesktopApp();
   }, []);
 
+  const requestTrash = useCallback(() => {
+    pendingTrashRef.current = true;
+    setMenuOpen(false);
+  }, []);
+
   return (
     <div
       role="article"
@@ -378,7 +385,7 @@ export function RecordingCard({
           </div>
 
           {showActions && (
-            <DropdownMenu>
+            <DropdownMenu open={menuOpen} onOpenChange={setMenuOpen}>
               <DropdownMenuTrigger asChild onClick={(e) => e.stopPropagation()}>
                 <button
                   className="pointer-events-auto rounded p-1 text-muted-foreground hover:bg-accent hover:text-foreground"
@@ -390,6 +397,12 @@ export function RecordingCard({
               <DropdownMenuContent
                 align="end"
                 onClick={(e) => e.stopPropagation()}
+                onCloseAutoFocus={(event) => {
+                  if (!pendingTrashRef.current) return;
+                  event.preventDefault();
+                  pendingTrashRef.current = false;
+                  setTimeout(() => onTrash?.(recording), 0);
+                }}
               >
                 {onShare && (
                   <DropdownMenuItem onSelect={() => onShare(recording)}>
@@ -453,7 +466,10 @@ export function RecordingCard({
                   ))}
                 {onTrash && (
                   <DropdownMenuItem
-                    onSelect={() => onTrash(recording)}
+                    onSelect={(event) => {
+                      event.preventDefault();
+                      requestTrash();
+                    }}
                     className="text-destructive focus:text-destructive"
                   >
                     <IconTrash className="h-4 w-4 me-2" />{" "}

package/corpus/templates/clips/changelog/2026-08-18-deleting-a-recording-no-longer-freezes-clips.md

@@ -0,0 +1,6 @@
+---
+type: fixed
+date: 2026-08-18
+---
+
+Deleting a recording no longer freezes Clips or blocks starting a new recording.

package/corpus/templates/clips/desktop/src/app.tsx

@@ -112,6 +112,7 @@ import {
   copyRecordingShareLink,
   recordingShareUrl,
 } from "./lib/recording-link";
+import { boundedCleanup } from "./lib/recording-start-guard";
 import { REWIND_AGENT_PROMPT } from "./lib/rewind-agent-prompt";
 import { getRewindStatusPresentation } from "./lib/rewind-status";
 import {
@@ -3218,16 +3219,14 @@ export function App() {
         bubbleStreamTransferredToRecorder.current = false;
         recordingFlowGateRef.current = false;
         setRecordingFlowActive(false);
-        try {
-          await invoke("set_recording_state", { active: false });
-        } catch {
-          // ignore — best-effort
-        }
-        try {
-          await invoke("show_popover");
-        } catch {
-          // ignore — best-effort
-        }
+        // Bounded, not just best-effort: a plain unbounded await here would
+        // let a stuck native command (e.g. a ScreenCaptureKit handshake that
+        // never returns) turn this "always recovers" block into another
+        // permanent hang on top of the one that just failed — exactly the
+        // "stuck on Preparing…, have to restart" symptom this exists to
+        // prevent.
+        await boundedCleanup(invoke("set_recording_state", { active: false }));
+        await boundedCleanup(invoke("show_popover"));
       }
     }
 

package/corpus/templates/clips/desktop/src/lib/recorder.ts

@@ -84,6 +84,7 @@ import {
   type NativeRecordingRequestOptions,
 } from "./recording-request";
 import {
+  boundedCleanup,
   guardRecordingStart,
   RECORDING_START_TIMEOUT_MS,
   RecordingStartCancelledError,
@@ -2748,7 +2749,7 @@ async function tryStartRewindFullscreenRecording(
       },
       async countdown() {
         console.log("[rewind-latency] countdown shown after preparation");
-        await invoke("hide_preparing").catch(() => {});
+        await boundedCleanup(invoke("hide_preparing"));
         // Overlap whisper startup with the countdown so the capture boundary
         // never waits on it, but have both settled before activation.
         await Promise.all([
@@ -2792,7 +2793,7 @@ async function tryStartRewindFullscreenRecording(
       });
     }
   } catch (err) {
-    await invoke("hide_preparing").catch(() => {});
+    await boundedCleanup(invoke("hide_preparing"));
     transcriptionAborted = true;
     // Cast: `transcriptionCapture` is only assigned inside the
     // `startRewindTranscription` closure, which TS's control-flow analysis
@@ -4090,7 +4091,7 @@ export async function startRecording(
       },
     });
   } catch (err) {
-    await invoke("hide_recording_chrome").catch(() => {});
+    await boundedCleanup(invoke("hide_recording_chrome"));
     const e = err as { name?: string; message?: string } | null;
     console.error(
       "[clips-recorder] startRecording threw:",

package/corpus/templates/clips/desktop/src/lib/recording-start-guard.ts

@@ -1,5 +1,12 @@
 export const RECORDING_START_TIMEOUT_MS = 90_000;
 
+// Cleanup invokes (closing overlay windows, clearing recording state) are
+// normally instant. This bounds them well above any real duration but far
+// below forever, so a stuck native call (e.g. a ScreenCaptureKit handshake
+// that never returns its completion) can't turn "recovery" into another
+// permanent hang on top of the one the start guard already gave up on.
+export const RECOVERY_INVOKE_TIMEOUT_MS = 5_000;
+
 export class RecordingStartTimeoutError extends Error {
   constructor(timeoutMs: number) {
     super(
@@ -82,3 +89,22 @@ export function guardRecordingStart<T>(
     }, timeoutMs);
   });
 }
+
+/**
+ * Best-effort recovery step that must never block the caller. Recording-start
+ * failure paths (and their "always restore the UI" `finally` blocks) await
+ * cleanup invokes like `hide_recording_chrome` — if the underlying native
+ * command hangs, an unbounded `await ...catch(() => {})` hangs the whole
+ * recovery with it, leaving the toolbar/"Preparing…" state stuck until the
+ * user restarts the app. Swallows both success and failure; only existence
+ * to cap how long a single cleanup step can stall recovery.
+ */
+export function boundedCleanup(
+  operation: Promise<unknown>,
+  timeoutMs = RECOVERY_INVOKE_TIMEOUT_MS,
+): Promise<void> {
+  return guardRecordingStart(operation, { timeoutMs }).then(
+    () => undefined,
+    () => undefined,
+  );
+}