@agent-native/core 0.157.2 → 0.157.4

package/corpus/templates/clips/actions/request-recording-access.ts

@@ -8,6 +8,7 @@ import {
   isEmailConfigured,
   renderEmail,
   sendEmail,
+  signScopedAgentAccessToken,
   verifyScopedAgentAccessToken,
   withConfiguredAppBasePath,
 } from "@agent-native/core/server";
@@ -23,12 +24,53 @@ import { z } from "zod";
 import { getDb, schema } from "../server/db/index.js";
 import { normalizeOwnerEmail } from "../server/lib/recordings.js";
 import {
+  CLIPS_ACCESS_APPROVAL_TOKEN_PREFIX,
+  CLIPS_ACCESS_APPROVAL_TOKEN_TTL_SECONDS,
   CLIPS_ACCESS_REQUEST_TOKEN_PREFIX,
+  recordingAccessApprovalPath,
   recordingSharePath,
 } from "../shared/recording-link.js";
 
 export const CLIPS_ACCESS_REQUEST_EMAIL_ID = "clips.access-request";
 
+const ANONYMOUS_ACCESS_REQUEST_WINDOW_MS = 10 * 60 * 1000;
+const ANONYMOUS_ACCESS_REQUEST_MAX = 5;
+const ANONYMOUS_ACCESS_REQUEST_MAX_BUCKETS = 5000;
+const anonymousAccessRequestBuckets = new Map<
+  string,
+  { count: number; resetAt: number }
+>();
+
+export function __resetAnonymousAccessRequestRateLimitForTests(): void {
+  anonymousAccessRequestBuckets.clear();
+}
+
+function allowAnonymousAccessRequest(recordingId: string): boolean {
+  const now = Date.now();
+  for (const [key, bucket] of anonymousAccessRequestBuckets) {
+    if (bucket.resetAt <= now) anonymousAccessRequestBuckets.delete(key);
+  }
+
+  let bucket = anonymousAccessRequestBuckets.get(recordingId);
+  if (!bucket) {
+    if (
+      anonymousAccessRequestBuckets.size >= ANONYMOUS_ACCESS_REQUEST_MAX_BUCKETS
+    ) {
+      const oldestKey = anonymousAccessRequestBuckets.keys().next().value;
+      if (oldestKey) anonymousAccessRequestBuckets.delete(oldestKey);
+    }
+    bucket = {
+      count: 0,
+      resetAt: now + ANONYMOUS_ACCESS_REQUEST_WINDOW_MS,
+    };
+    anonymousAccessRequestBuckets.set(recordingId, bucket);
+  }
+
+  if (bucket.count >= ANONYMOUS_ACCESS_REQUEST_MAX) return false;
+  bucket.count += 1;
+  return true;
+}
+
 function accessRequestEventId(
   recordingId: string,
   requesterEmail: string,
@@ -64,25 +106,38 @@ function absoluteRecordingUrl(recordingId: string): string {
   return `${withConfiguredAppBasePath(getAppProductionUrl()).replace(/\/+$/, "")}${recordingSharePath(recordingId)}`;
 }
 
+function absoluteAccessApprovalUrl(
+  recordingId: string,
+  approvalToken: string,
+): string {
+  return `${withConfiguredAppBasePath(getAppProductionUrl()).replace(/\/+$/, "")}${recordingAccessApprovalPath(recordingId, approvalToken)}`;
+}
+
 export function renderRecordingAccessRequestEmail(input: {
   requesterName: string;
   requesterEmail: string;
   recordingTitle: string;
   url: string;
+  allowAccessUrl: string;
 }) {
-  const subject = `${input.requesterName} requested access to "${input.recordingTitle}"`;
+  const subject = `Access request for "${input.recordingTitle}"`;
   return {
     subject,
     ...renderEmail({
       brandName: "Clips",
       preheader: subject,
-      heading: "Access request",
+      heading: "Access requested",
       paragraphs: [
-        `${emailStrong(input.requesterName)} (${emailStrong(input.requesterEmail)}) requested access to ${emailStrong(input.recordingTitle)}.`,
-        "Open the Clip and use Share to grant access if this request should be approved.",
+        `${emailStrong(input.requesterName)} (${emailStrong(input.requesterEmail)}) requested viewer access to ${emailStrong(input.recordingTitle)}.`,
+        "Select Allow access to add them to this Clip's standard sharing list. You can also open the Clip to review sharing first.",
       ],
-      cta: { label: "Open Clip", url: input.url },
-      footer: "You received this because you own this Clip.",
+      cta: { label: "Allow access", url: input.allowAccessUrl },
+      secondaryCta: { label: "Open Clip", url: input.url },
+      closingParagraphs: [
+        "This approval link expires in 7 days and requires you to be signed in as a Clip owner or admin.",
+      ],
+      footer:
+        "You received this because you own this Clip. If you do not recognize the requester, you can ignore this email.",
     }),
   };
 }
@@ -99,12 +154,23 @@ async function notifyOwner(input: {
   }
   if (!(await isEmailConfigured())) return false;
 
+  const approvalToken = signScopedAgentAccessToken({
+    resourceKind: CLIPS_ACCESS_APPROVAL_TOKEN_PREFIX,
+    resourceId: input.recordingId,
+    viewerEmail: input.requesterEmail,
+    ttlSeconds: CLIPS_ACCESS_APPROVAL_TOKEN_TTL_SECONDS,
+  });
+
   await sendEmail({
     ...renderRecordingAccessRequestEmail({
       requesterName: input.requesterName,
       requesterEmail: input.requesterEmail,
       recordingTitle: input.recordingTitle,
       url: absoluteRecordingUrl(input.recordingId),
+      allowAccessUrl: absoluteAccessApprovalUrl(
+        input.recordingId,
+        approvalToken,
+      ),
     }),
     to: input.ownerEmail,
     replyTo: input.requesterEmail,
@@ -115,7 +181,7 @@ async function notifyOwner(input: {
 
 export default defineAction({
   description:
-    "Request access to a private Clips recording. Records the request and notifies the owner in-app and by email when configured.",
+    "Request access to a private Clips recording. Signed-in viewers use their account email; anonymous viewers may provide an email address. Records the request and notifies the owner in-app and by email when configured.",
   schema: z.object({
     recordingId: z
       .string()
@@ -127,18 +193,53 @@ export default defineAction({
       .min(1)
       .optional()
       .describe("Short-lived capability from the private share page."),
+    requesterEmail: z
+      .string()
+      .trim()
+      .email()
+      .optional()
+      .describe(
+        "Email address to request access for when the viewer is not signed in.",
+      ),
   }),
   agentTool: false,
-  run: async ({ recordingId, accessRequestToken }) => {
-    const requesterEmail = getRequestUserEmail();
-    if (!requesterEmail) {
-      throw httpError("Sign in to request access to this clip.", 401);
+  run: async ({ recordingId, accessRequestToken, requesterEmail }) => {
+    const sessionEmail = getRequestUserEmail();
+    const token = accessRequestToken
+      ? verifyScopedAgentAccessToken(accessRequestToken, {
+          resourceKind: CLIPS_ACCESS_REQUEST_TOKEN_PREFIX,
+          resourceId: recordingId,
+        })
+      : { ok: false as const, reason: "missing" };
+    if (!token.ok) {
+      throw httpError(`Recording ${recordingId} not found`, 404);
+    }
+
+    const normalizedRequesterEmail = sessionEmail
+      ? normalizeOwnerEmail(sessionEmail)
+      : requesterEmail
+        ? normalizeOwnerEmail(requesterEmail)
+        : null;
+    if (!normalizedRequesterEmail) {
+      throw httpError(
+        "Sign in or provide an email address to request access to this clip.",
+        401,
+      );
+    }
+
+    const tokenViewerEmail = token.viewerEmail
+      ? normalizeOwnerEmail(token.viewerEmail)
+      : null;
+    if (tokenViewerEmail && tokenViewerEmail !== normalizedRequesterEmail) {
+      throw httpError(
+        "This request is tied to a different email. Sign in with the email that opened the link.",
+        403,
+      );
     }
 
-    const normalizedRequesterEmail = normalizeOwnerEmail(requesterEmail);
     const access = await resolveAccess("recording", recordingId, {
       userEmail: normalizedRequesterEmail,
-      orgId: getRequestOrgId() ?? undefined,
+      orgId: sessionEmail ? (getRequestOrgId() ?? undefined) : undefined,
     });
 
     if (access) {
@@ -157,16 +258,6 @@ export default defineAction({
       };
     }
 
-    if (
-      !accessRequestToken ||
-      !verifyScopedAgentAccessToken(accessRequestToken, {
-        resourceKind: CLIPS_ACCESS_REQUEST_TOKEN_PREFIX,
-        resourceId: recordingId,
-      }).ok
-    ) {
-      throw httpError(`Recording ${recordingId} not found`, 404);
-    }
-
     const db = getDb();
     const [recording] = await db
       .select({
@@ -223,6 +314,13 @@ export default defineAction({
       };
     }
 
+    if (!sessionEmail && !allowAnonymousAccessRequest(recordingId)) {
+      throw httpError(
+        "Too many anonymous access requests for this clip. Try again later.",
+        429,
+      );
+    }
+
     const requesterName =
       getRequestUserName()?.trim() ||
       displayNameForEmail(normalizedRequesterEmail);

package/corpus/templates/clips/actions/view-screen.ts

@@ -425,7 +425,7 @@ async function fetchMeetingDetail(meetingId: string) {
       source: meeting.source,
       userNotesMd: meeting.userNotesMd,
       transcriptStatus: meeting.transcriptStatus,
-      shareTranscript: Boolean(meeting.shareTranscript),
+      shareTranscript: meeting.shareTranscript === true,
       summaryMd: meeting.summaryMd,
       bullets: safeJsonArray<{ text: string }>(meeting.bulletsJson),
     },

package/corpus/templates/clips/app/components/meetings/share-meeting-dialog.tsx

@@ -1,11 +1,10 @@
 import { appPath } from "@agent-native/core/client/api-path";
 import {
-  useActionMutation,
   useActionQuery,
+  useActionMutation,
 } from "@agent-native/core/client/hooks";
 import { useT } from "@agent-native/core/client/i18n";
 import { ShareAgentsSection } from "@agent-native/toolkit/sharing";
-import { IconLink, IconMail } from "@tabler/icons-react";
 import {
   useCallback,
   useEffect,
@@ -34,7 +33,6 @@ import {
   PopoverTrigger,
 } from "@/components/ui/popover";
 import { Switch } from "@/components/ui/switch";
-import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
 
 export interface ShareMeetingPopoverProps {
   meetingId: string;
@@ -90,49 +88,16 @@ function ShareMeetingContent({
   const canManage = data?.role === "owner" || data?.role === "admin";
 
   return (
-    <>
-      <Tabs defaultValue="link" className="min-w-0 px-4 py-3">
-        <TabsList className="grid w-full grid-cols-2">
-          <TabsTrigger value="link" className="gap-1.5">
-            <IconLink size={14} />
-            {t("clipsFinalRaw.link")}
-          </TabsTrigger>
-          <TabsTrigger value="invite" className="gap-1.5">
-            <IconMail size={14} />
-            {t("clipsFinalRaw.invite")}
-          </TabsTrigger>
-        </TabsList>
-
-        <TabsContent value="link" className="mt-3">
-          <LinkTab
-            meetingId={meetingId}
-            shareUrl={shareUrl}
-            sharesQuery={sharesQuery}
-            canManage={canManage}
-            shareTranscript={shareTranscript}
-            transcriptReady={transcriptReady}
-          />
-        </TabsContent>
-
-        <TabsContent value="invite" className="mt-3">
-          <SharePeopleTab
-            resourceType="meeting"
-            resourceId={meetingId}
-            sharesQuery={sharesQuery}
-            canManage={canManage}
-            onError={(err, action) =>
-              toast.error(
-                err instanceof Error
-                  ? err.message
-                  : action === "invite"
-                    ? t("clipsFinalRaw.inviteFailed")
-                    : t("clipsFinalRaw.removePersonFailed"),
-              )
-            }
-          />
-        </TabsContent>
-      </Tabs>
-    </>
+    <div className="min-w-0 px-4 py-3">
+      <LinkTab
+        meetingId={meetingId}
+        shareUrl={shareUrl}
+        sharesQuery={sharesQuery}
+        canManage={canManage}
+        shareTranscript={shareTranscript}
+        transcriptReady={transcriptReady}
+      />
+    </div>
   );
 }
 
@@ -242,6 +207,16 @@ function LinkTab({
 
   return (
     <div className="space-y-3">
+      <CopyField
+        label={
+          isPublic
+            ? t("clipsFinalRaw.shareLink")
+            : t("shareDialog.shareWithHumans")
+        }
+        value={shareUrl}
+        disabled={!sharesLoaded}
+      />
+
       <GeneralAccessSelect
         visibility={visibility}
         canManage={canManage}
@@ -277,14 +252,20 @@ function LinkTab({
         />
       </div>
 
-      <CopyField
-        label={
-          isPublic
-            ? t("clipsFinalRaw.shareLink")
-            : t("shareDialog.shareWithHumans")
+      <SharePeopleTab
+        resourceType="meeting"
+        resourceId={meetingId}
+        sharesQuery={sharesQuery}
+        canManage={canManage}
+        onError={(err, action) =>
+          toast.error(
+            err instanceof Error
+              ? err.message
+              : action === "invite"
+                ? t("clipsFinalRaw.inviteFailed")
+                : t("clipsFinalRaw.removePersonFailed"),
+          )
         }
-        value={shareUrl}
-        disabled={!sharesLoaded}
       />
 
       {!isPublic && canManage ? (

package/corpus/templates/clips/app/components/player/request-access-dialog.tsx

@@ -0,0 +1,104 @@
+import { useT } from "@agent-native/core/client/i18n";
+import { IconLogin2 } from "@tabler/icons-react";
+import type { FormEvent } from "react";
+
+import { Button } from "@/components/ui/button";
+import {
+  Dialog,
+  DialogContent,
+  DialogDescription,
+  DialogHeader,
+  DialogTitle,
+} from "@/components/ui/dialog";
+import { Input } from "@/components/ui/input";
+import { Label } from "@/components/ui/label";
+import { Separator } from "@/components/ui/separator";
+
+export interface RequestAccessDialogProps {
+  open: boolean;
+  onOpenChange: (open: boolean) => void;
+  signInHref: string;
+  email: string;
+  onEmailChange: (email: string) => void;
+  onSubmit: (event: FormEvent<HTMLFormElement>) => void;
+  isSubmitting: boolean;
+  error?: string | null;
+}
+
+export function RequestAccessDialog({
+  open,
+  onOpenChange,
+  signInHref,
+  email,
+  onEmailChange,
+  onSubmit,
+  isSubmitting,
+  error,
+}: RequestAccessDialogProps) {
+  const t = useT();
+
+  return (
+    <Dialog open={open} onOpenChange={onOpenChange}>
+      <DialogContent className="sm:max-w-md">
+        <DialogHeader>
+          <DialogTitle>{t("sharePage.requestAccessDialogTitle")}</DialogTitle>
+          <DialogDescription>
+            {t("sharePage.requestAccessDialogDescription")}
+          </DialogDescription>
+        </DialogHeader>
+
+        <div className="grid gap-4">
+          <Button asChild className="w-full gap-2">
+            <a href={signInHref}>
+              <IconLogin2
+                className="size-4 rtl:-scale-x-100"
+                aria-hidden="true"
+              />
+              {t("sharePage.requestAccessSignIn")}
+            </a>
+          </Button>
+
+          <div className="flex items-center gap-3 text-xs text-muted-foreground">
+            <Separator className="flex-1" />
+            <span>{t("sharePage.requestAccessOr")}</span>
+            <Separator className="flex-1" />
+          </div>
+
+          <form className="grid gap-3" onSubmit={onSubmit}>
+            <div className="grid gap-2">
+              <Label htmlFor="private-clip-request-email">
+                {t("sharePage.requestAccessEmailLabel")}
+              </Label>
+              <Input
+                id="private-clip-request-email"
+                type="email"
+                inputMode="email"
+                autoComplete="email"
+                required
+                value={email}
+                onChange={(event) => onEmailChange(event.target.value)}
+                placeholder={t("sharePage.requestAccessEmailPlaceholder")}
+                aria-invalid={Boolean(error)}
+              />
+              <p className="text-xs text-muted-foreground">
+                {t("sharePage.requestAccessEmailHint")}
+              </p>
+            </div>
+
+            {error ? (
+              <p className="text-sm text-destructive" role="alert">
+                {error}
+              </p>
+            ) : null}
+
+            <Button type="submit" className="w-full" disabled={isSubmitting}>
+              {isSubmitting
+                ? t("sharePage.requestingAccess")
+                : t("sharePage.requestAccessWithEmail")}
+            </Button>
+          </form>
+        </div>
+      </DialogContent>
+    </Dialog>
+  );
+}

package/corpus/templates/clips/app/components/player/share-dialog.tsx

@@ -7,12 +7,7 @@ import {
 } from "@agent-native/core/client/hooks";
 import { useT } from "@agent-native/core/client/i18n";
 import { ShareAgentsSection } from "@agent-native/toolkit/sharing";
-import {
-  IconCode,
-  IconExternalLink,
-  IconLink,
-  IconMail,
-} from "@tabler/icons-react";
+import { IconExternalLink } from "@tabler/icons-react";
 import {
   useCallback,
   useEffect,
@@ -240,7 +235,7 @@ function ShareRecordingContent({
   // editor keep it regardless of visibility since they can flip to public
   // from inside it.
   const canEmbed = canViewShares || visibility === "public";
-  const tabCount = 1 + (canViewShares ? 1 : 0) + (canEmbed ? 1 : 0);
+  const tabCount = 1 + (canEmbed ? 1 : 0);
 
   // Attribution `via` must be a stable non-PII id, never an email. The only
   // owner id available client-side is the *current* session's userId, which is
@@ -266,21 +261,19 @@ function ShareRecordingContent({
       >
         {tabCount > 1 ? (
           <TabsList
-            className={`grid w-full ${tabCount === 3 ? "grid-cols-3" : "grid-cols-2"}`}
+            className={`grid w-full rounded-xl bg-muted/70 p-1 ${tabCount === 3 ? "grid-cols-3" : "grid-cols-2"}`}
           >
-            <TabsTrigger value="link" className="gap-1.5">
-              <IconLink size={14} />
+            <TabsTrigger
+              value="link"
+              className="h-10 rounded-lg px-3 text-sm font-medium text-muted-foreground transition-colors data-[state=active]:bg-background data-[state=active]:text-foreground data-[state=active]:shadow-sm data-[state=active]:ring-1 data-[state=active]:ring-border"
+            >
               {t("shareDialog.link")}
             </TabsTrigger>
-            {canViewShares ? (
-              <TabsTrigger value="invite" className="gap-1.5">
-                <IconMail size={14} />
-                {t("shareDialog.invite")}
-              </TabsTrigger>
-            ) : null}
             {canEmbed ? (
-              <TabsTrigger value="embed" className="gap-1.5">
-                <IconCode size={14} />
+              <TabsTrigger
+                value="embed"
+                className="h-10 rounded-lg px-3 text-sm font-medium text-muted-foreground transition-colors data-[state=active]:bg-background data-[state=active]:text-foreground data-[state=active]:shadow-sm data-[state=active]:ring-1 data-[state=active]:ring-border"
+              >
                 {t("shareDialog.embed")}
               </TabsTrigger>
             ) : null}
@@ -304,24 +297,6 @@ function ShareRecordingContent({
           />
         </TabsContent>
 
-        {canViewShares ? (
-          <TabsContent value="invite" className="mt-3">
-            <SharePeopleTab
-              resourceType="recording"
-              resourceId={recordingId}
-              resourceUrl={absoluteAppUrl(`/r/${recordingId}`)}
-              sharesQuery={sharesQuery}
-              canManage={canManage}
-              roleCopy={{
-                commenter: {
-                  label: t("shareUi.recordingCommenter.label"),
-                  description: t("shareUi.recordingCommenter.description"),
-                },
-              }}
-            />
-          </TabsContent>
-        ) : null}
-
         {canEmbed ? (
           <TabsContent value="embed" className="mt-3">
             <ClipsEmbedConfigurator
@@ -523,6 +498,16 @@ function LinkTab({
 
   return (
     <div className="space-y-4">
+      <CopyField
+        label={
+          isPublic
+            ? t("shareDialog.shareLink")
+            : t("shareDialog.shareWithHumans")
+        }
+        value={shareUrl}
+        disabled={visibilityPending || !sharesLoaded}
+      />
+
       {canViewShares ? (
         visibility ? (
           <GeneralAccessSelect
@@ -541,15 +526,21 @@ function LinkTab({
         )
       ) : null}
 
-      <CopyField
-        label={
-          isPublic
-            ? t("shareDialog.shareLink")
-            : t("shareDialog.shareWithHumans")
-        }
-        value={shareUrl}
-        disabled={visibilityPending || !sharesLoaded}
-      />
+      {canViewShares ? (
+        <SharePeopleTab
+          resourceType="recording"
+          resourceId={recordingId}
+          resourceUrl={absoluteAppUrl(`/r/${recordingId}`)}
+          sharesQuery={sharesQuery}
+          canManage={canManage}
+          roleCopy={{
+            commenter: {
+              label: t("shareUi.recordingCommenter.label"),
+              description: t("shareUi.recordingCommenter.description"),
+            },
+          }}
+        />
+      ) : null}
 
       <ShareAgentsSection
         label={t("shareDialog.shareWithAgents")}

package/corpus/templates/clips/app/components/sharing/share-ui.tsx

@@ -81,8 +81,8 @@ export const ROLE_OPTIONS: Array<{ value: Role; label: string }> = [
   { value: "admin", label: "Admin" },
 ];
 
-export function copyToClipboard(value: string): void {
-  void writeClipboardText(value);
+export function copyToClipboard(value: string): Promise<boolean> {
+  return writeClipboardText(value);
 }
 
 // ---------------------------------------------------------------------------
@@ -288,10 +288,7 @@ export function CopyField({
       disabled={disabled}
       copyLabel={t("shareUi.copy")}
       copiedLabel={t("recordRoute.linkCopied")}
-      onCopy={(nextValue) => {
-        copyToClipboard(nextValue);
-        return true;
-      }}
+      onCopy={copyToClipboard}
     />
   );
 }

package/corpus/templates/clips/app/i18n/en-US.ts

@@ -260,12 +260,37 @@ const messages = {
     privateClipMessage:
       "This clip is private. Request access and the owner will be notified.",
     privateClipSignedOutMessage:
-      "This clip is private. Sign in to request access from the owner.",
+      "This clip is private. Sign in or enter your email to request access.",
     requestAccess: "Request access",
+    requestAccessDialogTitle: "Request access",
+    requestAccessDialogDescription:
+      "Sign in, or enter the email address the owner should share this clip with.",
+    requestAccessSignIn: "Sign in or sign up",
+    requestAccessOr: "or",
+    requestAccessEmailLabel: "Email address",
+    requestAccessEmailPlaceholder: "you@example.com",
+    requestAccessEmailHint:
+      "After access is granted, sign in with this email to view the clip.",
+    requestAccessWithEmail: "Request with email",
+    requestAccessEmailRequired: "Enter a valid email address.",
     requestingAccess: "Requesting access...",
     accessRequested: "Access requested",
     accessRequestSent: "The clip owner was notified.",
+    accessRequestSentWithEmail:
+      "The clip owner was asked to share this clip with {{email}}.",
     accessRequestFailed: "Couldn't request access. Try again.",
+    accessApprovalTitle: "Access granted",
+    accessApprovalAlreadyTitle: "Access already granted",
+    accessApprovalMessage: "{{email}} can now view this clip.",
+    accessApprovalAlreadyMessage: "{{email}} already has access to this clip.",
+    accessApprovalErrorTitle: "Couldn't grant access",
+    accessApprovalInvalid: "This access request is invalid or expired.",
+    accessApprovalSignInTitle: "Sign in to allow access",
+    accessApprovalSignInMessage:
+      "Sign in as the clip owner or admin to approve this request.",
+    accessApprovalOpenClip: "Open clip",
+    accessApprovalSignIn: "Sign in",
+    accessApprovalLoading: "Granting access...",
     clipUnavailable: "Clip unavailable",
     clipUnavailableMessage:
       "This recording isn't public, or the link is invalid. If it's your clip, sign in to check access.",

package/corpus/templates/clips/app/lib/public-meeting.ts

@@ -39,7 +39,7 @@ export interface PublicMeeting {
   actualStart: string | null;
   actualEnd: string | null;
   transcriptStatus: string | null;
-  transcript?: PublicMeetingTranscript | null;
+  transcript: PublicMeetingTranscript | null;
 }
 
 export interface PublicMeetingPayload {