@agent-native/core 0.153.1 → 0.153.2

package/corpus/templates/analytics/.agents/skills/adhoc-analysis/SKILL.md

@@ -101,25 +101,27 @@ Don't just dump raw data. Synthesize findings:
 
 ### Step 4: Generate Charts (when useful)
 
-When the analysis benefits from a visual — trends over time, distributions, comparisons between categories — call `generate-chart` before formatting the report. The action returns a `url` you embed directly in the markdown.
-
-```
-generate-chart
-  --title "Closed-lost deals by month"
-  --type bar
-  --labels '["Jan","Feb","Mar"]'
-  --data '[18, 22, 14]'
-```
-
-Embed the returned URL in `resultMarkdown` using standard markdown image syntax:
-
-```markdown
-![Closed-lost deals by month](/api/media/closed-lost-deals-by-month-1234567890.png?v=1234567890)
-```
-
-You can include multiple charts in one analysis. Reach for a chart when it communicates the finding faster than a table — don't force visuals on every analysis.
-
-Include the re-generation step in your saved `instructions` so re-runs produce fresh charts.
+When the analysis benefits from a visual — trends over time, distributions, or
+comparisons between categories — query the data first, then use the live
+`/chart` embed described in `data-querying` for an in-chat answer. Do not call
+`generate-chart` for a one-off chat result: it produces a static image for
+saved artifacts, requires pre-stringified JSON, and does not count as a real
+data query for the final response guard.
+
+For a stacked multi-series bar chart, keep the query in long form and emit a
+panel with `chartType: "bar"`, `config.pivot` containing `xKey`, `seriesKey`,
+and `valueKey`, plus `config.stacked: true`. The live chart route pivots the
+rows and renders one stack per x-axis category. See `data-querying`'s
+"Inline Charts In Chat" section for the exact `embed` fence and encoding.
+
+Only use `generate-chart` when a saved analysis artifact explicitly needs a
+static image. If it returns an error while answering in chat, switch to the
+live embed instead of retrying reformatted `labels` or `data` parameters.
+
+You can include multiple live charts in one analysis. Reach for a chart when it
+communicates the finding faster than a table - don't force visuals on every
+analysis. Include the query and embed configuration in saved `instructions` so
+re-runs produce fresh charts.
 
 ### Step 5: Format Results as Markdown
 

package/corpus/templates/clips/app/components/meetings/share-meeting-dialog.tsx

@@ -12,7 +12,6 @@ import {
   CopyField,
   GeneralAccessSelect,
   MakePublicCard,
-  ShareCardHeader,
   SharePeopleTab,
   copyToClipboard,
   useResourceVisibilityMutation,
@@ -30,7 +29,6 @@ import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
 
 export interface ShareMeetingPopoverProps {
   meetingId: string;
-  meetingTitle?: string;
   shareTranscript: boolean;
   transcriptReady: boolean;
   children: ReactNode;
@@ -38,7 +36,6 @@ export interface ShareMeetingPopoverProps {
 
 export function ShareMeetingPopover({
   meetingId,
-  meetingTitle,
   shareTranscript,
   transcriptReady,
   children,
@@ -52,7 +49,6 @@ export function ShareMeetingPopover({
       >
         <ShareMeetingContent
           meetingId={meetingId}
-          meetingTitle={meetingTitle}
           shareTranscript={shareTranscript}
           transcriptReady={transcriptReady}
         />
@@ -63,12 +59,10 @@ export function ShareMeetingPopover({
 
 function ShareMeetingContent({
   meetingId,
-  meetingTitle,
   shareTranscript,
   transcriptReady,
 }: {
   meetingId: string;
-  meetingTitle?: string;
   shareTranscript: boolean;
   transcriptReady: boolean;
 }) {
@@ -85,14 +79,9 @@ function ShareMeetingContent({
 
   const data = sharesQuery.data;
   const canManage = data?.role === "owner" || data?.role === "admin";
-  const titleText = meetingTitle
-    ? t("clipsFinalRaw.shareNamedMeeting", { title: meetingTitle })
-    : t("clipsFinalRaw.shareMeeting");
 
   return (
     <>
-      <ShareCardHeader title={titleText} ownerEmail={data?.ownerEmail} />
-
       <Tabs defaultValue="link" className="min-w-0 px-4 py-3">
         <TabsList className="grid w-full grid-cols-2">
           <TabsTrigger value="link" className="gap-1.5">

package/corpus/templates/clips/app/components/player/share-dialog.tsx

@@ -27,7 +27,6 @@ import {
   CopyField,
   GeneralAccessSelect,
   MakePublicCard,
-  ShareCardHeader,
   SharePeopleTab,
   copyToClipboard,
   useResourceVisibilityMutation,
@@ -51,6 +50,7 @@ import {
 } from "@/components/ui/popover";
 import { Switch } from "@/components/ui/switch";
 import { Tabs, TabsList, TabsTrigger, TabsContent } from "@/components/ui/tabs";
+import { cn } from "@/lib/utils";
 
 import { buildEmailPreviewMarkup } from "../../../shared/email-preview";
 import { isLoomEmbedUrl } from "../../../shared/loom";
@@ -228,19 +228,12 @@ function ShareRecordingContent({
           absoluteAppUrl(`/share/${recordingId}`),
           ownerViaId,
         );
-  const titleText = recordingTitle
-    ? t("shareDialog.shareTitle", { title: recordingTitle })
-    : t("shareDialog.shareRecording");
-
   return (
     <>
-      <ShareCardHeader
-        title={titleText}
-        ownerEmail={data?.ownerEmail}
-        reserveCloseButton={reserveCloseButton}
-      />
-
-      <Tabs defaultValue="link" className="min-w-0 px-4 py-3">
+      <Tabs
+        defaultValue="link"
+        className={cn("min-w-0 px-4 py-3", reserveCloseButton && "pe-12")}
+      >
         <TabsList className="grid w-full grid-cols-3">
           <TabsTrigger value="link" className="gap-1.5">
             <IconLink size={14} />
@@ -441,6 +434,25 @@ function LinkTab({
     ? t("shareDialog.agentPrompt", { agentContextUrl: agentLink })
     : "";
   const [agentDetailsOpen, setAgentDetailsOpen] = useState(false);
+  const showMakePublic = sharesLoaded && !isPublic && canManage;
+  const downloadButton = videoUrl ? (
+    <Button
+      variant="outline"
+      size="sm"
+      className={isLoomRecording ? "gap-1.5" : undefined}
+      onClick={() => window.open(videoUrl, "_blank", "noopener,noreferrer")}
+    >
+      {isLoomRecording ? (
+        <>
+          <IconExternalLink className="h-4 w-4" />
+          {t("shareDialog.openPlayer")}
+        </>
+      ) : (
+        t("recordRoute.downloadRecording")
+      )}
+    </Button>
+  ) : null;
+  const moveDownloadIntoMakePublicRow = showMakePublic && Boolean(videoUrl);
 
   useEffect(() => {
     if (isPublic) setAgentDetailsOpen(false);
@@ -540,9 +552,12 @@ function LinkTab({
         </Collapsible>
       ) : null}
 
-      {sharesLoaded && !isPublic && canManage ? (
+      {showMakePublic ? (
         <MakePublicCard
           isPending={isPending}
+          secondaryAction={
+            moveDownloadIntoMakePublicRow ? downloadButton : undefined
+          }
           onMakePublic={() =>
             setResourceVisibility("public", {
               onSuccess: () => copyToClipboard(shareUrl),
@@ -551,7 +566,9 @@ function LinkTab({
         />
       ) : null}
 
-      {emailPreviewThumbnailUrl || videoUrl || animatedThumbnailUrl ? (
+      {emailPreviewThumbnailUrl ||
+      animatedThumbnailUrl ||
+      (videoUrl && !moveDownloadIntoMakePublicRow) ? (
         <div className="flex flex-wrap gap-2">
           {emailPreviewThumbnailUrl ? (
             <Button
@@ -571,25 +588,7 @@ function LinkTab({
               {t("shareDialog.gifPreview")}
             </Button>
           ) : null}
-          {videoUrl ? (
-            <Button
-              variant="outline"
-              size="sm"
-              className={isLoomRecording ? "gap-1.5" : undefined}
-              onClick={() =>
-                window.open(videoUrl, "_blank", "noopener,noreferrer")
-              }
-            >
-              {isLoomRecording ? (
-                <>
-                  <IconExternalLink className="h-4 w-4" />
-                  {t("shareDialog.openPlayer")}
-                </>
-              ) : (
-                t("recordRoute.downloadRecording")
-              )}
-            </Button>
-          ) : null}
+          {!moveDownloadIntoMakePublicRow ? downloadButton : null}
         </div>
       ) : null}
     </div>

package/corpus/templates/clips/app/components/sharing/share-ui.tsx

@@ -14,7 +14,7 @@ import {
   IconWorld,
 } from "@tabler/icons-react";
 import { useQueryClient } from "@tanstack/react-query";
-import { useMemo, useState } from "react";
+import { useMemo, useState, type ReactNode } from "react";
 
 import {
   Avatar as UserAvatar,
@@ -136,34 +136,19 @@ export function useResourceVisibilityMutation(
 }
 
 // ---------------------------------------------------------------------------
-// Header (title + owner)
+// Compact section labels
 // ---------------------------------------------------------------------------
 
-export function ShareCardHeader({
-  title,
-  ownerEmail,
-  reserveCloseButton = false,
+export function ShareSectionLabel({
+  children,
+  className,
 }: {
-  title: string;
-  ownerEmail?: string | null;
-  reserveCloseButton?: boolean;
+  children: ReactNode;
+  className?: string;
 }) {
-  const t = useT();
   return (
-    <div
-      className={cn(
-        "min-w-0 border-b border-border px-4 pb-3 pt-3",
-        reserveCloseButton && "pe-12",
-      )}
-    >
-      <div className="min-w-0 truncate text-sm font-semibold" title={title}>
-        {title}
-      </div>
-      {ownerEmail ? (
-        <div className="mt-0.5 truncate text-xs text-muted-foreground">
-          {t("shareUi.owner", { email: ownerEmail })}
-        </div>
-      ) : null}
+    <div className={cn("text-xs font-medium text-muted-foreground", className)}>
+      {children}
     </div>
   );
 }
@@ -197,9 +182,9 @@ export function GeneralAccessSelect({
 
   return (
     <div>
-      <div className="mb-2 text-xs font-semibold">
+      <ShareSectionLabel className="mb-2">
         {t("shareUi.generalAccess")}
-      </div>
+      </ShareSectionLabel>
       <div className="flex items-center gap-3">
         <span
           aria-hidden
@@ -245,9 +230,11 @@ export function GeneralAccessSelect({
 export function MakePublicCard({
   isPending,
   onMakePublic,
+  secondaryAction,
 }: {
   isPending: boolean;
   onMakePublic: () => void;
+  secondaryAction?: ReactNode;
 }) {
   const t = useT();
   return (
@@ -259,16 +246,21 @@ export function MakePublicCard({
         strokeWidth={1.8}
         className="text-muted-foreground"
       />
-      <Button
-        type="button"
-        variant="outline"
-        size="sm"
-        className="h-7"
-        onClick={onMakePublic}
-        disabled={isPending}
-      >
-        {isPending ? t("shareUi.makingPublic") : t("shareUi.makePublicAndCopy")}
-      </Button>
+      <div className="flex items-center gap-2">
+        {secondaryAction}
+        <Button
+          type="button"
+          variant="outline"
+          size="sm"
+          className="h-7"
+          onClick={onMakePublic}
+          disabled={isPending}
+        >
+          {isPending
+            ? t("shareUi.makingPublic")
+            : t("shareUi.makePublicAndCopy")}
+        </Button>
+      </div>
     </div>
   );
 }
@@ -297,9 +289,7 @@ export function CopyField({
   return (
     <div>
       {label ? (
-        <div className="mb-1 text-xs font-medium text-muted-foreground">
-          {label}
-        </div>
+        <ShareSectionLabel className="mb-1">{label}</ShareSectionLabel>
       ) : null}
       <div className="flex items-stretch gap-2">
         <Input

package/corpus/templates/clips/app/routes/_app.meetings.$meetingId.tsx

@@ -704,7 +704,6 @@ export default function MeetingDetailRoute() {
           ) : null}
           <ShareMeetingPopover
             meetingId={meeting.id}
-            meetingTitle={meeting.title}
             shareTranscript={meeting.shareTranscript === true}
             transcriptReady={
               meeting.transcriptStatus === "ready" &&