@agent-native/core-corpus 0.210.2 → 0.211.0

package/corpus/templates/content/shared/database-query.ts

@@ -1,12 +1,111 @@
 import type {
   ContentDatabaseFilter,
   ContentDatabaseFilterMode,
+  ContentDatabaseFilterOperator,
   ContentDatabaseItem,
   ContentDatabaseSort,
   ContentDatabaseTableQuery,
   DocumentProperty,
 } from "./api.js";
-import { documentPropertyDatePart, formulaValueText } from "./properties.js";
+import {
+  documentPropertyDatePart,
+  formulaValueText,
+  type DocumentPropertyType,
+} from "./properties.js";
+
+const OPTION_FILTER_OPERATORS = [
+  "contains",
+  "does_not_equal",
+  "is_empty",
+  "is_not_empty",
+] as const satisfies readonly ContentDatabaseFilterOperator[];
+
+const DATE_FILTER_OPERATORS = [
+  "equals",
+  "does_not_equal",
+  "before",
+  "after",
+  "between",
+  "is_empty",
+  "is_not_empty",
+] as const satisfies readonly ContentDatabaseFilterOperator[];
+
+const FILTER_OPERATORS_BY_TYPE: Partial<
+  Record<DocumentPropertyType, readonly ContentDatabaseFilterOperator[]>
+> = {
+  checkbox: ["is_checked", "is_unchecked"],
+  select: OPTION_FILTER_OPERATORS,
+  status: OPTION_FILTER_OPERATORS,
+  multi_select: OPTION_FILTER_OPERATORS,
+  person: OPTION_FILTER_OPERATORS,
+  number: [
+    "equals",
+    "does_not_equal",
+    "greater_than",
+    "less_than",
+    "greater_than_or_equal",
+    "less_than_or_equal",
+    "is_empty",
+    "is_not_empty",
+  ],
+  date: DATE_FILTER_OPERATORS,
+  created_time: DATE_FILTER_OPERATORS,
+  last_edited_time: DATE_FILTER_OPERATORS,
+};
+
+const DEFAULT_FILTER_OPERATORS = [
+  "contains",
+  "equals",
+  "does_not_equal",
+  "is_empty",
+  "is_not_empty",
+] as const satisfies readonly ContentDatabaseFilterOperator[];
+
+const VALUELESS_FILTER_OPERATORS: ReadonlySet<ContentDatabaseFilterOperator> =
+  new Set(["is_empty", "is_not_empty", "is_checked", "is_unchecked"]);
+
+const NUMBER_FILTER_COMPARISONS: Partial<
+  Record<
+    ContentDatabaseFilterOperator,
+    (current: number, target: number) => boolean
+  >
+> = {
+  greater_than: (current, target) => current > target,
+  less_than: (current, target) => current < target,
+  greater_than_or_equal: (current, target) => current >= target,
+  less_than_or_equal: (current, target) => current <= target,
+};
+
+// Listed in menu order; the first entry is the operator a new filter starts with.
+export function contentDatabaseFilterOperatorsForType(
+  type: DocumentPropertyType,
+): readonly ContentDatabaseFilterOperator[] {
+  return FILTER_OPERATORS_BY_TYPE[type] ?? DEFAULT_FILTER_OPERATORS;
+}
+
+export function contentDatabaseFilterOperatorNeedsValue(
+  operator: ContentDatabaseFilterOperator,
+) {
+  return !VALUELESS_FILTER_OPERATORS.has(operator);
+}
+
+// A "between" value is a JSON [start, end] pair. Read it by position: a
+// one-day range repeats its date, so deduplicating would lose the end.
+export function contentDatabaseFilterDateRangeValues(
+  value: string,
+): [string, string] {
+  const trimmed = value.trim();
+  if (!trimmed) return ["", ""];
+  try {
+    const parsed = JSON.parse(trimmed) as unknown;
+    if (!Array.isArray(parsed)) return [trimmed, ""];
+    const start = typeof parsed[0] === "string" ? parsed[0].trim() : "";
+    const end = typeof parsed[1] === "string" ? parsed[1].trim() : "";
+    return [start, end];
+  } catch {
+    return [trimmed, ""];
+  }
+}
 
 export function applyContentDatabaseTableQuery(
   items: ContentDatabaseItem[],
@@ -94,11 +193,7 @@ function combineMatches(
 }
 
 function isActiveFilter(filter: ContentDatabaseFilter) {
-  if (
-    !["is_empty", "is_not_empty", "is_checked", "is_unchecked"].includes(
-      filter.operator,
-    )
-  ) {
+  if (contentDatabaseFilterOperatorNeedsValue(filter.operator)) {
     return selectedFilterValues(filter.value).length > 0;
   }
   return true;
@@ -116,13 +211,12 @@ function itemMatchesFilter(
   if (filter.operator === "is_checked") return property?.value === true;
   if (filter.operator === "is_unchecked") return property?.value !== true;
 
-  if (filter.operator === "greater_than" || filter.operator === "less_than") {
+  const compareNumbers = NUMBER_FILTER_COMPARISONS[filter.operator];
+  if (compareNumbers) {
     const current = propertyNumberValue(property);
     const target = Number(filter.value.trim());
     if (!Number.isFinite(current) || !Number.isFinite(target)) return false;
-    return filter.operator === "greater_than"
-      ? current > target
-      : current < target;
+    return compareNumbers(current, target);
   }
 
   if (
@@ -198,9 +292,9 @@ function selectedFilterValues(value: string) {
 }
 
 function filterDateRange(value: string): [number, number] | null {
-  const values = selectedFilterValues(value);
-  const start = new Date(values[0] ?? "").getTime();
-  const end = new Date(values[1] ?? "").getTime();
+  const [startValue, endValue] = contentDatabaseFilterDateRangeValues(value);
+  const start = new Date(startValue).getTime();
+  const end = new Date(endValue).getTime();
   if (!Number.isFinite(start) || !Number.isFinite(end)) return null;
   return start <= end ? [start, end] : [end, start];
 }

package/corpus/templates/content/shared/suggestion-diff.ts

@@ -951,6 +951,41 @@ export function markdownSuggestionOperationsForFindReplace(input: {
   return operations;
 }
 
+/**
+ * Splits several non-overlapping find/replace edits against one source the
+ * way one edit is split. Each operation's anchor context stops at its
+ * neighbors, so accepting one never rewrites the text another is found by.
+ */
+export function markdownSuggestionOperationsForFindReplaceEdits(input: {
+  before: string;
+  edits: ReadonlyArray<{ find: string; replace: string; start: number }>;
+}): MarkdownSuggestionOperation[] {
+  return isolateSiblingAnchorContexts(
+    input.edits
+      .flatMap((edit) =>
+        markdownSuggestionOperationsForFindReplace({
+          before: input.before,
+          ...edit,
+        }),
+      )
+      .sort((left, right) => left.anchor.from - right.anchor.from)
+      .map((operation, ordinal) => ({ ...operation, ordinal })),
+  );
+}
+
+/** A one-line review label for a single operation's change. */
+export function markdownSuggestionOperationSummary(
+  operation: MarkdownSuggestionOperation,
+): string {
+  const removed = operation.before.changedText.slice(0, 80);
+  const inserted = operation.after.changedText.slice(0, 80);
+  return removed && inserted
+    ? `Replace "${removed}" with "${inserted}"`
+    : removed
+      ? `Delete "${removed}"`
+      : `Insert "${inserted}"`;
+}
+
 export function markdownSuggestionOperationsForReplacements(input: {
   before: string;
   after: string;

package/corpus/templates/crm/.agents/skills/actions/references/action-fields.md

@@ -95,9 +95,9 @@ MCP clients see no `outputSchema` by default. Set `mcpOutputSchema: true` (requi
 
 `authorize` decides whether the caller may run the action at all. It wraps
 `run`, so it holds at **all six dispatch sites** — agent tool, HTTP, frontend
-hook, MCP, A2A, CLI — unlike `needsApproval`, which is honoured only in the
-agent loop. Use `authorize` for "not everyone may do this"; use `needsApproval`
-to ask a human to bless one call a permitted caller is already allowed to make.
+hook, MCP, A2A, CLI. Use `authorize` for "not everyone may do this"; use
+`needsApproval` to ask a human to bless one call a permitted caller is already
+allowed to make.
 
 ```ts
 import { coachAccess } from "../lib/access.js"; // defineAppRoles(...)
@@ -140,4 +140,6 @@ export default defineAction({
 
 When the gate is truthy and the call isn't yet approved, the loop emits an `approval_required` event and **stops the turn — `run()` never executes**. A predicate gates conditionally (e.g. only external recipients) and **fails closed**: a throw is treated as "approval required". It receives its own copy of the prepared snapshot of the validated arguments, defaults applied, and the approval binds to the snapshot's hash, so an approved call runs only with the arguments that were approved (a Date binds by its time). The human approves via the chat UI's Approve affordance, which re-issues the turn with the call's `approvalKey`, and only then does the action run.
 
+Approval is given in the app, so HTTP never grants it. The HTTP action route and the generated Workers entry run a gated call only for the proven app UI (a frontend call from the signed-in user, same origin, holding the short-lived UI capability; `isProvenUiRequest`, the proof `uiOnly` uses) or the app's MCP directory widget. Every other HTTP caller (bearer or API key, MCP OAuth token, org service token, A2A, extension iframe, mobile app) gets `409 approval_required`, and a service identity can never approve. The shared client presents the capability with every write from a signed-in session (minted once per user, reused for nine minutes, never for reads or public pages), so a gated button works on its first request. A call without proof gets `403 ui_capability_required`; the client then re-mints and retries once, which is only the fallback for an expired or rejected capability. Every surface evaluates the gate through `preparedCallNeedsApproval`, so a throwing predicate asks there too. A caller that must run unattended needs a different action, never a bypass of the gate.
+
 **Keep approvals rare** — the default is off and almost every action should leave it off. The canonical example is Mail's `send-email` (`needsApproval: true`). See the `security` skill and the Human Approval doc.

package/corpus/templates/design/.agents/skills/actions/references/action-fields.md

@@ -95,9 +95,9 @@ MCP clients see no `outputSchema` by default. Set `mcpOutputSchema: true` (requi
 
 `authorize` decides whether the caller may run the action at all. It wraps
 `run`, so it holds at **all six dispatch sites** — agent tool, HTTP, frontend
-hook, MCP, A2A, CLI — unlike `needsApproval`, which is honoured only in the
-agent loop. Use `authorize` for "not everyone may do this"; use `needsApproval`
-to ask a human to bless one call a permitted caller is already allowed to make.
+hook, MCP, A2A, CLI. Use `authorize` for "not everyone may do this"; use
+`needsApproval` to ask a human to bless one call a permitted caller is already
+allowed to make.
 
 ```ts
 import { coachAccess } from "../lib/access.js"; // defineAppRoles(...)
@@ -140,4 +140,6 @@ export default defineAction({
 
 When the gate is truthy and the call isn't yet approved, the loop emits an `approval_required` event and **stops the turn — `run()` never executes**. A predicate gates conditionally (e.g. only external recipients) and **fails closed**: a throw is treated as "approval required". It receives its own copy of the prepared snapshot of the validated arguments, defaults applied, and the approval binds to the snapshot's hash, so an approved call runs only with the arguments that were approved (a Date binds by its time). The human approves via the chat UI's Approve affordance, which re-issues the turn with the call's `approvalKey`, and only then does the action run.
 
+Approval is given in the app, so HTTP never grants it. The HTTP action route and the generated Workers entry run a gated call only for the proven app UI (a frontend call from the signed-in user, same origin, holding the short-lived UI capability; `isProvenUiRequest`, the proof `uiOnly` uses) or the app's MCP directory widget. Every other HTTP caller (bearer or API key, MCP OAuth token, org service token, A2A, extension iframe, mobile app) gets `409 approval_required`, and a service identity can never approve. The shared client presents the capability with every write from a signed-in session (minted once per user, reused for nine minutes, never for reads or public pages), so a gated button works on its first request. A call without proof gets `403 ui_capability_required`; the client then re-mints and retries once, which is only the fallback for an expired or rejected capability. Every surface evaluates the gate through `preparedCallNeedsApproval`, so a throwing predicate asks there too. A caller that must run unattended needs a different action, never a bypass of the gate.
+
 **Keep approvals rare** — the default is off and almost every action should leave it off. The canonical example is Mail's `send-email` (`needsApproval: true`). See the `security` skill and the Human Approval doc.

package/corpus/templates/design/CHANGELOG.md

@@ -11,6 +11,7 @@ from the command menu (Cmd+K → "What's new") or from Settings.
 
 ### Fixed
 
+- Comments return to the prior Interact screen and device, stay open when that return is blocked, and fall back to Design if that screen was removed. Layers search toggles closed.
 - Public Design viewers no longer see repeated PNG export errors
 - Design resizes more high-resolution reference images before adding them to a prompt.
 - Review menus no longer trigger canvas gestures, and rewrite previews and proposal controls follow the uniquely resolved target.
@@ -29,6 +30,7 @@ from the command menu (Cmd+K → "What's new") or from Settings.
 
 ### Fixed
 
+- Reply and Edit on a comment, in the sidebar or on a canvas pin, put the cursor in the box, after the text when editing.
 - Comment mode no longer selects or hovers the design underneath, and pan and zoom work while commenting.
 - Text color adapts when layers move between screens with different backgrounds
 - Text keeps readable contrast when moved between screens with different backgrounds.

package/corpus/templates/design/actions/delete-file.ts

@@ -432,10 +432,7 @@ export default defineAction({
         "Legacy frontend checkpoint to validate before a delete; the live pre-delete version is always captured in the delete transaction.",
       ),
   }),
-  // MCP evaluates approval against raw arguments before the action schema
-  // normalizes boolean strings, so use the same truthiness boundary here.
-  needsApproval: (args) =>
-    Boolean((args as unknown as Record<string, unknown>).allowLockedLayers),
+  needsApproval: ({ allowLockedLayers }) => allowLockedLayers,
   allowPersistentApproval: false,
   run: async (
     { id, fileIds, allowLockedLayers, historyCheckpointId },

package/corpus/templates/design/app/components/design/LayersPanel.tsx

@@ -1188,6 +1188,15 @@ function LayersPanelImpl(
     window.requestAnimationFrame(() => searchInputRef.current?.focus());
   }, []);
 
+  const toggleSearch = useCallback(() => {
+    if (searchOpen || searchQuery.trim()) {
+      setSearchOpen(false);
+      if (searchQuery) onSearchQueryChange("");
+      return;
+    }
+    focusSearch();
+  }, [focusSearch, onSearchQueryChange, searchOpen, searchQuery]);
+
   const beginRename = useCallback(
     (layerId: string): boolean => {
       if (!onRename) return false;
@@ -1570,7 +1579,7 @@ function LayersPanelImpl(
             <IconTooltipButton
               label={labels.searchPlaceholder}
               dataAction="search"
-              onClick={focusSearch}
+              onClick={toggleSearch}
             >
               <IconSearch
                 className="!size-[var(--design-icon-size)]"

package/corpus/templates/design/app/components/visual-editor/ReviewCanvasPins.tsx

@@ -1108,6 +1108,8 @@ export function ReviewCanvasPins({
   const setUnread = useSetReviewThreadUnread();
   const updateComment = useUpdateReviewComment();
   const [canvas, setCanvas] = useState<HTMLElement | null>(null);
+  const onCloseRef = useRef(onClose);
+  onCloseRef.current = onClose;
   const [layoutTick, setLayoutTick] = useState(0);
   const [draftPin, setDraftPin] = useState<ReviewDraftPin | null>(null);
   const [draftAttachments, setDraftAttachments] = useState<
@@ -1964,8 +1966,8 @@ export function ReviewCanvasPins({
     setReplyAttachments([]);
     setReplyMentions([]);
     setExpandedClusterKey(null);
-    if (active) onClose();
-  }, [active, cancelDraft, hidden, onClose]);
+    if (active) onCloseRef.current();
+  }, [active, cancelDraft, hidden]);
 
   const dropCanvasPin = useCallback(
     (canvasPoint: ReviewCanvasPoint) => {
@@ -3977,6 +3979,7 @@ function ReviewThreadPopover({
   onSendToAgent?: () => void;
 }) {
   const t = useT();
+  const editChosenFromMenuRef = useRef(false);
   const rootAuthor = reviewAuthorLabel(thread.root, t("review.reviewer"));
   const avatarUrl = useAvatarUrl(thread.root.authorEmail);
   const [replyUploading, setReplyUploading] = useState(false);
@@ -4015,6 +4018,7 @@ function ReviewThreadPopover({
               mentionLabel={t("review.mention")}
               noMentionsLabel={t("review.noMentions")}
               textareaProps={{ "aria-label": t("review.editComment") }}
+              autoFocus
               disabled={updating}
               onChange={onEditDraftChange}
               onSubmit={() => onEditSubmit()}
@@ -4058,9 +4062,24 @@ function ReviewThreadPopover({
               <IconDots className="size-3.5" />
             </Button>
           </DropdownMenuTrigger>
-          <DropdownMenuContent data-review-popover align="end" className="w-44">
+          <DropdownMenuContent
+            data-review-popover
+            align="end"
+            className="w-44"
+            onCloseAutoFocus={(event) => {
+              // Edit puts focus in its composer; leave it there. Other
+              // actions return to the button.
+              if (editChosenFromMenuRef.current) event.preventDefault();
+              editChosenFromMenuRef.current = false;
+            }}
+          >
             {canEdit ? (
-              <DropdownMenuItem onSelect={onEdit}>
+              <DropdownMenuItem
+                onSelect={() => {
+                  editChosenFromMenuRef.current = true;
+                  onEdit();
+                }}
+              >
                 {t("review.editComment")}
               </DropdownMenuItem>
             ) : null}
@@ -4144,6 +4163,7 @@ function ReviewThreadPopover({
                 mentionLabel={t("review.mention")}
                 noMentionsLabel={t("review.noMentions")}
                 textareaProps={{ "data-review-reply-input": true }}
+                autoFocus
                 disabled={replying || resolving || replyUploading}
                 onChange={onReplyDraftChange}
                 onSubmit={() => onReply()}

package/corpus/templates/design/app/pages/design-editor/commands/mode-change.ts

@@ -97,7 +97,7 @@ export function runModeChange(
     /** A screen change made from inside Interact keeps the chosen device. */
     keepInteractDevice?: boolean;
   },
-) {
+): boolean {
   const next = resolveModeForAnnotateLab(requested, annotateLab);
   const interactEntry =
     next === "interact"
@@ -120,7 +120,7 @@ export function runModeChange(
     : options?.targetFileId
       ? files.find((file) => file.id === options.targetFileId)
       : activeFile;
-  if (!canEditDesign && next === "annotate") return;
+  if (!canEditDesign && next === "annotate") return false;
   if (interactEntry && !nextActiveFile) {
     toast.error(
       t(
@@ -129,9 +129,9 @@ export function runModeChange(
           : "designEditor.responsiveInteract.unknownScreen",
       ),
     );
-    return;
+    return false;
   }
-  if (next === "annotate" && !nextActiveFile) return;
+  if (next === "annotate" && !nextActiveFile) return false;
   if (
     next === "interact" &&
     hasPendingVisualEdits &&
@@ -140,7 +140,7 @@ export function runModeChange(
   ) {
     onPendingVisualEditsBlocked();
     toast.error(t("designEditor.pendingVisualStyles.interactBlocked"));
-    return;
+    return false;
   }
   if (options?.discardPendingLiveEdits) {
     requestPendingVisualStyleRevert(pendingVisualStyleEdits);
@@ -155,13 +155,17 @@ export function runModeChange(
   if (routing === "enter-single-interact") {
     rememberOverviewScreenSelection(nextActiveFile!.id);
     setOverviewInteractScreenId(nextActiveFile!.id);
-    enterSingleScreen(nextActiveFile?.id);
-    return;
+    if (options?.keepInteractDevice) {
+      enterSingleScreen(nextActiveFile?.id, { keepInteractDevice: true });
+    } else {
+      enterSingleScreen(nextActiveFile?.id);
+    }
+    return true;
   }
   if (routing === "enter-overview") {
     if (options?.targetFileId) setActiveFileId(options.targetFileId);
     enterOverviewFromZoom(next);
-    return;
+    return true;
   }
   if (next === "interact" && overviewInteractScreenId) {
     setOverviewInteractScreenId(nextActiveFile!.id);
@@ -175,7 +179,7 @@ export function runModeChange(
       } else {
         enterSingleScreen(nextActiveFile!.id);
       }
-      return;
+      return true;
     }
   }
   if (options?.targetFileId) setActiveFileId(options.targetFileId);
@@ -202,4 +206,5 @@ export function runModeChange(
     setDrawMode(false);
     setPinMode(false);
   }
+  return true;
 }

package/corpus/templates/design/app/pages/design-editor/domains/use-editor-modes.ts

@@ -48,6 +48,8 @@ import {
 import { computeInteractZoomToFit } from "../responsive-interact";
 import { hasSelectableCodeLayerParent } from "../selection-state";
 import {
+  commentModeReturnOptions,
+  resolveCommentModeExit,
   resolveDrawStateWithoutLab,
   resolveModeForAnnotateLab,
   shouldAutoEnableDrawOverlay,
@@ -466,6 +468,16 @@ export function useEditorModes({
 
   const lastSettledSingleZoomRef = useRef<number | null>(null);
   const suppressOverviewPopForExplicitZoomRef = useRef(false);
+  const commentReturnOptionsRef =
+    useRef<ReturnType<typeof commentModeReturnOptions>>(null);
+  useEffect(() => {
+    if (mode === "annotate") return;
+    commentReturnOptionsRef.current = commentModeReturnOptions(
+      mode,
+      activeFile?.id,
+    );
+  }, [activeFile?.id, mode]);
+
   useEffect(() => {
     if (!activeFile || viewMode !== "single" || mode !== "edit") {
       lastSettledSingleZoomRef.current = null;
@@ -781,12 +793,21 @@ export function useEditorModes({
   ]);
 
   const handleExitReviewCommentMode = useCallback(() => {
+    const exit = resolveCommentModeExit(
+      commentReturnOptionsRef.current,
+      new Set(overviewScreens.map((screen) => screen.id)),
+      new Set(files.map((file) => file.id)),
+    );
+    if (exit.mode === "interact" && !handleModeChange("interact", exit.options))
+      return;
+
+    commentReturnOptionsRef.current = null;
     setPinMode(false);
     setOverviewCommentPinRequest(null);
     setDrawMode(false);
     setActiveTool("move");
-    setMode("edit");
-  }, []);
+    if (exit.mode === "edit") setMode("edit");
+  }, [files, handleModeChange, overviewScreens]);
 
   const handleOverviewCommentPin = useCallback(
     (canvasPoint: { x: number; y: number }) => {

package/corpus/templates/design/app/pages/design-editor/tool-state.ts

@@ -82,6 +82,35 @@ export function normalizeDesignMode(value: unknown): EditorMode | null {
     : null;
 }
 
+export function commentModeReturnOptions(
+  mode: EditorMode,
+  activeFileId: string | null | undefined,
+): CommentModeReturnOptions | null {
+  return mode === "interact" && activeFileId
+    ? { targetFileId: activeFileId, keepInteractDevice: true }
+    : null;
+}
+
+export interface CommentModeReturnOptions {
+  targetFileId: string;
+  keepInteractDevice: true;
+}
+
+export function resolveCommentModeExit(
+  returnOptions: CommentModeReturnOptions | null,
+  screenIds: ReadonlySet<string>,
+  fileIds: ReadonlySet<string>,
+): { mode: "interact"; options: CommentModeReturnOptions } | { mode: "edit" } {
+  if (
+    returnOptions &&
+    screenIds.has(returnOptions.targetFileId) &&
+    fileIds.has(returnOptions.targetFileId)
+  ) {
+    return { mode: "interact", options: returnOptions };
+  }
+  return { mode: "edit" };
+}
+
 /**
  * `loading` is the stretch before the Labs answer arrives. It reads as off, but
  * a request that needs the lab waits for the answer instead of being refused.

package/corpus/templates/design/changelog/2026-10-19-reply-and-edit-on-a-comment-in-the-sidebar-or-on-a-canvas-pi.md

@@ -0,0 +1,6 @@
+---
+type: fixed
+date: 2026-10-19
+---
+
+Reply and Edit on a comment, in the sidebar or on a canvas pin, put the cursor in the box, after the text when editing.

package/corpus/templates/design/changelog/2026-10-20-comments-return-to-the-mode-they-came-from-and-layers-search.md

@@ -0,0 +1,6 @@
+---
+type: fixed
+date: 2026-10-20
+---
+
+Comments return to the prior Interact screen and device, stay open when that return is blocked, and fall back to Design if that screen was removed. Layers search toggles closed.