@africode/core 5.0.4 → 5.0.6

package/core/lipa-namba-journey.js

@@ -134,6 +134,22 @@ export class LipaNambaJourney extends EventEmitter {
 
         const validated = schema.parse(request);
 
+        // Deduplicate by reference when provided: return existing session if found
+        if (validated.reference) {
+            for (const session of this.sessions.values()) {
+                if (session.reference === validated.reference) {
+                    return {
+                        ok: true,
+                        paymentRequestId: session.id,
+                        sessionData: session,
+                        message: 'DUPLICATE_REFERENCE',
+                        nextStep: session.status === 'INITIATED' ? 'IDENTIFY_CUSTOMER' : undefined,
+                        expiresIn: Math.max(0, Math.floor((new Date(session.expiresAt) - Date.now()) / 1000))
+                    };
+                }
+            }
+        }
+
         // Verify merchant is registered and compliant
         const merchantStatus = await this._verifyMerchantCompliance(validated.merchantId);
         if (!merchantStatus.ok) {
@@ -400,7 +416,7 @@ export class LipaNambaJourney extends EventEmitter {
         try {
             // Step 1: Initiate
             const init = await this.initiatePayment(request);
-            if (!init.ok) return init;
+            if (!init.ok) return { ok: false, error: init.error || 'INITIATION_FAILED', completedSteps: steps };
             steps.push({ step: 'INITIATE', ok: true });
 
             // Step 2: Identify
@@ -409,7 +425,7 @@ export class LipaNambaJourney extends EventEmitter {
                 credentials.nin,
                 credentials.pin
             );
-            if (!identify.ok) return identify;
+            if (!identify.ok) return { ok: false, error: identify.error || 'IDENTIFICATION_FAILED', completedSteps: steps };
             steps.push({ step: 'IDENTIFY', ok: true });
 
             // Step 3: AML Screen
@@ -417,7 +433,7 @@ export class LipaNambaJourney extends EventEmitter {
                 init.paymentRequestId,
                 identify.customerId
             );
-            if (!aml.ok) return aml;
+            if (!aml.ok) return { ok: false, error: aml.error || 'AML_SCREEN_FAILED', completedSteps: steps };
             steps.push({ step: 'AML_SCREEN', ok: true });
 
             // Step 4: Confirm
@@ -426,7 +442,7 @@ export class LipaNambaJourney extends EventEmitter {
                 identify.customerId,
                 confirmation.code
             );
-            if (!confirm.ok) return confirm;
+            if (!confirm.ok) return { ok: false, error: confirm.error || 'CONFIRMATION_FAILED', completedSteps: steps };
             steps.push({ step: 'CONFIRM', ok: true });
 
             // Step 5: Process
@@ -434,7 +450,7 @@ export class LipaNambaJourney extends EventEmitter {
                 init.paymentRequestId,
                 identify.customerId
             );
-            if (!process.ok) return process;
+            if (!process.ok) return { ok: false, error: process.error || 'PROCESSING_FAILED', completedSteps: steps };
             steps.push({ step: 'PROCESS', ok: true });
 
             return {
@@ -525,7 +541,13 @@ export class LipaNambaJourney extends EventEmitter {
 
     async _verifyNIDA(nin, pin) {
         // Implementation calls NIDA CIG
-        // For now, return mock
+        // For now, provide a deterministic mock: valid NIN is 20 digits
+        const ninPattern = /^[0-9]{20}$/;
+        if (!nin || !ninPattern.test(nin)) {
+            return { verified: false, nin };
+        }
+
+        // Simulate successful lookup
         return { verified: true, nin, firstName: 'John', lastName: 'Doe' };
     }