@aeternity/aepp-sdk 13.0.0-alpha.0 → 13.0.0-alpha.1

package/src/tx/builder/index.ts

@@ -4,166 +4,19 @@ import {
 } from '../../utils/encoder';
 import { AE_AMOUNT_FORMATS } from '../../utils/amount-formatter';
 import { hash } from '../../utils/crypto';
-import { Field } from './field-types';
+import { BinaryData, Field } from './field-types';
 import {
-  FIELD_TYPES,
-  RawTxObject,
-  TX_SCHEMA,
-  TxField,
-  TxParamsCommon,
-  TxSchema,
-  TxTypeSchemas,
+  RawTxObject, TX_SCHEMA, TxField, TxSchema, TxTypeSchemas,
 } from './schema';
 import { Tag } from './constants';
 import { buildContractId, readInt } from './helpers';
-import { toBytes } from '../../utils/bytes';
-import MPTree, { MPTreeBinary } from '../../utils/mptree';
-import {
-  ArgumentError,
-  DecodeError,
-  InvalidTxParamsError,
-  SchemaNotFoundError,
-} from '../../utils/errors';
+import { ArgumentError, DecodeError, SchemaNotFoundError } from '../../utils/errors';
 import { isKeyOfObject } from '../../utils/other';
 
 /**
  * JavaScript-based Transaction builder
  */
 
-// SERIALIZE AND DESERIALIZE PART
-function deserializeField(
-  value: any,
-  type: FIELD_TYPES | Field,
-  prefix?: Encoding | Encoding[],
-): any {
-  if (value == null) return '';
-  switch (type) {
-    case FIELD_TYPES.ctVersion: {
-      const [vm, , abi] = value;
-      return {
-        vmVersion: readInt(Buffer.from([vm])),
-        abiVersion: readInt(Buffer.from([abi])),
-      };
-    }
-    case FIELD_TYPES.bool:
-      return value[0] === 1;
-    case FIELD_TYPES.binary:
-      return encode(value, prefix as Encoding);
-    case FIELD_TYPES.stateTree:
-      return encode(value, Encoding.StateTrees);
-    case FIELD_TYPES.string:
-      return value.toString();
-    case FIELD_TYPES.payload:
-      return encode(value, Encoding.Bytearray);
-    case FIELD_TYPES.rlpBinary:
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
-      return unpackTx(encode(value, Encoding.Transaction));
-    case FIELD_TYPES.rlpBinaries:
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
-      return value.map((v: Buffer) => unpackTx(encode(v, Encoding.Transaction)));
-    case FIELD_TYPES.rawBinary:
-      return value;
-    case FIELD_TYPES.hex:
-      return value.toString('hex');
-    case FIELD_TYPES.offChainUpdates:
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
-      return value.map((v: Buffer) => unpackTx(encode(v, Encoding.Transaction)));
-    case FIELD_TYPES.callStack:
-      // TODO: fix this
-      return [readInt(value)];
-    case FIELD_TYPES.mptrees:
-      return value.map((t: MPTreeBinary) => new MPTree(t));
-    case FIELD_TYPES.sophiaCodeTypeInfo:
-      return value.reduce(
-        (acc: object, [funHash, fnName, argType, outType]: [
-          funHash: Buffer,
-          fnName: string,
-          argType: string,
-          outType: string,
-        ]) => ({
-          ...acc,
-          [fnName.toString()]: { funHash, argType, outType },
-        }),
-        {},
-      );
-    default:
-      if (typeof type === 'number') return value;
-      return type.deserialize(value);
-  }
-}
-
-function serializeField(value: any, type: FIELD_TYPES | Field, params: any): any {
-  switch (type) {
-    case FIELD_TYPES.bool:
-      return Buffer.from([(value === true) ? 1 : 0]);
-    case FIELD_TYPES.binary:
-      return decode(value);
-    case FIELD_TYPES.stateTree:
-      return decode(value);
-    case FIELD_TYPES.hex:
-      return Buffer.from(value, 'hex');
-    case FIELD_TYPES.signatures:
-      return value.map(Buffer.from);
-    case FIELD_TYPES.payload:
-      return typeof value === 'string' && value.split('_')[0] === 'ba'
-        ? decode(value as Encoded.Bytearray)
-        : toBytes(value);
-    case FIELD_TYPES.string:
-      return toBytes(value);
-    case FIELD_TYPES.rlpBinary:
-      return value.rlpEncoded ?? value;
-    case FIELD_TYPES.mptrees:
-      return value.map((t: MPTree) => t.serialize());
-    case FIELD_TYPES.ctVersion:
-      return Buffer.from([...toBytes(value.vmVersion), 0, ...toBytes(value.abiVersion)]);
-    default:
-      if (typeof type === 'number') return value;
-      return type.serialize(value, params);
-  }
-}
-
-function validateField(
-  value: any,
-  type: FIELD_TYPES | Field,
-): string | undefined {
-  // All fields are required
-  if (value == null) return 'Field is required';
-
-  // Validate type of value
-  switch (type) {
-    case FIELD_TYPES.ctVersion:
-      if (!(Boolean(value.abiVersion) && Boolean(value.vmVersion))) {
-        return 'Value must be an object with "vmVersion" and "abiVersion" fields';
-      }
-      return undefined;
-    default:
-      return undefined;
-  }
-}
-
-/**
- * Validate transaction params
- * @category transaction builder
- * @param params - Object with tx params
- * @param schema - Transaction schema
- * @param excludeKeys - Array of keys to exclude for validation
- * @returns Object with validation errors
- */
-function validateParams(
-  params: any,
-  schema: TxField[],
-  { excludeKeys = [] }: { excludeKeys: string[] },
-): object {
-  const optionalFields = ['payload', 'nameFee', 'deposit', 'gasPrice', 'fee', 'gasLimit', 'amount'];
-  return Object.fromEntries(
-    schema
-      // TODO: allow optional keys in schema
-      .filter(([key]) => !excludeKeys.includes(key) && !optionalFields.includes(key))
-      .map(([key, type]) => [key, validateField(params[key], type)])
-      .filter(([, message]) => message),
-  );
-}
-
 /**
  * Unpack binary transaction
  * @category transaction builder
@@ -175,34 +28,29 @@ function unpackRawTx<Tx extends TxSchema>(
   binary: Uint8Array | NestedUint8Array,
   schema: TxField[],
 ): RawTxObject<Tx> {
+  if (binary.length !== schema.length) {
+    throw new ArgumentError('Transaction RLP length', schema.length, binary.length);
+  }
   return schema
     .reduce<any>(
     (
       acc,
-      [key, fieldType, prefix],
+      [name, field],
       index,
-    ) => Object.assign(acc, { [key]: deserializeField(binary[index], fieldType, prefix) }),
+    ) => {
+      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+      const deserialized = field.deserialize(binary[index] as BinaryData, { unpackTx });
+      return { ...acc, [name]: deserialized };
+    },
     {},
   );
 }
 
-/**
- * @category transaction builder
- */
-export interface BuiltTx<Tx extends TxSchema, Prefix extends Encoding> {
-  tx: Encoded.Generic<Prefix>;
-  rlpEncoded: Uint8Array;
-  binary: Uint8Array;
-  txObject: RawTxObject<Tx>;
-}
-
 /**
  * Build transaction hash
  * @category transaction builder
- * @param _params - Object with tx params
- * @param type - Transaction type
+ * @param params - Object with tx params
  * @param options - options
- * @param options.excludeKeys - Array of keys to exclude for validation and build
  * @param options.denomination - Denomination of amounts
  * @param options.prefix - Prefix of transaction
  * @throws {@link InvalidTxParamsError}
@@ -211,78 +59,51 @@ export interface BuiltTx<Tx extends TxSchema, Prefix extends Encoding> {
  * @returns object.rlpEncoded rlp encoded transaction
  * @returns object.binary binary transaction
  */
-export function buildTx<TxType extends Tag, Prefix>(
-  _params: Omit<TxTypeSchemas[TxType], 'tag' | 'VSN'> & { VSN?: number },
-  type: TxType,
+export function buildTx<
+  TxType extends Tag,
+  E extends Encoding = Encoding.Transaction,
+>(
+  params: { tag: TxType; version?: number } & Omit<TxTypeSchemas[TxType], 'tag' | 'version'>
+  // TODO: get it from gas-limit.ts somehow
+  & (TxType extends Tag.ContractCreateTx | Tag.ContractCallTx
+  | Tag.ChannelOffChainUpdateCallContract | Tag.GaAttachTx | Tag.GaMetaTx
+    ? { gasMax?: number } : {}),
   {
-    excludeKeys = [],
-    prefix = Encoding.Transaction,
-    vsn,
+    prefix,
     denomination = AE_AMOUNT_FORMATS.AETTOS,
   }: {
-    excludeKeys?: string[];
-    prefix?: Encoding;
-    vsn?: number;
+    prefix?: E;
     denomination?: AE_AMOUNT_FORMATS;
   } = {},
-): BuiltTx<TxSchema, Prefix extends Encoding ? Prefix : Encoding.Transaction> {
-  const schemas = TX_SCHEMA[type];
-
-  vsn ??= Math.max(...Object.keys(schemas).map((a) => +a));
-  if (!isKeyOfObject(vsn, schemas)) throw new SchemaNotFoundError('serialization', Tag[type], vsn);
-
-  const schema = schemas[vsn] as unknown as TxField[];
-
-  const params = _params as TxParamsCommon & { onNode: Node; denomination?: AE_AMOUNT_FORMATS };
-  params.VSN = vsn;
-  params.tag = type;
-  params.denomination = denomination;
-  const filteredSchema = schema.filter(([key]) => !excludeKeys.includes(key));
-
-  // Validation
-  const valid = validateParams(params, schema, { excludeKeys });
-  if (Object.keys(valid).length > 0) {
-    throw new InvalidTxParamsError(`Transaction build error. ${JSON.stringify(valid)}`);
+): Encoded.Generic<E> {
+  const schemas = TX_SCHEMA[params.tag];
+  params.version ??= Math.max(...Object.keys(schemas).map((a) => +a));
+  if (!isKeyOfObject(params.version, schemas)) {
+    throw new SchemaNotFoundError('serialization', Tag[params.tag], params.version);
   }
-
-  const binary = filteredSchema
-    .map(([key, fieldType]: [keyof TxSchema, FIELD_TYPES, Encoding]) => (
-      serializeField(
-        params[key],
-        fieldType,
-        {
-          ...params,
-          txType: type,
-          rebuildTx: (overrideParams: any) => buildTx(
-            { ...params, ...overrideParams },
-            type,
-            {
-              excludeKeys, prefix: Encoding.Transaction, vsn, denomination,
-            },
-          ),
-        },
-      )
-    ))
-    .filter((e) => e !== undefined);
-
-  const rlpEncoded = rlpEncode(binary);
-  const tx = encode(rlpEncoded, prefix);
-  return {
-    tx,
-    rlpEncoded,
-    binary,
-    txObject: unpackRawTx<TxTypeSchemas[Tag]>(binary, schema),
-  } as any;
+  const schema = schemas[params.version] as unknown as TxField[];
+
+  const binary = schema.map(([key, field]: [keyof TxSchema, Field]) => (
+    field.serialize(
+      params[key],
+      {
+        ...params,
+        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+        unpackTx,
+        buildTx,
+        denomination,
+        rebuildTx: (overrideParams: any) => buildTx(
+          { ...params, ...overrideParams },
+          { denomination },
+        ),
+      },
+    )
+  ));
+
+  // @ts-expect-error looks like a TypeScript edge case
+  return encode(rlpEncode(binary), prefix ?? Encoding.Transaction);
 }
 
-/**
- * @category transaction builder
- */
-export interface TxUnpacked<Tx extends TxSchema> {
-  txType: Tag;
-  tx: RawTxObject<Tx>;
-  rlpEncoded: Uint8Array;
-}
 /**
  * Unpack transaction hash
  * @category transaction builder
@@ -295,20 +116,15 @@ export interface TxUnpacked<Tx extends TxSchema> {
 export function unpackTx<TxType extends Tag>(
   encodedTx: Encoded.Transaction | Encoded.Poi,
   txType?: TxType,
-): TxUnpacked<TxTypeSchemas[TxType]> {
-  const rlpEncoded = decode(encodedTx);
-  const binary = rlpDecode(rlpEncoded);
-  const objId = +readInt(binary[0] as Buffer);
-  if (!isKeyOfObject(objId, TX_SCHEMA)) throw new DecodeError(`Unknown transaction tag: ${objId}`);
-  if (txType != null && txType !== objId) throw new DecodeError(`Expected transaction to have ${Tag[txType]} tag, got ${Tag[objId]} instead`);
-  const vsn = +readInt(binary[1] as Buffer);
-  if (!isKeyOfObject(vsn, TX_SCHEMA[objId])) throw new SchemaNotFoundError('deserialization', `tag ${objId}`, vsn);
-  const schema = TX_SCHEMA[objId][vsn];
-  return {
-    txType: objId,
-    tx: unpackRawTx<TxTypeSchemas[TxType]>(binary, schema),
-    rlpEncoded,
-  };
+): RawTxObject<TxTypeSchemas[TxType]> {
+  const binary = rlpDecode(decode(encodedTx));
+  const tag = +readInt(binary[0] as Buffer);
+  if (!isKeyOfObject(tag, TX_SCHEMA)) throw new DecodeError(`Unknown transaction tag: ${tag}`);
+  if (txType != null && txType !== tag) throw new DecodeError(`Expected transaction to have ${Tag[txType]} tag, got ${Tag[tag]} instead`);
+  const version = +readInt(binary[1] as Buffer);
+  if (!isKeyOfObject(version, TX_SCHEMA[tag])) throw new SchemaNotFoundError('deserialization', `tag ${tag}`, version);
+  const schema = TX_SCHEMA[tag][version];
+  return unpackRawTx<TxTypeSchemas[TxType]>(binary, schema);
 }
 
 /**
@@ -333,9 +149,9 @@ export function buildTxHash(rawTx: Encoded.Transaction | Uint8Array): Encoded.Tx
 export function buildContractIdByContractTx(
   contractTx: Encoded.Transaction,
 ): Encoded.ContractAddress {
-  const { txType, tx } = unpackTx<Tag.ContractCreateTx | Tag.GaAttachTx>(contractTx);
-  if (![Tag.ContractCreateTx, Tag.GaAttachTx].includes(txType)) {
-    throw new ArgumentError('contractCreateTx', 'a contractCreateTx or gaAttach', txType);
+  const { tag, ownerId, nonce } = unpackTx<Tag.ContractCreateTx | Tag.GaAttachTx>(contractTx);
+  if (![Tag.ContractCreateTx, Tag.GaAttachTx].includes(tag)) {
+    throw new ArgumentError('contractCreateTx', 'a contractCreateTx or gaAttach', tag);
   }
-  return buildContractId(tx.ownerId, +tx.nonce);
+  return buildContractId(ownerId, +nonce);
 }