@adyen/eslint-plugin-bento 2.9.0 → 2.10.0

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 2.10.0 (2026-04-29)
+
+### Features
+
+- added deprecation rule for `modifers` prop in `bento-popover` ([9fb597154](https://github.com/Adyen/bento/commit/9fb597154))
+- added deprecation rule for `ariaLabel` property ([155145eae](https://github.com/Adyen/bento/commit/155145eae))
+- added deprecation rule for `hasError` prop for `bento-checkbox-group` & `bento-radio-group` ([94b181c62](https://github.com/Adyen/bento/commit/94b181c62))
+- added deprecation rule for filter of type `BentoFilterItemType.INPUT` using dropdown props ([0b2d242ce](https://github.com/Adyen/bento/commit/0b2d242ce))
+- added deprecation rule for `variant` for `bento-timeline-item` ([245c7f7f8](https://github.com/Adyen/bento/commit/245c7f7f8))
+
+### ❤️ Thank You
+
+- gerald
+
+
 ## 2.9.0 (2026-04-22)
 
 ### Features

package/configs/vue-recommended.js

@@ -11,9 +11,14 @@ module.exports = [
             },
         },
         rules: {
+            '@adyen/bento/deprecation-input-filter-dropdown-options': 'warn',
             '@adyen/bento/deprecation-bento-dropdown-size-prop': 'warn',
+            '@adyen/bento/deprecation-bento-timeline-item-variant-prop': 'warn',
+            '@adyen/bento/deprecation-bento-popover-modifiers-prop': 'warn',
             '@adyen/bento/deprecation-components-error-prop': 'warn',
             '@adyen/bento/deprecation-filter-bar-deprecated-props': 'warn',
+            '@adyen/bento/deprecation-components-has-error-prop': 'warn',
+            '@adyen/bento/deprecation-components-aria-label-prop': 'warn',
             '@adyen/bento/deprecation-components-input-emit': 'warn',
             '@adyen/bento/deprecation-components-value-prop': 'warn',
             '@adyen/bento/deprecation-currency-default-slot': 'warn',

package/configs/vue-strict.js

@@ -11,9 +11,14 @@ module.exports = [
             },
         },
         rules: {
+            '@adyen/bento/deprecation-input-filter-dropdown-options': 'error',
             '@adyen/bento/deprecation-bento-dropdown-size-prop': 'error',
+            '@adyen/bento/deprecation-bento-timeline-item-variant-prop': 'error',
+            '@adyen/bento/deprecation-bento-popover-modifiers-prop': 'error',
             '@adyen/bento/deprecation-components-error-prop': 'error',
             '@adyen/bento/deprecation-filter-bar-deprecated-props': 'error',
+            '@adyen/bento/deprecation-components-has-error-prop': 'error',
+            '@adyen/bento/deprecation-components-aria-label-prop': 'error',
             '@adyen/bento/deprecation-components-input-emit': 'error',
             '@adyen/bento/deprecation-components-value-prop': 'error',
             '@adyen/bento/deprecation-currency-default-slot': 'error',

package/index.js

@@ -12,9 +12,14 @@ const plugin = {
         tailwind: require('./configs/tailwind'),
     },
     rules: {
+        'deprecation-input-filter-dropdown-options': require('./rules/deprecation-input-filter-dropdown-options/deprecation-input-filter-dropdown-options'),
         'deprecation-bento-dropdown-size-prop': require('./rules/deprecation-bento-dropdown-size-prop/deprecation-bento-dropdown-size-prop'),
+        'deprecation-bento-timeline-item-variant-prop': require('./rules/deprecation-bento-timeline-item-variant-prop/deprecation-bento-timeline-item-variant-prop'),
+        'deprecation-bento-popover-modifiers-prop': require('./rules/deprecation-bento-popover-modifiers-prop/deprecation-bento-popover-modifiers-prop'),
         'deprecation-components-error-prop': require('./rules/deprecation-components-error-prop/deprecation-components-error-prop'),
         'deprecation-filter-bar-deprecated-props': require('./rules/deprecation-filter-bar-deprecated-props/deprecation-filter-bar-deprecated-props'),
+        'deprecation-components-has-error-prop': require('./rules/deprecation-components-has-error-prop/deprecation-components-has-error-prop'),
+        'deprecation-components-aria-label-prop': require('./rules/deprecation-components-aria-label-prop/deprecation-components-aria-label-prop'),
         'deprecation-components-input-emit': require('./rules/deprecation-components-input-emit/deprecation-components-input-emit'),
         'deprecation-components-value-prop': require('./rules/deprecation-components-value-prop/deprecation-components-value-prop'),
         'deprecation-currency-default-slot': require('./rules/deprecation-currency-default-slot/deprecation-currency-default-slot'),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adyen/eslint-plugin-bento",
-  "version": "2.9.0",
+  "version": "2.10.0",
   "description": "Adyen Bento ESLint rules",
   "main": "index.js",
   "files": [

package/rules/deprecation-bento-popover-modifiers-prop/README.md

@@ -0,0 +1,23 @@
+# deprecation-bento-popover-modifiers-prop
+
+## Description
+
+The `modifiers` prop in the following components is deprecated:
+
+- `bento-popover`
+
+## Rule Details
+
+This rule reports usages of the deprecated item.
+
+### ❌ Incorrect
+
+```html
+<bento-popover modifiers="value" /> <bento-popover :modifiers="value" />
+```
+
+### ✅ Correct
+
+```html
+<bento-popover />
+```

package/rules/deprecation-bento-popover-modifiers-prop/__tests__/deprecation-bento-popover-modifiers-prop.vue

@@ -0,0 +1,9 @@
+<template>
+    <div>
+        <bento-popover modifiers="value" />
+        <bento-popover :modifiers="value" />
+        <bento-popover :modifiers="value" />
+    </div>
+</template>
+
+<script setup></script>

package/rules/deprecation-bento-popover-modifiers-prop/__tests__/eslint.config.js

@@ -0,0 +1,26 @@
+// eslint.config.js
+const { defineConfig } = require('eslint/config');
+const vueParser = require('vue-eslint-parser');
+const tsParser = require('@typescript-eslint/parser');
+const adyenBento = require('@adyen/eslint-plugin-bento');
+
+module.exports = defineConfig([
+    {
+        languageOptions: {
+            ecmaVersion: 'latest',
+            sourceType: 'module',
+            parser: vueParser,
+            parserOptions: {
+                parser: tsParser,
+            },
+        },
+        plugins: {
+            '@adyen/bento': adyenBento,
+        },
+        rules: {
+            // Register the specific rule we are testing
+            '@adyen/bento/deprecation-bento-popover-modifiers-prop': ['warn', { autofix: true }],
+        },
+        files: ['**/*.vue'],
+    },
+]);

package/rules/deprecation-bento-popover-modifiers-prop/deprecation-bento-popover-modifiers-prop.integration.test.ts

@@ -0,0 +1,24 @@
+import path from 'node:path';
+import { execFileSyncEslintVueFiles } from '../../utils/exec-file-sync-eslint-vue-files';
+
+describe('@adyen/bento/deprecation-bento-popover-modifiers-prop', () => {
+    it('should lint with warning', () => {
+        // Load .eslintrc
+        const eslintrc = path.resolve(__dirname, '__tests__', 'eslint.config.js');
+        // Load the test file generated alongside this one
+        const vueFile = path.resolve(__dirname, '__tests__', 'deprecation-bento-popover-modifiers-prop.vue');
+
+        // Execute the linter
+        const result = JSON.parse(execFileSyncEslintVueFiles(eslintrc, vueFile));
+
+        // 3 examples: static, shorthand, longhand
+        expect(result[0].warningCount).toBe(3);
+        expect(result[0].messages[0]).toMatchObject({
+            ruleId: '@adyen/bento/deprecation-bento-popover-modifiers-prop',
+            severity: 1,
+
+            messageId: 'deprecation',
+            message: `The "modifiers" prop is deprecated.`,
+        });
+    });
+});

package/rules/deprecation-bento-popover-modifiers-prop/deprecation-bento-popover-modifiers-prop.js

@@ -0,0 +1,78 @@
+/**
+ * @typedef {import('eslint').Rule.RuleContext} RuleContext
+ */
+/**
+ * @typedef {import('eslint-plugin-vue/lib/utils').RuleModule} RuleModule
+ */
+
+const VueUtils = require('eslint-plugin-vue/lib/utils');
+
+/** @type {RuleModule} */
+module.exports = {
+    meta: {
+        type: 'suggestion',
+        docs: {
+            description: 'Deprecates usage of modifiers prop in bento-popover',
+            category: 'Deprecations',
+            url: 'https://github.com/Adyen/bento/blob/main/packages/eslint/rules/deprecation-bento-popover-modifiers-prop/README.md',
+            recommended: true,
+        },
+        messages: {
+            deprecation: `The "modifiers" prop is deprecated.`,
+        },
+        fixable: 'code',
+        schema: [
+            {
+                type: 'object',
+                properties: {
+                    autofix: {
+                        type: 'boolean',
+                        default: false,
+                    },
+                },
+                additionalProperties: false,
+            },
+        ],
+    },
+
+    /** @param {RuleContext} context */
+    create(context) {
+        const options = context.options[0] || {};
+        const autofix = options.autofix === true;
+
+        /* ------------------------------------------------ */
+        /* PROP DEPRECATION                                 */
+        /* ------------------------------------------------ */
+        return VueUtils.defineTemplateBodyVisitor(context, {
+            // 1. STATIC: modifiers="foo"
+            [`VElement:matches([name="bento-popover"], [name="BentoPopover"]) > VStartTag > VAttribute[directive=false][key.name="modifiers"]`](
+                node
+            ) {
+                context.report({
+                    node,
+                    messageId: 'deprecation',
+                    ...(autofix && {
+                        fix(fixer) {
+                            return fixer.remove(node);
+                        },
+                    }),
+                });
+            },
+
+            // 2. DYNAMIC: :modifiers="foo" or v-bind:modifiers="foo"
+            [`VElement:matches([name="bento-popover"], [name="BentoPopover"]) > VStartTag > VAttribute[directive=true][key.name.name="bind"][key.argument.name="modifiers"]`](
+                node
+            ) {
+                context.report({
+                    node,
+                    messageId: 'deprecation',
+                    ...(autofix && {
+                        fix(fixer) {
+                            return fixer.remove(node);
+                        },
+                    }),
+                });
+            },
+        });
+    },
+};

package/rules/deprecation-bento-popover-modifiers-prop/deprecation-bento-popover-modifiers-prop.test.ts

@@ -0,0 +1,109 @@
+import { RuleTester } from 'eslint';
+import vueParser from 'vue-eslint-parser';
+import tsParser from '@typescript-eslint/parser';
+import deprecationBentoPopoverModifiersProp from './deprecation-bento-popover-modifiers-prop';
+
+const ruleTester = new RuleTester({
+    languageOptions: {
+        ecmaVersion: 'latest',
+        sourceType: 'module',
+        parser: vueParser,
+        parserOptions: {
+            parser: tsParser,
+        },
+    },
+});
+
+describe('@adyen/bento/deprecation-bento-popover-modifiers-prop', () => {
+    ruleTester.run('deprecation-bento-popover-modifiers-prop', deprecationBentoPopoverModifiersProp, {
+        valid: [
+            {
+                name: 'Valid usage for bento-popover',
+                filename: 'test.vue',
+                code: `
+                <template>
+                    <bento-popover other-prop="val" />
+                </template>
+                `,
+            },
+        ],
+        invalid: [
+            {
+                name: 'Invalid: autofix disabled (explicit false)',
+                filename: 'test.vue',
+                code: `<template><bento-popover modifiers="val" /></template>`,
+                output: null,
+                options: [{ autofix: false }],
+                errors: [{ messageId: 'deprecation' }],
+            },
+            {
+                name: 'Invalid: autofix disabled (no options)',
+                filename: 'test.vue',
+                code: `<template><bento-popover :modifiers="val" /></template>`,
+                output: null,
+                errors: [{ messageId: 'deprecation' }],
+            },
+            // bento-popover: Static
+            {
+                name: 'Invalid: Static prop on bento-popover',
+                filename: 'test.vue',
+                code: `<template><bento-popover modifiers="val" /></template>`,
+                errors: [{ messageId: 'deprecation' }],
+            },
+            // bento-popover: v-bind longhand
+            {
+                name: 'Invalid: v-bind longhand prop on bento-popover',
+                filename: 'test.vue',
+                code: `<template><bento-popover v-bind:modifiers="val" /></template>`,
+                errors: [{ messageId: 'deprecation' }],
+            },
+        ],
+    });
+
+    /* ------------------------------------------------ */
+    /* AUTOFIX TESTS                                    */
+    /* ------------------------------------------------ */
+    ruleTester.run('deprecation-bento-popover-modifiers-prop (autofix enabled)', deprecationBentoPopoverModifiersProp, {
+        valid: [
+            {
+                name: 'Valid: no modifiers prop (autofix enabled)',
+                filename: 'test.vue',
+                options: [{ autofix: true }],
+                code: `<template><bento-popover position="top" /></template>`,
+            },
+        ],
+        invalid: [
+            {
+                name: 'Autofix: removes static modifiers prop',
+                filename: 'test.vue',
+                options: [{ autofix: true }],
+                code: `<template><bento-popover modifiers="val" /></template>`,
+                output: `<template><bento-popover  /></template>`,
+                errors: [{ messageId: 'deprecation' }],
+            },
+            {
+                name: 'Autofix: removes dynamic modifiers prop',
+                filename: 'test.vue',
+                options: [{ autofix: true }],
+                code: `<template><bento-popover :modifiers="val" /></template>`,
+                output: `<template><bento-popover  /></template>`,
+                errors: [{ messageId: 'deprecation' }],
+            },
+            {
+                name: 'Autofix: removes v-bind longhand modifiers prop',
+                filename: 'test.vue',
+                options: [{ autofix: true }],
+                code: `<template><bento-popover v-bind:modifiers="val" /></template>`,
+                output: `<template><bento-popover  /></template>`,
+                errors: [{ messageId: 'deprecation' }],
+            },
+            {
+                name: 'Autofix: does not fix when autofix is false',
+                filename: 'test.vue',
+                options: [{ autofix: false }],
+                code: `<template><bento-popover modifiers="val" other="x" /></template>`,
+                errors: [{ messageId: 'deprecation' }],
+            },
+        ],
+    });
+});

package/rules/deprecation-bento-timeline-item-variant-prop/README.md

@@ -0,0 +1,25 @@
+# deprecation-bento-timeline-item-variant-prop
+
+## Description
+
+The `variant` prop in the following components is deprecated:
+
+- `bento-timeline-item`
+
+Please use `status` instead.
+
+## Rule Details
+
+This rule reports usages of the deprecated item.
+
+### ❌ Incorrect
+
+```html
+<bento-timeline-item variant="SUCCESS" /> <bento-timeline-item :variant="BentoTimelineItemVariant.CRITICAL" />
+```
+
+### ✅ Correct
+
+```html
+<bento-timeline-item status="green" /> <bento-timeline-item status="red" />
+```

package/rules/deprecation-bento-timeline-item-variant-prop/__tests__/deprecation-bento-timeline-item-variant-prop.vue

@@ -0,0 +1,9 @@
+<template>
+    <div>
+        <bento-timeline-item variant="SUCCESS" />
+        <bento-timeline-item :variant="BentoTimelineItemVariant.CRITICAL" />
+        <bento-timeline-item :variant="BentoTimelineItemVariant.SUCCESS" />
+    </div>
+</template>
+
+<script setup></script>

package/rules/deprecation-bento-timeline-item-variant-prop/__tests__/eslint.config.js

@@ -0,0 +1,26 @@
+// eslint.config.js
+const { defineConfig } = require('eslint/config');
+const vueParser = require('vue-eslint-parser');
+const tsParser = require('@typescript-eslint/parser');
+const adyenBento = require('@adyen/eslint-plugin-bento');
+
+module.exports = defineConfig([
+    {
+        languageOptions: {
+            ecmaVersion: 'latest',
+            sourceType: 'module',
+            parser: vueParser,
+            parserOptions: {
+                parser: tsParser,
+            },
+        },
+        plugins: {
+            '@adyen/bento': adyenBento,
+        },
+        rules: {
+            // Register the specific rule we are testing
+            '@adyen/bento/deprecation-bento-timeline-item-variant-prop': ['warn', { autofix: true }],
+        },
+        files: ['**/*.vue'],
+    },
+]);

package/rules/deprecation-bento-timeline-item-variant-prop/deprecation-bento-timeline-item-variant-prop.integration.test.ts

@@ -0,0 +1,31 @@
+import path from 'node:path';
+import { execFileSyncEslintVueFiles } from '../../utils/exec-file-sync-eslint-vue-files';
+
+describe('@adyen/bento/deprecation-bento-timeline-item-variant-prop', () => {
+    it('should lint with warning', () => {
+        // Load .eslintrc
+        const eslintrc = path.resolve(__dirname, '__tests__', 'eslint.config.js');
+        // Load the test file generated alongside this one
+        const vueFile = path.resolve(__dirname, '__tests__', 'deprecation-bento-timeline-item-variant-prop.vue');
+
+        // Execute the linter
+        const result = JSON.parse(execFileSyncEslintVueFiles(eslintrc, vueFile));
+
+        // 3 examples: static, shorthand, longhand
+        expect(result[0].warningCount).toBe(3);
+
+        // Verify the message structure on the first error found.
+        // Since the rule is the same for all components, checking the first one confirms the message is correct.
+        expect(result[0].messages[0]).toMatchObject({
+            ruleId: '@adyen/bento/deprecation-bento-timeline-item-variant-prop',
+            severity: 1,
+
+            messageId: 'deprecation',
+            message: `The "variant" prop is deprecated. Please use "status" instead.`,
+
+            fix: expect.objectContaining({
+                text: expect.stringContaining('status'),
+            }),
+        });
+    });
+});

package/rules/deprecation-bento-timeline-item-variant-prop/deprecation-bento-timeline-item-variant-prop.js

@@ -0,0 +1,78 @@
+/**
+ * @typedef {import('eslint').Rule.RuleContext} RuleContext
+ */
+/**
+ * @typedef {import('eslint-plugin-vue/lib/utils').RuleModule} RuleModule
+ */
+
+const VueUtils = require('eslint-plugin-vue/lib/utils');
+
+/** @type {RuleModule} */
+module.exports = {
+    meta: {
+        type: 'suggestion',
+        docs: {
+            description: 'Deprecates usage of variant prop in bento-timeline-item',
+            category: 'Deprecations',
+            url: 'https://github.com/Adyen/bento/blob/main/packages/eslint/rules/deprecation-bento-timeline-item-variant-prop/README.md',
+            recommended: true,
+        },
+        messages: {
+            deprecation: `The "variant" prop is deprecated. Please use "status" instead.`,
+        },
+        fixable: 'code',
+        schema: [
+            {
+                type: 'object',
+                properties: {
+                    autofix: {
+                        type: 'boolean',
+                        default: false,
+                    },
+                },
+                additionalProperties: false,
+            },
+        ],
+    },
+
+    /** @param {RuleContext} context */
+    create(context) {
+        const options = context.options[0] || {};
+        const autofix = options.autofix === true;
+
+        /* ------------------------------------------------ */
+        /* PROP DEPRECATION                                 */
+        /* ------------------------------------------------ */
+        return VueUtils.defineTemplateBodyVisitor(context, {
+            // 1. STATIC: value="foo"
+            [`VElement:matches([name="bento-timeline-item"], [name="BentoTimelineItem"]) > VStartTag > VAttribute[directive=false][key.name="variant"]`](
+                node
+            ) {
+                context.report({
+                    node,
+                    messageId: 'deprecation',
+                    ...(autofix && {
+                        fix(fixer) {
+                            return fixer.replaceText(node.key, 'status');
+                        },
+                    }),
+                });
+            },
+
+            // 2. DYNAMIC: :value="foo" or v-bind:value="foo"
+            [`VElement:matches([name="bento-timeline-item"], [name="BentoTimelineItem"]) > VStartTag > VAttribute[directive=true][key.name.name="bind"][key.argument.name="variant"]`](
+                node
+            ) {
+                context.report({
+                    node,
+                    messageId: 'deprecation',
+                    ...(autofix && {
+                        fix(fixer) {
+                            return fixer.replaceText(node.key.argument, 'status');
+                        },
+                    }),
+                });
+            },
+        });
+    },
+};

package/rules/deprecation-bento-timeline-item-variant-prop/deprecation-bento-timeline-item-variant-prop.test.ts

@@ -0,0 +1,66 @@
+import { RuleTester } from 'eslint';
+import vueParser from 'vue-eslint-parser';
+import tsParser from '@typescript-eslint/parser';
+import deprecationBentoTimelineItemVariantProp from './deprecation-bento-timeline-item-variant-prop';
+
+const ruleTester = new RuleTester({
+    languageOptions: {
+        ecmaVersion: 'latest',
+        sourceType: 'module',
+        parser: vueParser,
+        parserOptions: {
+            parser: tsParser,
+        },
+    },
+});
+
+describe('@adyen/bento/deprecation-bento-timeline-item-variant-prop', () => {
+    ruleTester.run('deprecation-bento-timeline-item-variant-prop', deprecationBentoTimelineItemVariantProp, {
+        valid: [
+            {
+                name: 'Valid usage for bento-timeline-item',
+                filename: 'test.vue',
+                code: `
+                <template>
+                    <bento-timeline-item status="val" />
+                </template>
+                `,
+            },
+        ],
+        invalid: [
+            {
+                name: 'Invalid: autofix disabled (explicit false)',
+                filename: 'test.vue',
+                code: `<template><bento-timeline-item variant="val" /></template>`,
+                output: null,
+                options: [{ autofix: false }],
+                errors: [{ messageId: 'deprecation' }],
+            },
+            {
+                name: 'Invalid: autofix disabled (no options)',
+                filename: 'test.vue',
+                code: `<template><bento-timeline-item :variant="val" /></template>`,
+                output: null,
+                errors: [{ messageId: 'deprecation' }],
+            },
+            // bento-timeline-item: Static
+            {
+                name: 'Invalid: Static prop on bento-timeline-item',
+                filename: 'test.vue',
+                code: `<template><bento-timeline-item variant="val" /></template>`,
+                output: `<template><bento-timeline-item status="val" /></template>`,
+                options: [{ autofix: true }],
+                errors: [{ messageId: 'deprecation' }],
+            },
+            // bento-timeline-item: Shorthand
+            {
+                name: 'Invalid: Dynamic prop on bento-timeline-item',
+                filename: 'test.vue',
+                code: `<template><bento-timeline-item :variant="val" /></template>`,
+                output: `<template><bento-timeline-item :status="val" /></template>`,
+                options: [{ autofix: true }],
+                errors: [{ messageId: 'deprecation' }],
+            },
+        ],
+    });
+});

package/rules/deprecation-components-aria-label-prop/README.md

@@ -0,0 +1,62 @@
+# deprecation-components-aria-label-prop
+
+## Description
+
+The `ariaLabel` prop in the following components is deprecated:
+
+- `bento-dropdown`
+- `bento-input-field`
+- `bento-pagination`
+- `bento-popover`
+- `bento-segmented-control`
+
+Please use `aria-label` instead.
+
+## Rule Details
+
+This rule reports usages of the deprecated `ariaLabel` prop (camelCase). The replacement `aria-label` is the native HTML
+attribute, which the components already pick up via `attrs['aria-label']`.
+
+### ❌ Incorrect
+
+```html
+<bento-dropdown ariaLabel="value" /> <bento-dropdown :ariaLabel="value" />
+```
+
+```html
+<bento-input-field ariaLabel="value" /> <bento-input-field :ariaLabel="value" />
+```
+
+```html
+<bento-pagination ariaLabel="value" /> <bento-pagination :ariaLabel="value" />
+```
+
+```html
+<bento-popover ariaLabel="value" /> <bento-popover :ariaLabel="value" />
+```
+
+```html
+<bento-segmented-control ariaLabel="value" /> <bento-segmented-control :ariaLabel="value" />
+```
+
+### ✅ Correct
+
+```html
+<bento-dropdown aria-label="value" />
+```
+
+```html
+<bento-input-field aria-label="value" />
+```
+
+```html
+<bento-pagination aria-label="value" />
+```
+
+```html
+<bento-popover aria-label="value" />
+```
+
+```html
+<bento-segmented-control aria-label="value" />
+```