@adyen/eslint-plugin-bento 2.23.0 → 2.24.1

package/rules/deprecation-filter-bar-deprecated-props/__tests__/eslint.config.js

@@ -1,25 +0,0 @@
-// eslint.config.js
-const { defineConfig } = require('eslint/config');
-const vueParser = require('vue-eslint-parser');
-const tsParser = require('@typescript-eslint/parser');
-const adyenBento = require('@adyen/eslint-plugin-bento');
-
-module.exports = defineConfig([
-    {
-        languageOptions: {
-            ecmaVersion: 'latest',
-            sourceType: 'module',
-            parser: vueParser,
-            parserOptions: {
-                parser: tsParser,
-            },
-        },
-        plugins: {
-            '@adyen/bento': adyenBento,
-        },
-        rules: {
-            '@adyen/bento/deprecation-filter-bar-deprecated-props': 'warn',
-        },
-        files: ['**/*.vue'],
-    },
-]);

package/rules/deprecation-filter-bar-deprecated-props/deprecation-filter-bar-deprecated-props.integration.test.ts

@@ -1,22 +0,0 @@
-import path from 'node:path';
-import { execFileSyncEslintVueFiles } from '../../utils/exec-file-sync-eslint-vue-files';
-
-describe('@adyen/bento/deprecation-filter-bar-deprecated-props', () => {
-    it('should lint with warning', () => {
-        const eslintrc = path.resolve(__dirname, '__tests__', 'eslint.config.js');
-        const vueFile = path.resolve(__dirname, '__tests__', 'deprecation-filter-bar-deprecated-props.vue');
-
-        const result = JSON.parse(execFileSyncEslintVueFiles(eslintrc, vueFile));
-
-        // 3 from direct value prop (static, dynamic, v-model)
-        // + 1 from configWithValue (value on config item)
-        // + 3 from configWithOptions (messages + 2 keys)
-        // + 1 from inline template (messages)
-        expect(result[0].warningCount).toBe(8);
-
-        expect(result[0].messages[0]).toMatchObject({
-            ruleId: '@adyen/bento/deprecation-filter-bar-deprecated-props',
-            severity: 1,
-        });
-    });
-});

package/rules/deprecation-filter-bar-deprecated-props/deprecation-filter-bar-deprecated-props.test.ts

@@ -1,492 +0,0 @@
-import { RuleTester } from 'eslint';
-import vueParser from 'vue-eslint-parser';
-import tsParser from '@typescript-eslint/parser';
-import deprecationFilterBarDeprecatedProps from './deprecation-filter-bar-deprecated-props';
-
-const ruleTester = new RuleTester({
-    languageOptions: {
-        ecmaVersion: 'latest',
-        sourceType: 'module',
-        parser: vueParser,
-        parserOptions: {
-            parser: tsParser,
-        },
-    },
-});
-
-describe('@adyen/bento/deprecation-filter-bar-deprecated-props', () => {
-    ruleTester.run('deprecation-filter-bar-deprecated-props', deprecationFilterBarDeprecatedProps, {
-        valid: [
-            {
-                name: 'Valid: bento-filter-bar with config prop (no value)',
-                filename: 'test.vue',
-                code: `
-                <template>
-                    <bento-filter-bar :config="config" :filter-values="values" />
-                </template>
-                `,
-            },
-            {
-                name: 'Valid: Vue 3 filter-values v-model on bento-filter-bar',
-                filename: 'test.vue',
-                code: `
-                <template>
-                    <bento-filter-bar :config="config" v-model:filter-values="filterValues" />
-                </template>
-                `,
-            },
-            {
-                name: 'Valid: filter config item without deprecated value property',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const config = [{ field: 'name', label: 'Name', type: 'BentoInputFilter' }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-            },
-            {
-                name: 'Valid: filter config options without deprecated messages keys',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const config = [{
-                    field: 'status',
-                    label: 'Status',
-                    type: 'BentoSelectFilter',
-                    options: { listboxItems: [] },
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-            },
-            {
-                name: 'Valid: computed property key matching deprecated name (no false positive)',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const key = 'value';
-                const config = [{ field: 'x', type: 'BentoInputFilter', [key]: 'test' }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-            },
-            {
-                name: 'Valid: spread in options (no crash)',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const defaults = {};
-                const config = [{
-                    field: 'x',
-                    type: 'BentoSelectFilter',
-                    options: { ...defaults, listboxItems: [] },
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-            },
-            {
-                name: 'Valid: bento-data-grid with filters without deprecated props',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const filters = [{ field: 'x', label: 'X', type: 'BentoInputFilter' }];
-                </script>
-                <template><bento-data-grid :filters="filters" /></template>
-                `,
-            },
-            {
-                name: 'Valid: unrelated object with options.messages (no false positive)',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const unrelated = { options: { messages: {} } };
-                </script>
-                <template><div /></template>
-                `,
-            },
-            {
-                name: 'Valid: unrelated binary operation object with field, type, and value properties',
-                filename: 'test.vue',
-                code: `
-                <script>
-                export const parseBinaryOperation = operation => ({
-                    field: operation.left.name,
-                    operator: operation.type,
-                    category: operation.left.type,
-                    type: parseOperationValueType(operation.right.type),
-                    value: parseOperationValue(operation),
-                    key: getUniqueId(),
-                });
-                </script>
-                <template><div /></template>
-                `,
-            },
-            {
-                name: 'Valid: unrelated object with a non-filter string type',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const operation = { field: 'name', type: 'BinaryOperation', value: 'test' };
-                </script>
-                <template><div /></template>
-                `,
-            },
-            {
-                name: 'Valid: unrelated enum member with a similar name',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const config = [{ field: 'name', type: OtherFilterItemType.INPUT, value: 'test' }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-            },
-            {
-                name: 'Valid: unrelated object with value property (no false positive)',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const obj = { value: 'test', options: { messages: {} } };
-                </script>
-                <template><div /></template>
-                `,
-            },
-        ],
-        invalid: [
-            // Direct "value" prop on bento-filter-bar
-            {
-                name: 'Invalid: static value prop on bento-filter-bar',
-                filename: 'test.vue',
-                code: `<template><bento-filter-bar value="val" /></template>`,
-                errors: [{ messageId: 'deprecationValue' }],
-            },
-            {
-                name: 'Invalid: dynamic value prop on bento-filter-bar',
-                filename: 'test.vue',
-                code: `<template><bento-filter-bar :value="filters" /></template>`,
-                errors: [{ messageId: 'deprecationValue' }],
-            },
-            {
-                name: 'Invalid: v-model on bento-filter-bar',
-                filename: 'test.vue',
-                code: `<template><bento-filter-bar v-model="filters" /></template>`,
-                errors: [{ messageId: 'deprecationValue' }],
-            },
-            {
-                name: 'Invalid: Vue 3 value v-model on bento-filter-bar',
-                filename: 'test.vue',
-                code: `<template><bento-filter-bar v-model:value="filters" /></template>`,
-                errors: [{ messageId: 'deprecationValue' }],
-            },
-            // "value" inside filter config items (script)
-            {
-                name: 'Invalid: value property in filter config item without a label',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const config = [{
-                    field: 'name',
-                    type: 'BentoInputFilter',
-                    value: 'test',
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-                errors: [{ messageId: 'deprecationConfigValue' }],
-            },
-            {
-                name: 'Invalid: value property in BentoFilterItemType enum config item',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const config = [{
-                    field: 'name',
-                    type: BentoFilterItemType.INPUT,
-                    value: 'test',
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-                errors: [{ messageId: 'deprecationConfigValue' }],
-            },
-            // "value" inside filter config items (inline template)
-            {
-                name: 'Invalid: value property in filter config item (inline template)',
-                filename: 'test.vue',
-                code: `
-                <template>
-                    <bento-filter-bar :config="[{ field: 'name', label: 'Name', type: 'BentoInputFilter', value: 'test' }]" />
-                </template>
-                `,
-                errors: [{ messageId: 'deprecationConfigValue' }],
-            },
-            // Deprecated messages option
-            {
-                name: 'Invalid: messages option in filter config',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const config = [{
-                    field: 'status',
-                    label: 'Status',
-                    type: 'BentoSelectFilter',
-                    options: { messages: { en: { persistentButtonLabelPartiallySelected: 'x' } }, listboxItems: [] },
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-                errors: [{ messageId: 'deprecationOption', data: { key: 'messages' } }],
-            },
-            // Deprecated messagesPersistentButtonLabelPartiallySelectedKey
-            {
-                name: 'Invalid: messagesPersistentButtonLabelPartiallySelectedKey option',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const config = [{
-                    field: 'status',
-                    label: 'Status',
-                    type: 'BentoSelectFilter',
-                    options: { messagesPersistentButtonLabelPartiallySelectedKey: 'customKey', listboxItems: [] },
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-                errors: [
-                    {
-                        messageId: 'deprecationOption',
-                        data: { key: 'messagesPersistentButtonLabelPartiallySelectedKey' },
-                    },
-                ],
-            },
-            // Deprecated messagesPersistentButtonLabelAllSelectedKey
-            {
-                name: 'Invalid: messagesPersistentButtonLabelAllSelectedKey option',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const config = [{
-                    field: 'status',
-                    label: 'Status',
-                    type: 'BentoSelectFilter',
-                    options: { messagesPersistentButtonLabelAllSelectedKey: 'customKey', listboxItems: [] },
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-                errors: [
-                    { messageId: 'deprecationOption', data: { key: 'messagesPersistentButtonLabelAllSelectedKey' } },
-                ],
-            },
-            // All 3 deprecated options together
-            {
-                name: 'Invalid: all deprecated options in one config',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const config = [{
-                    field: 'status',
-                    label: 'Status',
-                    type: 'BentoSelectFilter',
-                    options: {
-                        messages: {},
-                        messagesPersistentButtonLabelPartiallySelectedKey: 'k1',
-                        messagesPersistentButtonLabelAllSelectedKey: 'k2',
-                        listboxItems: [],
-                    },
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-                errors: [
-                    { messageId: 'deprecationOption', data: { key: 'messages' } },
-                    {
-                        messageId: 'deprecationOption',
-                        data: { key: 'messagesPersistentButtonLabelPartiallySelectedKey' },
-                    },
-                    { messageId: 'deprecationOption', data: { key: 'messagesPersistentButtonLabelAllSelectedKey' } },
-                ],
-            },
-            // String literal key (edge case)
-            {
-                name: 'Invalid: string literal key for deprecated option',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const config = [{
-                    field: 'status',
-                    label: 'Status',
-                    type: 'BentoSelectFilter',
-                    options: { 'messages': {} },
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-                errors: [{ messageId: 'deprecationOption', data: { key: 'messages' } }],
-            },
-            // bento-data-grid filters with deprecated value
-            {
-                name: 'Invalid: value in data-grid filter config item',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const filters = [{
-                    field: 'name',
-                    label: 'Name',
-                    type: 'BentoInputFilter',
-                    value: 'test',
-                }];
-                </script>
-                <template><bento-data-grid :filters="filters" /></template>
-                `,
-                errors: [{ messageId: 'deprecationConfigValue' }],
-            },
-            // bento-data-grid filters with deprecated options
-            {
-                name: 'Invalid: deprecated options in data-grid filter config',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const filters = [{
-                    field: 'status',
-                    label: 'Status',
-                    type: 'BentoSelectFilter',
-                    options: { messages: {}, listboxItems: [] },
-                }];
-                </script>
-                <template><bento-data-grid :filters="filters" /></template>
-                `,
-                errors: [{ messageId: 'deprecationOption', data: { key: 'messages' } }],
-            },
-            // Inline template with deprecated options
-            {
-                name: 'Invalid: deprecated options in inline template config',
-                filename: 'test.vue',
-                code: `
-                <template>
-                    <bento-filter-bar :config="[{
-                        field: 'status',
-                        label: 'Status',
-                        type: 'BentoSelectFilter',
-                        options: { messages: {}, listboxItems: [] },
-                    }]" />
-                </template>
-                `,
-                errors: [{ messageId: 'deprecationOption', data: { key: 'messages' } }],
-            },
-            // Spread + deprecated key combined
-            {
-                name: 'Invalid: spread + deprecated option combined',
-                filename: 'test.vue',
-                code: `
-                <script setup>
-                const defaults = {};
-                const config = [{
-                    field: 'status',
-                    label: 'Status',
-                    type: 'BentoSelectFilter',
-                    options: { ...defaults, messages: {} },
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-                errors: [{ messageId: 'deprecationOption', data: { key: 'messages' } }],
-            },
-        ],
-    });
-
-    /* ------------------------------------------------ */
-    /* AUTOFIX TESTS                                    */
-    /* ------------------------------------------------ */
-    ruleTester.run('deprecation-filter-bar-deprecated-props (autofix enabled)', deprecationFilterBarDeprecatedProps, {
-        valid: [
-            {
-                name: 'Valid: no deprecated props (autofix enabled)',
-                filename: 'test.vue',
-                options: [{ autofix: true }],
-                code: `<template><bento-filter-bar :config="config" /></template>`,
-            },
-        ],
-        invalid: [
-            {
-                name: 'Autofix: preserves static value prop on bento-filter-bar',
-                filename: 'test.vue',
-                options: [{ autofix: true }],
-                code: `<template><bento-filter-bar value="val" /></template>`,
-                output: null,
-                errors: [{ messageId: 'deprecationValue' }],
-            },
-            {
-                name: 'Autofix: preserves dynamic value prop on bento-filter-bar',
-                filename: 'test.vue',
-                options: [{ autofix: true }],
-                code: `<template><bento-filter-bar :value="filters" /></template>`,
-                output: null,
-                errors: [{ messageId: 'deprecationValue' }],
-            },
-            {
-                name: 'Autofix: preserves v-model on bento-filter-bar',
-                filename: 'test.vue',
-                options: [{ autofix: true }],
-                code: `<template><bento-filter-bar v-model="filters" /></template>`,
-                output: null,
-                errors: [{ messageId: 'deprecationValue' }],
-            },
-            {
-                name: 'Autofix: preserves value on filter config item',
-                filename: 'test.vue',
-                options: [{ autofix: true }],
-                code: `
-                <script setup>
-                const config = [{
-                    field: 'name',
-                    label: 'Name',
-                    type: 'BentoInputFilter',
-                    value: 'test',
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-                output: null,
-                errors: [{ messageId: 'deprecationConfigValue' }],
-            },
-            {
-                name: 'Autofix: removes deprecated messages option from filter config',
-                filename: 'test.vue',
-                options: [{ autofix: true }],
-                code: `
-                <script setup>
-                const config = [{
-                    field: 'status',
-                    label: 'Status',
-                    type: 'BentoSelectFilter',
-                    options: { messages: {}, listboxItems: [] },
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-                output: `
-                <script setup>
-                const config = [{
-                    field: 'status',
-                    label: 'Status',
-                    type: 'BentoSelectFilter',
-                    options: { listboxItems: [] },
-                }];
-                </script>
-                <template><bento-filter-bar :config="config" /></template>
-                `,
-                errors: [{ messageId: 'deprecationOption', data: { key: 'messages' } }],
-            },
-            {
-                name: 'Autofix: does not fix when autofix is false',
-                filename: 'test.vue',
-                options: [{ autofix: false }],
-                code: `<template><bento-filter-bar value="val" other="x" /></template>`,
-                errors: [{ messageId: 'deprecationValue' }],
-            },
-        ],
-    });
-});

package/rules/deprecation-input-filter-dropdown-options/__tests__/deprecation-input-filter-dropdown-options.vue

@@ -1,46 +0,0 @@
-<template>
-    <div>
-        <bento-filter-bar :config="filterBarConfig" />
-        <bento-data-grid :filters="dataGridFilters" />
-        <bento-filter-bar
-            :config="[
-                {
-                    field: 'inline',
-                    label: 'Inline',
-                    type: BentoFilterItemType.INPUT,
-                    options: { dropdown: { items: [] } },
-                },
-            ]"
-        />
-        <bento-data-grid
-            :filters="[
-                {
-                    field: 'inlineGrid',
-                    label: 'Inline Grid',
-                    type: BentoFilterItemType.INPUT,
-                    options: { variant: 'dropdown' },
-                },
-            ]"
-        />
-    </div>
-</template>
-
-<script setup>
-    const filterBarConfig = [
-        {
-            field: 'name',
-            label: 'Name',
-            type: BentoFilterItemType.INPUT,
-            options: { dropdown: { items: [] }, dropdownPosition: 'end', variant: 'dropdown' },
-        },
-    ];
-
-    const dataGridFilters = [
-        {
-            field: 'status',
-            label: 'Status',
-            type: BentoFilterItemType.INPUT,
-            options: { dropdown: { items: [] } },
-        },
-    ];
-</script>

package/rules/deprecation-input-filter-dropdown-options/__tests__/eslint.config.js

@@ -1,26 +0,0 @@
-// eslint.config.js
-const { defineConfig } = require('eslint/config');
-const vueParser = require('vue-eslint-parser');
-const tsParser = require('@typescript-eslint/parser');
-const adyenBento = require('@adyen/eslint-plugin-bento');
-
-module.exports = defineConfig([
-    {
-        languageOptions: {
-            ecmaVersion: 'latest',
-            sourceType: 'module',
-            parser: vueParser,
-            parserOptions: {
-                parser: tsParser,
-            },
-        },
-        plugins: {
-            '@adyen/bento': adyenBento,
-        },
-        rules: {
-            // Register the specific rule we are testing
-            '@adyen/bento/deprecation-input-filter-dropdown-options': 'warn',
-        },
-        files: ['**/*.vue'],
-    },
-]);

package/rules/deprecation-input-filter-dropdown-options/deprecation-input-filter-dropdown-options.integration.test.ts

@@ -1,27 +0,0 @@
-import path from 'node:path';
-import { execFileSyncEslintVueFiles } from '../../utils/exec-file-sync-eslint-vue-files';
-
-describe('@adyen/bento/deprecation-input-filter-dropdown-options', () => {
-    it('should lint with warning', () => {
-        const eslintrc = path.resolve(__dirname, '__tests__', 'eslint.config.js');
-        const vueFile = path.resolve(__dirname, '__tests__', 'deprecation-input-filter-dropdown-options.vue');
-
-        const result = JSON.parse(execFileSyncEslintVueFiles(eslintrc, vueFile));
-
-        // 3 from filterBarConfig (dropdown, dropdownPosition, variant)
-        // + 1 from dataGridFilters (dropdown)
-        // + 1 from inline bento-filter-bar (dropdown)
-        // + 1 from inline bento-data-grid (variant)
-        expect(result[0].warningCount).toBe(6);
-
-        expect(result[0].messages).toEqual(
-            expect.arrayContaining([
-                expect.objectContaining({
-                    ruleId: '@adyen/bento/deprecation-input-filter-dropdown-options',
-                    severity: 1,
-                    messageId: 'deprecation',
-                }),
-            ])
-        );
-    });
-});