@adyen/eslint-plugin-bento 2.22.0 → 2.23.0

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 2.23.0 (2026-08-17)
+
+### Features
+
+- updated `deprecation-filter-bar-deprecated-props` rule to check also for configs with enums ([5259ab283](https://github.com/Adyen/bento/commit/5259ab283))
+
+### Miscellaneous Chores
+
+- enabled strict `@adyen/eslint-plugin-bento` plugin ESLint rules to enforce deprecations ([974a8e49e](https://github.com/Adyen/bento/commit/974a8e49e))
+
+### ❤️ Thank You
+
+- daver
+
+
 ## 2.22.0 (2026-07-29)
 
 ### Bug Fixes

package/configs/vue-recommended.js

@@ -1,3 +1,4 @@
+/** @type {import('eslint').Linter.Config[]} */
 module.exports = [
     {
         name: '@bento/adyen/recommended',

package/configs/vue-strict.js

@@ -1,3 +1,4 @@
+/** @type {import('eslint').Linter.Config[]} */
 module.exports = [
     {
         name: '@bento/adyen/strict',
@@ -12,7 +13,7 @@ module.exports = [
         },
         rules: {
             '@adyen/bento/deprecation-bento-data-grid-cell-action-menu-item-handler': 'error',
-            '@adyen/bento/deprecation-bento-date-range-picker-has-actions-prop': 'error',
+            '@adyen/bento/deprecation-bento-date-range-picker-has-actions-prop': ['error', { action: 'remove' }],
             '@adyen/bento/deprecation-input-filter-dropdown-options': 'error',
             '@adyen/bento/deprecation-bento-dropdown-size-prop': 'error',
             '@adyen/bento/deprecation-bento-timeline-item-variant-prop': 'error',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adyen/eslint-plugin-bento",
-  "version": "2.22.0",
+  "version": "2.23.0",
   "description": "Adyen Bento ESLint rules",
   "main": "index.js",
   "files": [
@@ -30,8 +30,8 @@
     "@types/eslint": "9.6.1",
     "@types/estree": "1.0.6",
     "@types/node": "24.9.0",
-    "@typescript-eslint/eslint-plugin": "8.52.0",
-    "@typescript-eslint/parser": "8.52.0",
+    "@typescript-eslint/eslint-plugin": "8.61.0",
+    "@typescript-eslint/parser": "8.61.0",
     "@vitest/eslint-plugin": "1.1.25",
     "@vitest/coverage-v8": "3.2.6",
     "eslint": "9.39.0",

package/rules/deprecation-filter-bar-deprecated-props/README.md

@@ -61,4 +61,11 @@ const config = [
         options: { listboxItems: [] },
     },
 ];
+
+const values = [
+    {
+        field: 'status',
+        value: 'active',
+    },
+];
 ```

package/rules/deprecation-filter-bar-deprecated-props/deprecation-filter-bar-deprecated-props.js

@@ -20,6 +20,16 @@ function getStaticPropertyName(prop) {
     return prop.key.type === 'Identifier' ? prop.key.name : prop.key.type === 'Literal' ? String(prop.key.value) : null;
 }
 
+function isBentoFilterItemType(node) {
+    return (
+        node?.type === 'MemberExpression' &&
+        !node.computed &&
+        node.object.type === 'Identifier' &&
+        node.object.name === 'BentoFilterItemType' &&
+        node.property.type === 'Identifier'
+    );
+}
+
 /** @type {RuleModule} */
 module.exports = {
     meta: {
@@ -88,9 +98,10 @@ module.exports = {
             const filterType = propertyMap.type?.value;
             const isFilterConfig =
                 propertyMap.field &&
-                filterType?.type === 'Literal' &&
-                typeof filterType.value === 'string' &&
-                filterType.value.endsWith('Filter');
+                ((filterType?.type === 'Literal' &&
+                    typeof filterType.value === 'string' &&
+                    filterType.value.endsWith('Filter')) ||
+                    isBentoFilterItemType(filterType));
             if (!isFilterConfig) {
                 return;
             }

package/rules/deprecation-filter-bar-deprecated-props/deprecation-filter-bar-deprecated-props.test.ts

@@ -133,6 +133,16 @@ describe('@adyen/bento/deprecation-filter-bar-deprecated-props', () => {
                 <template><div /></template>
                 `,
             },
+            {
+                name: 'Valid: unrelated enum member with a similar name',
+                filename: 'test.vue',
+                code: `
+                <script setup>
+                const config = [{ field: 'name', type: OtherFilterItemType.INPUT, value: 'test' }];
+                </script>
+                <template><bento-filter-bar :config="config" /></template>
+                `,
+            },
             {
                 name: 'Valid: unrelated object with value property (no false positive)',
                 filename: 'test.vue',
@@ -186,6 +196,21 @@ describe('@adyen/bento/deprecation-filter-bar-deprecated-props', () => {
                 `,
                 errors: [{ messageId: 'deprecationConfigValue' }],
             },
+            {
+                name: 'Invalid: value property in BentoFilterItemType enum config item',
+                filename: 'test.vue',
+                code: `
+                <script setup>
+                const config = [{
+                    field: 'name',
+                    type: BentoFilterItemType.INPUT,
+                    value: 'test',
+                }];
+                </script>
+                <template><bento-filter-bar :config="config" /></template>
+                `,
+                errors: [{ messageId: 'deprecationConfigValue' }],
+            },
             // "value" inside filter config items (inline template)
             {
                 name: 'Invalid: value property in filter config item (inline template)',

package/rules/deprecation-tag-default-slot/deprecation-tag-default-slot.test.ts

@@ -42,6 +42,24 @@ describe('@adyen/bento/deprecation-tag-default-slot should suggest the usage of
                     <bento-tag :label="thisIsMyVariableWithText" variant="blue" />
                 `,
             },
+            {
+                name: 'BentoTag with named "icon" slot',
+                filename: 'test.vue',
+                code: `
+                <template>
+                    <bento-tag
+                        v-if="errorCounter != null"
+                        class="b-tabs__tab-error-counter"
+                        variant="red"
+                        :label="errorCounter"
+                    >
+                        <template #icon>
+                            <cross-circle-fill-icon aria-hidden="true" />
+                        </template>
+                    </bento-tag>
+                </template>
+                `,
+            },
         ],
         invalid: [
             {

package/utils/component-slot-migration.js

@@ -6,6 +6,7 @@ const j = require('jscodeshift');
  */
 
 /**
+ * @typedef {import('vue-eslint-parser').AST.VElement} VElement
  * @typedef {import('vue-eslint-parser').AST.VText} VText
  * @typedef {import('vue-eslint-parser').AST.VExpressionContainer} VExpressionContainer
  */
@@ -26,10 +27,23 @@ module.exports = {
      */
     componentSlotMigration({ propertyName, context, template, alwaysExpression = false }) {
         return node => {
-            if (!node.children.length) {
-                return;
+            /**
+             * @param {VElement | VText | VExpressionContainer} child
+             * @returns {boolean}
+             */
+            function isNamedSlot(child) {
+                return (
+                    child.type === 'VElement' &&
+                    child.name === 'template' &&
+                    child.startTag.attributes.some(
+                        attribute => attribute.directive && attribute.key.name.name === 'slot'
+                    )
+                );
             }
 
+            // Named slots are not default slot content and should not trigger migration.
+            const contentNodes = node.children.filter(child => !isNamedSlot(child));
+
             // Turned true if one of the children is an expression
             let hasExpression = false;
 
@@ -72,7 +86,11 @@ module.exports = {
 
             // Remove empty nodes
             /** @type { Array<VText | VExpressionContainer> } */
-            const filteredNodes = node.children.filter(removeEmptyVTextNodes);
+            const filteredNodes = contentNodes.filter(removeEmptyVTextNodes);
+
+            if (!filteredNodes.length) {
+                return;
+            }
 
             // Get all content and concat
             const slotContent = (() => {
@@ -80,7 +98,7 @@ module.exports = {
                     return transformNodeToText(filteredNodes[0])?.trim();
                 }
 
-                const content = node.children
+                const content = contentNodes
                     // eslint-disable-next-line @typescript-eslint/no-shadow
                     .map((/** @type {VText | VExpressionContainer} */ node) => transformNodeToText(node, true))
                     .join('')