@adventurelabs/scout-core 1.0.111 → 1.0.112

package/dist/hooks/useScoutRefresh.js

@@ -91,6 +91,16 @@ export function useScoutRefresh(options = {}) {
         }
         return true;
     }, []);
+    // Helper function to sort herd modules consistently by ID
+    const sortHerdModulesById = useCallback((herdModules) => {
+        if (!Array.isArray(herdModules))
+            return herdModules;
+        return [...herdModules].sort((a, b) => {
+            const aId = a?.herd?.id || 0;
+            const bId = b?.herd?.id || 0;
+            return aId - bId;
+        });
+    }, []);
     // Helper function to find differences between herd modules for debugging
     const findHerdModulesDifferences = useCallback((newData, currentData) => {
         if (!Array.isArray(newData) || !Array.isArray(currentData)) {
@@ -99,14 +109,26 @@ export function useScoutRefresh(options = {}) {
         if (newData.length !== currentData.length) {
             return `Array length mismatch: new=${newData.length}, current=${currentData.length}`;
         }
+        // Sort both arrays by herd ID for consistent comparison
+        const sortedNew = sortHerdModulesById(newData);
+        const sortedCurrent = sortHerdModulesById(currentData);
         const differences = [];
-        for (let i = 0; i < newData.length; i++) {
-            const newHerd = newData[i];
-            const currentHerd = currentData[i];
+        for (let i = 0; i < sortedNew.length; i++) {
+            const newHerd = sortedNew[i];
+            const currentHerd = sortedCurrent[i];
             if (!newHerd || !currentHerd) {
                 differences.push(`Herd ${i}: null/undefined mismatch`);
                 continue;
             }
+            // Get herd identifiers for better debugging
+            const newHerdId = newHerd.herd?.id || "unknown";
+            const currentHerdId = currentHerd.herd?.id || "unknown";
+            const newHerdName = newHerd.herd?.name || "unknown";
+            const currentHerdName = currentHerd.herd?.name || "unknown";
+            // Check if herd IDs match (data shuffling detection)
+            if (newHerdId !== currentHerdId) {
+                differences.push(`Herd ${i}: ID mismatch - expected ${currentHerdId}(${currentHerdName}) got ${newHerdId}(${newHerdName})`);
+            }
             // Check top-level fields
             const fieldsToCheck = [
                 "timestamp_last_refreshed",
@@ -116,7 +138,7 @@ export function useScoutRefresh(options = {}) {
             ];
             fieldsToCheck.forEach((field) => {
                 if (newHerd[field] !== currentHerd[field]) {
-                    differences.push(`Herd ${i}.${field}: ${currentHerd[field]} → ${newHerd[field]}`);
+                    differences.push(`Herd ${i}(${newHerdName}).${field}: ${currentHerd[field]} → ${newHerd[field]}`);
                 }
             });
             // Check array lengths for nested data
@@ -134,7 +156,7 @@ export function useScoutRefresh(options = {}) {
                 const currentArray = currentHerd[field];
                 if (Array.isArray(newArray) && Array.isArray(currentArray)) {
                     if (newArray.length !== currentArray.length) {
-                        differences.push(`Herd ${i}.${field}[]: length ${currentArray.length} → ${newArray.length}`);
+                        differences.push(`Herd ${i}(${newHerdName}).${field}[]: length ${currentArray.length} → ${newArray.length}`);
                     }
                 }
             });
@@ -145,21 +167,28 @@ export function useScoutRefresh(options = {}) {
     }, []);
     // Helper function to conditionally dispatch only if data has changed
     const conditionalDispatch = useCallback((newData, currentData, actionCreator, dataType, enableDebugging = false) => {
-        if (!deepEqual(newData, currentData)) {
+        // For herd modules, sort both datasets by ID before comparison
+        let dataToCompare = newData;
+        let currentToCompare = currentData;
+        if (dataType.includes("Herd modules")) {
+            dataToCompare = sortHerdModulesById(newData);
+            currentToCompare = sortHerdModulesById(currentData);
+        }
+        if (!deepEqual(dataToCompare, currentToCompare)) {
             console.log(`[useScoutRefresh] ${dataType} data changed, updating store`);
             // Add debugging for herd modules to see what actually changed
             if (enableDebugging && dataType.includes("Herd modules")) {
                 const differences = findHerdModulesDifferences(newData, currentData);
                 console.log(`[useScoutRefresh] ${dataType} differences: ${differences}`);
             }
-            dispatch(actionCreator(newData));
+            dispatch(actionCreator(newData)); // Always dispatch original unsorted data
             return true;
         }
         else {
             console.log(`[useScoutRefresh] ${dataType} data unchanged, skipping store update`);
             return false;
         }
-    }, [dispatch, deepEqual, findHerdModulesDifferences]);
+    }, [dispatch, deepEqual, findHerdModulesDifferences, sortHerdModulesById]);
     // Helper function to handle IndexedDB errors - memoized for stability
     const handleIndexedDbError = useCallback(async (error, operation, retryFn) => {
         if (error instanceof Error &&

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adventurelabs/scout-core",
-  "version": "1.0.111",
+  "version": "1.0.112",
   "description": "Core utilities and helpers for Adventure Labs Scout applications",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",