@adtrackify/at-service-common 1.0.21 → 1.0.23

package/dist/index.d.ts

@@ -76,8 +76,8 @@ declare module '@adtrackify/at-service-common/clients/index' {
 
 }
 declare module '@adtrackify/at-service-common/clients/internal-api/destinations-client' {
-  import { Destination } from 'aws-sdk/clients/lexmodelbuildingservice';
-  import { ApiResponse, ErrorData } from '@adtrackify/at-service-common/types/api-response';
+  import { ApiResponse } from '@adtrackify/at-service-common/types/api-response';
+  import { Destination } from '@adtrackify/at-service-common/types/db/destination';
   export class DestinationsClient {
       BASE_API_URL: string;
       DESTINATIONS_API_KEY: string;
@@ -119,12 +119,16 @@ declare module '@adtrackify/at-service-common/clients/internal-api/destinations-
           }>;
           setBaseUrl: (url: string) => boolean;
       }>;
-      createDestination: (createDestinationRequest: any) => Promise<ApiResponse<{
-          destination: Destination;
-      } | any>>;
-      getPixelDestinations: (pixelId: string) => Promise<ApiResponse<{
-          destinations: Destination[];
-      } | ErrorData>>;
+      createDestination: (createDestinationRequest: any) => Promise<ApiResponse<CreateDestinationResponseData>>;
+      getPixelDestinations: (pixelId: string) => Promise<ApiResponse<GetDestinationsResponseData>>;
+  }
+  export interface GetDestinationsResponseData {
+      destinations: Destination[];
+      [key: string]: any;
+  }
+  export interface CreateDestinationResponseData {
+      destination: Destination;
+      [key: string]: any;
   }
   export default DestinationsClient;
 
@@ -303,7 +307,6 @@ declare module '@adtrackify/at-service-common/types/api-response' {
       status: number;
       headers?: AxiosResponseHeaders;
   }
-  export type ErrorData = any;
 
 }
 declare module '@adtrackify/at-service-common/types/db/destination' {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adtrackify/at-service-common",
-  "version": "1.0.21",
+  "version": "1.0.23",
   "description": "",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",

package/src/clients/internal-api/destinations-client.ts

@@ -1,9 +1,7 @@
-import { Destination } from 'aws-sdk/clients/lexmodelbuildingservice';
 import * as log from 'lambda-log';
-import { HttpStatusCodes } from '../../libs';
-import { ApiResponse, ErrorData } from '../../types/api-response';
+import { ApiResponse } from '../../types/api-response';
 import { axiosHttpService } from '../generic/http-client';
-
+import { Destination } from '../../types/db/destination';
 //const BASE_API_URL = process.env.BASE_API_URL;
 //const DESTINATIONS_API_KEY = process.env.DESTINATIONS_API_KEY;
 
@@ -33,28 +31,28 @@ export class DestinationsClient {
     return axiosHttpService(this.getConfig());
   };
 
-  createDestination = async (createDestinationRequest: any): Promise<ApiResponse<{ destination: Destination; } | any>> => {
+  createDestination = async (createDestinationRequest: any): Promise<ApiResponse<CreateDestinationResponseData>> => {
     const client = await this.getClient();
-    const createDestinationResponse = await client.post('/', createDestinationRequest);
-    log.info('createDestinationResponse', { createDestinationResponse });
-    return {
-      status: createDestinationResponse.status,
-      headers: createDestinationResponse.headers,
-      data: createDestinationResponse.status === HttpStatusCodes.OK ? createDestinationResponse.data as { destination: Destination; } : createDestinationResponse.data
-    } as ApiResponse<{ destination: Destination; } | any>;
+    const response = await client.post('/', createDestinationRequest);
+    log.info('createDestinationResponse', { response });
+    return response as ApiResponse<CreateDestinationResponseData>;
   };
 
-  getPixelDestinations = async (pixelId: string): Promise<ApiResponse<{ destinations: Destination[]; } | ErrorData>> => {
+  getPixelDestinations = async (pixelId: string): Promise<ApiResponse<GetDestinationsResponseData>> => {
     const client = await this.getClient();
     const response = await client.get(`/?pixelId=${pixelId}`);
     log.info('getPixelResponse', { response });
-    return {
-      status: response.status,
-      headers: response.headers,
-      data: response.status === HttpStatusCodes.OK ? response.data as { destinations: Destination[]; } : response.data as ErrorData
-    } as ApiResponse<{ destination: Destination; } | ErrorData>;
+    return response as ApiResponse<GetDestinationsResponseData>;
   };
 }
 
+export interface GetDestinationsResponseData {
+  destinations: Destination[];
+  [ key: string ]: any;
+}
+export interface CreateDestinationResponseData {
+  destination: Destination;
+  [ key: string ]: any;
+}
 
 export default DestinationsClient;

package/src/types/api-response.ts

@@ -4,5 +4,3 @@ export interface ApiResponse<T> {
   status: number;
   headers?: AxiosResponseHeaders;
 }
-
-export type ErrorData = any;