@adtrackify/at-service-common 1.0.20 → 1.0.22

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adtrackify/at-service-common",
-  "version": "1.0.20",
+  "version": "1.0.22",
   "description": "",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",

package/src/clients/internal-api/destinations-client.ts

@@ -1,7 +1,6 @@
 import { Destination } from 'aws-sdk/clients/lexmodelbuildingservice';
 import * as log from 'lambda-log';
-import { HttpStatusCodes } from '../../libs';
-import { ApiResponse, ErrorData } from '../../types/api-response';
+import { ApiResponse } from '../../types/api-response';
 import { axiosHttpService } from '../generic/http-client';
 
 //const BASE_API_URL = process.env.BASE_API_URL;
@@ -33,28 +32,28 @@ export class DestinationsClient {
     return axiosHttpService(this.getConfig());
   };
 
-  createDestination = async (createDestinationRequest: any): Promise<ApiResponse<{ destination: Destination; } | any>> => {
+  createDestination = async (createDestinationRequest: any): Promise<ApiResponse<CreateDestinationResponseData>> => {
     const client = await this.getClient();
-    const createDestinationResponse = await client.post('/', createDestinationRequest);
-    log.info('createDestinationResponse', { createDestinationResponse });
-    return {
-      status: createDestinationResponse.status,
-      headers: createDestinationResponse.headers,
-      data: createDestinationResponse.status === HttpStatusCodes.OK ? createDestinationResponse.data as { destination: Destination; } : createDestinationResponse.data
-    } as ApiResponse<{ destination: Destination; } | any>;
+    const response = await client.post('/', createDestinationRequest);
+    log.info('createDestinationResponse', { response });
+    return response as ApiResponse<CreateDestinationResponseData>;
   };
 
-  getPixelDestinations = async (pixelId: string): Promise<ApiResponse<{ destinations: Destination[]; } | ErrorData>> => {
+  getPixelDestinations = async (pixelId: string): Promise<ApiResponse<GetDestinationsResponseData>> => {
     const client = await this.getClient();
     const response = await client.get(`/?pixelId=${pixelId}`);
     log.info('getPixelResponse', { response });
-    return {
-      status: response.status,
-      headers: response.headers,
-      data: response.status === HttpStatusCodes.OK ? response.data as { destinations: Destination[]; } : response.data as ErrorData
-    } as ApiResponse<{ destination: Destination; } | any>;
+    return response as ApiResponse<GetDestinationsResponseData>;
   };
 }
 
+export interface GetDestinationsResponseData {
+  destinations: Destination[];
+  [ key: string ]: any;
+}
+export interface CreateDestinationResponseData {
+  destination: Destination;
+  [ key: string ]: any;
+}
 
 export default DestinationsClient;

package/src/index.ts

@@ -1,4 +1,4 @@
-export * from './clients';
+export * from './clients/generic';
 export * from './helpers';
 export * from './libs';
 export * from './types';

package/src/types/api-response.ts

@@ -5,4 +5,4 @@ export interface ApiResponse<T> {
   headers?: AxiosResponseHeaders;
 }
 
-export type ErrorData = any;
+export type ErrorData = unknown;