@adsim/wordpress-mcp-server 4.6.0 → 5.1.0

package/tests/unit/tools/dynamicFiltering.test.js

@@ -3,7 +3,7 @@ import { vi, describe, it, expect, beforeEach, afterEach } from 'vitest';
 vi.mock('node-fetch', () => ({ default: vi.fn() }));
 
 import fetch from 'node-fetch';
-import { handleToolCall, getFilteredTools } from '../../../index.js';
+import { handleToolCall, getFilteredTools, getEnabledCategories, TOOLS_DEFINITIONS } from '../../../index.js';
 import { makeRequest, mockSuccess, mockError, parseResult } from '../../helpers/mockWpRequest.js';
 
 function call(name, args = {}) {
@@ -26,11 +26,12 @@ function restoreEnv() {
 beforeEach(() => {
   fetch.mockReset();
   consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
-  saveEnv('WC_CONSUMER_KEY', 'WP_REQUIRE_APPROVAL', 'WP_ENABLE_PLUGIN_INTELLIGENCE');
-  // Default: all optional features OFF
+  saveEnv('WC_CONSUMER_KEY', 'WP_REQUIRE_APPROVAL', 'WP_ENABLE_PLUGIN_INTELLIGENCE', 'WP_TOOL_CATEGORIES');
+  // Default: all optional features OFF, no category filter
   delete process.env.WC_CONSUMER_KEY;
   delete process.env.WP_REQUIRE_APPROVAL;
   delete process.env.WP_ENABLE_PLUGIN_INTELLIGENCE;
+  delete process.env.WP_TOOL_CATEGORIES;
 });
 afterEach(() => {
   consoleSpy.mockRestore();
@@ -52,7 +53,7 @@ describe('WooCommerce filtering', () => {
     process.env.WC_CONSUMER_KEY = 'ck_test';
     const tools = getFilteredTools();
     const wcTools = tools.filter(t => t.name.startsWith('wc_'));
-    expect(wcTools.length).toBe(13);
+    expect(wcTools.length).toBe(20);
   });
 });
 
@@ -106,15 +107,15 @@ describe('Plugin Intelligence filtering', () => {
 // =========================================================================
 
 describe('Combined filtering counts', () => {
-  it('returns all 86 tools when all features enabled', () => {
+  it('returns all tools when all features enabled', () => {
     process.env.WC_CONSUMER_KEY = 'ck_test';
     process.env.WP_REQUIRE_APPROVAL = 'true';
     process.env.WP_ENABLE_PLUGIN_INTELLIGENCE = 'true';
-    expect(getFilteredTools()).toHaveLength(86);
+    expect(getFilteredTools()).toHaveLength(175);
   });
 
-  it('returns 64 tools with no optional features (86 - 13wc - 3editorial - 6pi)', () => {
-    expect(getFilteredTools()).toHaveLength(64);
+  it('returns 145 tools with no optional features (174 - 20wc - 3editorial - 6pi)', () => {
+    expect(getFilteredTools()).toHaveLength(146);
   });
 });
 
@@ -134,3 +135,94 @@ describe('Filtered tools remain callable', () => {
     expect(res.content[0].text).not.toContain('Unknown tool');
   });
 });
+
+// =========================================================================
+// WP_TOOL_CATEGORIES filtering
+// =========================================================================
+
+describe('WP_TOOL_CATEGORIES filtering', () => {
+  it('WP_TOOL_CATEGORIES=seo → seo + core only', () => {
+    process.env.WP_TOOL_CATEGORIES = 'seo';
+    const tools = getFilteredTools();
+    const categories = [...new Set(tools.map(t => t._category))];
+    expect(categories).toContain('core');
+    expect(categories).toContain('seo');
+    expect(categories).not.toContain('content');
+    expect(categories).not.toContain('fse');
+    expect(tools.some(t => t.name === 'wp_audit_seo')).toBe(true);
+  });
+
+  it('_category is stripped from exposed tools (not present in returned objects)', () => {
+    process.env.WP_TOOL_CATEGORIES = 'seo';
+    const tools = getFilteredTools();
+    // _category IS present in getFilteredTools (internal)
+    expect(tools[0]._category).toBeDefined();
+    // But the ListTools handler strips it — we test the stripping logic directly
+    const exposed = tools.map(({ _category, ...tool }) => tool);
+    exposed.forEach(t => expect(t._category).toBeUndefined());
+  });
+
+  it('WP_TOOL_CATEGORIES=seo,content → union of seo + content + core', () => {
+    process.env.WP_TOOL_CATEGORIES = 'seo,content';
+    const tools = getFilteredTools();
+    const categories = [...new Set(tools.map(t => t._category))];
+    expect(categories).toContain('core');
+    expect(categories).toContain('seo');
+    expect(categories).toContain('content');
+    expect(categories).not.toContain('fse');
+    // No duplicates
+    const names = tools.map(t => t.name);
+    expect(names.length).toBe(new Set(names).size);
+  });
+
+  it('WP_TOOL_CATEGORIES=unknown_xyz → only core tools', () => {
+    process.env.WP_TOOL_CATEGORIES = 'unknown_xyz';
+    const tools = getFilteredTools();
+    const categories = [...new Set(tools.map(t => t._category))];
+    expect(categories).toEqual(['core']);
+    expect(tools.some(t => t.name === 'wp_site_info')).toBe(true);
+    expect(tools.some(t => t.name === 'wp_set_target')).toBe(true);
+  });
+
+  it('WP_TOOL_CATEGORIES= (empty string) → all tools exposed', () => {
+    process.env.WP_TOOL_CATEGORIES = '';
+    const tools = getFilteredTools();
+    // Same as default (no category filter) — 143 base tools
+    expect(tools).toHaveLength(146);
+  });
+
+  it('WP_TOOL_CATEGORIES undefined → all tools exposed', () => {
+    delete process.env.WP_TOOL_CATEGORIES;
+    const tools = getFilteredTools();
+    expect(tools).toHaveLength(146);
+  });
+
+  it('core tools (wp_site_info, wp_set_target) always present regardless of config', () => {
+    process.env.WP_TOOL_CATEGORIES = 'performance';
+    const tools = getFilteredTools();
+    const names = tools.map(t => t.name);
+    expect(names).toContain('wp_site_info');
+    expect(names).toContain('wp_set_target');
+  });
+
+  it('handleToolCall works for category-filtered-out tool', async () => {
+    process.env.WP_TOOL_CATEGORIES = 'seo';
+    const names = getFilteredTools().map(t => t.name);
+    expect(names).not.toContain('wp_list_posts');
+    // But calling it directly still works (not "Unknown tool")
+    fetch.mockImplementation(() => Promise.resolve({ ok: true, status: 200, headers: new Map([['x-wp-total', '0'], ['x-wp-totalpages', '0']]), json: () => Promise.resolve([]) }));
+    const res = await call('wp_list_posts');
+    expect(res.content[0].text).not.toContain('Unknown tool');
+  });
+
+  it('total TOOLS_DEFINITIONS count is 174', () => {
+    expect(TOOLS_DEFINITIONS).toHaveLength(175);
+  });
+
+  it('getEnabledCategories reflects WP_TOOL_CATEGORIES', () => {
+    process.env.WP_TOOL_CATEGORIES = 'seo,content';
+    expect(getEnabledCategories()).toEqual(['seo', 'content']);
+    delete process.env.WP_TOOL_CATEGORIES;
+    expect(getEnabledCategories()).toBeNull();
+  });
+});