@adsim/wordpress-mcp-server 4.5.1 → 5.1.0

package/tests/unit/tools/validateBlocks.test.js

@@ -0,0 +1,186 @@
+import { vi, describe, it, expect, beforeEach, afterEach } from 'vitest';
+
+vi.mock('node-fetch', () => ({ default: vi.fn() }));
+
+import fetch from 'node-fetch';
+import { handleToolCall, _testSetTarget } from '../../../index.js';
+import { makeRequest, mockSuccess, parseResult } from '../../helpers/mockWpRequest.js';
+
+function call(name, args = {}) {
+  return handleToolCall(makeRequest(name, args));
+}
+
+let consoleSpy;
+
+beforeEach(() => {
+  fetch.mockReset();
+  consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
+  _testSetTarget('site1', { url: 'https://example.com', auth: 'Basic dGVzdDp0ZXN0' });
+  delete process.env.WP_VALIDATE_BLOCKS;
+  delete process.env.WP_READ_ONLY;
+});
+afterEach(() => {
+  consoleSpy.mockRestore();
+  delete process.env.WP_VALIDATE_BLOCKS;
+  delete process.env.WP_READ_ONLY;
+});
+
+// =========================================================================
+// 1. Valid HTML → valid: true, errors: []
+// =========================================================================
+describe('wp_validate_block_structure', () => {
+  it('returns valid for well-formed Gutenberg blocks', async () => {
+    const content = [
+      '<!-- wp:paragraph -->',
+      '<p>Hello world</p>',
+      '<!-- /wp:paragraph -->',
+      '',
+      '<!-- wp:heading {"level":2} -->',
+      '<h2>Title</h2>',
+      '<!-- /wp:heading -->'
+    ].join('\n');
+
+    const res = await call('wp_validate_block_structure', { content });
+    const data = parseResult(res);
+    expect(data.valid).toBe(true);
+    expect(data.errors).toHaveLength(0);
+    expect(data.blocks_found).toEqual(
+      expect.arrayContaining([
+        { name: 'core/paragraph', count: 1 },
+        { name: 'core/heading', count: 1 }
+      ])
+    );
+  });
+
+  // =========================================================================
+  // 2. Unclosed block → error detected
+  // =========================================================================
+  it('detects unclosed block comment', async () => {
+    const content = [
+      '<!-- wp:paragraph -->',
+      '<p>No closing comment</p>'
+    ].join('\n');
+
+    const res = await call('wp_validate_block_structure', { content });
+    const data = parseResult(res);
+    expect(data.valid).toBe(false);
+    expect(data.errors.some(e => e.type === 'unclosed_block')).toBe(true);
+  });
+
+  // =========================================================================
+  // 3. Malformed JSON in comment → error detected
+  // =========================================================================
+  it('detects malformed JSON in block attributes', async () => {
+    const content = [
+      '<!-- wp:heading {level:2} -->',
+      '<h2>Bad JSON</h2>',
+      '<!-- /wp:heading -->'
+    ].join('\n');
+
+    const res = await call('wp_validate_block_structure', { content });
+    const data = parseResult(res);
+    expect(data.valid).toBe(false);
+    expect(data.errors.some(e => e.type === 'malformed_json')).toBe(true);
+  });
+
+  // =========================================================================
+  // 4. Invalid nesting → error detected
+  // =========================================================================
+  it('detects invalid nesting (paragraph inside paragraph)', async () => {
+    const content = [
+      '<!-- wp:paragraph -->',
+      '<p>Outer</p>',
+      '<!-- wp:paragraph -->',
+      '<p>Inner — invalid</p>',
+      '<!-- /wp:paragraph -->',
+      '<!-- /wp:paragraph -->'
+    ].join('\n');
+
+    const res = await call('wp_validate_block_structure', { content });
+    const data = parseResult(res);
+    expect(data.valid).toBe(false);
+    expect(data.errors.some(e => e.type === 'invalid_nesting')).toBe(true);
+  });
+
+  // =========================================================================
+  // 5. strict: false → no error on missing attributes
+  // =========================================================================
+  it('does not error on missing attributes when strict=false', async () => {
+    const content = [
+      '<!-- wp:heading -->',
+      '<h2>No attributes</h2>',
+      '<!-- /wp:heading -->'
+    ].join('\n');
+
+    const res = await call('wp_validate_block_structure', { content, strict: false });
+    const data = parseResult(res);
+    expect(data.valid).toBe(true);
+    expect(data.errors.filter(e => e.type === 'missing_attributes')).toHaveLength(0);
+  });
+
+  // =========================================================================
+  // 6. strict: true → error on missing attributes
+  // =========================================================================
+  it('errors on missing attributes when strict=true', async () => {
+    const content = [
+      '<!-- wp:heading -->',
+      '<h2>No attributes</h2>',
+      '<!-- /wp:heading -->'
+    ].join('\n');
+
+    const res = await call('wp_validate_block_structure', { content, strict: true });
+    const data = parseResult(res);
+    expect(data.valid).toBe(false);
+    expect(data.errors.some(e => e.type === 'missing_attributes')).toBe(true);
+  });
+});
+
+// =========================================================================
+// 7-9. WP_VALIDATE_BLOCKS guard on wp_update_post
+// =========================================================================
+describe('WP_VALIDATE_BLOCKS guard', () => {
+  // 7. WP_VALIDATE_BLOCKS=true → blocks update if invalid content
+  it('blocks wp_update_post with invalid content when WP_VALIDATE_BLOCKS=true', async () => {
+    process.env.WP_VALIDATE_BLOCKS = 'true';
+    const invalidContent = '<!-- wp:paragraph -->\n<p>Unclosed block</p>';
+
+    const res = await call('wp_update_post', { id: 1, content: invalidContent });
+    expect(res.isError).toBe(true);
+    const data = JSON.parse(res.content[0].text);
+    expect(data.status).toBe('blocked');
+    expect(data.reason).toContain('WP_VALIDATE_BLOCKS');
+    expect(data.errors.length).toBeGreaterThan(0);
+  });
+
+  // 8. WP_VALIDATE_BLOCKS=true → allows update if valid content
+  it('allows wp_update_post with valid content when WP_VALIDATE_BLOCKS=true', async () => {
+    process.env.WP_VALIDATE_BLOCKS = 'true';
+    const validContent = '<!-- wp:paragraph -->\n<p>Valid</p>\n<!-- /wp:paragraph -->';
+
+    // POST /posts/1 → updated
+    mockSuccess({
+      id: 1, title: { rendered: 'Test' }, status: 'publish',
+      link: 'https://example.com/test/', modified: '2025-06-16'
+    });
+
+    const res = await call('wp_update_post', { id: 1, content: validContent });
+    const data = parseResult(res);
+    expect(data.success).toBe(true);
+  });
+
+  // 9. WP_VALIDATE_BLOCKS not set → no interception
+  it('does not intercept wp_update_post when WP_VALIDATE_BLOCKS is not set', async () => {
+    // No WP_VALIDATE_BLOCKS env var
+    const invalidContent = '<!-- wp:paragraph -->\n<p>Unclosed</p>';
+
+    // POST /posts/1 → updated normally despite invalid blocks
+    mockSuccess({
+      id: 1, title: { rendered: 'Test' }, status: 'publish',
+      link: 'https://example.com/test/', modified: '2025-06-16'
+    });
+
+    const res = await call('wp_update_post', { id: 1, content: invalidContent });
+    const data = parseResult(res);
+    expect(data.success).toBe(true);
+  });
+});

package/tests/unit/tools/visualStaging.test.js

@@ -0,0 +1,271 @@
+import { vi, describe, it, expect, beforeEach, afterEach } from 'vitest';
+
+vi.mock('node-fetch', () => ({ default: vi.fn() }));
+
+import fetch from 'node-fetch';
+import { handleToolCall, _testSetTarget, TOOLS_DEFINITIONS } from '../../../index.js';
+import { makeRequest, mockSuccess, parseResult } from '../../helpers/mockWpRequest.js';
+
+function call(name, args = {}) {
+  return handleToolCall(makeRequest(name, args));
+}
+
+let consoleSpy;
+
+beforeEach(() => {
+  fetch.mockReset();
+  consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
+  _testSetTarget('site1', { url: 'https://example.com', auth: 'Basic dGVzdDp0ZXN0' });
+  // Reset env vars
+  delete process.env.WP_VISUAL_STAGING;
+  delete process.env.WP_READ_ONLY;
+});
+afterEach(() => {
+  consoleSpy.mockRestore();
+  delete process.env.WP_VISUAL_STAGING;
+  delete process.env.WP_READ_ONLY;
+});
+
+function mockPage(overrides = {}) {
+  const { title, content, excerpt, ...rest } = overrides;
+  return {
+    id: 42,
+    title: { rendered: title || 'Live Page' },
+    content: { rendered: content || '<p>Live content</p>' },
+    excerpt: { rendered: excerpt || '' },
+    status: 'publish',
+    slug: 'live-page',
+    link: 'https://example.com/live-page/',
+    date: '2025-06-15T10:00:00',
+    modified: '2025-06-15T10:00:00',
+    parent: 0,
+    template: '',
+    meta: {},
+    ...rest
+  };
+}
+
+function mockStagingDraft(overrides = {}) {
+  const { title, content, excerpt, ...rest } = overrides;
+  return {
+    id: 99,
+    title: { rendered: title || '[STAGING] Live Page' },
+    content: { rendered: content || '<p>Updated staging content</p>' },
+    excerpt: { rendered: excerpt || '' },
+    status: 'draft',
+    slug: 'staging-live-page',
+    link: 'https://example.com/?p=99',
+    date: '2025-06-16T10:00:00',
+    modified: '2025-06-16T12:00:00',
+    meta: { _staging_source_id: 42 },
+    ...rest
+  };
+}
+
+// =========================================================================
+// 1. wp_create_staging_draft — creates draft with correct _staging_source_id
+// =========================================================================
+describe('wp_create_staging_draft', () => {
+  it('creates a staging draft from a published page', async () => {
+    // 1st call: GET /pages/42 → published page
+    mockSuccess(mockPage());
+    // 2nd call: GET /pages?status=draft... → no existing drafts
+    mockSuccess([]);
+    // 3rd call: POST /pages → created draft
+    mockSuccess(mockStagingDraft());
+
+    const res = await call('wp_create_staging_draft', { source_id: 42, post_type: 'page' });
+    const data = parseResult(res);
+    expect(data.status).toBe('created');
+    expect(data.staging_draft_id).toBe(99);
+    expect(data.source_id).toBe(42);
+  });
+
+  // 2. Returns already_exists if draft exists
+  it('returns already_exists if staging draft already exists', async () => {
+    mockSuccess(mockPage());
+    mockSuccess([mockStagingDraft()]);
+
+    const res = await call('wp_create_staging_draft', { source_id: 42 });
+    const data = parseResult(res);
+    expect(data.status).toBe('already_exists');
+    expect(data.staging_draft_id).toBe(99);
+  });
+
+  // 3. Error if source is not published
+  it('throws error if source is not published', async () => {
+    mockSuccess(mockPage({ status: 'draft' }));
+
+    const res = await call('wp_create_staging_draft', { source_id: 42 });
+    expect(res.isError).toBe(true);
+    expect(res.content[0].text).toContain('Only published content can be staged');
+  });
+});
+
+// =========================================================================
+// 4. wp_list_staging_drafts — returns list filtered by source_id
+// =========================================================================
+describe('wp_list_staging_drafts', () => {
+  it('returns staging drafts filtered by source_id', async () => {
+    // Posts search
+    mockSuccess([]);
+    // Pages search
+    mockSuccess([mockStagingDraft(), mockStagingDraft({ id: 100, meta: { _staging_source_id: 55 } })]);
+
+    const res = await call('wp_list_staging_drafts', { source_id: 42 });
+    const data = parseResult(res);
+    expect(data.total).toBe(1);
+    expect(data.staging_drafts[0].source_id).toBe(42);
+  });
+});
+
+// =========================================================================
+// 5. wp_get_staging_preview_url — returns correct preview_url
+// =========================================================================
+describe('wp_get_staging_preview_url', () => {
+  it('returns preview URL for a staging draft', async () => {
+    mockSuccess(mockStagingDraft());
+
+    const res = await call('wp_get_staging_preview_url', { staging_id: 99 });
+    const data = parseResult(res);
+    expect(data.preview_url).toBe('https://example.com/?p=99&preview=true');
+    expect(data.source_id).toBe(42);
+  });
+
+  // 6. Error if not a staging draft
+  it('throws error if post is not a staging draft', async () => {
+    mockSuccess(mockPage({ id: 42, meta: {} }));
+
+    const res = await call('wp_get_staging_preview_url', { staging_id: 42 });
+    expect(res.isError).toBe(true);
+    expect(res.content[0].text).toContain('not a staging draft');
+  });
+});
+
+// =========================================================================
+// 7-8. wp_merge_staging_to_live
+// =========================================================================
+describe('wp_merge_staging_to_live', () => {
+  // 7. confirm:false → dry-run
+  it('returns dry-run preview when confirm=false', async () => {
+    // GET /pages/99 → staging draft
+    mockSuccess(mockStagingDraft());
+    // GET /pages/42 → live page
+    mockSuccess(mockPage());
+
+    const res = await call('wp_merge_staging_to_live', { staging_id: 99, confirm: false });
+    const data = parseResult(res);
+    expect(data.status).toBe('dry_run');
+    expect(data.changes_preview).toBeDefined();
+    expect(data.changes_preview.title.from).toBe('Live Page');
+  });
+
+  // 8. confirm:true → merge + audit
+  it('merges staging draft to live when confirm=true', async () => {
+    // GET /pages/99 → staging draft
+    mockSuccess(mockStagingDraft());
+    // GET /pages/42 → live page (for comparison, though merge skips this in confirm path)
+    mockSuccess(mockPage());
+    // POST /pages/42 → updated live page
+    mockSuccess(mockPage({ modified: '2025-06-16T14:00:00' }));
+    // DELETE /pages/99 → deleted
+    mockSuccess({ deleted: true });
+
+    const res = await call('wp_merge_staging_to_live', { staging_id: 99, confirm: true });
+    const data = parseResult(res);
+    expect(data.status).toBe('merged');
+    expect(data.source_id).toBe(42);
+  });
+
+  // 9. Blocked by WP_READ_ONLY
+  it('is blocked when WP_READ_ONLY=true', async () => {
+    process.env.WP_READ_ONLY = 'true';
+
+    const res = await call('wp_merge_staging_to_live', { staging_id: 99 });
+    expect(res.isError).toBe(true);
+    expect(res.content[0].text).toContain('READ-ONLY');
+
+    delete process.env.WP_READ_ONLY;
+  });
+});
+
+// =========================================================================
+// 10-11. wp_discard_staging_draft
+// =========================================================================
+describe('wp_discard_staging_draft', () => {
+  // 10. confirm:false → dry-run
+  it('returns dry-run when confirm=false', async () => {
+    mockSuccess(mockStagingDraft());
+
+    const res = await call('wp_discard_staging_draft', { staging_id: 99, confirm: false });
+    const data = parseResult(res);
+    expect(data.status).toBe('dry_run');
+    expect(data.source_id).toBe(42);
+  });
+
+  // 11. confirm:true → deletion + audit
+  it('discards staging draft when confirm=true', async () => {
+    mockSuccess(mockStagingDraft());
+    mockSuccess({ deleted: true });
+
+    const res = await call('wp_discard_staging_draft', { staging_id: 99, confirm: true });
+    const data = parseResult(res);
+    expect(data.status).toBe('discarded');
+    expect(data.staging_id).toBe(99);
+  });
+});
+
+// =========================================================================
+// 12-14. WP_VISUAL_STAGING interception
+// =========================================================================
+describe('WP_VISUAL_STAGING interception', () => {
+  // 12. wp_update_post on published → intercepted
+  it('intercepts wp_update_post on published content when WP_VISUAL_STAGING=true', async () => {
+    process.env.WP_VISUAL_STAGING = 'true';
+    // GET /posts/42 → published post
+    mockSuccess({ id: 42, status: 'publish', title: { rendered: 'Test' }, content: { rendered: '' }, meta: {} });
+
+    const res = await call('wp_update_post', { id: 42, title: 'New Title' });
+    const data = parseResult(res);
+    expect(data.status).toBe('intercepted');
+    expect(data.reason).toContain('WP_VISUAL_STAGING');
+  });
+
+  // 13. wp_update_post on draft → NOT intercepted (normal flow)
+  it('does NOT intercept wp_update_post on draft content', async () => {
+    process.env.WP_VISUAL_STAGING = 'true';
+    // GET /posts/42 → draft post
+    mockSuccess({ id: 42, status: 'draft', title: { rendered: 'Test' }, content: { rendered: '' }, meta: {} });
+    // POST /posts/42 → updated
+    mockSuccess({ id: 42, status: 'draft', title: { rendered: 'New Title' }, link: 'https://example.com/?p=42', modified: '2025-06-16' });
+
+    const res = await call('wp_update_post', { id: 42, title: 'New Title' });
+    const data = parseResult(res);
+    expect(data.success).toBe(true);
+  });
+
+  // 14. WP_VISUAL_STAGING=false → normal (no interception)
+  it('does NOT intercept when WP_VISUAL_STAGING is not set', async () => {
+    // No WP_VISUAL_STAGING env var
+    // POST /posts/42 → updated
+    mockSuccess({ id: 42, status: 'publish', title: { rendered: 'New Title' }, link: 'https://example.com/test/', modified: '2025-06-16' });
+
+    const res = await call('wp_update_post', { id: 42, title: 'New Title' });
+    const data = parseResult(res);
+    expect(data.success).toBe(true);
+  });
+});
+
+// =========================================================================
+// 15. TOOLS_DEFINITIONS contains the 5 new tools
+// =========================================================================
+describe('TOOLS_DEFINITIONS', () => {
+  it('contains the 5 visual staging tools with workflow category', () => {
+    const stagingTools = ['wp_create_staging_draft', 'wp_list_staging_drafts', 'wp_get_staging_preview_url', 'wp_merge_staging_to_live', 'wp_discard_staging_draft'];
+    for (const toolName of stagingTools) {
+      const tool = TOOLS_DEFINITIONS.find(t => t.name === toolName);
+      expect(tool, `${toolName} should exist in TOOLS_DEFINITIONS`).toBeDefined();
+      expect(tool._category).toBe('workflow');
+    }
+  });
+});