@adonisjs/eslint-plugin 1.1.9 → 1.2.0

package/dist/src/rules/prefer_lazy_controller_import.js

@@ -29,6 +29,13 @@ exports.default = (0, utils_2.createEslintRule)({
                 node.callee.property.type === utils_1.AST_NODE_TYPES.Identifier &&
                 httpMethods.includes(node.callee.property.name));
         }
+        function isRouteResourceCallExpression(node, identifier) {
+            return (node.callee.type === utils_1.AST_NODE_TYPES.MemberExpression &&
+                node.callee.object.type === utils_1.AST_NODE_TYPES.Identifier &&
+                node.callee.object.name === identifier &&
+                node.callee.property.type === utils_1.AST_NODE_TYPES.Identifier &&
+                node.callee.property.name === 'resource');
+        }
         return {
             /**
              * Track all imported identifiers
@@ -50,35 +57,54 @@ exports.default = (0, utils_2.createEslintRule)({
             CallExpression(node) {
                 /**
                  * Check if we are calling router.get() or any other http method
+                 * OR if we are calling router.resource that also takes a controller
+                 * as an argument
                  */
-                if (!isRouteCallExpression(node, routerIdentifier)) {
+                const isRouteCallExpr = isRouteCallExpression(node, routerIdentifier);
+                const isRouteResourceExpr = isRouteResourceCallExpression(node, routerIdentifier);
+                if (!isRouteCallExpr && !isRouteResourceExpr) {
                     return;
                 }
                 /**
-                 * Ensure the second argument is an array
+                 * Now let's extract the controller identifier from the call expression
+                 *
+                 * In the case of router.get/post/put.. we have to extract
+                 * the first element from the array
+                 *
+                 * router.get("/", [HomeController, 'index'])
                  */
-                const secondArgument = node.arguments[1];
-                if (secondArgument.type !== utils_1.AST_NODE_TYPES.ArrayExpression) {
-                    return;
+                let controller;
+                if (isRouteCallExpr) {
+                    const secondArgument = node.arguments[1];
+                    if (secondArgument.type !== utils_1.AST_NODE_TYPES.ArrayExpression)
+                        return;
+                    controller = secondArgument.elements[0];
                 }
-                for (const element of secondArgument.elements) {
-                    /**
-                     * If we are dealing with an Identifier that was imported
-                     * through a standard import, then report it as an error
-                     */
-                    if (element.type !== 'Identifier' || !importIdentifiers.includes(element.name)) {
-                        continue;
-                    }
-                    context.report({
-                        node: importNodes[element.name],
-                        messageId: 'preferLazyControllerImport',
-                        fix(fixer) {
-                            const importPath = importNodes[element.name].source.raw;
-                            const newImportDeclaration = `const ${element.name} = () => import(${importPath})`;
-                            return fixer.replaceText(importNodes[element.name], newImportDeclaration);
-                        },
-                    });
+                /**
+                 * In the case of router.resource, we just have to extract the first argument
+                 *
+                 * router.resource("foo", UserController)
+                 */
+                if (isRouteResourceExpr) {
+                    controller = node.arguments[1];
+                }
+                /**
+                 * If we are dealing with an Identifier that was imported
+                 * through a standard import, then report it as an error
+                 */
+                const element = controller;
+                if (element.type !== 'Identifier' || !importIdentifiers.includes(element.name)) {
+                    return;
                 }
+                context.report({
+                    node: importNodes[element.name],
+                    messageId: 'preferLazyControllerImport',
+                    fix(fixer) {
+                        const importPath = importNodes[element.name].source.raw;
+                        const newImportDeclaration = `const ${element.name} = () => import(${importPath})`;
+                        return fixer.replaceText(importNodes[element.name], newImportDeclaration);
+                    },
+                });
             },
         };
     },

package/dist/tests/prefer_lazy_controller_import.spec.js

@@ -43,6 +43,23 @@ const invalids = [
     })
     `,
     ],
+    /**
+     * When used with route.resource
+     */
+    [
+        `
+    import router from "@adonisjs/core/services/router"
+    import ProjectThreadsController from "./controller"
+
+    router.resource("project/:id/threads", ProjectThreadsController)
+    `,
+        `
+    import router from "@adonisjs/core/services/router"
+    const ProjectThreadsController = () => import("./controller")
+
+    router.resource("project/:id/threads", ProjectThreadsController)
+    `,
+    ],
 ];
 (0, runner_1.test)('Prefer lazy controller import', ({ assert }) => {
     const ruleTester = new ts_eslint_1.RuleTester({

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@adonisjs/eslint-plugin",
   "description": "ESLint plugin to enforce AdonisJS app specific linting rules",
-  "version": "1.1.9",
+  "version": "1.2.0",
   "main": "dist/src/index.js",
   "files": [
     "dist"