@adonis-agora/media 0.10.2 → 0.10.3

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @adonis-agora/media
 
+## 0.10.3
+
+### Patch Changes
+
+- [`fdfafea`](https://github.com/DavideCarvalho/adonis-media/commit/fdfafeabf618b2787a970c4b104af822dcec03fe) Thanks [@DavideCarvalho](https://github.com/DavideCarvalho)! - `services/main` no longer throws when imported before `MediaProvider.register()`
+
+  The `@adonis-agora/media/services/main` singleton used a provider-captured `getBootedApp()` with a
+  top-level `await` — importing it before `MediaProvider.register()` ran (e.g. the ace command loader
+  reading command metadata during `node ace list`) threw `app accessed before MediaProvider registered`.
+
+  It now follows the ecosystem-standard pattern used by `@adonisjs/lucid`, `@adonisjs/drive` and
+  `@adonisjs/queue`: read the app from `@adonisjs/core/services/app` (whose binding is set by
+  `bin/server`/`bin/console` before any command module is imported) and capture the `MediaManager`
+  inside `app.booted(...)`. Importing the singleton is now safe at any time; the manager resolves once
+  the app boots.
+
 ## 0.10.2
 
 ### Patch Changes

package/dist/src/services/main.d.ts

@@ -9,17 +9,17 @@ import { MediaManager } from '../media_manager.js';
  * await media.library.attach({ ownerType: 'Post', ownerId: '1', collection: 'gallery', ... })
  * ```
  *
- * The app is read from the provider-captured booted instance ({@link getBootedApp}) rather than
- * `@adonisjs/core/services/app` — see `./booted_app.js` for why that import is unreliable under a
- * duplicated `@adonisjs/core` tree (pnpm dual-package hazard).
+ * Same pattern as `@adonisjs/lucid/services/db`, `@adonisjs/drive/services/main` and
+ * `@adonisjs/queue/services/main`: read the app from `@adonisjs/core/services/app` (whose binding is
+ * set by `bin/server`/`bin/console` before any command/route module is imported) and capture the
+ * manager inside `app.booted(...)`. This makes importing this module safe at ANY time — including
+ * the ace command loader reading command metadata before the app boots.
  *
- * This module's top-level `await` runs at import time, so importing it requires
- * `MediaProvider.register()` to already have run. In the previous `@adonisjs/core/services/app`
- * import this "just worked" in a single-copy tree (that module's `app` binding is set very early,
- * long before any provider registers) but threw an opaque `Cannot read properties of undefined
- * (reading 'booted')` in a duplicated-`@adonisjs/core` tree — the exact class of crash this file
- * exists to fix. Importing this module before `MediaProvider.register()` has run now throws the same
- * clear, actionable error {@link getBootedApp} gives everywhere else in this package.
+ * (Historical note: this module used a provider-captured `getBootedApp()` instead, because under a
+ * duplicated `@adonisjs/core` tree (pnpm dual-package hazard) `services/app`'s binding could resolve
+ * to a non-booted copy and stay `undefined`. That hazard is solved at the app level — the Lumen
+ * workspace pins `@adonisjs/core` to a single copy via `pnpm.overrides` — and the ecosystem-standard
+ * `services/app` pattern is what `lucid`/`drive`/`queue` use, so we align with it.)
  */
 declare let media: MediaManager;
 export { media as default };

package/dist/src/services/main.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"main.d.ts","sourceRoot":"","sources":["../../../src/services/main.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,MAAM,qBAAqB,CAAC;AAGnD;;;;;;;;;;;;;;;;;;;;;GAqBG;AACH,QAAA,IAAI,KAAK,EAAE,YAAY,CAAC;AAMxB,OAAO,EAAE,KAAK,IAAI,OAAO,EAAE,CAAC"}
+{"version":3,"file":"main.d.ts","sourceRoot":"","sources":["../../../src/services/main.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,YAAY,EAAE,MAAM,qBAAqB,CAAC;AAEnD;;;;;;;;;;;;;;;;;;;;;GAqBG;AACH,QAAA,IAAI,KAAK,EAAE,YAAY,CAAC;AAMxB,OAAO,EAAE,KAAK,IAAI,OAAO,EAAE,CAAC"}

package/dist/src/services/main.js

@@ -1,5 +1,5 @@
+import app from '@adonisjs/core/services/app';
 import { MediaManager } from '../media_manager.js';
-import { getBootedApp } from './booted_app.js';
 /**
  * Service-singleton for the {@link MediaManager}, resolved from the container once the app has
  * booted. Import it for a ready-to-use manager instead of resolving the binding by hand:
@@ -10,21 +10,21 @@ import { getBootedApp } from './booted_app.js';
  * await media.library.attach({ ownerType: 'Post', ownerId: '1', collection: 'gallery', ... })
  * ```
  *
- * The app is read from the provider-captured booted instance ({@link getBootedApp}) rather than
- * `@adonisjs/core/services/app` — see `./booted_app.js` for why that import is unreliable under a
- * duplicated `@adonisjs/core` tree (pnpm dual-package hazard).
+ * Same pattern as `@adonisjs/lucid/services/db`, `@adonisjs/drive/services/main` and
+ * `@adonisjs/queue/services/main`: read the app from `@adonisjs/core/services/app` (whose binding is
+ * set by `bin/server`/`bin/console` before any command/route module is imported) and capture the
+ * manager inside `app.booted(...)`. This makes importing this module safe at ANY time — including
+ * the ace command loader reading command metadata before the app boots.
  *
- * This module's top-level `await` runs at import time, so importing it requires
- * `MediaProvider.register()` to already have run. In the previous `@adonisjs/core/services/app`
- * import this "just worked" in a single-copy tree (that module's `app` binding is set very early,
- * long before any provider registers) but threw an opaque `Cannot read properties of undefined
- * (reading 'booted')` in a duplicated-`@adonisjs/core` tree — the exact class of crash this file
- * exists to fix. Importing this module before `MediaProvider.register()` has run now throws the same
- * clear, actionable error {@link getBootedApp} gives everywhere else in this package.
+ * (Historical note: this module used a provider-captured `getBootedApp()` instead, because under a
+ * duplicated `@adonisjs/core` tree (pnpm dual-package hazard) `services/app`'s binding could resolve
+ * to a non-booted copy and stay `undefined`. That hazard is solved at the app level — the Lumen
+ * workspace pins `@adonisjs/core` to a single copy via `pnpm.overrides` — and the ecosystem-standard
+ * `services/app` pattern is what `lucid`/`drive`/`queue` use, so we align with it.)
  */
 let media;
-await getBootedApp().booted(async () => {
-    media = await getBootedApp().container.make(MediaManager);
+await app.booted(async () => {
+    media = await app.container.make(MediaManager);
 });
 export { media as default };
 //# sourceMappingURL=main.js.map

package/dist/src/services/main.js.map

@@ -1 +1 @@
-{"version":3,"file":"main.js","sourceRoot":"","sources":["../../../src/services/main.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,MAAM,qBAAqB,CAAC;AACnD,OAAO,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAC;AAE/C;;;;;;;;;;;;;;;;;;;;;GAqBG;AACH,IAAI,KAAmB,CAAC;AAExB,MAAM,YAAY,EAAE,CAAC,MAAM,CAAC,KAAK,IAAI,EAAE;IACrC,KAAK,GAAG,MAAM,YAAY,EAAE,CAAC,SAAS,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;AAC5D,CAAC,CAAC,CAAC;AAEH,OAAO,EAAE,KAAK,IAAI,OAAO,EAAE,CAAC"}
+{"version":3,"file":"main.js","sourceRoot":"","sources":["../../../src/services/main.ts"],"names":[],"mappings":"AAAA,OAAO,GAAG,MAAM,6BAA6B,CAAC;AAC9C,OAAO,EAAE,YAAY,EAAE,MAAM,qBAAqB,CAAC;AAEnD;;;;;;;;;;;;;;;;;;;;;GAqBG;AACH,IAAI,KAAmB,CAAC;AAExB,MAAM,GAAG,CAAC,MAAM,CAAC,KAAK,IAAI,EAAE;IAC1B,KAAK,GAAG,MAAM,GAAG,CAAC,SAAS,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;AACjD,CAAC,CAAC,CAAC;AAEH,OAAO,EAAE,KAAK,IAAI,OAAO,EAAE,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adonis-agora/media",
-  "version": "0.10.2",
+  "version": "0.10.3",
   "description": "Media-library for AdonisJS — owner collections (MIME whitelist, single-file replace, ordering), image conversions (eager/lazy), pluggable content transformers (HLS video via mediabunny, metadata probe), and column attachments, all on top of @adonisjs/drive. Pluggable MediaStore (in-memory + Lucid) and ImageProcessor (sharp). Part of the Agora ecosystem.",
   "license": "MIT",
   "repository": {