@adobe/spacecat-shared-utils 1.52.0 → 1.54.0

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [@adobe/spacecat-shared-utils-v1.54.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.53.0...@adobe/spacecat-shared-utils-v1.54.0) (2025-10-02)
+
+
+### Features
+
+* remove topic from brand alias and make regions mandatory in categories + make regions mandatory for categories ([#997](https://github.com/adobe/spacecat-shared/issues/997)) ([78e609a](https://github.com/adobe/spacecat-shared/commit/78e609a336cb2a2645199d94d4464c4843bd8c4a))
+
+# [@adobe/spacecat-shared-utils-v1.53.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.52.0...@adobe/spacecat-shared-utils-v1.53.0) (2025-10-02)
+
+
+### Features
+
+* Add regions to categories and related validation on dependent entities ([#996](https://github.com/adobe/spacecat-shared/issues/996)) ([60c52e2](https://github.com/adobe/spacecat-shared/commit/60c52e2d9c7e79a67132ae2b26e40e617e8af358))
+
 # [@adobe/spacecat-shared-utils-v1.52.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.51.1...@adobe/spacecat-shared-utils-v1.52.0) (2025-09-29)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-utils",
-  "version": "1.52.0",
+  "version": "1.54.0",
   "description": "Shared modules of the Spacecat Services - utils",
   "type": "module",
   "engines": {

package/src/schemas.js

@@ -36,14 +36,14 @@ import * as z from 'zod';
 
 const nonEmptyString = z.string().min(1);
 
+const region = z.string().length(2).regex(/^[a-z][a-z]$/i);
+
 const entity = z.union([
-  z.object({ type: z.literal('category'), name: nonEmptyString }),
+  z.object({ type: z.literal('category'), name: nonEmptyString, region: z.union([region, z.array(region)]) }),
   z.object({ type: z.literal('topic'), name: nonEmptyString }),
   z.object({ type: nonEmptyString }),
 ]);
 
-const region = z.string().length(2).regex(/^[a-z][a-z]$/i);
-
 export const llmoConfig = z.object({
   entities: z.record(z.uuid(), entity),
   brands: z.object({
@@ -52,7 +52,6 @@ export const llmoConfig = z.object({
         aliases: z.array(nonEmptyString),
         category: z.uuid(),
         region: z.union([region, z.array(region)]),
-        topic: z.uuid(),
       }),
     ),
   }),
@@ -72,11 +71,12 @@ export const llmoConfig = z.object({
 
   brands.aliases.forEach((alias, index) => {
     ensureEntityType(entities, ctx, alias.category, 'category', ['brands', 'aliases', index, 'category'], 'category');
-    ensureEntityType(entities, ctx, alias.topic, 'topic', ['brands', 'aliases', index, 'topic'], 'topic');
+    ensureRegionCompatibility(entities, ctx, alias.category, alias.region, ['brands', 'aliases', index, 'region'], 'brand alias');
   });
 
   competitors.competitors.forEach((competitor, index) => {
     ensureEntityType(entities, ctx, competitor.category, 'category', ['competitors', 'competitors', index, 'category'], 'category');
+    ensureRegionCompatibility(entities, ctx, competitor.category, competitor.region, ['competitors', 'competitors', index, 'region'], 'competitor');
   });
 });
 
@@ -107,3 +107,37 @@ function ensureEntityType(entities, ctx, id, expectedType, path, refLabel) {
     });
   }
 }
+
+/**
+ * @param {LLMOConfig['entities']} entities
+ * @param {z.RefinementCtx} ctx
+ * @param {string} categoryId
+ * @param {string | string[]} itemRegion
+ * @param {Array<number | string>} path
+ * @param {string} itemLabel
+ */
+function ensureRegionCompatibility(entities, ctx, categoryId, itemRegion, path, itemLabel) {
+  const categoryEntity = entities[categoryId];
+  if (!categoryEntity) {
+    // Category validation is handled by ensureEntityType
+    return;
+  }
+
+  const categoryRegions = categoryEntity.region;
+
+  // Normalize regions to arrays for comparison
+  const categoryRegionArray = Array.isArray(categoryRegions) ? categoryRegions : [categoryRegions];
+  const itemRegionArray = Array.isArray(itemRegion) ? itemRegion : [itemRegion];
+
+  // Check if all item regions are contained in category regions
+  const invalidRegions = itemRegionArray.filter(
+    (regionItem) => !categoryRegionArray.includes(regionItem),
+  );
+  if (invalidRegions.length > 0) {
+    ctx.addIssue({
+      code: 'custom',
+      path,
+      message: `${itemLabel} regions [${invalidRegions.join(', ')}] are not allowed. Category only supports regions: [${categoryRegionArray.join(', ')}]`,
+    });
+  }
+}