@adobe/spacecat-shared-utils 1.35.1 → 1.36.0

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [@adobe/spacecat-shared-utils-v1.36.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.35.2...@adobe/spacecat-shared-utils-v1.36.0) (2025-04-02)
+
+
+### Features
+
+* changing forms api signature ([#677](https://github.com/adobe/spacecat-shared/issues/677)) ([30b4825](https://github.com/adobe/spacecat-shared/commit/30b48250c492d1611503cb701c6acd0126a6c057))
+
+# [@adobe/spacecat-shared-utils-v1.35.2](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.35.1...@adobe/spacecat-shared-utils-v1.35.2) (2025-04-01)
+
+
+### Bug Fixes
+
+* **deps:** update external major (major) ([#674](https://github.com/adobe/spacecat-shared/issues/674)) ([285b37d](https://github.com/adobe/spacecat-shared/commit/285b37de9df42adb6a23694bcc699608e3b5b8fe))
+
 # [@adobe/spacecat-shared-utils-v1.35.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.35.0...@adobe/spacecat-shared-utils-v1.35.1) (2025-04-01)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-utils",
-  "version": "1.35.1",
+  "version": "1.36.0",
   "description": "Shared modules of the Spacecat Services - utils",
   "type": "module",
   "engines": {
@@ -40,7 +40,7 @@
     "chai-as-promised": "8.0.1",
     "husky": "9.1.7",
     "nock": "14.0.1",
-    "sinon": "19.0.2",
+    "sinon": "20.0.0",
     "sinon-chai": "4.0.0"
   },
   "dependencies": {

package/src/formcalc.js

@@ -10,10 +10,9 @@
  * governing permissions and limitations under the License.
  */
 
+export const FORMS_AUDIT_INTERVAL = 15;
 const DAILY_PAGEVIEW_THRESHOLD = 200;
 const CR_THRESHOLD_RATIO = 0.3;
-// audit interval
-const INTERVAL = 15;
 const MOBILE = 'mobile';
 const DESKTOP = 'desktop';
 
@@ -63,7 +62,7 @@ function aggregateFormVitalsByDevice(formVitalsCollection) {
 }
 
 function hasHighPageViews(pageViews) {
-  return pageViews > DAILY_PAGEVIEW_THRESHOLD * INTERVAL;
+  return pageViews > DAILY_PAGEVIEW_THRESHOLD * FORMS_AUDIT_INTERVAL;
 }
 
 function hasLowerConversionRate(formSubmit, formViews) {

package/src/index.d.ts

@@ -184,10 +184,9 @@ declare function getQuery(placeholders: object, filename: string, log: object):
 /**
  * Retrieves the high-form-view-low-form-conversion metrics from the provided array of form vitals.
  * @param {Object[]} formVitals - An array of form vitals.
- * @param {number} interval - The interval in days.
  * @returns {Object[]} - An array of high-form-view-low-form-conversion metrics.
  */
-declare function getHighFormViewsLowConversionMetrics(formVitals: object[], interval: number):
+declare function getHighFormViewsLowConversionMetrics(formVitals: object[]):
   object[];
 
 /**
@@ -195,7 +194,7 @@ declare function getHighFormViewsLowConversionMetrics(formVitals: object[], inte
  * @param {Object[]} formVitals - An array of form vitals.
  * @returns {Object[]} - An array of high-page-view-low-form-view metrics.
  */
-declare function getHighPageViewsLowFormViewsMetrics(formVitals: object[], interval: number):
+declare function getHighPageViewsLowFormViewsMetrics(formVitals: object[]):
   object[];
 
 /**
@@ -203,7 +202,7 @@ declare function getHighPageViewsLowFormViewsMetrics(formVitals: object[], inter
  * @param {Object[]} formVitals - An array of form vitals.
  * @returns {Object[]} - An array of high-page-view-low-form-ctr metrics.
  */
-declare function getHighPageViewsLowFormCtrMetrics(formVitals: object[], interval: number):
+declare function getHighPageViewsLowFormCtrMetrics(formVitals: object[]):
   object[];
 
 /**

package/src/index.js

@@ -62,4 +62,9 @@ export { s3Wrapper } from './s3.js';
 
 export { fetch } from './adobe-fetch.js';
 export { tracingFetch, SPACECAT_USER_AGENT } from './tracing-fetch.js';
-export { getHighFormViewsLowConversionMetrics, getHighPageViewsLowFormViewsMetrics, getHighPageViewsLowFormCtrMetrics } from './formcalc.js';
+export {
+  getHighFormViewsLowConversionMetrics,
+  getHighPageViewsLowFormViewsMetrics,
+  getHighPageViewsLowFormCtrMetrics,
+  FORMS_AUDIT_INTERVAL,
+} from './formcalc.js';