@adobe/spacecat-shared-utils 1.34.0 → 1.35.1

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [@adobe/spacecat-shared-utils-v1.35.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.35.0...@adobe/spacecat-shared-utils-v1.35.1) (2025-04-01)
+
+
+### Bug Fixes
+
+* adding forms constants at common place ([#672](https://github.com/adobe/spacecat-shared/issues/672)) ([4b8254d](https://github.com/adobe/spacecat-shared/commit/4b8254d32112e4921ae63396733101fa1f3bbed7))
+
+# [@adobe/spacecat-shared-utils-v1.35.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.34.0...@adobe/spacecat-shared-utils-v1.35.0) (2025-03-06)
+
+
+### Features
+
+* tracing fetch timeout ([#657](https://github.com/adobe/spacecat-shared/issues/657)) ([67335e3](https://github.com/adobe/spacecat-shared/commit/67335e32b7cceeb500ca58dc05518876589a108a))
+
 # [@adobe/spacecat-shared-utils-v1.34.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.33.3...@adobe/spacecat-shared-utils-v1.34.0) (2025-03-05)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-utils",
-  "version": "1.34.0",
+  "version": "1.35.1",
   "description": "Shared modules of the Spacecat Services - utils",
   "type": "module",
   "engines": {

package/src/formcalc.js

@@ -11,7 +11,9 @@
  */
 
 const DAILY_PAGEVIEW_THRESHOLD = 200;
-const CR_THRESHOLD_RATIO = 0.2;
+const CR_THRESHOLD_RATIO = 0.3;
+// audit interval
+const INTERVAL = 15;
 const MOBILE = 'mobile';
 const DESKTOP = 'desktop';
 
@@ -60,8 +62,8 @@ function aggregateFormVitalsByDevice(formVitalsCollection) {
   return resultMap;
 }
 
-function hasHighPageViews(interval, pageViews) {
-  return pageViews > DAILY_PAGEVIEW_THRESHOLD * interval;
+function hasHighPageViews(pageViews) {
+  return pageViews > DAILY_PAGEVIEW_THRESHOLD * INTERVAL;
 }
 
 function hasLowerConversionRate(formSubmit, formViews) {
@@ -84,7 +86,7 @@ function hasHighPageViewLowFormCtr(ctaPageViews, ctaClicks, ctaPageTotalClicks,
  * @param {*} formVitalsCollection - form vitals collection
  * @returns {Array} - urls with high form views and low conversion rate
  */
-export function getHighFormViewsLowConversionMetrics(formVitalsCollection, interval) {
+export function getHighFormViewsLowConversionMetrics(formVitalsCollection) {
   const resultMap = aggregateFormVitalsByDevice(formVitalsCollection);
   const urls = [];
   resultMap.forEach((metrics, url) => {
@@ -94,7 +96,7 @@ export function getHighFormViewsLowConversionMetrics(formVitalsCollection, inter
     const formEngagement = metrics.formengagement.total;
     const formSubmit = metrics.formsubmit.total || formEngagement;
 
-    if (hasHighPageViews(interval, pageViews) && hasLowerConversionRate(formSubmit, formViews)) {
+    if (hasHighPageViews(pageViews) && hasLowerConversionRate(formSubmit, formViews)) {
       urls.push({
         url,
         pageViews,
@@ -113,7 +115,7 @@ export function getHighFormViewsLowConversionMetrics(formVitalsCollection, inter
  * @param resultMap
  * @returns {*[]}
  */
-export function getHighPageViewsLowFormViewsMetrics(formVitalsCollection, interval) {
+export function getHighPageViewsLowFormViewsMetrics(formVitalsCollection) {
   const urls = [];
   const resultMap = aggregateFormVitalsByDevice(formVitalsCollection);
   resultMap.forEach((metrics, url) => {
@@ -121,7 +123,7 @@ export function getHighPageViewsLowFormViewsMetrics(formVitalsCollection, interv
     const { total: formViews } = metrics.formview;
     const { total: formEngagement } = metrics.formengagement;
 
-    if (hasHighPageViews(interval, pageViews) && hasLowFormViews(pageViews, formViews)) {
+    if (hasHighPageViews(pageViews) && hasLowFormViews(pageViews, formViews)) {
       urls.push({
         url,
         pageViews,
@@ -139,7 +141,7 @@ export function getHighPageViewsLowFormViewsMetrics(formVitalsCollection, interv
  * @param formVitalsByDevice
  * @returns {*[]}
  */
-export function getHighPageViewsLowFormCtrMetrics(formVitalsCollection, interval) {
+export function getHighPageViewsLowFormCtrMetrics(formVitalsCollection) {
   const urls = [];
   const formVitalsByDevice = aggregateFormVitalsByDevice(formVitalsCollection);
   formVitalsCollection.forEach((entry) => {
@@ -176,7 +178,7 @@ export function getHighPageViewsLowFormCtrMetrics(formVitalsCollection, interval
     const f = Object.values(pageview).reduce((sum, val) => sum + val, 0);
 
     // Evaluate conditions and add URL to the result if all are met
-    if (hasHighPageViews(interval, x) && hasHighPageViewLowFormCtr(x, y.clicks, z, f)) {
+    if (hasHighPageViews(x) && hasHighPageViewLowFormCtr(x, y.clicks, z, f)) {
       const deviceData = formVitalsByDevice.get(entry.url);
       if (deviceData != null) {
         urls.push({

package/src/tracing-fetch.js

@@ -9,7 +9,7 @@
  * OF ANY KIND, either express or implied. See the License for the specific language
  * governing permissions and limitations under the License.
  */
-import { Request } from '@adobe/fetch';
+import { Request, timeoutSignal, AbortError } from '@adobe/fetch';
 import AWSXRay from 'aws-xray-sdk';
 
 import { fetch as adobeFetch } from './adobe-fetch.js';
@@ -107,17 +107,60 @@ const handleSubSegmentError = (subSegment, request, error) => {
   subSegment.close(error);
 };
 
+/**
+ * Creates a timeout error with a consistent format
+ * @param {number} timeout - The timeout value in milliseconds
+ * @returns {Error} A formatted timeout error
+ */
+const createTimeoutError = (timeout) => {
+  const timeoutError = new Error(`Request timeout after ${timeout}ms`);
+  timeoutError.code = 'ETIMEOUT';
+  return timeoutError;
+};
+
+/**
+ * Performs a fetch request with timeout handling
+ * @param {string|Request} resource - The resource to fetch
+ * @param {Object} options - Options for the fetch call
+ * @param {Object} signal - The timeout signal
+ * @returns {Promise<Response>} The fetch response
+ */
+const fetchWithTimeout = async (resource, options, signal) => {
+  try {
+    const fetchOptions = { ...options, signal };
+    return await adobeFetch(resource, fetchOptions);
+  } catch (error) {
+    if (error instanceof AbortError) {
+      // Extract timeout from signal (implementation detail, but necessary)
+      // eslint-disable-next-line no-underscore-dangle
+      const timeout = signal._ms || 10000;
+      throw createTimeoutError(timeout);
+    }
+    throw error;
+  } finally {
+    signal.clear(); // Clean up the signal
+  }
+};
+
 /**
  * Performs a fetch request and adds AWS X-Ray tracing, including request/response tracking.
  * @param {string} url - The URL for the request.
- * @param {Object} options - Options to be passed to the fetch call.
+ * @param {Object} [options] - Optional options to be passed to the fetch call.
+ * @param {number} [options.timeout=10000] - Timeout in milliseconds (defaults to 10 seconds).
  * @returns {Promise<Response>} The response from the fetch request.
  */
 export async function tracingFetch(url, options) {
   const parentSegment = AWSXRay.getSegment();
 
-  options = isObject(options) ? options : {};
-  options.headers = isObject(options.headers) ? options.headers : new Headers();
+  options = isObject(options) ? { ...options } : {};
+  options.headers = isObject(options.headers) ? options.headers : { };
+
+  // Set default timeout of 10 seconds if not specified
+  const timeout = options.timeout || 10000;
+  delete options.timeout; // Remove from options as we'll handle it separately
+
+  // Create a timeout signal
+  const signal = timeoutSignal(timeout);
 
   // find user-agent header in headers case insensitively
   let hasUserAgent = false;
@@ -131,10 +174,12 @@ export async function tracingFetch(url, options) {
     options.headers['User-Agent'] = SPACECAT_USER_AGENT;
   }
 
+  // If no parent segment, perform fetch without tracing
   if (!parentSegment) {
-    return adobeFetch(url, options);
+    return fetchWithTimeout(url, options, signal);
   }
 
+  // With parent segment, create subsegment and add tracing
   const request = new Request(url, options);
   const { hostname } = new URL(request.url);
   const subSegment = createSubsegment(parentSegment, hostname);
@@ -145,21 +190,22 @@ export async function tracingFetch(url, options) {
     setTraceHeaders(request, parentSegment, subSegment);
   }
 
-  const capturedAdobeFetch = async () => {
-    let response = null;
-    try {
-      response = await adobeFetch(request);
-    } catch (e) {
-      handleSubSegmentError(subSegment, request, e);
-      throw e;
-    }
+  subSegment.addAnnotation('timeout_ms', timeout);
 
-    setSubSegmentFlagsByStatusCode(subSegment, response.status);
+  try {
+    // Create a new request with the signal
+    const requestWithSignal = new Request(request, { signal });
+
+    // Use the same fetchWithTimeout function but catch errors to handle subsegment
+    const response = await fetchWithTimeout(requestWithSignal, { }, signal);
 
+    setSubSegmentFlagsByStatusCode(subSegment, response.status);
     addFetchRequestDataToSegment(subSegment, request, response);
     subSegment.close();
-    return response;
-  };
 
-  return capturedAdobeFetch();
+    return response;
+  } catch (error) {
+    handleSubSegmentError(subSegment, request, error);
+    throw error;
+  }
 }