@adobe/spacecat-shared-utils 1.26.2 → 1.26.3

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [@adobe/spacecat-shared-utils-v1.26.3](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.26.2...@adobe/spacecat-shared-utils-v1.26.3) (2025-01-15)
+
+
+### Bug Fixes
+
+* improve sqs event adapter error handling ([#541](https://github.com/adobe/spacecat-shared/issues/541)) ([2e9fca8](https://github.com/adobe/spacecat-shared/commit/2e9fca89e327b9b680b20a6105088f0e844eb54a))
+
 # [@adobe/spacecat-shared-utils-v1.26.2](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.26.1...@adobe/spacecat-shared-utils-v1.26.2) (2025-01-12)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-utils",
-  "version": "1.26.2",
+  "version": "1.26.3",
   "description": "Shared modules of the Spacecat Services - utils",
   "type": "module",
   "engines": {

package/src/sqs.js

@@ -12,7 +12,15 @@
 
 import { SendMessageCommand, SQSClient } from '@aws-sdk/client-sqs';
 import AWSXray from 'aws-xray-sdk';
-import { hasText } from './functions.js';
+
+import { hasText, isNonEmptyArray } from './functions.js';
+
+function badRequest(message) {
+  return new Response('', {
+    status: 400,
+    headers: { 'x-error': message },
+  });
+}
 
 /**
  * @class SQS utility to send messages to SQS
@@ -94,24 +102,24 @@ export function sqsEventAdapter(fn) {
     const { log } = context;
     let message;
 
+    // currently not processing batch messages
+    const records = context.invocation?.event?.Records;
+
+    if (!isNonEmptyArray(records)) {
+      log.warn('Function was not invoked properly, event does not contain any records');
+      return badRequest('Event does not contain any records');
+    }
+
+    const record = records[0];
+
+    log.info(`Received ${records.length} records. ID of the first message in the batch: ${record.messageId}`);
+
     try {
-      // currently not publishing batch messages
-      const records = context.invocation?.event?.Records;
-      if (!Array.isArray(records) || records.length === 0) {
-        throw new Error('No records found');
-      }
-
-      log.info(`Received ${records.length} records. ID of the first message in the batch: ${records[0]?.messageId}`);
-      message = JSON.parse(records[0]?.body);
-      log.info(`Received message with id: ${records[0]?.messageId}`);
+      message = JSON.parse(record.body);
+      log.info(`Received message with id: ${record.messageId}`);
     } catch (e) {
       log.warn('Function was not invoked properly, message body is not a valid JSON', e);
-      return new Response('', {
-        status: 400,
-        headers: {
-          'x-error': 'Event does not contain a valid message body',
-        },
-      });
+      return badRequest('Event does not contain a valid message body');
     }
     return fn(message, context);
   };