@adobe/spacecat-shared-tokowaka-client 1.7.1 → 1.7.3

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [@adobe/spacecat-shared-tokowaka-client-v1.7.3](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tokowaka-client-v1.7.2...@adobe/spacecat-shared-tokowaka-client-v1.7.3) (2026-02-04)
+
+
+### Bug Fixes
+
+* edge-deploy: update patch lastUpdated to now ([#1315](https://github.com/adobe/spacecat-shared/issues/1315)) ([754be98](https://github.com/adobe/spacecat-shared/commit/754be986ac8ee8aa76a53f142338b214eca30b8c))
+
+# [@adobe/spacecat-shared-tokowaka-client-v1.7.2](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tokowaka-client-v1.7.1...@adobe/spacecat-shared-tokowaka-client-v1.7.2) (2026-02-04)
+
+
+### Bug Fixes
+
+* preview for all using apply Stale ([#1310](https://github.com/adobe/spacecat-shared/issues/1310)) ([ccadd8f](https://github.com/adobe/spacecat-shared/commit/ccadd8f230259c781c33b977fd6214375a563ab9))
+
 # [@adobe/spacecat-shared-tokowaka-client-v1.7.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tokowaka-client-v1.7.0...@adobe/spacecat-shared-tokowaka-client-v1.7.1) (2026-02-03)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-tokowaka-client",
-  "version": "1.7.1",
+  "version": "1.7.3",
   "description": "Tokowaka Client for SpaceCat - Edge optimization config management",
   "type": "module",
   "engines": {

package/src/index.js

@@ -949,6 +949,12 @@ class TokowakaClient {
       };
     }
 
+    // preview for all: never drop stale suggestions that are being previewed
+    newConfig.patches = newConfig.patches.map((patch) => ({
+      ...patch,
+      applyStale: true,
+    }));
+
     // Merge with existing deployed config to include already-deployed patches for this URL
     let config = newConfig;
     if (existingConfig && existingConfig.patches?.length > 0) {

package/src/mappers/base-mapper.js

@@ -88,20 +88,13 @@ export default class BaseOpportunityMapper {
    * @returns {Object} - Base patch object
    */
   createBasePatch(suggestion, opportunityId) {
-    const updatedAt = suggestion.getUpdatedAt();
-
-    // Parse timestamp, fallback to Date.now() if invalid
-    let lastUpdated = Date.now();
-    if (updatedAt) {
-      const parsed = new Date(updatedAt).getTime();
-      lastUpdated = Number.isNaN(parsed) ? Date.now() : parsed;
-    }
-
     return {
       opportunityId,
       suggestionId: suggestion.getId(),
       prerenderRequired: this.requiresPrerender(),
-      lastUpdated,
+      // the lastUpdated is kept as 'now' assuming the user has reviewed
+      // the suggestion being deployed, we will revisit this if need arises.
+      lastUpdated: Date.now(),
     };
   }
 

package/src/mappers/faq-mapper.js

@@ -108,19 +108,7 @@ export default class FaqMapper extends BaseOpportunityMapper {
     const firstData = firstSuggestion.getData();
     const { headingText = 'FAQs', transformRules } = firstData;
 
-    // Calculate the most recent lastUpdated from all eligible suggestions
-    // The heading patch should have the same timestamp as the newest FAQ
-    const maxLastUpdated = Math.max(...eligibleSuggestions.map((suggestion) => {
-      const updatedAt = suggestion.getUpdatedAt();
-
-      if (updatedAt) {
-        const parsed = new Date(updatedAt).getTime();
-        return Number.isNaN(parsed) ? Date.now() : parsed;
-      }
-      return Date.now();
-    }));
-
-    // Always create/update heading patch with latest timestamp
+    // Always create/update heading patch
     // mergePatches will replace existing heading if it already exists
     this.log.debug(`Creating/updating heading patch for ${urlPath}`);
 
@@ -135,7 +123,7 @@ export default class FaqMapper extends BaseOpportunityMapper {
       opportunityId,
       // No suggestionId for FAQ heading patch
       prerenderRequired: this.requiresPrerender(),
-      lastUpdated: maxLastUpdated,
+      lastUpdated: Date.now(),
       op: transformRules.action,
       selector: transformRules.selector,
       value: headingHast,

package/test/index.test.js

@@ -2871,6 +2871,51 @@ describe('TokowakaClient', () => {
       expect(s3Client.send).to.have.been.calledOnce;
     });
 
+    it('should set applyStale to true for all preview patches', async () => {
+      // Create a scenario with existing deployed patches
+      client.fetchConfig.resolves({
+        url: 'https://example.com/page1',
+        version: '1.0',
+        forceFail: false,
+        prerender: true,
+        patches: [
+          {
+            op: 'replace',
+            selector: 'h3',
+            value: 'Existing Heading',
+            opportunityId: 'opp-999',
+            suggestionId: 'sugg-999',
+            prerenderRequired: true,
+            lastUpdated: 1234567890,
+          },
+        ],
+      });
+
+      const result = await client.previewSuggestions(
+        mockSite,
+        mockOpportunity,
+        mockSuggestions,
+        { warmupDelayMs: 0 },
+      );
+
+      expect(result.config).to.exist;
+      expect(result.config.patches).to.have.length(3); // 2 new + 1 existing
+
+      // Verify that all new preview patches have applyStale: true
+      const newPatches = result.config.patches.filter(
+        (p) => p.suggestionId === 'sugg-1' || p.suggestionId === 'sugg-2',
+      );
+      expect(newPatches).to.have.length(2);
+      newPatches.forEach((patch) => {
+        expect(patch.applyStale).to.equal(true);
+      });
+
+      // Existing patch should not have applyStale field
+      const existingPatch = result.config.patches.find((p) => p.suggestionId === 'sugg-999');
+      expect(existingPatch).to.exist;
+      expect(existingPatch.applyStale).to.be.undefined;
+    });
+
     it('should preview prerender-only suggestions with no patches', async () => {
       // Update fetchConfig to return existing config with deployed patches
       client.fetchConfig.resolves({

package/test/mappers/base-mapper.test.js

@@ -53,7 +53,7 @@ describe('BaseOpportunityMapper', () => {
   });
 
   describe('createBasePatch', () => {
-    it('should use getUpdatedAt method when available', () => {
+    it('should use Date.now() for lastUpdated', () => {
       // Create a concrete subclass for testing
       class TestMapper extends BaseOpportunityMapper {
         getOpportunityType() { return 'test'; }
@@ -71,11 +71,14 @@ describe('BaseOpportunityMapper', () => {
         getUpdatedAt: () => '2025-01-15T10:00:00.000Z',
       };
 
+      const beforeTime = Date.now();
       const patch = testMapper.createBasePatch(suggestion, 'opp-456');
+      const afterTime = Date.now();
 
       expect(patch.suggestionId).to.equal('test-123');
       expect(patch.opportunityId).to.equal('opp-456');
-      expect(patch.lastUpdated).to.equal(new Date('2025-01-15T10:00:00.000Z').getTime());
+      expect(patch.lastUpdated).to.be.at.least(beforeTime);
+      expect(patch.lastUpdated).to.be.at.most(afterTime);
       expect(patch.prerenderRequired).to.be.true;
     });
 

package/test/mappers/faq-mapper.test.js

@@ -760,7 +760,7 @@ Overall, Bulk positions itself as a better choice for sports nutrition through i
       expect(patches[1].suggestionId).to.equal('sugg-faq-new'); // FAQ
     });
 
-    it('should use correct updatedAt timestamp for each patch', () => {
+    it('should use Date.now() for all patch timestamps', () => {
       const suggestions = [
         {
           getId: () => 'sugg-faq-1',
@@ -798,17 +798,18 @@ Overall, Bulk positions itself as a better choice for sports nutrition through i
         },
       ];
 
+      const beforeTime = Date.now();
       const patches = mapper.suggestionsToPatches('/page', suggestions, 'opp-faq-123', null);
-
-      const expectedTimestamp1 = new Date('2025-01-15T10:00:00.000Z').getTime();
-      const expectedTimestamp2 = new Date('2025-01-15T12:00:00.000Z').getTime();
+      const afterTime = Date.now();
 
       expect(patches.length).to.equal(3); // heading + 2 FAQs
-      // Heading uses the most recent timestamp from suggestions (12:00:00)
-      expect(patches[0].lastUpdated).to.equal(expectedTimestamp2);
-      // FAQ patches use their respective suggestion timestamps
-      expect(patches[1].lastUpdated).to.equal(expectedTimestamp1);
-      expect(patches[2].lastUpdated).to.equal(expectedTimestamp2);
+      // All patches should use Date.now()
+      expect(patches[0].lastUpdated).to.be.at.least(beforeTime);
+      expect(patches[0].lastUpdated).to.be.at.most(afterTime);
+      expect(patches[1].lastUpdated).to.be.at.least(beforeTime);
+      expect(patches[1].lastUpdated).to.be.at.most(afterTime);
+      expect(patches[2].lastUpdated).to.be.at.least(beforeTime);
+      expect(patches[2].lastUpdated).to.be.at.most(afterTime);
     });
 
     it('should use Date.now() when getUpdatedAt returns null', () => {
@@ -1191,20 +1192,23 @@ Overall, Bulk positions itself as a better choice for sports nutrition through i
         },
       };
 
+      const beforeTime = Date.now();
       const patches = mapper.suggestionsToPatches(
         '/page',
         [newSuggestion],
         'opp-faq-123',
         existingConfig,
       );
+      const afterTime = Date.now();
 
       expect(patches).to.be.an('array');
       expect(patches.length).to.equal(2); // Heading + FAQ (always create heading)
 
-      // First patch: heading with updated timestamp
+      // First patch: heading with Date.now() timestamp
       expect(patches[0].suggestionId).to.be.undefined;
       expect(patches[0].value.tagName).to.equal('h2');
-      expect(patches[0].lastUpdated).to.equal(new Date('2025-01-15T10:00:00.000Z').getTime());
+      expect(patches[0].lastUpdated).to.be.at.least(beforeTime);
+      expect(patches[0].lastUpdated).to.be.at.most(afterTime);
 
       // Second patch: FAQ
       expect(patches[1].suggestionId).to.equal('sugg-new-1');

package/test/mappers/readability-mapper.test.js

@@ -289,7 +289,7 @@ describe('ReadabilityMapper', () => {
       expect(patch.lastUpdated).to.be.a('number');
     });
 
-    it('should create patch with updatedAt timestamp', () => {
+    it('should create patch with Date.now() timestamp', () => {
       const suggestion = {
         getId: () => 'sugg-456',
         getUpdatedAt: () => '2025-09-20T06:21:12.584Z',
@@ -304,11 +304,15 @@ describe('ReadabilityMapper', () => {
         }),
       };
 
+      const beforeTime = Date.now();
       const patches = mapper.suggestionsToPatches('/path', [suggestion], 'opp-456');
+      const afterTime = Date.now();
+
       expect(patches.length).to.equal(1);
       const patch = patches[0];
 
-      expect(patch.lastUpdated).to.equal(new Date('2025-09-20T06:21:12.584Z').getTime());
+      expect(patch.lastUpdated).to.be.at.least(beforeTime);
+      expect(patch.lastUpdated).to.be.at.most(afterTime);
     });
 
     it('should use default target when not specified', () => {