@adobe/spacecat-shared-tokowaka-client 1.4.6 → 1.4.7

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [@adobe/spacecat-shared-tokowaka-client-v1.4.7](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tokowaka-client-v1.4.6...@adobe/spacecat-shared-tokowaka-client-v1.4.7) (2026-01-14)
+
+
+### Bug Fixes
+
+* update tokowaka s3 config with patches ([#1263](https://github.com/adobe/spacecat-shared/issues/1263)) ([59605e9](https://github.com/adobe/spacecat-shared/commit/59605e9b75b7289029bd14e1832e594ea565296d))
+
 # [@adobe/spacecat-shared-tokowaka-client-v1.4.6](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tokowaka-client-v1.4.5...@adobe/spacecat-shared-tokowaka-client-v1.4.6) (2026-01-13)
 
 

package/README.md

@@ -64,10 +64,12 @@ Creates a client instance from a context object.
 
 #### `deploySuggestions(site, opportunity, suggestions)`
 
-Generates configuration and uploads to S3 **per URL**. **Automatically fetches existing configuration for each URL and merges** new suggestions with it. Invalidates CDN cache after upload.
+Generates configuration and uploads to S3 **per URL**. **Automatically fetches existing configuration for each URL and merges** new suggestions with it. Invalidates CDN cache after upload. **Updates the metaconfig's `patches` field** to track deployed endpoints.
 
 **Architecture Change:** Creates one S3 file per URL instead of a single file with all URLs. This prevents files from growing too large over time.
 
+**Metaconfig Tracking:** After successful deployment, the method updates the domain-level metaconfig's `patches` object with the normalized paths of all deployed endpoints (e.g., `{ "/products/item": true }`). This provides a centralized registry of all deployed endpoints for the domain.
+
 **Returns:** `Promise<DeploymentResult>` with:
 - `s3Paths` - Array of S3 keys where configs were uploaded (one per URL)
 - `cdnInvalidations` - Array of CDN invalidation results (one per URL per provider)
@@ -212,7 +214,17 @@ Domain-level metaconfig (created once per domain, shared by all URLs):
 {
   "siteId": "abc-123",
   "apiKeys": ["tokowaka-api-key-1"],
-  "prerender": true
+  "tokowakaEnabled": true,
+  "enhancements": true,
+  "prerender": {
+    "allowList": [],
+    "denyList": ["/*"]
+  },
+  "patches": {
+    "/products/item": true,
+    "/about": true,
+    "/contact": true
+  }
 }
 ```
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-tokowaka-client",
-  "version": "1.4.6",
+  "version": "1.4.7",
   "description": "Tokowaka Client for SpaceCat - Edge optimization config management",
   "type": "module",
   "engines": {

package/src/index.js

@@ -17,7 +17,12 @@ import { v4 as uuidv4 } from 'uuid';
 import MapperRegistry from './mappers/mapper-registry.js';
 import CdnClientRegistry from './cdn/cdn-client-registry.js';
 import { mergePatches } from './utils/patch-utils.js';
-import { getTokowakaConfigS3Path, getTokowakaMetaconfigS3Path, getHostName } from './utils/s3-utils.js';
+import {
+  getTokowakaConfigS3Path,
+  getTokowakaMetaconfigS3Path,
+  getHostName,
+  normalizePath,
+} from './utils/s3-utils.js';
 import { groupSuggestionsByUrlPath, filterEligibleSuggestions } from './utils/suggestion-utils.js';
 import { getEffectiveBaseURL } from './utils/site-utils.js';
 import { fetchHtmlWithWarmup, calculateForwardedHost } from './utils/custom-html-utils.js';
@@ -94,6 +99,44 @@ class TokowakaClient {
     return error;
   }
 
+  /**
+   * Updates the metaconfig with deployed endpoint paths
+   * @param {Object} metaconfig - Existing metaconfig object
+   * @param {Array<string>} deployedUrls - Array of successfully deployed URLs
+   * @param {string} baseUrl - Base URL for uploading metaconfig
+   * @returns {Promise<void>}
+   * @private
+   */
+  async #updateMetaconfigWithDeployedPaths(metaconfig, deployedUrls, baseUrl) {
+    if (!Array.isArray(deployedUrls) || deployedUrls.length === 0) {
+      return;
+    }
+
+    try {
+      // Initialize patches field if it doesn't exist
+      const updatedMetaconfig = {
+        ...metaconfig,
+        patches: { ...(metaconfig.patches || {}) },
+      };
+
+      // Extract normalized paths from deployed URLs and add to patches object
+      deployedUrls.forEach((url) => {
+        const urlObj = new URL(url);
+        const normalizedPath = normalizePath(urlObj.pathname);
+        updatedMetaconfig.patches[normalizedPath] = true;
+      });
+
+      await this.uploadMetaconfig(baseUrl, updatedMetaconfig);
+      this.log.info(`Updated metaconfig with ${deployedUrls.length} deployed endpoint(s)`);
+    } catch (error) {
+      this.log.error(`Failed to update metaconfig with deployed paths: ${error.message}`, error);
+      throw this.#createError(
+        `Failed to update metaconfig with deployed paths: ${error.message}`,
+        HTTP_INTERNAL_SERVER_ERROR,
+      );
+    }
+  }
+
   /**
    * Gets the list of CDN providers from environment configuration
    * Supports both single provider (string) and multiple providers (comma-separated string or array)
@@ -597,6 +640,9 @@ class TokowakaClient {
 
     this.log.info(`Uploaded Tokowaka configs for ${s3Paths.length} URLs`);
 
+    // Update metaconfig with deployed paths
+    await this.#updateMetaconfigWithDeployedPaths(metaconfig, deployedUrls, baseURL);
+
     // Invalidate CDN cache for all deployed URLs at once
     const cdnInvalidations = await this.invalidateCdnCache({ urls: deployedUrls });
 

package/test/index.test.js

@@ -1030,6 +1030,161 @@ describe('TokowakaClient', () => {
       expect(result.failedSuggestions[0].suggestion.getId()).to.equal('sugg-2');
     });
 
+    it('should update metaconfig patches field with deployed endpoints', async () => {
+      mockSuggestions = [
+        {
+          getId: () => 'sugg-1',
+          getUpdatedAt: () => '2025-01-15T10:00:00.000Z',
+          getData: () => ({
+            url: 'https://example.com/page1',
+            recommendedAction: 'Page 1 Heading',
+            checkType: 'heading-empty',
+            transformRules: {
+              action: 'replace',
+              selector: 'h1',
+            },
+          }),
+        },
+        {
+          getId: () => 'sugg-2',
+          getUpdatedAt: () => '2025-01-15T10:00:00.000Z',
+          getData: () => ({
+            url: 'https://example.com/page2',
+            recommendedAction: 'Page 2 Heading',
+            checkType: 'heading-empty',
+            transformRules: {
+              action: 'replace',
+              selector: 'h1',
+            },
+          }),
+        },
+      ];
+
+      const result = await client.deploySuggestions(
+        mockSite,
+        mockOpportunity,
+        mockSuggestions,
+      );
+
+      expect(result.succeededSuggestions).to.have.length(2);
+      // Verify uploadMetaconfig was called to update the metaconfig
+      expect(client.uploadMetaconfig).to.have.been.called;
+      // Check that the last call included the patches field
+      const { lastCall } = client.uploadMetaconfig;
+      expect(lastCall.args[1]).to.have.property('patches');
+      expect(lastCall.args[1].patches).to.deep.equal({
+        '/page1': true,
+        '/page2': true,
+      });
+    });
+
+    it('should add to existing patches in metaconfig when deploying new endpoints', async () => {
+      // Set up metaconfig with existing patches
+      // Reset the stub to provide consistent behavior
+      client.fetchMetaconfig.reset();
+      client.fetchMetaconfig.resolves({
+        siteId: 'site-123',
+        prerender: true,
+        patches: {
+          '/existing-page': true,
+        },
+      });
+
+      mockSuggestions = [
+        {
+          getId: () => 'sugg-1',
+          getUpdatedAt: () => '2025-01-15T10:00:00.000Z',
+          getData: () => ({
+            url: 'https://example.com/new-page',
+            recommendedAction: 'New Heading',
+            checkType: 'heading-empty',
+            transformRules: {
+              action: 'replace',
+              selector: 'h1',
+            },
+          }),
+        },
+      ];
+
+      await client.deploySuggestions(
+        mockSite,
+        mockOpportunity,
+        mockSuggestions,
+      );
+
+      // Verify the updated metaconfig includes both existing and new patches
+      const { lastCall } = client.uploadMetaconfig;
+      expect(lastCall.args[1].patches).to.deep.equal({
+        '/existing-page': true,
+        '/new-page': true,
+      });
+    });
+
+    it('should throw error when metaconfig update fails', async () => {
+      // Make uploadMetaconfig fail during the update
+      client.uploadMetaconfig.rejects(new Error('S3 upload error'));
+
+      try {
+        await client.deploySuggestions(
+          mockSite,
+          mockOpportunity,
+          mockSuggestions,
+        );
+        expect.fail('Should have thrown error');
+      } catch (error) {
+        expect(error.message).to.include('Failed to update metaconfig with deployed paths');
+        expect(error.status).to.equal(500);
+      }
+    });
+
+    it('should return early when no eligible suggestions to deploy', async () => {
+      // All suggestions are ineligible
+      mockSuggestions = [
+        {
+          getId: () => 'sugg-1',
+          getData: () => ({
+            url: 'https://example.com/page1',
+            recommendedAction: 'New Heading',
+            checkType: 'heading-missing', // Not eligible
+          }),
+        },
+      ];
+
+      const result = await client.deploySuggestions(
+        mockSite,
+        mockOpportunity,
+        mockSuggestions,
+      );
+
+      // No suggestions deployed - returns early before metaconfig check
+      expect(result.succeededSuggestions).to.have.length(0);
+      expect(result.failedSuggestions).to.have.length(1);
+      // fetchMetaconfig should not be called at all (returns before that point)
+      expect(client.fetchMetaconfig).to.not.have.been.called;
+      // uploadMetaconfig should not be called at all
+      expect(client.uploadMetaconfig).to.not.have.been.called;
+    });
+
+    it('should not update metaconfig when all URLs fail to generate configs', async () => {
+      // Stub generateConfig to return null (no config generated)
+      sinon.stub(client, 'generateConfig').returns(null);
+
+      const result = await client.deploySuggestions(
+        mockSite,
+        mockOpportunity,
+        mockSuggestions,
+      );
+
+      // Suggestions are marked as succeeded (eligible) but no configs uploaded
+      expect(result.succeededSuggestions).to.have.length(2);
+      expect(result.s3Paths).to.have.length(0); // No configs uploaded
+      // fetchMetaconfig called once for initial check, but not for update
+      // since no URLs were actually deployed (deployedUrls is empty)
+      expect(client.fetchMetaconfig).to.have.been.calledOnce;
+      // uploadMetaconfig should not be called at all
+      expect(client.uploadMetaconfig).to.not.have.been.called;
+    });
+
     it('should skip URL when generateConfig returns no patches', async () => {
       // Stub mapper to return empty patches for the first call, normal for subsequent calls
       const mapper = client.mapperRegistry.getMapper('headings');