@adobe/spacecat-shared-tokowaka-client 1.17.3 → 1.18.0

package/test/utils/suggestion-utils.test.js

@@ -11,7 +11,8 @@
  */
 
 import { expect } from 'chai';
-import { groupSuggestionsByUrlPath, filterEligibleSuggestions } from '../../src/utils/suggestion-utils.js';
+import sinon from 'sinon';
+import { groupSuggestionsByUrlPath, filterEligibleSuggestions, saveSuggestions } from '../../src/utils/suggestion-utils.js';
 
 describe('Suggestion Utils', () => {
   describe('groupSuggestionsByUrlPath', () => {
@@ -182,4 +183,45 @@ describe('Suggestion Utils', () => {
       expect(result.ineligible[0].reason).to.equal('Suggestion cannot be deployed');
     });
   });
+
+  describe('saveSuggestions', () => {
+    it('should no-op for empty array', async () => {
+      const dataAccess = { Suggestion: { saveMany: sinon.stub() } };
+      await saveSuggestions(dataAccess, []);
+      expect(dataAccess.Suggestion.saveMany.called).to.be.false;
+    });
+
+    it('should use saveMany for <= 1700 suggestions', async () => {
+      const dataAccess = { Suggestion: { saveMany: sinon.stub().resolves() } };
+      const items = [{ save: sinon.stub().resolves() }];
+      await saveSuggestions(dataAccess, items);
+      expect(dataAccess.Suggestion.saveMany.calledOnce).to.be.true;
+      expect(items[0].save.called).to.be.false;
+    });
+
+    it('should use Promise.allSettled for > 1700 suggestions', async () => {
+      const dataAccess = { Suggestion: { saveMany: sinon.stub() } };
+      const items = Array.from({ length: 1701 }, () => ({ save: sinon.stub().resolves() }));
+      await saveSuggestions(dataAccess, items);
+      expect(dataAccess.Suggestion.saveMany.called).to.be.false;
+      expect(items[0].save.calledOnce).to.be.true;
+      expect(items[1700].save.calledOnce).to.be.true;
+    });
+
+    it('should throw when Promise.allSettled has failures', async () => {
+      const dataAccess = { Suggestion: { saveMany: sinon.stub() } };
+      const items = Array.from({ length: 1701 }, (_, i) => ({
+        save: i === 0
+          ? sinon.stub().rejects(new Error('DB error'))
+          : sinon.stub().resolves(),
+      }));
+      try {
+        await saveSuggestions(dataAccess, items);
+        expect.fail('should have thrown');
+      } catch (error) {
+        expect(error.message).to.include('1 of 1701 suggestions failed');
+        expect(error.message).to.include('DB error');
+      }
+    });
+  });
 });