@adobe/spacecat-shared-tier-client 1.3.6 → 1.3.8

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [@adobe/spacecat-shared-tier-client-v1.3.8](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tier-client-v1.3.7...@adobe/spacecat-shared-tier-client-v1.3.8) (2025-11-28)
+
+
+### Bug Fixes
+
+* remove instanceof check ([#1191](https://github.com/adobe/spacecat-shared/issues/1191)) ([c2bf75d](https://github.com/adobe/spacecat-shared/commit/c2bf75d44003e1d0c25bea75640559cd46794301))
+
+# [@adobe/spacecat-shared-tier-client-v1.3.7](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tier-client-v1.3.6...@adobe/spacecat-shared-tier-client-v1.3.7) (2025-11-28)
+
+
+### Bug Fixes
+
+* using entity name instead of instanceof ([#1190](https://github.com/adobe/spacecat-shared/issues/1190)) ([eccda60](https://github.com/adobe/spacecat-shared/commit/eccda60d02f1df7d251957430cb7fcef4041f89c))
+
 # [@adobe/spacecat-shared-tier-client-v1.3.6](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-tier-client-v1.3.5...@adobe/spacecat-shared-tier-client-v1.3.6) (2025-11-28)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-tier-client",
-  "version": "1.3.6",
+  "version": "1.3.8",
   "description": "Shared modules of the Spacecat Services - Tier Client",
   "type": "module",
   "engines": {

package/src/tier-client.js

@@ -12,9 +12,7 @@
 
 import { isNonEmptyObject, hasText } from '@adobe/spacecat-shared-utils';
 import {
-  Site,
   Entitlement as EntitlementModel,
-  Organization,
 } from '@adobe/spacecat-shared-data-access';
 /**
  * TierClient provides methods to manage entitlements and site enrollments.
@@ -28,9 +26,6 @@ class TierClient {
    * @returns {TierClient} TierClient instance for organization operations.
    */
   static createForOrg(context, organization, productCode) {
-    if (!(organization instanceof Organization)) {
-      throw new Error('Entity must be an instance of Organization');
-    }
     if (!hasText(productCode)) {
       throw new Error('Product code is required');
     }
@@ -48,9 +43,6 @@ class TierClient {
    * @returns {TierClient} TierClient instance for site operations.
    */
   static async createForSite(context, site, productCode) {
-    if (!(site instanceof Site)) {
-      throw new Error('Entity must be an instance of Site');
-    }
     if (!hasText(productCode)) {
       throw new Error('Product code is required');
     }

package/test/tier-client.test.js

@@ -50,7 +50,10 @@ describe('TierClient', () => {
 
   // Create actual Organization instance for instanceof checks
   const organizationInstance = Object.create(Organization.prototype);
-  Object.assign(organizationInstance, mockOrganization);
+  Object.assign(
+    organizationInstance,
+    { entityName: Organization.ENTITY_NAME, ...mockOrganization },
+  );
 
   const mockSite = {
     getId: () => siteId,
@@ -60,7 +63,7 @@ describe('TierClient', () => {
 
   // Create actual Site instance for instanceof checks
   const siteInstance = Object.create(Site.prototype);
-  Object.assign(siteInstance, mockSite);
+  Object.assign(siteInstance, { entityName: Site.ENTITY_NAME, ...mockSite });
 
   const mockDataAccess = {
     Entitlement: {
@@ -118,10 +121,11 @@ describe('TierClient', () => {
 
   describe('Static Factory Methods', () => {
     const testOrganization = Object.create(Organization.prototype);
-    Object.assign(testOrganization, { getId: () => orgId });
+    Object.assign(testOrganization, { entityName: Organization.ENTITY_NAME, getId: () => orgId });
 
     const testSite = Object.create(Site.prototype);
     Object.assign(testSite, {
+      entityName: Site.ENTITY_NAME,
       getId: () => siteId,
       getOrganizationId: () => orgId,
       getOrganization: () => testOrganization,
@@ -129,6 +133,7 @@ describe('TierClient', () => {
 
     const testSiteWithOrgRef = Object.create(Site.prototype);
     Object.assign(testSiteWithOrgRef, {
+      entityName: Site.ENTITY_NAME,
       getId: () => siteId,
       getOrganizationId: () => orgId,
     });
@@ -142,13 +147,16 @@ describe('TierClient', () => {
         expect(client.createEntitlement).to.be.a('function');
       });
 
-      it('should throw error when organization is not provided', () => {
-        expect(() => TierClient.createForOrg(mockContext, null, productCode)).to.throw('Entity must be an instance of Organization');
+      it('should allow null organization (validation removed)', () => {
+        const client = TierClient.createForOrg(mockContext, null, productCode);
+        expect(client).to.be.an('object');
+        expect(client.createEntitlement).to.be.a('function');
       });
 
-      it('should throw error when organization has no getId method', () => {
+      it('should allow organization without getId (validation removed)', () => {
         const invalidOrg = { name: 'test' };
-        expect(() => TierClient.createForOrg(mockContext, invalidOrg, productCode)).to.throw('Entity must be an instance of Organization');
+        const client = TierClient.createForOrg(mockContext, invalidOrg, productCode);
+        expect(client).to.be.an('object');
       });
 
       it('should throw error when context is invalid', () => {
@@ -194,12 +202,12 @@ describe('TierClient', () => {
       });
 
       it('should throw error when site is not provided', async () => {
-        await expect(TierClient.createForSite(mockContext, null, productCode)).to.be.rejectedWith('Entity must be an instance of Site');
+        await expect(TierClient.createForSite(mockContext, null, productCode)).to.be.rejectedWith('Cannot read properties of null');
       });
 
       it('should throw error when site has no getId method', async () => {
         const invalidSite = { name: 'test' };
-        await expect(TierClient.createForSite(mockContext, invalidSite, productCode)).to.be.rejectedWith('Entity must be an instance of Site');
+        await expect(TierClient.createForSite(mockContext, invalidSite, productCode)).to.be.rejectedWith('site.getOrganizationId is not a function');
       });
 
       it('should throw error when context is invalid', async () => {