@adobe/spacecat-shared-rum-api-client 2.23.3 → 2.23.4

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [@adobe/spacecat-shared-rum-api-client-v2.23.4](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-rum-api-client-v2.23.3...@adobe/spacecat-shared-rum-api-client-v2.23.4) (2025-04-30)
+
+
+### Bug Fixes
+
+* form source proper handling in form vitals ([#711](https://github.com/adobe/spacecat-shared/issues/711)) ([e37bf0a](https://github.com/adobe/spacecat-shared/commit/e37bf0a6df28952a0e51f8689c4016a9bbff82e0))
+
 # [@adobe/spacecat-shared-rum-api-client-v2.23.3](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-rum-api-client-v2.23.2...@adobe/spacecat-shared-rum-api-client-v2.23.3) (2025-04-26)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-rum-api-client",
-  "version": "2.23.3",
+  "version": "2.23.4",
   "description": "Shared modules of the Spacecat Services - Rum API client",
   "type": "module",
   "engines": {

package/src/functions/form-vitals.js

@@ -89,7 +89,7 @@ function populateFormsInternalNavigation(bundles, formVitals) {
       const fv = findByUrl(formVitals, formInternalNav.source);
       formVital.forminternalnavigation.push({
         url: formInternalNav.source,
-        pageview: fv?.pageview,
+        ...(fv && { pageview: fv.pageview }),
       });
     }
   });
@@ -176,16 +176,19 @@ function handler(bundles) {
     // aggregates metrics per group (url and user agent)
     dataChunks.facets.urlUserAgents.reduce((acc, { value, metrics, weight }) => {
       const [url, userAgent] = value.split(DELIMITER);
-      const key = formSourceMap[url].has(source) ? generateKey(url, source) : url;
-      acc[key] = acc[key] || initializeResult(url);
-      acc[key].pageview[userAgent] = acc[key].pageview[userAgent] || weight;
-      // Enable traffic acquisition for persistence by uncommenting this line
-      // acc[key].trafficacquisition = trafficByUrlMap[url];
-      acc[key].formsource = source;
-      METRICS.filter((metric) => metrics[metric].sum) // filter out user-agents with no form vitals
-        .forEach((metric) => {
-          acc[key][metric][userAgent] = metrics[metric].sum;
-        });
+      if (formSourceMap[url].has(source)) {
+        const key = generateKey(url, source);
+        acc[key] = acc[key] || initializeResult(url);
+        acc[key].pageview[userAgent] = acc[key].pageview[userAgent] || weight;
+        // Enable traffic acquisition for persistence by uncommenting this line
+        // acc[key].trafficacquisition = trafficByUrlMap[url];
+        acc[key].formsource = source;
+        // filter out user-agents with no form vitals
+        METRICS.filter((metric) => metrics[metric].sum)
+          .forEach((metric) => {
+            acc[key][metric][userAgent] = metrics[metric].sum;
+          });
+      }
       return acc;
     }, formVitals);
   });