@adobe/spacecat-shared-rum-api-client 2.2.0 → 2.3.0

package/CHANGELOG.md

@@ -1,3 +1,18 @@
+# [@adobe/spacecat-shared-rum-api-client-v2.3.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-rum-api-client-v2.2.1...@adobe/spacecat-shared-rum-api-client-v2.3.0) (2024-07-12)
+
+
+### Features
+
+* audit top pages for language mismatch (SITES-22690) ([#289](https://github.com/adobe/spacecat-shared/issues/289)) ([ec9d83a](https://github.com/adobe/spacecat-shared/commit/ec9d83a9f59ba7c88b2be3181c60290eae132219))
+
+# [@adobe/spacecat-shared-rum-api-client-v2.2.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-rum-api-client-v2.2.0...@adobe/spacecat-shared-rum-api-client-v2.2.1) (2024-07-08)
+
+
+### Bug Fixes
+
+* Click count is artificially inflating the conversion rate ([#278](https://github.com/adobe/spacecat-shared/issues/278)) ([77a1c6a](https://github.com/adobe/spacecat-shared/commit/77a1c6a27103db4ce463959b882311cf1d3924a3))
+* **deps:** update external fixes ([#284](https://github.com/adobe/spacecat-shared/issues/284)) ([f4fe169](https://github.com/adobe/spacecat-shared/commit/f4fe1699c432637f1217198ad7f4a1cde6deeb76))
+
 # [@adobe/spacecat-shared-rum-api-client-v2.2.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-rum-api-client-v2.1.1...@adobe/spacecat-shared-rum-api-client-v2.2.0) (2024-06-28)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-rum-api-client",
-  "version": "2.2.0",
+  "version": "2.3.0",
   "description": "Shared modules of the Spacecat Services - Rum API client",
   "type": "module",
   "main": "src/index.js",
@@ -44,6 +44,6 @@
     "nock": "13.5.4",
     "sinon": "18.0.0",
     "sinon-chai": "3.7.0",
-    "typescript": "5.5.2"
+    "typescript": "5.5.3"
   }
 }

package/src/functions/experiment.js

@@ -62,9 +62,25 @@ function handler(bundles) {
       const variantObject = getOrCreateVariantObject(experimentObject.variants, variantName);
       variantObject.views += weight;
 
+      const metrics = {};
+      for (const checkpoint of METRIC_CHECKPOINTS) {
+        metrics[checkpoint] = {};
+      }
       for (const event of bundle.events) {
         if (METRIC_CHECKPOINTS.includes(event.checkpoint)) {
           const { source, checkpoint } = event;
+          if (!metrics[checkpoint][source]) {
+            metrics[checkpoint][source] = weight;
+          } else {
+            metrics[checkpoint][source] += weight;
+          }
+        }
+      }
+      // combine metrics and variantObject, considering the interaction events
+      // only once during the session
+      for (const checkpoint of METRIC_CHECKPOINTS) {
+        // eslint-disable-next-line no-restricted-syntax
+        for (const source in metrics[checkpoint]) {
           if (!variantObject[checkpoint][source]) {
             variantObject[checkpoint][source] = weight;
           } else {
@@ -72,6 +88,25 @@ function handler(bundles) {
           }
         }
       }
+      // add each metric to the variantObject's * count by weight
+      for (const checkpoint of Object.keys(metrics)) {
+        if (Object.keys(metrics[checkpoint]).length > 0) {
+          if (!variantObject[checkpoint]['*']) {
+            variantObject[checkpoint]['*'] = weight;
+          } else {
+            variantObject[checkpoint]['*'] += weight;
+          }
+        }
+      }
+      // add global interactionsCount if there's any interaction
+      const hasInteraction = Object.values(metrics).some((m) => Object.keys(m).length > 0);
+      if (hasInteraction) {
+        if (!variantObject.interactionsCount) {
+          variantObject.interactionsCount = weight;
+        } else {
+          variantObject.interactionsCount += weight;
+        }
+      }
     }
   }
   return experimentInsights;

package/src/functions/variant.js

@@ -0,0 +1,121 @@
+/*
+ * Copyright 2024 Adobe. All rights reserved.
+ * This file is licensed to you under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License. You may obtain a copy
+ * of the License at http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under
+ * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
+ * OF ANY KIND, either express or implied. See the License for the specific language
+ * governing permissions and limitations under the License.
+ */
+
+import { isObject } from '@adobe/spacecat-shared-utils';
+
+const VARIANT_CHECKPOINT = 'variant';
+
+function getOrCreateLanguageObject(languageInsights, language) {
+  let languageObject = languageInsights.find((l) => l.language === language);
+
+  if (isObject(languageObject)) {
+    return languageObject;
+  }
+
+  languageObject = {
+    language,
+    count: 0,
+    mismatches: {
+      type1: { preferredLanguages: {} }, // Type 1 mismatches
+      type2: { preferredLanguages: {} }, // Type 2 mismatches
+      type3: { preferredLanguages: {} }, // Type 3 mismatches
+    },
+    regions: {}, // Tracks the count of events for each region
+  };
+
+  languageInsights.push(languageObject);
+  return languageObject;
+}
+
+function handler(bundles) {
+  const languageInsights = [];
+
+  for (const bundle of bundles) {
+    let preferredLanguages = [];
+    let pageLanguage = null;
+    let userRegion = null;
+
+    for (const event of bundle.events) {
+      if (event.checkpoint === VARIANT_CHECKPOINT) {
+        const { target, source } = event;
+
+        if (source === 'preferred-languages') {
+          preferredLanguages = target.split(',').map((lang) => lang.trim());
+        } else if (source === 'page-language') {
+          pageLanguage = target;
+        } else if (source === 'user-region') {
+          userRegion = target;
+        }
+      }
+    }
+
+    if (pageLanguage) {
+      const languageObject = getOrCreateLanguageObject(languageInsights, pageLanguage);
+      languageObject.count += 1; // Increment the total count for this page language
+
+      // Type 1 Mismatch: List out each mismatch if the preferred language list
+      // does not contain the page language
+      const isType1Mismatch = !preferredLanguages.includes(pageLanguage);
+      if (isType1Mismatch) {
+        preferredLanguages.forEach((preferredLanguage) => {
+          if (!languageObject.mismatches.type1.preferredLanguages[preferredLanguage]) {
+            languageObject.mismatches.type1.preferredLanguages[preferredLanguage] = 1;
+          } else {
+            languageObject.mismatches.type1.preferredLanguages[preferredLanguage] += 1;
+          }
+        });
+      }
+
+      // Type 2 Mismatch: Count as one mismatch if any preferred language
+      // is different from page language
+      const isType2Mismatch = preferredLanguages.some(
+        (preferredLanguage) => preferredLanguage !== pageLanguage,
+      );
+      if (isType2Mismatch) {
+        const preferredLanguage = preferredLanguages.join(',');
+        if (!languageObject.mismatches.type2.preferredLanguages[preferredLanguage]) {
+          languageObject.mismatches.type2.preferredLanguages[preferredLanguage] = 1;
+        } else {
+          languageObject.mismatches.type2.preferredLanguages[preferredLanguage] += 1;
+        }
+      }
+
+      // Type 3 Mismatch: Compare each language in preferred language list to page language,
+      // and count each mismatch
+      preferredLanguages.forEach((preferredLanguage) => {
+        if (preferredLanguage !== pageLanguage) {
+          if (!languageObject.mismatches.type3.preferredLanguages[preferredLanguage]) {
+            languageObject.mismatches.type3.preferredLanguages[preferredLanguage] = 1;
+          } else {
+            languageObject.mismatches.type3.preferredLanguages[preferredLanguage] += 1;
+          }
+        }
+      });
+
+      // Track regions
+      if (userRegion) {
+        if (!languageObject.regions[userRegion]) {
+          languageObject.regions[userRegion] = 1;
+        } else {
+          languageObject.regions[userRegion] += 1;
+        }
+      }
+    }
+  }
+
+  return languageInsights;
+}
+
+export default {
+  handler,
+  checkpoints: VARIANT_CHECKPOINT,
+};

package/src/index.js

@@ -13,11 +13,13 @@ import { fetchBundles } from './common/rum-bundler-client.js';
 import notfound from './functions/404.js';
 import cwv from './functions/cwv.js';
 import experiment from './functions/experiment.js';
+import variant from './functions/variant.js';
 
 const HANDLERS = {
   404: notfound,
   cwv,
   experiment,
+  variant,
 };
 
 export default class RUMAPIClient {