@adobe/spacecat-shared-data-access 4.7.0 → 4.9.0

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+## [@adobe/spacecat-shared-data-access-v4.9.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v4.8.0...@adobe/spacecat-shared-data-access-v4.9.0) (2026-07-15)
+
+### Features
+
+* **data-access:** guidance + feedback_subject_id + code-patch export gate for feedback ([#1809](https://github.com/adobe/spacecat-shared/issues/1809)) ([941b9f9](https://github.com/adobe/spacecat-shared/commit/941b9f92621df09a9ce887b70307f4c1261bfd37))
+
+## [@adobe/spacecat-shared-data-access-v4.8.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v4.7.0...@adobe/spacecat-shared-data-access-v4.8.0) (2026-07-14)
+
+### Features
+
+* add temporary replaceHandlerEnabledDisabled method for cleanup. ([#1328](https://github.com/adobe/spacecat-shared/issues/1328)) ([be9234f](https://github.com/adobe/spacecat-shared/commit/be9234fa67dc9960d4abbb0b0425e621b7ad33c7))
+
 ## [@adobe/spacecat-shared-data-access-v4.7.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v4.6.0...@adobe/spacecat-shared-data-access-v4.7.0) (2026-07-13)
 
 ### Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-data-access",
-  "version": "4.7.0",
+  "version": "4.9.0",
   "description": "Shared modules of the Spacecat Services - Data Access",
   "type": "module",
   "engines": {

package/src/models/configuration/configuration.model.js

@@ -554,6 +554,84 @@ class Configuration {
     this.setHandlers(handlers);
   }
 
+  /**
+   * Replaces enabled/disabled lists for a handler.
+   * This method replaces (not merges) the provided arrays.
+   * Only the arrays provided in the data object will be replaced.
+   *
+   * TEMPORARY: This method was created to support a temporary API endpoint for
+   * cleaning up enabled and disabled lists (SITES-40312). It will be removed once the cleanup
+   * task is completed. SITES-40878 is the ticket to remove this temporary endpoint.
+   *
+   * @deprecated Temporary method for cleanup. See SITES-40312. Will be removed (SITES-40878).
+   * @param {string} type - The handler type to update
+   * @param {object} data - Object containing enabled/disabled arrays to replace
+   * @param {object} [data.enabled] - Enabled lists to replace (use null-safe check)
+   * @param {string[]} [data.enabled.sites] - Sites array to replace (if provided, must be array)
+   * @param {string[]} [data.enabled.orgs] - Orgs array to replace (if provided, must be array)
+   * @param {object} [data.disabled] - Disabled lists to replace (use null-safe check)
+   * @param {string[]} [data.disabled.sites] - Sites array to replace (if provided, must be array)
+   * @param {string[]} [data.disabled.orgs] - Orgs array to replace (if provided, must be array)
+   * @throws {Error} If data is empty, handler not found, or non-array value provided for sites/orgs
+   */
+  replaceHandlerEnabledDisabled(type, data) {
+    if (!isNonEmptyObject(data)) {
+      throw new Error('Data cannot be empty');
+    }
+
+    this.log.warn('replaceHandlerEnabledDisabled invoked (temporary method - see SITES-40312)');
+
+    const handlers = this.getHandlers();
+    if (!handlers[type]) {
+      throw new Error(`Handler "${type}" not found in configuration`);
+    }
+
+    const handler = handlers[type];
+
+    // Initialize enabled/disabled objects if they don't exist
+    if (!isNonEmptyObject(handler.enabled)) {
+      handler.enabled = { orgs: [], sites: [] };
+    }
+    if (!isNonEmptyObject(handler.disabled)) {
+      handler.disabled = { orgs: [], sites: [] };
+    }
+
+    // Replace enabled arrays if provided (use != null to catch both null and undefined)
+    if (data.enabled != null) {
+      if (data.enabled.sites !== undefined) {
+        if (!Array.isArray(data.enabled.sites)) {
+          throw new Error('enabled.sites must be an array');
+        }
+        handler.enabled.sites = data.enabled.sites;
+      }
+      if (data.enabled.orgs !== undefined) {
+        if (!Array.isArray(data.enabled.orgs)) {
+          throw new Error('enabled.orgs must be an array');
+        }
+        handler.enabled.orgs = data.enabled.orgs;
+      }
+    }
+
+    // Replace disabled arrays if provided (use != null to catch both null and undefined)
+    if (data.disabled != null) {
+      if (data.disabled.sites !== undefined) {
+        if (!Array.isArray(data.disabled.sites)) {
+          throw new Error('disabled.sites must be an array');
+        }
+        handler.disabled.sites = data.disabled.sites;
+      }
+      if (data.disabled.orgs !== undefined) {
+        if (!Array.isArray(data.disabled.orgs)) {
+          throw new Error('disabled.orgs must be an array');
+        }
+        handler.disabled.orgs = data.disabled.orgs;
+      }
+    }
+
+    handlers[type] = handler;
+    this.setHandlers(handlers);
+  }
+
   /**
    * Updates the configuration by merging changes into existing sections.
    * This is a flexible update method that allows updating one or more sections at once.

package/src/models/configuration/index.d.ts

@@ -40,6 +40,10 @@ export interface Configuration {
   isHandlerEnabledForOrg(type: string, org: Organization): boolean;
   isHandlerEnabledForSite(type: string, site: Site): boolean;
   registerAudit(type: string, enabledByDefault?: boolean, interval?: string, productCodes?: string[]): void;
+  replaceHandlerEnabledDisabled(
+    type: string,
+    data: { enabled?: { sites?: string[]; orgs?: string[] }; disabled?: { sites?: string[]; orgs?: string[] } }
+  ): void;
   save(): Promise<Configuration>;
   setHandlers(handlers: object): void;
   setJobs(jobs: object[]): void;

package/src/models/feedback-event/feedback-event.constants.js

@@ -79,16 +79,19 @@ export const EXPORT_EXCLUDED_REJECTION_CATEGORIES = Object.freeze([
 ]);
 
 /**
- * Customer-derived fields stripped from the JSONL export for organizations with
- * `training_opt_in = false`. Verdict / signal / category / identity metadata
- * still ship. snake_case to match the JSONL row shape (and the feedback_event
- * DB columns) — {@link toJsonlRow} uses this list to do the stripping, so the
- * opt-out boundary is single-sourced here.
+ * HUMAN-authored fields stripped from the JSONL export for organizations with
+ * `training_opt_in = false`: the reviewer's written feedback (`detail_markdown`)
+ * and their hand-corrected patch (`edited_fix`). The AI-generated fields — the
+ * issue context (`guidance_markdown`) and the generated patch (`previous_fix`) —
+ * are ALWAYS exported (the Learning Agent needs the issue + generated patch to
+ * map a verdict to what was generated), as are verdict / signal / category /
+ * identity metadata. snake_case to match the JSONL row shape (and the
+ * feedback_event DB columns) — {@link toJsonlRow} uses this list to do the
+ * stripping, so the opt-out boundary is single-sourced here (SITES-43974).
  */
 export const OPT_OUT_STRIPPED_FIELDS = Object.freeze([
-  'previous_fix',
-  'edited_fix',
   'detail_markdown',
+  'edited_fix',
 ]);
 
 /**
@@ -163,11 +166,17 @@ export function toReviewView(row, { includePatches = false } = {}) {
     rejectionCategory: row.rejection_category ?? null,
     stateTransition: row.state_transition ?? null,
     tier: row.tier,
+    // Sub-item id (e.g. a CWV issue) this review is about; the Backoffice groups
+    // its per-issue "previous feedback" table on it. Always in the base view (the
+    // UI filters on it) — not gated behind includePatches. Null for
+    // whole-suggestion reviews.
+    feedbackSubjectId: row.feedback_subject_id ?? null,
   };
 
   if (includePatches) {
     view.previousFix = row.previous_fix ?? null;
     view.editedFix = row.edited_fix ?? null;
+    view.guidanceMarkdown = row.guidance_markdown ?? null;
   }
 
   return view;
@@ -175,14 +184,21 @@ export function toReviewView(row, { includePatches = false } = {}) {
 
 /**
  * Whether a raw `feedback_event` row should be exported to the Learning Agent
- * corpus. `product_bug` rejections are excluded (routed to Jira); NULL-category
- * rows ARE exported. See {@link EXPORT_EXCLUDED_REJECTION_CATEGORIES}.
+ * corpus. Two gates (SITES-43974):
+ *   1. It must carry a generated code patch (`previous_fix`). The corpus is
+ *      code-patch feedback; text-guidance-only reviews (no patch) are retained
+ *      in Postgres but NOT exported — reserved for a future text-guidance corpus.
+ *   2. `product_bug` rejections are excluded (routed to Jira). NULL-category rows
+ *      (approvals / uncategorised) ARE exported. See
+ *      {@link EXPORT_EXCLUDED_REJECTION_CATEGORIES}.
  *
  * @param {object} row - a raw feedback_event row from PostgREST.
  * @returns {boolean} true if the row should be exported.
  */
 export function shouldExport(row) {
-  return !EXPORT_EXCLUDED_REJECTION_CATEGORIES.includes(row.rejection_category);
+  const hasCodePatch = row.previous_fix != null;
+  return hasCodePatch
+    && !EXPORT_EXCLUDED_REJECTION_CATEGORIES.includes(row.rejection_category);
 }
 
 /**
@@ -190,8 +206,10 @@ export function shouldExport(row) {
  * object — the canonical Learning Agent export contract. The row mirrors the
  * feedback_event columns (snake_case), stamped with {@link SCHEMA_VERSION} and
  * the derived `verdict`. For organizations that have NOT opted into training,
- * the customer-derived fields in {@link OPT_OUT_STRIPPED_FIELDS} are nulled;
- * verdict / signal / category / identity metadata still ship (§10.5.7).
+ * the HUMAN-authored fields in {@link OPT_OUT_STRIPPED_FIELDS} are nulled; the
+ * AI-generated issue context (`guidance_markdown`) + generated patch
+ * (`previous_fix`) and the verdict / signal / category / identity metadata still
+ * ship (§10.5.7).
  *
  * This is the single source of truth for the JSONL row shape — the exporter
  * (spacecat-jobs-dispatcher) calls it rather than re-deriving the contract.
@@ -218,6 +236,7 @@ export function toJsonlRow(row, { optedIn = false } = {}) {
     state_transition: row.state_transition ?? null,
     tier: row.tier,
     detail_markdown: row.detail_markdown ?? null,
+    guidance_markdown: row.guidance_markdown ?? null,
     previous_fix: row.previous_fix ?? null,
     edited_fix: row.edited_fix ?? null,
   };

package/src/models/feedback-event/index.d.ts

@@ -53,8 +53,10 @@ export interface ReviewView {
   rejectionCategory: string | null;
   stateTransition: string | null;
   tier: string;
+  feedbackSubjectId: string | null;
   previousFix?: unknown;
   editedFix?: unknown;
+  guidanceMarkdown?: string | null;
 }
 
 /**