@adobe/spacecat-shared-data-access 3.6.1 → 3.6.2

package/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [@adobe/spacecat-shared-data-access-v3.6.2](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v3.6.1...@adobe/spacecat-shared-data-access-v3.6.2) (2026-03-04)
+
+### Bug Fixes
+
+* **data-access:** surface PG error details in logs ([#1401](https://github.com/adobe/spacecat-shared/issues/1401)) ([ddd3041](https://github.com/adobe/spacecat-shared/commit/ddd3041322a1468ee911f49f06c240a6697b8e66))
+
 ## [@adobe/spacecat-shared-data-access-v3.6.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v3.6.0...@adobe/spacecat-shared-data-access-v3.6.1) (2026-03-03)
 
 ### Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-data-access",
-  "version": "3.6.1",
+  "version": "3.6.2",
   "description": "Shared modules of the Spacecat Services - Data Access",
   "type": "module",
   "engines": {

package/src/models/base/base.collection.js

@@ -104,21 +104,29 @@ class BaseCollection {
   #isInvalidInputError(error) {
     let current = error;
     while (current) {
-      if (current?.code === '22P02') {
-        return true;
-      }
+      if (current?.code === '22P02') return true;
       current = current.cause;
     }
     return false;
   }
 
   #logAndThrowError(message, cause) {
-    const error = new DataAccessError(message, this, cause);
-    this.log.error(`Base Collection Error [${this.entityName}]`, error);
-    if (isNonEmptyArray(error.cause?.fields)) {
-      this.log.error(`Validation errors: ${JSON.stringify(error.cause.fields)}`);
+    const parts = [message];
+    if (cause?.code) parts.push(`[${cause.code}] ${cause.message}`);
+    if (cause?.details) parts.push(cause.details);
+    if (cause?.hint) parts.push(`hint: ${cause.hint}`);
+
+    this.log.error(`[${this.entityName}] ${parts.join(' - ')}`);
+
+    if (isNonEmptyArray(cause?.fields)) {
+      this.log.error(`Validation errors: ${JSON.stringify(cause.fields)}`);
     }
-    throw error;
+
+    throw new DataAccessError(
+      message,
+      { entityName: this.entityName, tableName: this.tableName },
+      cause,
+    );
   }
 
   #initializeCollectionMethods() {
@@ -547,7 +555,7 @@ class BaseCollection {
       const instances = this.#createInstances(allRows);
       return shouldReturnCursor ? { data: instances, cursor } : instances;
     } catch (error) {
-      if (error instanceof DataAccessError) {
+      if (error.constructor === DataAccessError) {
         throw error;
       }
       return this.#logAndThrowError('Failed to query', error);
@@ -601,6 +609,7 @@ class BaseCollection {
     return isNonEmptyObject(item);
   }
 
+  // eslint-disable-next-line consistent-return
   async batchGetByKeys(keys, options = {}) {
     guardArray('keys', keys, this.entityName, 'any');
 
@@ -677,8 +686,11 @@ class BaseCollection {
         unprocessed: [],
       };
     } catch (error) {
-      this.log.error(`Failed to batch get by keys [${this.entityName}]`, error);
-      throw new DataAccessError('Failed to batch get by keys', this, error);
+      /* c8 ignore next 3 -- re-throw guard (exact match; excludes ValidationError subclass) */
+      if (error.constructor === DataAccessError) {
+        throw error;
+      }
+      this.#logAndThrowError('Failed to batch get by keys', error);
     }
   }
 
@@ -721,6 +733,8 @@ class BaseCollection {
       await this.#onCreate(instance);
       return instance;
     } catch (error) {
+      /* c8 ignore next -- re-throw guard (exact match; excludes ValidationError subclass) */
+      if (error.constructor === DataAccessError) throw error;
       return this.#logAndThrowError('Failed to create', error);
     }
   }
@@ -833,6 +847,8 @@ class BaseCollection {
       await this.#onCreateMany({ createdItems, errorItems });
       return { createdItems, errorItems };
     } catch (error) {
+      /* c8 ignore next -- re-throw guard (exact match; excludes ValidationError subclass) */
+      if (error.constructor === DataAccessError) throw error;
       return this.#logAndThrowError('Failed to create many', error);
     }
   }
@@ -856,7 +872,7 @@ class BaseCollection {
 
     const { error } = await query.select().maybeSingle();
     if (error) {
-      throw new DataAccessError('Failed to update entity', this, error);
+      this.#logAndThrowError('Failed to update entity', error);
     }
   }
 
@@ -917,6 +933,8 @@ class BaseCollection {
       this.#invalidateCache();
       return undefined;
     } catch (error) {
+      /* c8 ignore next -- re-throw guard (exact match; excludes ValidationError subclass) */
+      if (error.constructor === DataAccessError) throw error;
       return this.#logAndThrowError('Failed to save many', error);
     }
   }
@@ -947,6 +965,8 @@ class BaseCollection {
       this.#invalidateCache();
       return undefined;
     } catch (error) {
+      /* c8 ignore next -- re-throw guard (exact match; excludes ValidationError subclass) */
+      if (error.constructor === DataAccessError) throw error;
       return this.#logAndThrowError('Failed to remove by IDs', error);
     }
   }