@adobe/spacecat-shared-data-access 3.47.0 → 3.49.0

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+## [@adobe/spacecat-shared-data-access-v3.49.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v3.48.0...@adobe/spacecat-shared-data-access-v3.49.0) (2026-04-10)
+
+### Features
+
+* **audit-url:** add moneyPages source to auditTargetURLs config ([#1496](https://github.com/adobe/spacecat-shared/issues/1496)) ([78df8f9](https://github.com/adobe/spacecat-shared/commit/78df8f91008e739bfd67e2277858523a276d70b2))
+
+## [@adobe/spacecat-shared-data-access-v3.48.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v3.47.0...@adobe/spacecat-shared-data-access-v3.48.0) (2026-04-08)
+
+### Features
+
+* **data-access:** add INACTIVE status, reviews field, and REVIEW_DECISIONS to PlgOnboarding ([#1516](https://github.com/adobe/spacecat-shared/issues/1516)) ([8f038e9](https://github.com/adobe/spacecat-shared/commit/8f038e93287da51acf0e586f3e786aeb00d4a0d3))
+
 ## [@adobe/spacecat-shared-data-access-v3.47.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v3.46.0...@adobe/spacecat-shared-data-access-v3.47.0) (2026-04-07)
 
 ### Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-data-access",
-  "version": "3.47.0",
+  "version": "3.49.0",
   "description": "Shared modules of the Spacecat Services - Data Access",
   "type": "module",
   "engines": {

package/src/models/audit-url/audit-url.collection.js

@@ -60,9 +60,16 @@ class AuditUrlCollection extends BaseCollection {
       }
 
       // Handle null/undefined values (push to end)
-      if (aValue == null && bValue == null) return 0;
-      if (aValue == null) return 1;
-      if (bValue == null) return -1;
+      /* c8 ignore next 6 */
+      if (aValue == null && bValue == null) {
+        return 0;
+      }
+      if (aValue == null) {
+        return 1;
+      }
+      if (bValue == null) {
+        return -1;
+      }
 
       // Compare values
       let comparison = 0;

package/src/models/base/base.collection.js

@@ -75,7 +75,10 @@ class BaseCollection {
 
   // eslint-disable-next-line class-methods-use-this
   #resolveBulkKeyField(keys) {
-    if (!isNonEmptyArray(keys)) return null;
+    /* c8 ignore next 3 */
+    if (!isNonEmptyArray(keys)) {
+      return null;
+    }
 
     const [firstKey] = keys;
     const fields = Object.keys(firstKey);
@@ -93,9 +96,13 @@ class BaseCollection {
   }
 
   #normalizeEnumValue(key, value) {
-    if (typeof value !== 'string') return value;
+    if (typeof value !== 'string') {
+      return value;
+    }
     const attr = this.schema.getAttribute(key);
-    if (!Array.isArray(attr?.type)) return value;
+    if (!Array.isArray(attr?.type)) {
+      return value;
+    }
     const match = attr.type.find((v) => v.toLowerCase() === value.toLowerCase());
     return match ?? value;
   }
@@ -104,7 +111,9 @@ class BaseCollection {
   #isInvalidInputError(error) {
     let current = error;
     while (current) {
-      if (current?.code === '22P02') return true;
+      if (current?.code === '22P02') {
+        return true;
+      }
       current = current.cause;
     }
     return false;
@@ -112,9 +121,16 @@ class BaseCollection {
 
   #logAndThrowError(message, cause) {
     const parts = [message];
-    if (cause?.code) parts.push(`[${cause.code}] ${cause.message}`);
-    if (cause?.details) parts.push(cause.details);
-    if (cause?.hint) parts.push(`hint: ${cause.hint}`);
+    if (cause?.code) {
+      parts.push(`[${cause.code}] ${cause.message}`);
+    }
+    if (cause?.details) {
+      parts.push(cause.details);
+    }
+    /* c8 ignore next 3 */
+    if (cause?.hint) {
+      parts.push(`hint: ${cause.hint}`);
+    }
 
     this.log.error(`[${this.entityName}] ${parts.join(' - ')}`);
 
@@ -595,7 +611,10 @@ class BaseCollection {
    * @returns {object|null} A model instance, or null if the row is empty/invalid.
    */
   createInstanceFromRow(row) {
-    if (!isNonEmptyObject(row)) return null;
+    /* c8 ignore next 3 */
+    if (!isNonEmptyObject(row)) {
+      return null;
+    }
     return this.#createInstance(this.#toModelRecord(row));
   }
 
@@ -748,7 +767,9 @@ class BaseCollection {
       return instance;
     } catch (error) {
       /* c8 ignore next -- re-throw guard (exact match; excludes ValidationError subclass) */
-      if (error.constructor === DataAccessError) throw error;
+      if (error.constructor === DataAccessError) {
+        throw error;
+      }
       return this.#logAndThrowError('Failed to create', error);
     }
   }
@@ -862,7 +883,9 @@ class BaseCollection {
       return { createdItems, errorItems };
     } catch (error) {
       /* c8 ignore next -- re-throw guard (exact match; excludes ValidationError subclass) */
-      if (error.constructor === DataAccessError) throw error;
+      if (error.constructor === DataAccessError) {
+        throw error;
+      }
       return this.#logAndThrowError('Failed to create many', error);
     }
   }
@@ -990,7 +1013,9 @@ class BaseCollection {
       return undefined;
     } catch (error) {
       /* c8 ignore next -- re-throw guard (exact match; excludes ValidationError subclass) */
-      if (error.constructor === DataAccessError) throw error;
+      if (error.constructor === DataAccessError) {
+        throw error;
+      }
       return this.#logAndThrowError('Failed to save many', error);
     }
   }
@@ -1022,7 +1047,9 @@ class BaseCollection {
       return undefined;
     } catch (error) {
       /* c8 ignore next -- re-throw guard (exact match; excludes ValidationError subclass) */
-      if (error.constructor === DataAccessError) throw error;
+      if (error.constructor === DataAccessError) {
+        throw error;
+      }
       return this.#logAndThrowError('Failed to remove by IDs', error);
     }
   }

package/src/models/base/schema.js

@@ -143,7 +143,9 @@ class Schema {
     Object.keys(indexes).forEach((indexName) => {
       const indexKeys = this.getIndexKeys(indexName);
 
-      if (!isNonEmptyArray(indexKeys)) return;
+      if (!isNonEmptyArray(indexKeys)) {
+        return;
+      }
 
       const keySets = [];
       for (let i = 1; i <= indexKeys.length; i += 1) {

package/src/models/configuration/configuration.model.js

@@ -176,7 +176,9 @@ class Configuration {
 
   isHandlerEnabledForSite(type, site) {
     const handler = this.getHandlers()?.[type];
-    if (!handler) return false;
+    if (!handler) {
+      return false;
+    }
 
     const siteId = site.getId();
     const orgId = site.getOrganizationId();
@@ -203,7 +205,9 @@ class Configuration {
 
   isHandlerEnabledForOrg(type, org) {
     const handler = this.getHandlers()?.[type];
-    if (!handler) return false;
+    if (!handler) {
+      return false;
+    }
 
     const orgId = org.getId();
 
@@ -226,7 +230,9 @@ class Configuration {
     const handlers = this.getHandlers();
     const handler = handlers?.[type];
 
-    if (!isNonEmptyObject(handler)) return;
+    if (!isNonEmptyObject(handler)) {
+      return;
+    }
 
     if (!isNonEmptyObject(handler.disabled)) {
       handler.disabled = { orgs: [], sites: [] };
@@ -267,7 +273,9 @@ class Configuration {
 
   enableHandlerForSite(type, site) {
     const siteId = site.getId();
-    if (this.isHandlerEnabledForSite(type, site)) return;
+    if (this.isHandlerEnabledForSite(type, site)) {
+      return;
+    }
 
     const deps = this.isHandlerDependencyMetForSite(type, site);
     if (deps !== true) {
@@ -287,7 +295,9 @@ class Configuration {
   isHandlerDependencyMetForOrg(type, org) {
     const handler = this.getHandler(type);
 
-    if (!handler || !isNonEmptyArray(handler?.dependencies)) return true;
+    if (!handler || !isNonEmptyArray(handler?.dependencies)) {
+      return true;
+    }
 
     const unmetDependencies = handler.dependencies
       .filter(({ handler: depHandler }) => !this.isHandlerEnabledForOrg(depHandler, org))
@@ -305,7 +315,9 @@ class Configuration {
    */
   isHandlerDependencyMetForSite(type, site) {
     const handler = this.getHandler(type);
-    if (!handler || !isNonEmptyArray(handler?.dependencies)) return true;
+    if (!handler || !isNonEmptyArray(handler?.dependencies)) {
+      return true;
+    }
 
     const unmetDependencies = handler.dependencies
       .filter(({ handler: depHandler }) => !this.isHandlerEnabledForSite(depHandler, site))
@@ -316,7 +328,9 @@ class Configuration {
 
   enableHandlerForOrg(type, org) {
     const orgId = org.getId();
-    if (this.isHandlerEnabledForOrg(type, org)) return;
+    if (this.isHandlerEnabledForOrg(type, org)) {
+      return;
+    }
     const deps = this.isHandlerDependencyMetForOrg(type, org);
     if (deps !== true) {
       throw new Error(`Cannot enable handler ${type} for org ${orgId} because of missing dependencies: ${deps}`);
@@ -327,14 +341,18 @@ class Configuration {
 
   disableHandlerForSite(type, site) {
     const siteId = site.getId();
-    if (!this.isHandlerEnabledForSite(type, site)) return;
+    if (!this.isHandlerEnabledForSite(type, site)) {
+      return;
+    }
 
     this.updateHandlerSites(type, siteId, false);
   }
 
   disableHandlerForOrg(type, org) {
     const orgId = org.getId();
-    if (!this.isHandlerEnabledForOrg(type, org)) return;
+    if (!this.isHandlerEnabledForOrg(type, org)) {
+      return;
+    }
 
     this.updateHandlerOrgs(type, orgId, false);
   }

package/src/models/plg-onboarding/index.d.ts

@@ -18,7 +18,18 @@ export type PlgOnboardingStatus =
   | 'ONBOARDED'
   | 'ERROR'
   | 'WAITING_FOR_IP_ALLOWLISTING'
-  | 'WAITLISTED';
+  | 'WAITLISTED'
+  | 'INACTIVE';
+
+export type PlgOnboardingReviewDecision = 'BYPASSED' | 'UPHELD';
+
+export interface PlgOnboardingReview {
+  reason: string;
+  decision: PlgOnboardingReviewDecision;
+  reviewedBy: string;
+  reviewedAt: string;
+  justification: string;
+}
 
 export interface PlgOnboarding extends BaseModel {
   getImsOrgId(): string;
@@ -31,6 +42,7 @@ export interface PlgOnboarding extends BaseModel {
   getError(): object | null;
   getBotBlocker(): object | null;
   getWaitlistReason(): string | null;
+  getReviews(): PlgOnboardingReview[] | null;
   getCompletedAt(): string | null;
   setStatus(status: PlgOnboardingStatus): PlgOnboarding;
   setSiteId(siteId: string): PlgOnboarding;
@@ -39,6 +51,7 @@ export interface PlgOnboarding extends BaseModel {
   setError(error: object): PlgOnboarding;
   setBotBlocker(botBlocker: object): PlgOnboarding;
   setWaitlistReason(waitlistReason: string): PlgOnboarding;
+  setReviews(reviews: PlgOnboardingReview[]): PlgOnboarding;
   setCompletedAt(completedAt: string): PlgOnboarding;
 }
 

package/src/models/plg-onboarding/plg-onboarding.model.js

@@ -33,6 +33,12 @@ class PlgOnboarding extends BaseModel {
     ERROR: 'ERROR',
     WAITING_FOR_IP_ALLOWLISTING: 'WAITING_FOR_IP_ALLOWLISTING',
     WAITLISTED: 'WAITLISTED',
+    INACTIVE: 'INACTIVE',
+  };
+
+  static REVIEW_DECISIONS = {
+    BYPASSED: 'BYPASSED',
+    UPHELD: 'UPHELD',
   };
 }
 

package/src/models/plg-onboarding/plg-onboarding.schema.js

@@ -80,6 +80,27 @@ const schema = new SchemaBuilder(PlgOnboarding, PlgOnboardingCollection)
     type: 'string',
     required: false,
   })
+  .addAttribute('reviews', {
+    type: 'list',
+    required: false,
+    items: {
+      type: 'map',
+      properties: {
+        reason: { type: 'string' },
+        decision: { type: 'string' },
+        reviewedBy: { type: 'string' },
+        reviewedAt: { type: 'string' },
+        justification: { type: 'string' },
+      },
+    },
+    validate: (value) => {
+      if (!Array.isArray(value)) {
+        return false;
+      }
+      const valid = Object.values(PlgOnboarding.REVIEW_DECISIONS);
+      return value.every((r) => valid.includes(r.decision) && isIsoDate(r.reviewedAt));
+    },
+  })
   .addAttribute('completedAt', {
     type: 'string',
     validate: (value) => !value || isIsoDate(value),

package/src/models/site/config.js

@@ -404,6 +404,9 @@ export const configSchema = Joi.object({
     manual: Joi.array().items(Joi.object({
       url: Joi.string().uri().required(),
     })).optional().default([]),
+    moneyPages: Joi.array().items(Joi.object({
+      url: Joi.string().uri().required(),
+    })).optional().default([]),
   }).options({ stripUnknown: true }).optional(),
   handlers: Joi.object().pattern(Joi.string(), Joi.object({
     mentions: Joi.object().pattern(Joi.string(), Joi.array().items(Joi.string())),
@@ -515,7 +518,7 @@ export const Config = (data = {}) => {
   self.getEdgeOptimizeConfig = () => state?.edgeOptimizeConfig;
   self.getOnboardConfig = () => state?.onboardConfig;
   self.getCommerceLlmoConfig = () => state?.commerceLlmoConfig;
-  const AUDIT_TARGET_SOURCES = ['manual'];
+  const AUDIT_TARGET_SOURCES = ['manual', 'moneyPages'];
   const auditTargetEntrySchema = Joi.object({
     url: Joi.string().uri().required(),
   });
@@ -530,7 +533,9 @@ export const Config = (data = {}) => {
 
   self.getAuditTargetURLs = () => {
     const targets = state?.auditTargetURLs;
-    if (!targets) return [];
+    if (!targets) {
+      return [];
+    }
     return AUDIT_TARGET_SOURCES.flatMap(
       (source) => (targets[source] || []).map((entry) => ({ ...entry, source })),
     );
@@ -564,7 +569,9 @@ export const Config = (data = {}) => {
 
   self.removeAuditTargetURL = (source, url) => {
     validateAuditTargetSource(source);
-    if (!state.auditTargetURLs?.[source]) return;
+    if (!state.auditTargetURLs?.[source]) {
+      return;
+    }
     state.auditTargetURLs[source] = state.auditTargetURLs[source]
       .filter((t) => t.url !== url);
   };
@@ -702,7 +709,10 @@ export const Config = (data = {}) => {
 
   self.removeLlmoUrlPattern = (urlPattern) => {
     const urlPatterns = state.llmo?.urlPatterns;
-    if (!urlPatterns) return;
+    /* c8 ignore next 3 */
+    if (!urlPatterns) {
+      return;
+    }
 
     state.llmo.urlPatterns = urlPatterns.filter(
       (pattern) => pattern.urlPattern !== urlPattern,
@@ -733,7 +743,9 @@ export const Config = (data = {}) => {
   };
 
   self.removeLlmoTag = (tag) => {
-    if (!state.llmo?.tags) return;
+    if (!state.llmo?.tags) {
+      return;
+    }
     state.llmo.tags = state.llmo.tags.filter((t) => t !== tag);
   };
 
@@ -803,7 +815,10 @@ export const Config = (data = {}) => {
     const prior = state.brandProfile || {};
     // compute hash over all content except functional fields
     const stripFunctional = (p) => {
-      if (!isNonEmptyObject(p)) return {};
+      /* c8 ignore next 3 */
+      if (!isNonEmptyObject(p)) {
+        return {};
+      }
       const {
         /* eslint-disable no-unused-vars */
         version, updatedAt, contentHash, ...rest
@@ -861,7 +876,9 @@ export const Config = (data = {}) => {
   };
 
   self.disableImport = (type) => {
-    if (!state.imports) return;
+    if (!state.imports) {
+      return;
+    }
 
     state.imports = state.imports.map(
       (imp) => (imp.type === type ? { ...imp, enabled: false } : imp),

package/src/models/site/index.d.ts

@@ -110,7 +110,7 @@ export interface LlmoCustomerIntent {
   value: string;
 }
 
-export type AuditTargetSource = 'manual';
+export type AuditTargetSource = 'manual' | 'moneyPages';
 
 export interface AuditTargetEntry {
   url: string;
@@ -122,6 +122,7 @@ export interface AuditTargetEntryWithSource extends AuditTargetEntry {
 
 export interface AuditTargetURLs {
   manual?: AuditTargetEntry[];
+  moneyPages?: AuditTargetEntry[];
 }
 
 export interface SiteConfig {

package/src/models/site-enrollment/site-enrollment.collection.js

@@ -53,7 +53,9 @@ class SiteEnrollmentCollection extends BaseCollection {
         siteId: item.siteId,
         entitlementId: item.entitlementId,
       });
-      if (existing) return existing;
+      if (existing) {
+        return existing;
+      }
     }
 
     return super.create(item, options);

package/src/models/suggestion/suggestion.projection-utils.js

@@ -37,7 +37,9 @@ export const FIELD_TRANSFORMERS = {
    * Used for accessibility-related opportunity types.
    */
   filterIssuesOccurrences: (issues) => {
-    if (!Array.isArray(issues)) return issues;
+    if (!Array.isArray(issues)) {
+      return issues;
+    }
     return issues.map((issue) => ({
       occurrences: issue.occurrences,
     }));
@@ -47,7 +49,9 @@ export const FIELD_TRANSFORMERS = {
    * Used for Core Web Vitals opportunity type.
    */
   filterCwvMetrics: (metrics) => {
-    if (!Array.isArray(metrics)) return metrics;
+    if (!Array.isArray(metrics)) {
+      return metrics;
+    }
     return metrics.map((metric) => ({
       deviceType: metric.deviceType,
       lcp: metric.lcp,
@@ -65,7 +69,9 @@ export const FIELD_TRANSFORMERS = {
    * /AltText/handlers/AltTextOpportunityAdapter.tsx
    */
   extractPageUrlFromRecommendations: (recommendations) => {
-    if (!Array.isArray(recommendations)) return recommendations;
+    if (!Array.isArray(recommendations)) {
+      return recommendations;
+    }
     return recommendations.map((rec) => ({
       pageUrl: rec.pageUrl,
       ...(rec.isDecorative !== undefined && { isDecorative: rec.isDecorative }),
@@ -77,7 +83,9 @@ export const FIELD_TRANSFORMERS = {
    * Used for security vulnerability opportunity types.
    */
   extractCveUrls: (cves) => {
-    if (!Array.isArray(cves)) return cves;
+    if (!Array.isArray(cves)) {
+      return cves;
+    }
     return cves.map((cve) => ({
       url: cve.url,
     }));

package/src/models/suggestion-grant/suggestion-grant.collection.js

@@ -100,7 +100,9 @@ class SuggestionGrantCollection extends BaseCollection {
 
       return { grantedIds, notGrantedIds, grantIds };
     } catch (err) {
-      if (err instanceof DataAccessError) throw err;
+      if (err instanceof DataAccessError) {
+        throw err;
+      }
       this.log.error('splitSuggestionsByGrantStatus failed', err);
       throw new DataAccessError('Failed to split suggestions by grant status', this, err);
     }
@@ -115,7 +117,9 @@ class SuggestionGrantCollection extends BaseCollection {
    *   false otherwise or if id is empty.
    */
   async isSuggestionGranted(suggestionId) {
-    if (!hasText(suggestionId)) return false;
+    if (!hasText(suggestionId)) {
+      return false;
+    }
     const { grantedIds } = await this.splitSuggestionsByGrantStatus([suggestionId]);
     return grantedIds.length > 0;
   }

package/src/util/guards.js

@@ -74,14 +74,18 @@ export const guardAny = (propertyName, value, entityName, nullable = false) => {
  * @throws Will throw an error if the value is not a valid boolean.
  */
 export const guardBoolean = (propertyName, value, entityName, nullable = false) => {
-  if (checkNullable(value, nullable)) return;
+  if (checkNullable(value, nullable)) {
+    return;
+  }
   if (typeof value !== 'boolean') {
     throw new ValidationError(`Validation failed in ${entityName}: ${propertyName} must be a boolean`);
   }
 };
 
 export const guardArray = (propertyName, value, entityName, type = 'string', nullable = false) => {
-  if (checkNullable(value, nullable)) return;
+  if (checkNullable(value, nullable)) {
+    return;
+  }
   if (!Array.isArray(value)) {
     throw new ValidationError(`Validation failed in ${entityName}: ${propertyName} must be an array`);
   }
@@ -100,7 +104,9 @@ export const guardArray = (propertyName, value, entityName, type = 'string', nul
  * @throws Will throw an error if the value is not a valid set (unique array) of a given type.
  */
 export const guardSet = (propertyName, value, entityName, type = 'string', nullable = false) => {
-  if (checkNullable(value, nullable)) return;
+  if (checkNullable(value, nullable)) {
+    return;
+  }
   if (!Array.isArray(value) || new Set(value).size !== value.length) {
     throw new ValidationError(`Validation failed in ${entityName}: ${propertyName} must be a unique array (set)`);
   }
@@ -118,7 +124,9 @@ export const guardSet = (propertyName, value, entityName, type = 'string', nulla
  * @throws Will throw an error if the value is not a valid string.
  */
 export const guardString = (propertyName, value, entityName, nullable = false) => {
-  if (checkNullable(value, nullable)) return;
+  if (checkNullable(value, nullable)) {
+    return;
+  }
   if (!hasText(value)) {
     throw new ValidationError(`Validation failed in ${entityName}: ${propertyName} is required`);
   }
@@ -134,7 +142,9 @@ export const guardString = (propertyName, value, entityName, nullable = false) =
  * @throws Will throw an error if the value is not a valid enum value.
  */
 export const guardEnum = (propertyName, value, enumValues, entityName, nullable = false) => {
-  if (checkNullable(value, nullable)) return;
+  if (checkNullable(value, nullable)) {
+    return;
+  }
   if (!enumValues.includes(value)) {
     throw new ValidationError(`Validation failed in ${entityName}: ${propertyName} must be one of ${enumValues}`);
   }
@@ -149,7 +159,9 @@ export const guardEnum = (propertyName, value, enumValues, entityName, nullable
  * @throws Will throw an error if the value is not a valid ID.
  */
 export const guardId = (propertyName, value, entityName, nullable = false) => {
-  if (checkNullable(value, nullable)) return;
+  if (checkNullable(value, nullable)) {
+    return;
+  }
   if (!isValidUUID(value)) {
     throw new ValidationError(`Validation failed in ${entityName}: ${propertyName} must be a valid UUID`);
   }
@@ -164,7 +176,9 @@ export const guardId = (propertyName, value, entityName, nullable = false) => {
  * @throws Will throw an error if the value is not a valid map (object).
  */
 export const guardMap = (propertyName, value, entityName, nullable = false) => {
-  if (checkNullable(value, nullable)) return;
+  if (checkNullable(value, nullable)) {
+    return;
+  }
   if (!isObject(value)) {
     throw new ValidationError(`Validation failed in ${entityName}: ${propertyName} must be an object`);
   }
@@ -179,7 +193,9 @@ export const guardMap = (propertyName, value, entityName, nullable = false) => {
  * @throws Will throw an error if the value is not a valid number.
  */
 export const guardNumber = (propertyName, value, entityName, nullable = false) => {
-  if (checkNullable(value, nullable)) return;
+  if (checkNullable(value, nullable)) {
+    return;
+  }
   if (!isNumber(value)) {
     throw new ValidationError(`Validation failed in ${entityName}: ${propertyName} must be a number`);
   }