@adobe/spacecat-shared-data-access 1.61.11 → 1.61.13

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [@adobe/spacecat-shared-data-access-v1.61.13](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.61.12...@adobe/spacecat-shared-data-access-v1.61.13) (2025-01-03)
+
+
+### Bug Fixes
+
+* audit result to validate array ([#522](https://github.com/adobe/spacecat-shared/issues/522)) ([a6978d5](https://github.com/adobe/spacecat-shared/commit/a6978d54c52e668ea2336e68c9dcb000ba1a45a3))
+
+# [@adobe/spacecat-shared-data-access-v1.61.12](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.61.11...@adobe/spacecat-shared-data-access-v1.61.12) (2024-12-31)
+
+
+### Bug Fixes
+
+* calling all wrong args ([#520](https://github.com/adobe/spacecat-shared/issues/520)) ([b727e50](https://github.com/adobe/spacecat-shared/commit/b727e50e8375c8b6a33bac101d0a2ecaf8fc8b7e))
+
 # [@adobe/spacecat-shared-data-access-v1.61.11](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.61.10...@adobe/spacecat-shared-data-access-v1.61.11) (2024-12-31)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-data-access",
-  "version": "1.61.11",
+  "version": "1.61.13",
   "description": "Shared modules of the Spacecat Services - Data Access",
   "type": "module",
   "engines": {

package/src/v2/models/audit/audit.model.js

@@ -10,7 +10,7 @@
  * governing permissions and limitations under the License.
  */
 
-import { isObject } from '@adobe/spacecat-shared-utils';
+import { isArray, isObject } from '@adobe/spacecat-shared-utils';
 
 import { ValidationError } from '../../errors/index.js';
 import BaseModel from '../base/base.model.js';
@@ -53,7 +53,7 @@ class Audit extends BaseModel {
    * @returns {boolean} - True if valid, false otherwise.
    */
   static validateAuditResult = (auditResult, auditType) => {
-    if (!isObject(auditResult) && !Array.isArray(auditResult)) {
+    if (!isObject(auditResult) && !isArray(auditResult)) {
       throw new ValidationError('Audit result must be an object or array');
     }
 

package/src/v2/models/audit/audit.schema.js

@@ -12,7 +12,7 @@
 
 /* c8 ignore start */
 
-import { isIsoDate, isNonEmptyObject } from '@adobe/spacecat-shared-utils';
+import { isArray, isIsoDate, isNonEmptyObject } from '@adobe/spacecat-shared-utils';
 
 import SchemaBuilder from '../base/schema.builder.js';
 import Audit from './audit.model.js';
@@ -33,7 +33,7 @@ const schema = new SchemaBuilder(Audit, AuditCollection)
   .addAttribute('auditResult', {
     type: 'any',
     required: true,
-    validate: (value) => isNonEmptyObject(value),
+    validate: (value) => isNonEmptyObject(value) || isArray(value),
     set: (value, attributes) => {
       // as the electroDb validate function does not provide access to the model instance
       // we need to call the validate function from the model on setting the value

package/src/v2/models/audit/index.d.ts

@@ -17,7 +17,7 @@ import type {
 export interface Audit extends BaseModel {
   getAuditedAt(): string;
   getAuditId(): string;
-  getAuditResult(): object;
+  getAuditResult(): object | [];
   getAuditType(): string;
   getFullAuditRef(): string;
   getIsError(): boolean;

package/src/v2/models/site/site.collection.js

@@ -26,7 +26,7 @@ import Site from './site.model.js';
  */
 class SiteCollection extends BaseCollection {
   async allSitesToAudit() {
-    return (await this.all({ attributes: ['siteId'] })).map((site) => site.getId());
+    return (await this.all({}, { attributes: ['siteId'] })).map((site) => site.getId());
   }
 
   async allWithLatestAudit(auditType, order = 'asc', deliveryType = null) {
@@ -43,7 +43,7 @@ class SiteCollection extends BaseCollection {
 
     const [sites, latestAudits] = await Promise.all([
       sitesQuery,
-      latestAuditCollection.all([auditType], { order }),
+      latestAuditCollection.all({ auditType }, { order }),
     ]);
 
     const sitesMap = new Map(sites.map((site) => [site.getId(), site]));