@adobe/spacecat-shared-data-access 1.44.4 → 1.45.0

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [@adobe/spacecat-shared-data-access-v1.45.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.44.5...@adobe/spacecat-shared-data-access-v1.45.0) (2024-09-24)
+
+
+### Features
+
+* Add an additional scope to all imports on all domains ([#383](https://github.com/adobe/spacecat-shared/issues/383)) ([92ad32c](https://github.com/adobe/spacecat-shared/commit/92ad32c892b151082b1ac6b67b29f6307dbeba15))
+
+# [@adobe/spacecat-shared-data-access-v1.44.5](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.44.4...@adobe/spacecat-shared-data-access-v1.44.5) (2024-09-23)
+
+
+### Bug Fixes
+
+* [Importer] Specify the list of supported features ([#362](https://github.com/adobe/spacecat-shared/issues/362)) ([c1cf7e1](https://github.com/adobe/spacecat-shared/commit/c1cf7e19b7a4bfe78a03a1996bb6d6c8667dd823))
+
 # [@adobe/spacecat-shared-data-access-v1.44.4](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.44.3...@adobe/spacecat-shared-data-access-v1.44.4) (2024-09-21)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-data-access",
-  "version": "1.44.4",
+  "version": "1.45.0",
   "description": "Shared modules of the Spacecat Services - Data Access",
   "type": "module",
   "engines": {

package/src/dto/import-job.js

@@ -13,18 +13,18 @@
 import { createImportJob } from '../models/importer/import-job.js';
 
 /**
- * Data Transfer Object for ImportJob
+ * The ImportJobDto is a helper that can convert an ImportJob object to a DynamoDB item and
+ * vice versa.
  */
-
 export const ImportJobDto = {
 
   /**
-     * Converts an ImportJob object into a DynamoDB item.
-     * @param importJob
-     * @returns {{duration: *, baseURL: *, failedCount: *, apiKey: *,
-     *      options: *, successCount: *, importQueueId: *, startTime: *, id: *,
-     *      endTime: *, status: *}}
-     */
+   * Converts an ImportJob object into a DynamoDB item.
+   * @param importJob
+   * @returns {{duration: *, baseURL: *, failedCount: *, apiKey: *,
+   *      options: *, successCount: *, importQueueId: *, startTime: *, id: *,
+   *      endTime: *, status: *}}
+   */
   toDynamoItem: (importJob) => ({
     id: importJob.getId(),
     baseURL: importJob.getBaseURL(),
@@ -37,14 +37,17 @@ export const ImportJobDto = {
     urlCount: importJob.getUrlCount(),
     successCount: importJob.getSuccessCount(),
     failedCount: importJob.getFailedCount(),
+    redirectCount: importJob.getRedirectCount(),
     importQueueId: importJob.getImportQueueId(),
     initiatedBy: importJob.getInitiatedBy(),
     GSI1PK: 'ALL_IMPORT_JOBS',
   }),
 
   /**
-     * Converts a DynamoDB item into an ImportJob object.
-     */
+   * Converts a DynamoDB item into an ImportJob object.
+   * @param {object} dynamoItem - The DynamoDB item to convert.
+   * @returns {ImportJob} - The ImportJob object.
+   */
   fromDynamoItem: (dynamoItem) => {
     const importJobData = {
       id: dynamoItem.id,
@@ -58,10 +61,12 @@ export const ImportJobDto = {
       urlCount: dynamoItem.urlCount,
       successCount: dynamoItem.successCount,
       failedCount: dynamoItem.failedCount,
+      redirectCount: dynamoItem.redirectCount,
       importQueueId: dynamoItem.importQueueId,
       initiatedBy: dynamoItem.initiatedBy,
     };
 
     return createImportJob(importJobData);
   },
+
 };

package/src/dto/import-url.js

@@ -13,14 +13,15 @@
 import { createImportUrl } from '../models/importer/import-url.js';
 
 /**
- * Data Transfer Object for ImportUrl
+ * The ImportUrlDto is a helper that can convert an ImportUrl object to a DynamoDB item and
+ * vice versa.
  */
-
 export const ImportUrlDto = {
 
   /**
-     * Converts an importUrl object to a DynamoDB item
-     */
+   * Converts an ImportUrl object to a DynamoDB item.
+   * @returns {object} The new DynamoDB item.
+   */
   toDynamoItem: (importUrl) => ({
     id: importUrl.getId(),
     jobId: importUrl.getJobId(),
@@ -32,8 +33,10 @@ export const ImportUrlDto = {
   }),
 
   /**
-     * Converts a DynamoDB item into an ImportUrl object
-     */
+   * Converts a DynamoDB item into an ImportUrl object.
+   * @param {object} dynamoItem - The DynamoDB item to convert.
+   * @returns {ImportUrl} - The ImportUrl object.
+   */
   fromDynamoItem: (dynamoItem) => {
     const importUrlData = {
       id: dynamoItem.id,

package/src/index.d.ts

@@ -10,6 +10,22 @@
  * governing permissions and limitations under the License.
  */
 
+// see packages/spacecat-shared-data-access/src/models/importer/import-constants.js
+export declare const ImportJobStatus: {
+  readonly RUNNING: 'RUNNING';
+  readonly COMPLETE: 'COMPLETE';
+  readonly FAILED: 'FAILED';
+};
+
+// packages/spacecat-shared-data-access/src/models/importer/import-constants.js
+export declare const ImportUrlStatus: {
+  readonly PENDING: 'PENDING';
+  readonly REDIRECT: 'REDIRECT';
+  readonly RUNNING: 'RUNNING';
+  readonly COMPLETE: 'COMPLETE';
+  readonly FAILED: 'FAILED';
+};
+
 // TODO: introduce AuditType interface or Scores interface
 
 /**
@@ -463,7 +479,7 @@ export interface ImportJob {
   /**
    * Retrieves the status of the import job.
    */
-  getStatus: () => string;
+  getStatus: () => typeof ImportJobStatus;
 
   /**
    * Retrieves the baseURL of the import job.
@@ -505,6 +521,11 @@ export interface ImportJob {
    */
   getFailedCount: () => number;
 
+  /**
+   * Retrieves the redirect count of the import job.
+   */
+  getRedirectCount: () => number;
+
   /**
    * Retrieves the importQueueId of the import job.
    */
@@ -514,30 +535,43 @@ export interface ImportJob {
    * Retrieves the initiatedBy metadata (name, imsOrgId, imsUserId, userAgent) of the import job.
    */
   getInitiatedBy: () => object;
-
 }
 
 export interface ImportUrl {
   /**
    * Retrieves the ID of the import URL.
    */
-    getId: () => string;
+  getId: () => string;
 
   /**
    * Retrieves the status of the import URL.
    */
-    getStatus: () => string;
+  getStatus: () => typeof ImportUrlStatus;
 
   /**
    * Retrieves the URL of the import URL.
    */
-    getUrl: () => string;
+  getUrl: () => string;
 
   /**
    * Retrieves the job ID of the import URL.
    */
-    getJobId: () => string;
+  getJobId: () => string;
 
+  /**
+   * The reason that the import of a URL failed.
+   */
+  getReason: () => string;
+
+  /**
+   * The absolute path to the resource that is being imported for the given URL.
+   */
+  getFile: () => string;
+
+  /**
+   * Retrieves the resulting path and filename of the imported file.
+   */
+  getPath: () => string;
 }
 
 /**
@@ -853,13 +887,3 @@ export function createDataAccess(
   config: DataAccessConfig,
   logger: object,
 ): DataAccess;
-
-export interface ImportJobStatus {
-  RUNNING: string,
-  COMPLETE: string,
-  FAILED: string,
-}
-
-export interface ImportUrlStatus extends ImportJobStatus {
-  PENDING: string,
-}

package/src/index.js

@@ -11,8 +11,8 @@
  */
 
 import { createDataAccess } from './service/index.js';
-import { ImportJobStatus } from './models/importer/import-job.js';
-import { ImportUrlStatus } from './models/importer/import-url.js';
+
+export { ImportJobStatus, ImportUrlStatus, ImportOptions } from './models/importer/import-constants.js';
 
 const TABLE_NAME_AUDITS = 'spacecat-services-audits-dev';
 const TABLE_NAME_KEY_EVENTS = 'spacecat-services-key-events';
@@ -113,8 +113,3 @@ export default function dataAccessWrapper(fn) {
     return fn(request, context);
   };
 }
-
-export {
-  ImportJobStatus,
-  ImportUrlStatus,
-};

package/src/models/api-key.js

@@ -26,6 +26,7 @@ const scopeNames = [
   'imports.read',
   'imports.write',
   'imports.read_all',
+  'imports.write_all_domains',
 ];
 
 const ApiKey = (data) => {

package/src/models/importer/import-constants.js

@@ -0,0 +1,39 @@
+/*
+ * Copyright 2024 Adobe. All rights reserved.
+ * This file is licensed to you under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License. You may obtain a copy
+ * of the License at http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under
+ * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
+ * OF ANY KIND, either express or implied. See the License for the specific language
+ * governing permissions and limitations under the License.
+ */
+
+/**
+ * Supported Import Options.
+ */
+export const ImportOptions = {
+  ENABLE_JAVASCRIPT: 'enableJavascript',
+  PAGE_LOAD_TIMEOUT: 'pageLoadTimeout',
+};
+
+/**
+ * Import Job Status types.
+ * Any changes to this object needs to be reflected in the index.d.ts file as well.
+ */
+export const ImportJobStatus = {
+  RUNNING: 'RUNNING',
+  COMPLETE: 'COMPLETE',
+  FAILED: 'FAILED',
+};
+
+/**
+ * ImportURL Status types.
+ * Any changes to this object needs to be reflected in the index.d.ts file as well.
+ */
+export const ImportUrlStatus = {
+  PENDING: 'PENDING',
+  REDIRECT: 'REDIRECT',
+  ...ImportJobStatus,
+};

package/src/models/importer/import-job.js

@@ -14,22 +14,18 @@ import {
   hasText, isIsoDate, isValidUrl, isObject, isString, isNumber, isInteger,
 } from '@adobe/spacecat-shared-utils';
 import { Base } from '../base.js';
-
-export const ImportJobStatus = {
-  RUNNING: 'RUNNING',
-  COMPLETE: 'COMPLETE',
-  FAILED: 'FAILED',
-};
+import { ImportJobStatus, ImportOptions } from './import-constants.js';
 
 /**
  * Creates a new ImportJob object.
  *
- * @param {Object} importJobData - The data for the ImportJob object.
+ * @param {Object} data - The data for the ImportJob object.
  * @returns {ImportJob} The new ImportJob object.
  */
 const ImportJob = (data) => {
   const self = Base(data);
 
+  // generate get methods for all properties of our base object
   self.getBaseURL = () => self.state.baseURL;
   self.getHashedApiKey = () => self.state.hashedApiKey;
   self.getOptions = () => self.state.options;
@@ -40,131 +36,147 @@ const ImportJob = (data) => {
   self.getUrlCount = () => self.state.urlCount;
   self.getSuccessCount = () => self.state.successCount;
   self.getFailedCount = () => self.state.failedCount;
+  self.getRedirectCount = () => self.state.redirectCount;
   self.getImportQueueId = () => self.state.importQueueId;
   self.getInitiatedBy = () => self.state.initiatedBy;
 
   /**
-     * Updates the end time of the ImportJob.
-     * @param {string} endTime - The new end time.
-     * @returns {ImportJob} The updated ImportJob object.
-     */
-  self.updateEndTime = (endTime) => {
-    if (!isIsoDate(endTime)) {
-      throw new Error(`Invalid end time during update: ${endTime}`);
+   * Updates the state of the ImportJob.
+   * @param key - The key to update.
+   * @param value - The new value.
+   * @param validator - An optional validation function to use before updating the value.
+   * @returns {ImportJob} The updated ImportJob object.
+   */
+  const updateState = (key, value, validator) => {
+    if (validator && typeof validator === 'function') {
+      validator(value);
     }
 
-    self.state.endTime = endTime;
+    self.state[key] = value;
     self.touch();
 
     return self;
   };
 
   /**
-     * Updates the duration of the ImportJob.
-     * @param {number} duration - The new duration.
-     * @returns {ImportJob} The updated ImportJob object.
-     */
-  self.updateDuration = (duration) => {
-    if (!isNumber(duration)) {
-      throw new Error(`Invalid duration during update: ${duration}`);
+   * Updates the end time of the ImportJob.
+   * @param {string} endTime - The new end time in JavaScript ISO date string in Zulu (UTC)
+   * timezone. eg. 2024-05-29T14:36:00.000Z.
+   */
+  self.updateEndTime = (endTime) => updateState('endTime', endTime, (value) => {
+    if (!isIsoDate(value)) {
+      throw new Error(`Invalid end time during update: ${endTime}`);
     }
-
-    self.state.duration = duration;
-    self.touch();
-
-    return self;
-  };
+  });
 
   /**
-     * Updates the status of the ImportJob.
-     * @param {string} status - The new status.
-     * @returns {ImportJob} The updated ImportJob object.
-     */
-  self.updateStatus = (status) => {
-    if (!Object.values(ImportJobStatus).includes(status)) {
-      throw new Error(`Invalid Import Job status during update: ${status}`);
+   * Updates the duration of the ImportJob.
+   * @param {number} duration - The new duration.
+   */
+  self.updateDuration = (duration) => updateState('duration', duration, (value) => {
+    if (!isNumber(value)) {
+      throw new Error(`Invalid duration during update: ${value}`);
     }
+  });
 
-    self.state.status = status;
-    self.touch();
-
-    return self;
-  };
+  /**
+   * Updates the status of the ImportJob.
+   * @param {string} status - The new status.
+   */
+  self.updateStatus = (status) => updateState('status', status, (value) => {
+    if (!Object.values(ImportJobStatus).includes(value)) {
+      throw new Error(`Invalid Import Job status during update: ${value}`);
+    }
+  });
 
   /**
    * Updates the Url count of the ImportJob
    * @param {number} urlCount - The new url count.
-   * @returns {ImportJob} The updated ImportJob object.
    */
-  self.updateUrlCount = (urlCount) => {
-    if (!isInteger(urlCount)) {
-      throw new Error(`Invalid url count during update: ${urlCount}`);
+  self.updateUrlCount = (urlCount) => updateState('urlCount', urlCount, (value) => {
+    if (!isInteger(value)) {
+      throw new Error(`Invalid url count during update: ${value}`);
     }
-
-    self.state.urlCount = urlCount;
-    self.touch();
-
-    return self;
-  };
+  });
 
   /**
-     * Updates the success count of the ImportJob.
-     * @param {number} successCount - The new success count.
-     * @returns {ImportJob} The updated ImportJob object.
-     */
-  self.updateSuccessCount = (successCount) => {
-    if (!isInteger(successCount)) {
-      throw new Error(`Invalid success count during update: ${successCount}`);
+   * Updates the success count of the ImportJob.
+   * @param {number} successCount - The new success count.
+   * @returns {ImportJob} The updated ImportJob object.
+   */
+  self.updateSuccessCount = (successCount) => updateState('successCount', successCount, (value) => {
+    if (!isInteger(value) || value < 0) {
+      throw new Error(`Invalid success count during update: ${value}`);
     }
-
-    self.state.successCount = successCount;
-    self.touch();
-
-    return self;
-  };
+  });
 
   /**
-     * Updates the failed count of the ImportJob.
-     * @param {number} failedCount - The new failed count.
-     * @returns {ImportJob} The updated ImportJob object.
-     */
-  self.updateFailedCount = (failedCount) => {
-    if (!isInteger(failedCount)) {
-      throw new Error(`Invalid failed count during update: ${failedCount}`);
+   * Updates the failed count of the ImportJob.
+   * @param {number} failedCount - The new failed count.
+   * @returns {ImportJob} The updated ImportJob object.
+   */
+  self.updateFailedCount = (failedCount) => updateState('failedCount', failedCount, (value) => {
+    if (!isInteger(value) || value < 0) {
+      throw new Error(`Invalid failed count during update: ${value}`);
     }
-
-    self.state.failedCount = failedCount;
-    self.touch();
-
-    return self;
-  };
+  });
 
   /**
-     * Updates the import queue id of the ImportJob.
-     * @param {string} importQueueId - The new import queue id.
-     * @returns {ImportJob} The updated ImportJob object.
-     */
-  self.updateImportQueueId = (importQueueId) => {
-    if (!hasText(importQueueId)) {
-      throw new Error(`Invalid import queue id during update: ${importQueueId}`);
+   * Updates the redirect count of the ImportJob.
+   * @param {number} redirectCount - The new redirect count.
+   * @returns {ImportJob} The updated ImportJob object.
+   */
+  self.updateRedirectCount = (redirectCount) => updateState('redirectCount', redirectCount, (value) => {
+    if (!isInteger(value) || value < 0) {
+      throw new Error(`Invalid redirect count during update: ${value}`);
     }
+  });
 
-    self.state.importQueueId = importQueueId;
-    self.touch();
+  /**
+   * Updates the import queue id of the ImportJob.
+   * @param {string} importQueueId - The new import queue id.
+   * @returns {ImportJob} The updated ImportJob object.
+   */
+  self.updateImportQueueId = (importQueueId) => updateState(
+    'importQueueId',
+    importQueueId,
+    (value) => {
+      if (!hasText(importQueueId)) {
+        throw new Error(`Invalid import queue id during update: ${value}`);
+      }
+    },
+  );
 
-    return self;
-  };
   return Object.freeze(self);
 };
 
 /**
  * Creates a new ImportJob object.
- * @param {Object} importJobData - The data for the ImportJob object.
+ * @param {Object} data - The data for the ImportJob object.
  * @returns {ImportJob} The new ImportJob object.
  */
 export const createImportJob = (data) => {
+  // Define a list of data type validators for each import option
+  const ImportOptionTypeValidator = {
+    [ImportOptions.ENABLE_JAVASCRIPT]: (value) => {
+      if (value !== true && value !== false) {
+        throw new Error(`Invalid value for ${ImportOptions.ENABLE_JAVASCRIPT}: ${value}`);
+      }
+    },
+    [ImportOptions.PAGE_LOAD_TIMEOUT]: (value) => {
+      if (!isInteger(value) || value < 0) {
+        throw new Error(`Invalid value for ${ImportOptions.PAGE_LOAD_TIMEOUT}: ${value}`);
+      }
+    },
+  };
+
   const newState = { ...data };
 
+  // set default values for the start time if one is not provided
+  if (!hasText(newState.startTime)) {
+    newState.startTime = new Date().toISOString();
+  }
+
   if (!isValidUrl(newState.baseURL)) {
     throw new Error(`Invalid base URL: ${newState.baseURL}`);
   }
@@ -177,16 +189,30 @@ export const createImportJob = (data) => {
     throw new Error('"StartTime" should be a valid ISO string');
   }
 
-  if (!hasText(newState.startTime)) {
-    newState.startTime = new Date().toISOString();
-  }
-
   if (!Object.values(ImportJobStatus).includes(newState.status)) {
     throw new Error(`Invalid Import Job status ${newState.status}`);
   }
 
-  if (!isObject(newState.options)) {
-    throw new Error(`Invalid options: ${newState.options}`);
+  if (newState.options) {
+    if (!isObject(newState.options)) {
+      throw new Error(`Invalid options: ${newState.options}`);
+    }
+
+    const invalidOptions = Object.keys(newState.options).filter(
+      (key) => !Object.values(ImportOptions)
+        .some((value) => value.toLowerCase() === key.toLowerCase()),
+    );
+
+    if (invalidOptions.length > 0) {
+      throw new Error(`Invalid options: ${invalidOptions}`);
+    }
+
+    // validate each option for it's expected data type
+    Object.keys(newState.options).forEach((key) => {
+      if (ImportOptionTypeValidator[key]) {
+        ImportOptionTypeValidator[key](data.options[key]);
+      }
+    });
   }
 
   return ImportJob(newState);

package/src/models/importer/import-url.js

@@ -12,18 +12,12 @@
 
 import { hasText, isValidUrl } from '@adobe/spacecat-shared-utils';
 import { Base } from '../base.js';
-import { ImportJobStatus } from './import-job.js';
-
-export const ImportUrlStatus = {
-  PENDING: 'PENDING',
-  REDIRECT: 'REDIRECT',
-  ...ImportJobStatus,
-};
+import { ImportUrlStatus } from './import-constants.js';
 
 /**
  * Creates a new ImportUrl object
  *
- * @param {Object} importUrlData
+ * @param {Object} data
  * @returns {ImportUrl}
  */
 const ImportUrl = (data) => {
@@ -39,58 +33,53 @@ const ImportUrl = (data) => {
   self.getFile = () => self.state.file;
 
   /**
-   * Updates the status of the ImportUrl
+   * Updates the state of the ImportJob.
+   * @param key - The key to update.
+   * @param value - The new value.
+   * @param {Function} validator - An optional validation function to use before updating the value.
+   * The validator can return false to indicate that the value isn't worth throwing an exception,
+   * but continue to use the previous value.
    */
-  self.setStatus = (status) => {
-    if (!Object.values(ImportUrlStatus).includes(status)) {
-      throw new Error(`Invalid Import URL status during update: ${status}`);
+  const updateState = (key, value, validator) => {
+    if (validator && typeof validator === 'function') {
+      // a validator can return true or false to indicate if the value is valid
+      // however if a validator throws an error, it is considered critical and invalid.
+      if (!validator(value)) {
+        return self;
+      }
     }
 
-    self.state.status = status;
+    self.state[key] = value;
     self.touch();
 
     return self;
   };
 
   /**
-   * Updates the reason that the import of this URL was not successful
+   * Updates the status of the ImportUrl
    */
-  self.setReason = (reason) => {
-    if (!hasText(reason)) {
-      return self; // no-op
+  self.setStatus = (status) => updateState('status', status, (value) => {
+    if (!ImportUrlStatus[value]) {
+      throw new Error(`Invalid Import URL status during update: ${value}`);
     }
+    return true;
+  });
 
-    self.state.reason = reason;
-    self.touch();
-    return self;
-  };
+  /**
+   * Updates the reason that the import of this URL was not successful.
+   */
+  self.setReason = (reason) => updateState('reason', reason, hasText);
 
   /**
    * Updates the path of the ImportUrl
    */
-  self.setPath = (path) => {
-    if (!hasText(path)) {
-      return self; // no-op
-    }
-
-    self.state.path = path;
-    self.touch();
-    return self;
-  };
+  self.setPath = (path) => updateState('path', path, hasText);
 
   /**
    * Updates the file of the ImportUrl. This is the path and file name of the file which
    * was imported.
    */
-  self.setFile = (file) => {
-    if (!hasText(file)) {
-      return self; // no-op
-    }
-
-    self.state.file = file;
-    self.touch();
-    return self;
-  };
+  self.setFile = (file) => updateState('file', file, hasText);
 
   return Object.freeze(self);
 };

package/src/service/import-job/accessPatterns.js

@@ -40,7 +40,7 @@ export const getImportJobsByDateRange = async (dynamoClient, config, log, startD
 };
 
 /**
- * Get Import Job by ID
+ * Get Import Job by ID.
  * @param {DynamoClient} dynamoClient
  * @param {Object} config
  * @param {Logger} log
@@ -52,6 +52,7 @@ export const getImportJobByID = async (dynamoClient, config, log, id) => {
     config.tableNameImportJobs,
     { id },
   );
+
   return item ? ImportJobDto.fromDynamoItem(item) : null;
 };
 

package/src/service/import-url/accessPatterns.js

@@ -64,7 +64,7 @@ export const updateImportUrl = async (dynamoClient, config, log, importUrl) => {
   );
 
   if (!isObject(existingImportUrl)) {
-    throw new Error(`Import Url with ID:${importUrl.getId()} does not exist`);
+    throw new Error(`Import Url with ID: ${importUrl.getId()} does not exist`);
   }
 
   await dynamoClient.putItem(config.tableNameImportUrls, ImportUrlDto.toDynamoItem(importUrl));
@@ -98,12 +98,12 @@ export const getImportUrlsByJobIdAndStatus = async (dynamoClient, config, log, j
 };
 
 /**
- * Get Import Urls by Job ID
+ * Get Import Urls by Job ID, if no urls exist an empty array is returned.
  * @param {DynamoClient} dynamoClient
  * @param {Object} config
  * @param {Logger} log
  * @param {string} jobId
- * @returns {Promise<ImportUrl[]>}
+ * @returns {Promise<ImportUrlDto[]> | []}
  */
 export const getImportUrlsByJobId = async (dynamoClient, config, log, jobId) => {
   const items = await dynamoClient.query({
@@ -114,5 +114,6 @@ export const getImportUrlsByJobId = async (dynamoClient, config, log, jobId) =>
       ':jobId': jobId,
     },
   });
-  return items.map((item) => ImportUrlDto.fromDynamoItem(item));
+
+  return items ? items.map((item) => ImportUrlDto.fromDynamoItem(item)) : [];
 };