@adobe/spacecat-shared-data-access 1.21.0 → 1.21.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [@adobe/spacecat-shared-data-access-v1.21.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.21.0...@adobe/spacecat-shared-data-access-v1.21.1) (2024-04-01)
+
+
+### Bug Fixes
+
+* validate scores only needed ([#203](https://github.com/adobe/spacecat-shared/issues/203)) ([e2e4d14](https://github.com/adobe/spacecat-shared/commit/e2e4d14fa7d28bf2606b933c6c8f6f329c1ff33a))
+
 # [@adobe/spacecat-shared-data-access-v1.21.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.20.5...@adobe/spacecat-shared-data-access-v1.21.0) (2024-03-25)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-data-access",
-  "version": "1.21.0",
+  "version": "1.21.1",
   "description": "Shared modules of the Spacecat Services - Data Access",
   "type": "module",
   "main": "src/index.js",

package/src/models/audit.js

@@ -13,6 +13,7 @@
 import { hasText, isIsoDate, isObject } from '@adobe/spacecat-shared-utils';
 import { Base } from './base.js';
 
+// some of these unused exports are being imported from other projects. Handle with care.
 export const AUDIT_TYPE_404 = '404';
 export const AUDIT_TYPE_BROKEN_BACKLINKS = 'broken-backlinks';
 export const AUDIT_TYPE_EXPERIMENTATION = 'experimentation';
@@ -25,12 +26,6 @@ export const AUDIT_TYPE_LHS_MOBILE = 'lhs-mobile';
 const EXPIRES_IN_DAYS = 30;
 
 const AUDIT_TYPE_PROPERTIES = {
-  [AUDIT_TYPE_404]: [],
-  [AUDIT_TYPE_BROKEN_BACKLINKS]: [],
-  [AUDIT_TYPE_EXPERIMENTATION]: [],
-  [AUDIT_TYPE_ORGANIC_KEYWORDS]: [],
-  [AUDIT_TYPE_ORGANIC_TRAFFIC]: [],
-  [AUDIT_TYPE_CWV]: [],
   [AUDIT_TYPE_LHS_DESKTOP]: ['performance', 'seo', 'accessibility', 'best-practices'],
   [AUDIT_TYPE_LHS_MOBILE]: ['performance', 'seo', 'accessibility', 'best-practices'],
 };
@@ -52,13 +47,12 @@ const validateScores = (auditResult, auditType) => {
   }
 
   const expectedProperties = AUDIT_TYPE_PROPERTIES[auditType];
-  if (!expectedProperties) {
-    throw new Error(`Unknown audit type: ${auditType}`);
-  }
 
-  for (const prop of expectedProperties) {
-    if (!(prop in auditResult.scores)) {
-      throw new Error(`Missing expected property '${prop}' for audit type '${auditType}'`);
+  if (expectedProperties) {
+    for (const prop of expectedProperties) {
+      if (!(prop in auditResult.scores)) {
+        throw new Error(`Missing expected property '${prop}' for audit type '${auditType}'`);
+      }
     }
   }