@adobe/spacecat-shared-data-access 1.2.5 → 1.2.6

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [@adobe/spacecat-shared-data-access-v1.2.6](https://github.com/adobe-rnd/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.2.5...@adobe/spacecat-shared-data-access-v1.2.6) (2023-12-11)
+
+
+### Bug Fixes
+
+* include sites without latest audits ([#45](https://github.com/adobe-rnd/spacecat-shared/issues/45)) ([b843190](https://github.com/adobe-rnd/spacecat-shared/commit/b843190da09916832a743d6fc4bf83e804b61912))
+
 # [@adobe/spacecat-shared-data-access-v1.2.5](https://github.com/adobe-rnd/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.2.4...@adobe/spacecat-shared-data-access-v1.2.5) (2023-12-10)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-data-access",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "Shared modules of the Spacecat Services - Data Access",
   "type": "module",
   "main": "src/index.js",

package/src/service/sites/accessPatterns.js

@@ -55,7 +55,10 @@ export const getSitesToAudit = async (dynamoClient, config) => {
 };
 
 /**
- * Retrieves sites with their latest audit of a specified type.
+ * Retrieves sites with their latest audit of a specified type. If there is
+ * no audit of the specified type for a site, the site will be returned with
+ * an empty audits array.
+ * The audits are sorted ascending or descending by scores.
  *
  * @param {DynamoDbClient} dynamoClient - The DynamoDB client.
  * @param {DataAccessConfig} config - The data access config.
@@ -78,16 +81,17 @@ export const getSitesWithLatestAudit = async (
     getLatestAudits(dynamoClient, config, log, auditType, sortAuditsAscending),
   ]);
 
-  const sitesMap = new Map(sites.map((site) => [site.getId(), site]));
+  const auditsMap = new Map(latestAudits.map((audit) => [audit.getSiteId(), audit]));
 
-  return latestAudits.reduce((result, audit) => {
-    const site = sitesMap.get(audit.getSiteId());
-    if (site) {
+  return sites.map((site) => {
+    const audit = auditsMap.get(site.getId());
+    if (audit) {
       site.setAudits([audit]);
-      result.push(site);
+    } else {
+      site.setAudits([]);
     }
-    return result;
-  }, []);
+    return site;
+  });
 };
 
 /**