@adobe/spacecat-shared-data-access 1.1.1 → 1.1.2

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [@adobe/spacecat-shared-data-access-v1.1.2](https://github.com/adobe-rnd/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.1.1...@adobe/spacecat-shared-data-access-v1.1.2) (2023-12-02)
+
+
+### Bug Fixes
+
+* wrap scores ([#28](https://github.com/adobe-rnd/spacecat-shared/issues/28)) ([4733a93](https://github.com/adobe-rnd/spacecat-shared/commit/4733a93d2db087dd57f94955a2101e5a4bb74ce2))
+
 # [@adobe/spacecat-shared-data-access-v1.1.1](https://github.com/adobe-rnd/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.1.0...@adobe/spacecat-shared-data-access-v1.1.1) (2023-12-02)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/spacecat-shared-data-access",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "Shared modules of the Spacecat Services - Data Access",
   "type": "module",
   "main": "src/index.js",

package/src/models/audit.js

@@ -31,14 +31,14 @@ const AUDIT_TYPE_PROPERTIES = {
  * @param {string} auditType - The type of the audit.
  * @returns {boolean} - True if valid, false otherwise.
  */
-const validateAuditResult = (auditResult, auditType) => {
+const validateScores = (auditResult, auditType) => {
   const expectedProperties = AUDIT_TYPE_PROPERTIES[auditType];
   if (!expectedProperties) {
     throw new Error(`Unknown audit type: ${auditType}`);
   }
 
   for (const prop of expectedProperties) {
-    if (!(prop in auditResult)) {
+    if (!(prop in auditResult.scores)) {
       throw new Error(`Missing expected property '${prop}' for audit type '${auditType}'`);
     }
   }
@@ -61,7 +61,7 @@ const Audit = (data = {}) => {
   self.getExpiresAt = () => self.state.expiresAt;
   self.getFullAuditRef = () => self.state.fullAuditRef;
   self.isLive = () => self.state.isLive;
-  self.getScores = () => self.getAuditResult();
+  self.getScores = () => self.getAuditResult().scores;
 
   return Object.freeze(self);
 };
@@ -91,7 +91,7 @@ export const createAudit = (data) => {
     throw new Error('Audit result must be an object');
   }
 
-  validateAuditResult(data.auditResult, data.auditType);
+  validateScores(data.auditResult, data.auditType);
 
   if (!hasText(newState.fullAuditRef)) {
     throw new Error('Full audit ref must be provided');