@adobe/helix-rum-enhancer 2.6.0 → 2.7.1

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [2.7.1](https://github.com/adobe/helix-rum-enhancer/compare/v2.7.0...v2.7.1) (2024-04-18)
+
+
+### Bug Fixes
+
+* make targetselector null safe ([#156](https://github.com/adobe/helix-rum-enhancer/issues/156)) ([691d40d](https://github.com/adobe/helix-rum-enhancer/commit/691d40d1659d6aaac81f4037e11c243341181b80))
+
+# [2.7.0](https://github.com/adobe/helix-rum-enhancer/compare/v2.6.0...v2.7.0) (2024-04-18)
+
+
+### Features
+
+* add logic to capture target from wrapping anchor tag ([2a733b3](https://github.com/adobe/helix-rum-enhancer/commit/2a733b307d00c1a0613f645a01e325e683734625))
+
 # [2.6.0](https://github.com/adobe/helix-rum-enhancer/compare/v2.5.0...v2.6.0) (2024-04-16)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-rum-enhancer",
-  "version": "2.6.0",
+  "version": "2.7.1",
   "description": "Helix RUM Enhancer",
   "main": "src/index.js",
   "type": "module",

package/src/index.js

@@ -12,7 +12,6 @@
 /* eslint-env browser */
 const KNOWN_PROPERTIES = ['weight', 'id', 'referer', 'checkpoint', 't', 'source', 'target', 'cwv', 'CLS', 'FID', 'LCP', 'INP', 'TTFB'];
 const DEFAULT_TRACKING_EVENTS = ['click', 'cwv', 'form', 'enterleave', 'viewblock', 'viewmedia', 'loadresource', 'utm'];
-const SESSION_STORAGE_KEY = 'aem-rum';
 const { sampleRUM, queue, isSelected } = window.hlx.rum;
 
 const urlSanitizers = {
@@ -21,9 +20,15 @@ const urlSanitizers = {
   path: () => window.location.href.replace(/\?.*$/, ''),
 };
 
-const targetselector = (element) => {
-  let value = element.getAttribute('data-rum-target') || element.getAttribute('href')
+const getTargetValue = (element) => element.getAttribute('data-rum-target') || element.getAttribute('href')
     || element.currentSrc || element.getAttribute('src') || element.dataset.action || element.action;
+
+const targetselector = (element) => {
+  if (!element) return undefined;
+  let value = getTargetValue(element);
+  if (!value && element.tagName !== 'A' && element.closest('a')) {
+    value = getTargetValue(element.closest('a'));
+  }
   if (value && !value.startsWith('https://')) {
     // resolve relative links
     value = new URL(value, window.location).href;
@@ -113,8 +118,8 @@ function addCWVTracking() {
         data.cwv[measurement.name] = measurement.value;
         if (measurement.name === 'LCP' && measurement.entries.length > 0) {
           const { element } = measurement.entries.pop();
-          data.target = sampleRUM.targetselector(element);
-          data.source = sampleRUM.sourceselector(element) || element.outerHTML.slice(0, 30);
+          data.target = targetselector(element);
+          data.source = sourceselector(element) || element.outerHTML.slice(0, 30);
         }
         sampleRUM('cwv', data);
       };
@@ -286,9 +291,6 @@ function addTrackingFromConfig() {
 }
 
 function initEnhancer() {
-  // eslint-disable-next-line max-len
-  const rumStorage = sessionStorage.getItem(SESSION_STORAGE_KEY) ? JSON.parse(sessionStorage.getItem(SESSION_STORAGE_KEY)) : {};
-  sampleRUM('pagesviewed', { source: rumStorage.pages });
   addTrackingFromConfig();
   window.hlx.rum.collector = trackCheckpoint;
   processQueue();