@adobe/helix-rum-enhancer 2.39.0 → 2.40.0

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [2.40.0](https://github.com/adobe/helix-rum-enhancer/compare/v2.39.0...v2.40.0) (2025-07-29)
+
+
+### Features
+
+* escape invalid/special characters from source selector ([#438](https://github.com/adobe/helix-rum-enhancer/issues/438)) ([#452](https://github.com/adobe/helix-rum-enhancer/issues/452)) ([6918ffa](https://github.com/adobe/helix-rum-enhancer/commit/6918ffaffd22d9c444a85815bc26bc8ebf655900))
+
 # [2.39.0](https://github.com/adobe/helix-rum-enhancer/compare/v2.38.0...v2.39.0) (2025-07-28)
 
 

package/modules/dom.js

@@ -10,7 +10,7 @@
  * governing permissions and limitations under the License.
  */
 export const getTargetValue = (el) => el.getAttribute('data-rum-target') || el.getAttribute('href')
-    || el.currentSrc || el.getAttribute('src') || el.dataset.action || el.action;
+  || el.currentSrc || el.getAttribute('src') || el.dataset.action || el.action;
 
 export const targetSelector = (el) => {
   try {
@@ -20,7 +20,7 @@ export const targetSelector = (el) => {
       v = getTargetValue(el.closest('a'));
     }
     if (v && !v.startsWith('https://')) {
-    // resolve relative links
+      // resolve relative links
       v = new URL(v, window.location).href;
     }
     return v;
@@ -63,34 +63,34 @@ function getSourceContext(el) {
   if (formEl) {
     const id = formEl.getAttribute('id');
     if (id) {
-      return `form#${id}`;
+      return `form#${CSS.escape(id)}`;
     }
-    return `form${formEl.classList.length > 0 ? `.${formEl.classList[0]}` : ''}`;
+    return `form${formEl.classList.length > 0 ? `.${CSS.escape(formEl.classList[0])}` : ''}`;
   }
   const block = el.closest('.block[data-block-name]');
   return ((block && `.${block.getAttribute('data-block-name')}`)
     || (walk(el, isDialog) && 'dialog')
     || (walk(el, (e) => e.tagName && e.tagName.includes('-') && e.tagName.toLowerCase()))
     || ['nav', 'header', 'footer', 'aside'].find((t) => el.closest(t))
-    || walk(el, (e) => e.id && `#${e.id}`));
+    || walk(el, (e) => e.id && `#${CSS.escape(e.id)}`));
 }
 
 function getSourceElement(el) {
   const f = el.closest('form');
   if (f && Array.from(f.elements).includes(el)) {
     return (el.tagName.toLowerCase()
-        + (['INPUT', 'BUTTON'].includes(el.tagName)
-          ? `[type='${el.getAttribute('type') || ''}']`
-          : ''));
+      + (['INPUT', 'BUTTON'].includes(el.tagName)
+        ? `[type='${el.getAttribute('type') || ''}']`
+        : ''));
   }
   if (walk(el, isButton)) return 'button';
   return el.tagName.toLowerCase().match(/^(a|img|video|form)$/) && el.tagName.toLowerCase();
 }
 
 function getSourceIdentifier(el) {
-  if (el.id) return `#${el.id}`;
+  if (el.id) return `#${CSS.escape(el.id)}`;
   if (el.getAttribute('data-block-name')) return `.${el.getAttribute('data-block-name')}`;
-  return (el.classList.length > 0 && `.${el.classList[0]}`);
+  return (el.classList.length > 0 && `.${CSS.escape(el.classList[0])}`);
 }
 
 export const sourceSelector = (el) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-rum-enhancer",
-  "version": "2.39.0",
+  "version": "2.40.0",
   "description": "Helix RUM Enhancer",
   "main": "src/index.js",
   "type": "module",
@@ -60,7 +60,7 @@
     "lint-staged": "16.1.2",
     "mocha": "11.7.1",
     "mocha-multi-reporters": "1.5.1",
-    "rollup": "4.45.1",
+    "rollup": "4.46.1",
     "rollup-plugin-eslint-bundle": "9.0.0",
     "semantic-release": "24.2.7",
     "semantic-release-slack-bot": "^4.0.2",

package/src/index.js

@@ -82,12 +82,12 @@
     if (formEl) {
       const id = formEl.getAttribute('id');
       if (id) {
-        return `form#${id}`;
+        return `form#${CSS.escape(id)}`;
       }
-      return `form${formEl.classList.length > 0 ? `.${formEl.classList[0]}` : ''}`;
+      return `form${formEl.classList.length > 0 ? `.${CSS.escape(formEl.classList[0])}` : ''}`;
     }
     const block = el.closest('.block[data-block-name]');
-    return block && `.${block.getAttribute('data-block-name')}` || walk(el, isDialog) && 'dialog' || walk(el, e => e.tagName && e.tagName.includes('-') && e.tagName.toLowerCase()) || ['nav', 'header', 'footer', 'aside'].find(t => el.closest(t)) || walk(el, e => e.id && `#${e.id}`);
+    return block && `.${block.getAttribute('data-block-name')}` || walk(el, isDialog) && 'dialog' || walk(el, e => e.tagName && e.tagName.includes('-') && e.tagName.toLowerCase()) || ['nav', 'header', 'footer', 'aside'].find(t => el.closest(t)) || walk(el, e => e.id && `#${CSS.escape(e.id)}`);
   }
   function getSourceElement(el) {
     const f = el.closest('form');
@@ -98,9 +98,9 @@
     return el.tagName.toLowerCase().match(/^(a|img|video|form)$/) && el.tagName.toLowerCase();
   }
   function getSourceIdentifier(el) {
-    if (el.id) return `#${el.id}`;
+    if (el.id) return `#${CSS.escape(el.id)}`;
     if (el.getAttribute('data-block-name')) return `.${el.getAttribute('data-block-name')}`;
-    return el.classList.length > 0 && `.${el.classList[0]}`;
+    return el.classList.length > 0 && `.${CSS.escape(el.classList[0])}`;
   }
   const sourceSelector = el => {
     try {

package/src/index.md5

@@ -1 +1 @@
-c69c2dbd6602a4f9ddaabfb336dbf6c3
+12d31296a6a7ae88c3e6f8545975c5ed

package/src/index.sri

@@ -1 +1 @@
-sha384-I5K6alRMVQ/PEU4HdrN6eVdLhmFyFiprozg8vhN5h5gNbohsTdZ5JO5imnjM8Ccv
+sha384-3VwEyTYUZI9gWm9M9J5acrD5Ub8kFjJ8DckCos5iDVXHKrJni6mlz9VV89dKwmWa

package/src/plugins/a11y.md5

@@ -1 +1 @@
-ca3630c51ee48da2595696b4b11cb586
+411af2624f736f7385cfb1230be854c3

package/src/plugins/onetrust.md5

@@ -1 +1 @@
-c00518b019647f564ce00dce9d07c74b
+4b5cf6c41be188be11c519f419592e7e