@adobe/helix-rum-enhancer 2.31.0-beta.4 → 2.31.0-beta.5

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [2.31.0-beta.5](https://github.com/adobe/helix-rum-enhancer/compare/v2.31.0-beta.4...v2.31.0-beta.5) (2025-01-17)
+
+
+### Bug Fixes
+
+* just forcing a release ([84ab687](https://github.com/adobe/helix-rum-enhancer/commit/84ab68734b5862816a532d4847df0ffa753b0717))
+
 # [2.31.0-beta.4](https://github.com/adobe/helix-rum-enhancer/compare/v2.31.0-beta.3...v2.31.0-beta.4) (2025-01-16)
 
 

package/modules/index.js

@@ -29,16 +29,18 @@ const [blocksMO, mediaMO] = [blocksMCB, mediaMCB].map(createMO);
 // Check for the presence of a given cookie
 const hasCookieKey = (key) => () => document.cookie.split(';').some((c) => c.trim().startsWith(`${key}=`));
 
+// Set the base path for the plugins
 const pluginBasePath = new URL(document.currentScript.src).href.replace(/index(\.map)?\.js/, 'plugins');
 
 const PLUGINS = {
   cwv: `${pluginBasePath}/cwv.js`,
   // Interactive elements
-  form: { url: `${pluginBasePath}/form.js`, condition: () => document.querySelector('form'), isBlockDependent: true },
-  video: { url: `${pluginBasePath}/video.js`, condition: () => document.querySelector('video'), isBlockDependent: true },
+  form: { url: `${pluginBasePath}/form.js`, when: () => document.querySelector('form'), isBlockDependent: true },
+  video: { url: `${pluginBasePath}/video.js`, when: () => document.querySelector('video'), isBlockDependent: true },
   // Martech
-  martech: { url: `${pluginBasePath}/martech.js`, condition: ({ urlParameters }) => urlParameters.size > 0 },
-  onetrust: { url: `${pluginBasePath}/onetrust.js`, condition: () => (document.querySelector('#onetrust-consent-sdk') || hasCookieKey('OptanonAlertBoxClosed')), isBlockDependent: true },
+  martech: { url: `${pluginBasePath}/martech.js`, when: ({ urlParameters }) => urlParameters.size > 0 },
+  onetrust: { url: `${pluginBasePath}/onetrust.js`, when: () => (document.querySelector('#onetrust-consent-sdk') || hasCookieKey('OptanonAlertBoxClosed')), isBlockDependent: true },
+  // test: broken-plugin
 };
 
 const PLUGIN_PARAMETERS = {
@@ -54,19 +56,16 @@ const pluginCache = new Map();
 function loadPlugin(key, params) {
   const plugin = PLUGINS[key];
   const usp = new URLSearchParams(window.location.search);
-  if (!pluginCache.has(key) && plugin.condition && !plugin.condition({ urlParameters: usp })) {
+  if (!pluginCache.has(key) && plugin.when && !plugin.when({ urlParameters: usp })) {
     return null;
   }
   if (!pluginCache.has(key)) {
-    try {
-      pluginCache.set(key, import(`${plugin.url || plugin}`));
-    } catch (e) {
-      return null;
-    }
+    pluginCache.set(key, import(`${plugin.url || plugin}`));
   }
   const pluginLoadPromise = pluginCache.get(key);
   return pluginLoadPromise
-    .then((p) => (p.default && p.default(params)) || (typeof p === 'function' && p(params)));
+    .then((p) => (p.default && p.default(params)) || (typeof p === 'function' && p(params)))
+    .catch(() => { /* silent plugin error catching */ });
 }
 
 function loadPlugins(filter = () => true, params = PLUGIN_PARAMETERS) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-rum-enhancer",
-  "version": "2.31.0-beta.4",
+  "version": "2.31.0-beta.5",
   "description": "Helix RUM Enhancer",
   "main": "src/index.js",
   "type": "module",

package/src/index.js

@@ -136,23 +136,23 @@
     cwv: `${pluginBasePath}/cwv.js`,
     form: {
       url: `${pluginBasePath}/form.js`,
-      condition: () => document.querySelector('form'),
+      when: () => document.querySelector('form'),
       isBlockDependent: true
     },
     video: {
       url: `${pluginBasePath}/video.js`,
-      condition: () => document.querySelector('video'),
+      when: () => document.querySelector('video'),
       isBlockDependent: true
     },
     martech: {
       url: `${pluginBasePath}/martech.js`,
-      condition: ({
+      when: ({
         urlParameters
       }) => urlParameters.size > 0
     },
     onetrust: {
       url: `${pluginBasePath}/onetrust.js`,
-      condition: () => document.querySelector('#onetrust-consent-sdk') || hasCookieKey('OptanonAlertBoxClosed'),
+      when: () => document.querySelector('#onetrust-consent-sdk') || hasCookieKey('OptanonAlertBoxClosed'),
       isBlockDependent: true
     }
   };
@@ -167,20 +167,16 @@
   function loadPlugin(key, params) {
     const plugin = PLUGINS[key];
     const usp = new URLSearchParams(window.location.search);
-    if (!pluginCache.has(key) && plugin.condition && !plugin.condition({
+    if (!pluginCache.has(key) && plugin.when && !plugin.when({
       urlParameters: usp
     })) {
       return null;
     }
     if (!pluginCache.has(key)) {
-      try {
-        pluginCache.set(key, import(`${plugin.url || plugin}`));
-      } catch (e) {
-        return null;
-      }
+      pluginCache.set(key, import(`${plugin.url || plugin}`));
     }
     const pluginLoadPromise = pluginCache.get(key);
-    return pluginLoadPromise.then(p => p.default && p.default(params) || typeof p === 'function' && p(params));
+    return pluginLoadPromise.then(p => p.default && p.default(params) || typeof p === 'function' && p(params)).catch(() => {});
   }
   function loadPlugins(filter = () => true, params = PLUGIN_PARAMETERS) {
     Object.entries(PLUGINS).filter(([, plugin]) => filter(plugin)).map(([key]) => loadPlugin(key, params));

package/src/index.md5

@@ -1 +1 @@
-4496e739d9016b3ea998093c5552cd22
+6927b0ca98e3d69c532b6b104f0ffb14

package/src/plugins/cwv.md5

@@ -1 +1 @@
-0175624433f85a59db5522a50fe580b7
+102443b9b53f78e1540d0bb8afa8d769

package/src/plugins/form.md5

@@ -1 +1 @@
-1c696968df786f64dd52b97922bfd98a
+089e973dcd9f9b5796c161c18e88647f

package/src/plugins/video.md5

@@ -1 +1 @@
-a058b9abed9074b20828bc07cd615ad6
+ff797faa2362e5adf389383b0e6422d1

package/web-test-runner.config.js

@@ -58,6 +58,15 @@ export default {
           // rewriting dynamic plugins base url
           .replace(/document\.currentScript\.src/g, '"http://localhost:8000/plugins"');
         return true;
+      } else if (context.url.startsWith('/modules/index-broken.js')) {
+        const [_, search] = context.url.split('?');
+        context.url = `/modules/index.js?${search}`;
+        await next();
+        context.body = context.body
+          // rewriting dynamic plugins base url
+          .replace(/document\.currentScript\.src/g, '"http://localhost:8000/plugins"')
+          .replace(/\/\/ test: broken-plugin/g, 'foo: "foo.js",');
+        return true;
       } else if (context.url.startsWith('/.rum')) {
         if (context.url.startsWith('/.rum/@adobe/helix-rum-js@%5E2/dist/')
           || context.url.startsWith('/.rum/@adobe/helix-rum-js@^2/dist/')