@adobe/helix-rum-enhancer 2.30.0 → 2.30.2

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [2.30.2](https://github.com/adobe/helix-rum-enhancer/compare/v2.30.1...v2.30.2) (2025-01-17)
+
+
+### Bug Fixes
+
+* do not trigger fill checkpoint for hidden fields ([f6f4c51](https://github.com/adobe/helix-rum-enhancer/commit/f6f4c519d38c48740ace4ba64f47cafc6cea2f47))
+
+## [2.30.1](https://github.com/adobe/helix-rum-enhancer/compare/v2.30.0...v2.30.1) (2025-01-17)
+
+
+### Bug Fixes
+
+* form elements having name/id as id breaks the sourceSelector logic. ([37bd0ab](https://github.com/adobe/helix-rum-enhancer/commit/37bd0ab4c6bb1aac1326bc9be0097a7ccf038870))
+
 # [2.30.0](https://github.com/adobe/helix-rum-enhancer/compare/v2.29.0...v2.30.0) (2025-01-15)
 
 

package/README.md

@@ -62,10 +62,6 @@ All three parts are optional
 Even if an `identifier` is provided, having a `context` and `element` is recommended, as it makes the `source` parameter more readable and easier to understand.
 
 
-#### Examples
-
-- ``
-
 ## Development
 
 ### Build
@@ -85,3 +81,6 @@ $ npm test
 ```bash
 $ npm run lint
 ```
+### Cutting a Pre-Release
+
+Releases are handled by [semantic-release](https://github.com/semantic-release/semantic-release), and will happen automatically when a PR is merged into the `main` or the `1.x` branch. By merging into `beta`, a pre-release will be created.

package/modules/dom.js

@@ -41,12 +41,10 @@ function isDialog(el) {
   // doing it well
   if (el.tagName === 'DIALOG') return true;
   // making the best of it
-  if (el.getAttribute('role') === 'dialog') return true;
-  if (el.getAttribute('role') === 'alertdialog') return true;
-  if (el.getAttribute('aria-modal') === 'true') return true;
-  // doing it wrong
   const cs = window.getComputedStyle(el);
-  return (cs && cs.position === 'fixed' && cs.zIndex > 100);
+  return ['dialog', 'alertdialog'].find((r) => el.getAttribute('role') === r)
+    || el.getAttribute('aria-modal') === 'true'
+    || (cs && cs.position === 'fixed' && cs.zIndex > 100);
 }
 
 function isButton(el) {
@@ -62,16 +60,14 @@ function isButton(el) {
 function getSourceContext(el) {
   const formEl = el.closest('form');
   if (formEl) {
-    return `form${formEl.id ? `#${formEl.id}` : ''}`;
+    const id = formEl.getAttribute('id');
+    return `form${id ? `#${id}` : ''}`;
   }
   const block = el.closest('.block[data-block-name]');
-  if (block) return `.${block.getAttribute('data-block-name')}`;
-  if (walk(el, isDialog)) return 'dialog';
-  if (el.closest('nav')) return 'nav';
-  if (el.closest('header')) return 'header';
-  if (el.closest('footer')) return 'footer';
-  if (el.closest('aside')) return 'aside';
-  return (walk(el, (e) => e.id && `#${e.id}`));
+  return ((block && `.${block.getAttribute('data-block-name')}`)
+    || (walk(el, isDialog) && 'dialog')
+    || ['nav', 'header', 'footer', 'aside'].find((t) => el.closest(t))
+    || walk(el, (e) => e.id && `#${e.id}`));
 }
 
 function getSourceElement(el) {

package/modules/index.js

@@ -258,10 +258,12 @@ function addFormTracking(parent) {
     form.addEventListener('submit', (e) => sampleRUM('formsubmit', { target: targetSelector(e.target), source: sourceSelector(e.target) }), { once: true });
     let lastSource;
     form.addEventListener('change', (e) => {
-      const source = sourceSelector(e.target);
-      if (source !== lastSource) {
-        sampleRUM('fill', { source });
-        lastSource = source;
+      if (e.target.checkVisibility()) {
+        const source = sourceSelector(e.target);
+        if (source !== lastSource) {
+          sampleRUM('fill', { source });
+          lastSource = source;
+        }
       }
     });
     form.addEventListener('focusin', (e) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-rum-enhancer",
-  "version": "2.30.0",
+  "version": "2.30.2",
   "description": "Helix RUM Enhancer",
   "main": "src/index.js",
   "type": "module",

package/src/index.js

@@ -63,11 +63,10 @@
   }
   function isDialog(el) {
     if (el.tagName === 'DIALOG') return true;
-    if (el.getAttribute('role') === 'dialog') return true;
-    if (el.getAttribute('role') === 'alertdialog') return true;
-    if (el.getAttribute('aria-modal') === 'true') return true;
     const cs = window.getComputedStyle(el);
-    return (cs && cs.position === 'fixed' && cs.zIndex > 100);
+    return ['dialog', 'alertdialog'].find((r) => el.getAttribute('role') === r)
+      || el.getAttribute('aria-modal') === 'true'
+      || (cs && cs.position === 'fixed' && cs.zIndex > 100);
   }
   function isButton(el) {
     if (el.tagName === 'BUTTON') return true;
@@ -81,16 +80,14 @@
   function getSourceContext(el) {
     const formEl = el.closest('form');
     if (formEl) {
-      return `form${formEl.id ? `#${formEl.id}` : ''}`;
+      const id = formEl.getAttribute('id');
+      return `form${id ? `#${id}` : ''}`;
     }
     const block = el.closest('.block[data-block-name]');
-    if (block) return `.${block.getAttribute('data-block-name')}`;
-    if (walk(el, isDialog)) return 'dialog';
-    if (el.closest('nav')) return 'nav';
-    if (el.closest('header')) return 'header';
-    if (el.closest('footer')) return 'footer';
-    if (el.closest('aside')) return 'aside';
-    return (walk(el, (e) => e.id && `#${e.id}`));
+    return ((block && `.${block.getAttribute('data-block-name')}`)
+      || (walk(el, isDialog) && 'dialog')
+      || ['nav', 'header', 'footer', 'aside'].find((t) => el.closest(t))
+      || walk(el, (e) => e.id && `#${e.id}`));
   }
   function getSourceElement(el) {
     const f = el.closest('form');
@@ -390,10 +387,12 @@
       form.addEventListener('submit', (e) => sampleRUM('formsubmit', { target: targetSelector(e.target), source: sourceSelector(e.target) }), { once: true });
       let lastSource;
       form.addEventListener('change', (e) => {
-        const source = sourceSelector(e.target);
-        if (source !== lastSource) {
-          sampleRUM('fill', { source });
-          lastSource = source;
+        if (e.target.checkVisibility()) {
+          const source = sourceSelector(e.target);
+          if (source !== lastSource) {
+            sampleRUM('fill', { source });
+            lastSource = source;
+          }
         }
       });
       form.addEventListener('focusin', (e) => {

package/src/index.md5

@@ -1 +1 @@
-5424a86261f2304969b6951549ac3941
+389f38e9847798177fc9bd3f8f9b763b