@adobe/helix-rum-enhancer 2.24.0 → 2.25.0

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [2.25.0](https://github.com/adobe/helix-rum-enhancer/compare/v2.24.0...v2.25.0) (2024-10-03)
+
+
+### Features
+
+* capturing id of form and button type inside a form ([#293](https://github.com/adobe/helix-rum-enhancer/issues/293)) ([530572f](https://github.com/adobe/helix-rum-enhancer/commit/530572f7c441c72f8d5f7683bef7490d37186a9f))
+
 # [2.24.0](https://github.com/adobe/helix-rum-enhancer/compare/v2.23.0...v2.24.0) (2024-09-20)
 
 

package/modules/dom.js

@@ -61,7 +61,9 @@ function isButton(element) {
 }
 
 function getSourceContext(element) {
-  if (element.closest('form')) return 'form';
+  if (element.closest('form')) {
+    return `form${element.id ? `#${element.id}` : ''}`;
+  }
   const block = element.closest('.block[data-block-name]');
   if (block) return `.${block.getAttribute('data-block-name')}`;
   if (walk(element, isDialog)) return 'dialog';
@@ -73,7 +75,12 @@ function getSourceContext(element) {
 }
 
 function getSourceElement(element) {
-  if (element.closest('form') && Array.from(element.closest('form').elements).includes(element)) return element.tagName.toLowerCase() + (element.tagName === 'INPUT' ? `[type='${element.getAttribute('type') || ''}']` : '');
+  if (element.closest('form') && Array.from(element.closest('form').elements).includes(element)) {
+    return (element.tagName.toLowerCase()
+        + (['INPUT', 'BUTTON'].includes(element.tagName)
+          ? `[type='${element.getAttribute('type') || ''}']`
+          : ''));
+  }
   if (walk(element, isButton)) return 'button';
   return element.tagName.toLowerCase().match(/^(a|img|video)$/) && element.tagName.toLowerCase();
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-rum-enhancer",
-  "version": "2.24.0",
+  "version": "2.25.0",
   "description": "Helix RUM Enhancer",
   "main": "src/index.js",
   "type": "module",
@@ -49,16 +49,16 @@
     "eslint-plugin-header": "3.1.1",
     "eslint-plugin-import": "2.30.0",
     "husky": "9.1.6",
-    "jsdoc-to-markdown": "9.0.1",
-    "junit-report-builder": "5.0.0",
+    "jsdoc-to-markdown": "9.0.2",
+    "junit-report-builder": "5.1.1",
     "lint-staged": "15.2.10",
     "mocha": "10.7.3",
     "mocha-multi-reporters": "1.5.1",
-    "rollup": "4.21.3",
+    "rollup": "4.24.0",
     "rollup-plugin-checksum": "1.0.1",
     "rollup-plugin-cleanup": "3.2.1",
     "rollup-plugin-eslint-bundle": "9.0.0",
-    "semantic-release": "24.1.1",
+    "semantic-release": "24.1.2",
     "semantic-release-slack-bot": "^4.0.2",
     "web-vitals": "4.2.3"
   },

package/src/index.js

@@ -80,7 +80,9 @@
     return element.getAttribute('role') === 'button';
   }
   function getSourceContext(element) {
-    if (element.closest('form')) return 'form';
+    if (element.closest('form')) {
+      return `form${element.id ? `#${element.id}` : ''}`;
+    }
     const block = element.closest('.block[data-block-name]');
     if (block) return `.${block.getAttribute('data-block-name')}`;
     if (walk(element, isDialog)) return 'dialog';
@@ -91,7 +93,12 @@
     return (walk(element, (e) => e.id && `#${e.id}`));
   }
   function getSourceElement(element) {
-    if (element.closest('form') && Array.from(element.closest('form').elements).includes(element)) return element.tagName.toLowerCase() + (element.tagName === 'INPUT' ? `[type='${element.getAttribute('type') || ''}']` : '');
+    if (element.closest('form') && Array.from(element.closest('form').elements).includes(element)) {
+      return (element.tagName.toLowerCase()
+          + (['INPUT', 'BUTTON'].includes(element.tagName)
+            ? `[type='${element.getAttribute('type') || ''}']`
+            : ''));
+    }
     if (walk(element, isButton)) return 'button';
     return element.tagName.toLowerCase().match(/^(a|img|video)$/) && element.tagName.toLowerCase();
   }

package/src/index.md5

@@ -1 +1 @@
-734919c8255ab6180ebd17f83f09b78f
+f87fdcb7d5c1e4526225b185d4f392fb