@adobe/helix-onedrive-support 8.2.8 → 8.3.0

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [8.3.0](https://github.com/adobe/helix-onedrive-support/compare/v8.2.8...v8.3.0) (2022-09-10)
+
+
+### Features
+
+* support delete column ([#298](https://github.com/adobe/helix-onedrive-support/issues/298)) ([9e41fbd](https://github.com/adobe/helix-onedrive-support/commit/9e41fbdb091f372314bb2311a1c912315c108111))
+
 ## [8.2.8](https://github.com/adobe/helix-onedrive-support/compare/v8.2.7...v8.2.8) (2022-09-03)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-onedrive-support",
-  "version": "8.2.8",
+  "version": "8.3.0",
   "description": "Helix OneDrive Support",
   "main": "src/index.js",
   "exports": {

package/src/OneDriveMock.js

@@ -96,6 +96,7 @@ function handleTable(container, segs, method, body) {
   }
   let command;
   let name;
+  let index;
   if (segs[0]) {
     [, command, , name] = segs.shift().match(/([^?(]+)(\('([^)]+)'\))?(\?(.+))?/);
   }
@@ -113,7 +114,7 @@ function handleTable(container, segs, method, body) {
         table.rows.push(...body.values);
         return { index: table.rows.length - 1 };
       }
-      const index = parseInt(subCommand.replace(/itemAt\(index=([0-9]+)\)/, '$1'), 10);
+      index = parseInt(subCommand.replace(/itemAt\(index=([0-9]+)\)/, '$1'), 10);
       if (index < 0 || index >= table.rows.length) {
         throw new StatusCodeError(`Index out of range: ${index}`, 400);
       }
@@ -127,7 +128,27 @@ function handleTable(container, segs, method, body) {
       return { values: [table.rows[index]] };
     }
     case 'columns': {
+      if (method === 'DELETE') {
+        const headerName = segs.shift();
+        index = table.headerNames.indexOf(headerName);
+        if (index === -1) {
+          throw new StatusCodeError(`Column name not found: ${headerName}`, 400);
+        }
+        table.headerNames.splice(index, 1);
+        table.rows.forEach((row) => {
+          row.splice(index, 1);
+        });
+        return null;
+      }
+      if (body) {
+        ({ name, index = table.headerNames.length } = body);
+        table.headerNames.splice(index, 0, name);
+        table.rows.forEach((row) => {
+          row.splice(index, 0, '');
+        });
+      }
       if (!name) {
+        // return all columns and their data
         const cols = table.headerNames.map((n) => ({
           name: n,
           values: [[n]],
@@ -142,7 +163,7 @@ function handleTable(container, segs, method, body) {
         };
       }
       const columnName = name;
-      const index = table.headerNames.findIndex((n) => n === columnName);
+      index = table.headerNames.findIndex((n) => n === columnName);
       if (index === -1) {
         throw new StatusCodeError(`Column name not found: ${columnName}`, 400);
       }

package/src/excel/Table.d.ts

@@ -86,11 +86,17 @@ export declare interface Table {
    */
    getColumn(name: string): Promise<string[]>;
 
-   /**
+  /**
    * Add a column to an existing table
    * @param name name of new column
    * @param index zero-based index or missing to add at end
    * @returns new column
    */
-   addColumn(name:string, index?:number): Promise<DriveItem>;
+  addColumn(name:string, index?:number): Promise<DriveItem>;
+
+  /**
+   * Delete a column from the table
+   * @param name column name
+   */
+  deleteColumn(name: string): Promise<void>;
 }

package/src/excel/Table.js

@@ -116,7 +116,7 @@ export class Table {
     const body = {
       name,
     };
-    if (index) {
+    if (index !== undefined) {
       body.index = index;
     }
     return this._oneDrive.doFetch(`${this.uri}/columns`, false, {
@@ -125,6 +125,12 @@ export class Table {
     });
   }
 
+  async deleteColumn(name) {
+    return this._oneDrive.doFetch(`${this.uri}/columns/${name}`, true, {
+      method: 'DELETE',
+    });
+  }
+
   get name() {
     return this._name;
   }

package/src/excel/Workbook.d.ts

@@ -51,7 +51,7 @@ export declare interface Workbook {
    * @param hasHeaders whether the table has headers
    * @param name optional name
    */
-   addTable(address: string, hasHeaders: boolean, name?: string): Promise<Table>;
+  addTable(address: string, hasHeaders: boolean, name?: string): Promise<Table>;
 
   /**
    * Return the named items in a work book

package/src/excel/Worksheet.d.ts

@@ -82,5 +82,5 @@ export declare interface Worksheet {
    * Returns a new range object that spans the address given
    * @param address address, e.g. A1:C2
    */
-   range(address): Range;
+  range(address): Range;
 }