@adobe/helix-onedrive-support 11.0.2 → 11.0.3

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [11.0.3](https://github.com/adobe/helix-onedrive-support/compare/v11.0.2...v11.0.3) (2023-10-21)
+
+
+### Bug Fixes
+
+* report authenticate failures as 401 ([#454](https://github.com/adobe/helix-onedrive-support/issues/454)) ([26caba0](https://github.com/adobe/helix-onedrive-support/commit/26caba08586beecb08bf88ed5e0afe9032fbb9ae))
+
 ## [11.0.2](https://github.com/adobe/helix-onedrive-support/compare/v11.0.1...v11.0.2) (2023-10-20)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-onedrive-support",
-  "version": "11.0.2",
+  "version": "11.0.3",
   "description": "Helix OneDrive Support",
   "main": "src/index.js",
   "exports": {

package/src/OneDrive.js

@@ -218,7 +218,7 @@ export class OneDrive {
     try {
       return await this.doFetch(`/shares/${link}/driveItem`);
     } catch (e) {
-      if (e.statusCode === 401 || e.statusCode === 403) {
+      if ((e.statusCode === 401 && e.details?.code !== 'silentAcquireFailed') || e.statusCode === 403) {
         // an inexistent share returns either 401 or 403, we prefer to just say it wasn't found
         throw new StatusCodeError(e.message, 404, e.details);
       }
@@ -535,7 +535,7 @@ export class OneDrive {
         log: this.log,
       });
     } catch (e) {
-      if (e.statusCode === 401) {
+      if (e.statusCode === 401 && e.details?.code !== 'silentAcquireFailed') {
         // an inexistant share returns 401, we prefer to just say it wasn't found
         throw new StatusCodeError(e.message, 404, e.details);
       }

package/src/OneDriveAuth.js

@@ -15,6 +15,7 @@ import { keepAliveNoCache } from '@adobe/fetch';
 import { ConfidentialClientApplication, LogLevel, PublicClientApplication } from '@azure/msal-node';
 import { MemCachePlugin } from '@adobe/helix-shared-tokencache';
 import { decodeJwt } from 'jose';
+import { StatusCodeError } from './StatusCodeError.js';
 
 const AZ_AUTHORITY_HOST_URL = 'https://login.windows.net';
 const AZ_COMMON_TENANT = 'common';
@@ -343,7 +344,8 @@ export class OneDriveAuth {
       throw e;
     }
 
-    throw new Error('Unable to acquire token silently and no other acquire method supplied');
+    const message = 'Unable to acquire token silently and no other acquire method supplied';
+    throw new StatusCodeError(message, 401, { code: 'silentAcquireFailed', message });
   }
 
   /**