@adobe/helix-md2jcr 1.1.29 → 1.1.31

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [1.1.31](https://github.com/adobe/helix-md2jcr/compare/v1.1.30...v1.1.31) (2025-08-17)
+
+
+### Bug Fixes
+
+* custom sections/normal sections should identify their model ([#137](https://github.com/adobe/helix-md2jcr/issues/137)) ([2d69b7a](https://github.com/adobe/helix-md2jcr/commit/2d69b7a84dfd4717cd1fe3757a0c47dff28ccb6a)), closes [#136](https://github.com/adobe/helix-md2jcr/issues/136)
+
+## [1.1.30](https://github.com/adobe/helix-md2jcr/compare/v1.1.29...v1.1.30) (2025-08-12)
+
+
+### Bug Fixes
+
+* ignore any inline images ([#135](https://github.com/adobe/helix-md2jcr/issues/135)) ([be36770](https://github.com/adobe/helix-md2jcr/commit/be3677000b55c3e19d0f05fff7223c9f227e6bfc)), closes [#134](https://github.com/adobe/helix-md2jcr/issues/134)
+
 ## [1.1.29](https://github.com/adobe/helix-md2jcr/compare/v1.1.28...v1.1.29) (2025-07-29)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-md2jcr",
-  "version": "1.1.29",
+  "version": "1.1.31",
   "description": "Helix Service that converts markdown to JCR content structure",
   "main": "src/index.js",
   "type": "module",
@@ -54,8 +54,8 @@
     "xml-formatter": "^3.6.3"
   },
   "devDependencies": {
-    "@adobe/eslint-config-helix": "3.0.8",
-    "@adobe/helix-mediahandler": "2.7.21",
+    "@adobe/eslint-config-helix": "3.0.9",
+    "@adobe/helix-mediahandler": "2.7.23",
     "@commitlint/cli": "^19.6.1",
     "@commitlint/config-conventional": "^19.6.0",
     "@semantic-release/changelog": "6.0.3",
@@ -70,7 +70,7 @@
     "eslint-plugin-import": "2.32.0",
     "husky": "^9.1.7",
     "junit-report-builder": "5.1.1",
-    "lint-staged": "16.1.2",
+    "lint-staged": "16.1.5",
     "mocha": "11.7.1",
     "mocha-multi-reporters": "1.5.1",
     "nock": "13.5.6",

package/src/mdast2jcr/hb/helpers/section-helper.js

@@ -134,7 +134,10 @@ function findSectionMetadata(children, models) {
     const result = processMetadataRows(rows, model);
 
     return {
-      attributes: result.attributes,
+      attributes: {
+        ...result.attributes,
+        model: sectionModelId || 'section',
+      },
       modelFields: result.modelFields,
     };
   }
@@ -146,6 +149,9 @@ function findSectionMetadata(children, models) {
   }
 
   return {
+    attributes: {
+      model: sectionModel.id,
+    },
     modelFields: getModelFieldNames(sectionModel),
   };
 }

package/src/mdast2jcr/hb/partials/image.js

@@ -13,9 +13,16 @@ import Handlebars from 'handlebars';
 import { encodeHtml } from '../../utils.js';
 
 function image(context) {
-  const uniqueName = Handlebars.helpers.nameHelper.call(context, 'image');
   const { alt, url } = context;
 
+  // discard any inline data images
+  if (url.startsWith('data:')) {
+    console.info(`[WARN] Discaring inline data image: ${url}`);
+    return '\n';
+  }
+
+  const uniqueName = Handlebars.helpers.nameHelper.call(context, 'image');
+
   const encoded = encodeHtml(url);
   return `<image${uniqueName} sling:resourceType="core/franklin/components/image/v1/image" 
     jcr:primaryType="nt:unstructured" image="${encoded}" imageAlt="${encodeHtml(alt)}"/>\n`;

package/src/mdast2jcr/hb/partials/supports/image.js

@@ -16,8 +16,10 @@ const image = {
 
   getProperties: (node) => {
     const imageNode = find(node, { type: 'image' });
+
+    // if the image url starts with data: then return an empty string for image url
     return {
-      url: imageNode?.url || '',
+      url: imageNode?.url?.startsWith('data:') ? '' : imageNode?.url || '',
       alt: imageNode?.alt || '',
       label: imageNode?.label || '',
     };