@adobe/helix-md2jcr 1.0.4 → 1.0.6

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [1.0.6](https://github.com/adobe/helix-md2jcr/compare/v1.0.5...v1.0.6) (2025-02-03)
+
+
+### Bug Fixes
+
+* unsupported elements, include all template fields ([#43](https://github.com/adobe/helix-md2jcr/issues/43)) ([4cba7ec](https://github.com/adobe/helix-md2jcr/commit/4cba7ec79aee391a908c680519cf45429cb9bdb8))
+
+## [1.0.5](https://github.com/adobe/helix-md2jcr/compare/v1.0.4...v1.0.5) (2025-01-30)
+
+
+### Bug Fixes
+
+* **sites-28655:** blocks that have no model are missing properties ([#42](https://github.com/adobe/helix-md2jcr/issues/42)) ([7b07416](https://github.com/adobe/helix-md2jcr/commit/7b07416bb0fb691c9cfc1213b8e87362a87980b6))
+
 ## [1.0.4](https://github.com/adobe/helix-md2jcr/compare/v1.0.3...v1.0.4) (2025-01-28)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-md2jcr",
-  "version": "1.0.4",
+  "version": "1.0.6",
   "description": "Helix Service that converts markdown to JCR content structure",
   "main": "src/index.js",
   "type": "module",

package/src/mdast2jcr/domain/Component.js

@@ -52,14 +52,7 @@ class Component {
 
   /* eslint-disable no-unused-vars */
   get defaultFields() {
-    // remove the fields that are listed below, but keep the rest as default fields
-    // to be added to the block
-    const {
-      'key-value': keyValue,
-      ...rest
-    } = this._template;
-
-    return rest;
+    return this._template;
   }
 }
 

package/src/mdast2jcr/{hb/partials/table.js → error/UnsupportedElementError.js}

@@ -1,5 +1,5 @@
 /*
- * Copyright 2024 Adobe. All rights reserved.
+ * Copyright 2025 Adobe. All rights reserved.
  * This file is licensed to you under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License. You may obtain a copy
  * of the License at http://www.apache.org/licenses/LICENSE-2.0
@@ -9,8 +9,9 @@
  * OF ANY KIND, either express or implied. See the License for the specific language
  * governing permissions and limitations under the License.
  */
-function tablePartial() {
-  return '<section></section>\n';
+export class UnsupportedElementError extends Error {
+  constructor(type) {
+    super(`Element '${type}' is currently not supported. Please open an issue for us and describe your use case.`);
+    this.name = 'UnsupportedElementError';
+  }
 }
-
-export default tablePartial;

package/src/mdast2jcr/hb/helpers/which-partial-helper.js

@@ -9,14 +9,17 @@
  * OF ANY KIND, either express or implied. See the License for the specific language
  * governing permissions and limitations under the License.
  */
+
+import Handlebars from 'handlebars';
+
 /**
  * Partial Resolver will return the partial helper that's associated with the
- * type.
+ * type. If no partial is found, it will return the unsupported partial.
  * @param type the type of partial
  * @returns {string} the partial type
  */
 function whichPartialHelper(type) {
-  return type;
+  return Handlebars.partials[type] || Handlebars.partials.unsupported;
 }
 
 export default whichPartialHelper;

package/src/mdast2jcr/hb/partials/grid-table.js

@@ -458,17 +458,17 @@ function gridTablePartial(context) {
   if (model) {
     fieldGroup = modelHelper.getModelFieldGroup(model.id);
     extractProperties(mdast, model, mode, component, fieldGroup.fields, properties);
-
-    // sort all the properties so that they are in a consistent order
-    // helpful for debugging and xml readability
-    const sorted = Object.entries(properties).sort(sortJcrProperties);
-    blockProperties = sorted.map(([k, v]) => `${k}="${v}"`).join(' ');
   } else {
     // because we have no model we expect the block to have a filter with a component that does
     // so that means we can remove the header row from the mdast tree
     remove(mdast, (n) => is(n, { type: 'gtHeader' }));
   }
 
+  // sort all the properties so that they are in a consistent order
+  // helpful for debugging and xml readability
+  const sorted = Object.entries(properties).sort(sortJcrProperties);
+  blockProperties = sorted.map(([k, v]) => `${k}="${v}"`).join(' ');
+
   // *****************************************************
   // Component Block Processing
   // *****************************************************

package/src/mdast2jcr/hb/partials/{blockquote.js → unsupported.js}

@@ -1,5 +1,5 @@
 /*
- * Copyright 2024 Adobe. All rights reserved.
+ * Copyright 2025 Adobe. All rights reserved.
  * This file is licensed to you under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License. You may obtain a copy
  * of the License at http://www.apache.org/licenses/LICENSE-2.0
@@ -9,8 +9,10 @@
  * OF ANY KIND, either express or implied. See the License for the specific language
  * governing permissions and limitations under the License.
  */
-function blockQuotePartial() {
-  return '<section></section>\n';
+import { UnsupportedElementError } from '../../error/UnsupportedElementError.js';
+
+function unsupportedPartial(context) {
+  throw new UnsupportedElementError(context.type);
 }
 
-export default blockQuotePartial;
+export default unsupportedPartial;

package/src/mdast2jcr/index.js

@@ -26,10 +26,9 @@ import imagePartial from './hb/partials/image.js';
 import encodeHelper from './hb/helpers/encode-helper.js';
 import whichPartialHelper from './hb/helpers/which-partial-helper.js';
 import gridTablePartial from './hb/partials/grid-table.js';
-import blockQuotePartial from './hb/partials/blockquote.js';
-import tablePartial from './hb/partials/table.js';
 import pageHelper from './hb/helpers/page-helper.js';
 import pageTemplate from './templates/page-template.js';
+import unsupportedPartial from './hb/partials/unsupported.js';
 
 /**
  * Converts a markdown AST to JCR XML.  This function is the main entry point
@@ -53,8 +52,7 @@ export default async function mdast2jcr(mdast, options = {}) {
   Handlebars.registerPartial('emphasis', emphasisPartial);
   Handlebars.registerPartial('paragraphWrapper', paragraphWrapperPartial);
   Handlebars.registerPartial('gridTable', gridTablePartial);
-  Handlebars.registerPartial('blockquote', blockQuotePartial); // TODO
-  Handlebars.registerPartial('table', tablePartial); // TODO
+  Handlebars.registerPartial('unsupported', unsupportedPartial);
 
   Handlebars.registerHelper('whichPartial', whichPartialHelper);
   Handlebars.registerHelper('encode', encodeHelper);