@adobe/helix-md2jcr 1.0.3 → 1.0.5

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [1.0.5](https://github.com/adobe/helix-md2jcr/compare/v1.0.4...v1.0.5) (2025-01-30)
+
+
+### Bug Fixes
+
+* **sites-28655:** blocks that have no model are missing properties ([#42](https://github.com/adobe/helix-md2jcr/issues/42)) ([7b07416](https://github.com/adobe/helix-md2jcr/commit/7b07416bb0fb691c9cfc1213b8e87362a87980b6))
+
+## [1.0.4](https://github.com/adobe/helix-md2jcr/compare/v1.0.3...v1.0.4) (2025-01-28)
+
+
+### Bug Fixes
+
+* fix typo and silence eslint warning ([#41](https://github.com/adobe/helix-md2jcr/issues/41)) ([b1f9e51](https://github.com/adobe/helix-md2jcr/commit/b1f9e51dc08caef83ab092a4195d2f6a95a26af3))
+
 ## [1.0.3](https://github.com/adobe/helix-md2jcr/compare/v1.0.2...v1.0.3) (2025-01-28)
 
 

package/commitlint.config.js

@@ -0,0 +1,17 @@
+/*
+ * Copyright 2025 Adobe. All rights reserved.
+ * This file is licensed to you under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License. You may obtain a copy
+ * of the License at http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under
+ * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
+ * OF ANY KIND, either express or implied. See the License for the specific language
+ * governing permissions and limitations under the License.
+ */
+export default {
+  extends: ['@commitlint/config-conventional'],
+  rules: {
+    'footer-max-line-length': [0],
+  },
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-md2jcr",
-  "version": "1.0.3",
+  "version": "1.0.5",
   "description": "Helix Service that converts markdown to JCR content structure",
   "main": "src/index.js",
   "type": "module",
@@ -9,7 +9,7 @@
     "lint": "eslint .",
     "semantic-release": "semantic-release",
     "semantic-release-dry": "semantic-release --dry-run --branches $CI_BRANCH",
-    "prepare": "husky install"
+    "prepare": "husky"
   },
   "mocha": {
     "spec": "test/*.test.js",
@@ -56,6 +56,8 @@
   "devDependencies": {
     "@adobe/eslint-config-helix": "2.0.8",
     "@adobe/helix-mediahandler": "2.5.48",
+    "@commitlint/cli": "^19.6.1",
+    "@commitlint/config-conventional": "^19.6.0",
     "@semantic-release/changelog": "6.0.3",
     "@semantic-release/exec": "6.0.3",
     "@semantic-release/git": "10.0.1",
@@ -65,7 +67,7 @@
     "eslint-import-resolver-exports": "1.0.0-beta.5",
     "eslint-plugin-header": "3.1.1",
     "eslint-plugin-import": "2.31.0",
-    "husky": "9.1.7",
+    "husky": "^9.1.7",
     "junit-report-builder": "5.1.1",
     "lint-staged": "15.4.3",
     "mocha": "10.8.2",

package/src/mdast2jcr/hb/partials/grid-table.js

@@ -29,6 +29,8 @@ import image from './supports/image.js';
 import FieldGroupFieldResolver from '../../domain/FieldGroupFieldResolver.js';
 import ModelHelper from '../../domain/ModelHelper.js';
 
+/* eslint-disable no-console */
+
 /**
  * @typedef {import('../../index.d.ts').FieldDef} Field
  * @typedef {import('../../index.d.ts').DefinitionDef} Definition
@@ -250,9 +252,9 @@ function extractProperties(mdast, model, mode, component, fields, properties) {
       extractKeyValueProperties(row, model, fieldResolver, fieldGroup, properties);
     } else {
       // for each cell in the row, process the nodes that exist in the cell
-      let processsing = false;
+      let processing = false;
       for (const cell of cells) {
-        if (mode === 'blockItem' && !processsing) {
+        if (mode === 'blockItem' && !processing) {
           fieldGroup = fieldsCloned.shift();
         }
 
@@ -260,7 +262,7 @@ function extractProperties(mdast, model, mode, component, fields, properties) {
         if (nodes.length === 0) {
           // throw away the field that was associated with the cell
           fieldGroup.fields.shift();
-          processsing = true;
+          processing = true;
           // if there are no nodes in the cell, then we need to skip it
         } else {
           while (nodes.length > 0) {
@@ -456,17 +458,17 @@ function gridTablePartial(context) {
   if (model) {
     fieldGroup = modelHelper.getModelFieldGroup(model.id);
     extractProperties(mdast, model, mode, component, fieldGroup.fields, properties);
-
-    // sort all the properties so that they are in a consistent order
-    // helpful for debugging and xml readability
-    const sorted = Object.entries(properties).sort(sortJcrProperties);
-    blockProperties = sorted.map(([k, v]) => `${k}="${v}"`).join(' ');
   } else {
     // because we have no model we expect the block to have a filter with a component that does
     // so that means we can remove the header row from the mdast tree
     remove(mdast, (n) => is(n, { type: 'gtHeader' }));
   }
 
+  // sort all the properties so that they are in a consistent order
+  // helpful for debugging and xml readability
+  const sorted = Object.entries(properties).sort(sortJcrProperties);
+  blockProperties = sorted.map(([k, v]) => `${k}="${v}"`).join(' ');
+
   // *****************************************************
   // Component Block Processing
   // *****************************************************