@adobe/helix-html-pipeline 6.8.1 → 6.10.0

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [6.10.0](https://github.com/adobe/helix-html-pipeline/compare/v6.9.0...v6.10.0) (2024-04-24)
+
+
+### Features
+
+* support dynamic and configurable robots.txt ([#591](https://github.com/adobe/helix-html-pipeline/issues/591)) ([9796e35](https://github.com/adobe/helix-html-pipeline/commit/9796e35903556ba211010fbabd86b45c90b409e6))
+
+# [6.9.0](https://github.com/adobe/helix-html-pipeline/compare/v6.8.1...v6.9.0) (2024-04-23)
+
+
+### Features
+
+* improve xfh parsing ([#594](https://github.com/adobe/helix-html-pipeline/issues/594)) ([d90a285](https://github.com/adobe/helix-html-pipeline/commit/d90a285a575fa36527e0045271b5f856ce66a932)), closes [#592](https://github.com/adobe/helix-html-pipeline/issues/592)
+
 ## [6.8.1](https://github.com/adobe/helix-html-pipeline/compare/v6.8.0...v6.8.1) (2024-04-18)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-html-pipeline",
-  "version": "6.8.1",
+  "version": "6.10.0",
   "description": "Helix HTML Pipeline",
   "main": "src/index.js",
   "types": "src/index.d.ts",

package/src/index.js

@@ -13,6 +13,7 @@ export * from './html-pipe.js';
 export * from './json-pipe.js';
 export * from './auth-pipe.js';
 export * from './options-pipe.js';
+export * from './robots-pipe.js';
 export * from './sitemap-pipe.js';
 export * from './PipelineContent.js';
 export * from './PipelineRequest.js';

package/src/robots-pipe.js

@@ -0,0 +1,214 @@
+/*
+ * Copyright 2024 Adobe. All rights reserved.
+ * This file is licensed to you under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License. You may obtain a copy
+ * of the License at http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under
+ * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
+ * OF ANY KIND, either express or implied. See the License for the specific language
+ * governing permissions and limitations under the License.
+ */
+import { cleanupHeaderValue, computeSurrogateKey } from '@adobe/helix-shared-utils';
+import fetchContent from './steps/fetch-content.js';
+import renderCode from './steps/render-code.js';
+import setCustomResponseHeaders from './steps/set-custom-response-headers.js';
+import { PipelineStatusError } from './PipelineStatusError.js';
+import { PipelineResponse } from './PipelineResponse.js';
+import initConfig from './steps/init-config.js';
+
+/**
+ * Default robots.txt contents returned on inner/outer CDN.
+ */
+const DEFAULT_ROBOTS = `# Franklin robots.txt FAQ
+#
+# Q: This looks like a default robots.txt, how can I provide my own?
+# A: Put a file named robots.txt into the root of your GitHub
+# repo, Franklin will serve it from there.
+#
+# Q: Why am I'm seeing this robots.txt instead of the one I
+# configured?
+# A: You are visiting from *.aem.page or *.aem.live - in order
+# to prevent these sites from showing up in search engines and
+# giving you a duplicate content penalty on your real site we
+# exclude all robots
+#
+# Q: What do you mean with "real site"?
+# A: If you add a custom domain to this site (e.g.
+# example.com), then Franklin detects that you are ready for
+# production and serves your own robots.txt - but only on
+# example.com
+#
+# Q: This does not answer my questions at all. What can I do?
+# A: head over to #franklin-chat on Slack or
+# github.com/adobe/helix-home/issues and ask your question
+# there.
+User-agent: *
+Disallow: /
+`;
+
+/**
+ * Internal domains suffixes, either inner or outer CDN. Every host that
+ * ends with one of those is considered internal.
+ */
+const INTERNAL_DOMAINS = [
+  '.aem.page',
+  '.aem-fastly.page',
+  '.aem-cloudflare.page',
+  '.aem.live',
+  '.aem-fastly.live',
+  '.aem-cloudflare.live',
+  '.hlx.page',
+  '.hlx-fastly.page',
+  '.hlx-cloudflare.page',
+  '.hlx.live',
+  '.hlx-fastly.live',
+  '.hlx-cloudflare.live',
+];
+
+/**
+ * Hosts that should not be treated as internal.
+ */
+const EXCLUDED_HOSTS = [
+  'www.aem.live',
+];
+
+/**
+ * Generate dynamic robots.txt with production host in the sitemap.
+ *
+ * @param {import('./PipelineState.js').PipelineState} state state
+ * @returns {import('./PipelineResponse.js').PipelineResponse} response
+ */
+function generateRobots(state) {
+  const {
+    prodHost,
+  } = state;
+  const txt = [
+    'User-Agent: *',
+    'Allow: /',
+    '',
+    `Sitemap: https://${prodHost}/sitemap.xml`,
+  ].join('\n');
+  return new PipelineResponse(txt, {
+    status: 200,
+    headers: {
+      'content-type': 'text/plain; charset=utf-8',
+    },
+  });
+}
+
+/**
+ * Return the array of hosts in the `X-Forwarded-Host` request header.
+ *
+ * @param {import('./PipelineRequest.js').PipelineRequest} req request
+ * @returns {Array<String>} array of hosts
+ */
+function getForwardedHosts(req) {
+  const xfh = req.headers.get('x-forwarded-host');
+  if (!xfh) {
+    return [];
+  }
+  return xfh.split(',').map((v) => v.trim()).filter((v) => !!v);
+}
+
+/**
+ * Return the array of surrogate keys to return for a `robots.txt`
+ *
+ * @param {import('./PipelineState.js').PipelineState} state state
+ * @returns {Array<String>} surrogate keys
+ */
+async function computeSurrogateKeys(state) {
+  const keys = [];
+
+  const pathKey = `${state.ref}--${state.repo}--${state.owner}${state.info.path}`;
+  keys.push(await computeSurrogateKey(`${state.site}--${state.org}_config.json`));
+  keys.push(pathKey.replace(/\//g, '_')); // TODO: remove
+  keys.push(await computeSurrogateKey(pathKey));
+  return keys;
+}
+
+/**
+ * Serves or renders the robots.txt.
+ *
+ * @param {PipelineState} state
+ * @param {PipelineRequest} req
+ * @returns {PipelineResponse}
+ */
+export async function robotsPipe(state, req) {
+  const { log } = state;
+  state.type = 'robots';
+
+  if (state.info?.path !== '/robots.txt') {
+    // this should not happen as it would mean that the caller used the wrong route. so we respond
+    // with a 500 to indicate that something is wrong.
+    return new PipelineResponse('', {
+      status: 500,
+      headers: {
+        'x-error': 'invalid route',
+      },
+    });
+  }
+
+  /** @type PipelineResponse */
+  const res = new PipelineResponse('', {
+    headers: {
+      'content-type': 'text/plain; charset=utf-8',
+    },
+  });
+
+  const { partition } = state;
+  const forwardedHosts = getForwardedHosts(req);
+
+  if (partition === 'preview' || forwardedHosts.every(
+    (host) => !EXCLUDED_HOSTS.includes(host)
+      && INTERNAL_DOMAINS.some((domain) => host.endsWith(domain)),
+  )) {
+    // return default robots.txt, vary and no surrogate key
+    res.body = DEFAULT_ROBOTS;
+    res.headers.set('vary', 'x-forwarded-host');
+    return res;
+  }
+
+  try {
+    await initConfig(state, req, res);
+
+    // fetch robots.txt
+    state.timer?.update('content-fetch');
+
+    state.content.sourceBus = 'code';
+    await fetchContent(state, req, res);
+    if (res.status === 404) {
+      const robots = state.config?.robots?.txt;
+      if (robots) {
+        state.content.data = robots;
+      } else {
+        const ret = generateRobots(state);
+        state.content.data = ret.body;
+      }
+      res.headers.set('content-type', 'text/plain; charset=utf-8');
+      res.status = 200;
+      delete res.error;
+    }
+    if (res.error) {
+      // if content loading produced an error, we're done.
+      throw new PipelineStatusError(res.status, res.error);
+    }
+
+    state.timer?.update('serialize');
+    await renderCode(state, req, res);
+
+    // set surrogate keys
+    const keys = await computeSurrogateKeys(state);
+    res.headers.set('x-surrogate-key', keys.join(' '));
+    res.headers.set('vary', 'x-forwarded-host');
+
+    await setCustomResponseHeaders(state, req, res);
+  } catch (e) {
+    res.error = e.message;
+    res.status = e.code || 500;
+
+    log.error(`pipeline status: ${res.status} ${res.error}`);
+    res.headers.set('x-error', cleanupHeaderValue(res.error));
+  }
+  return res;
+}

package/src/sitemap-pipe.js

@@ -66,9 +66,6 @@ async function generateSitemap(state) {
  * Serves or renders the sitemap xml. The sitemap is always served from the preview content-bus
  * partition.
  *
- * todo: currently only serves an existing sitemap.xml from the contentbus.
- *       generate sitemap on the fly based on the sitemap.json
- *
  * @param {PipelineState} state
  * @param {PipelineRequest} req
  * @returns {PipelineResponse}

package/src/steps/utils.js

@@ -24,7 +24,13 @@ const HELIX_URL_REGEXP = /^https:\/\/(?!admin\.|www\.)[^.]+\.(aem|hlx3?)\.(live|
 export function getOriginalHost(headers) {
   const xfh = headers.get('x-forwarded-host');
   if (xfh) {
-    return xfh.split(',')[0].trim();
+    const segs = xfh.split(',');
+    for (const seg of segs) {
+      const host = seg.trim();
+      if (host) {
+        return host;
+      }
+    }
   }
   return headers.get('host');
 }