@adobe/helix-html-pipeline 3.6.2 → 3.6.3

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [3.6.3](https://github.com/adobe/helix-html-pipeline/compare/v3.6.2...v3.6.3) (2022-11-01)
+
+
+### Bug Fixes
+
+* handle errors when loading config ([#180](https://github.com/adobe/helix-html-pipeline/issues/180)) ([f4f4b5f](https://github.com/adobe/helix-html-pipeline/commit/f4f4b5ff4f687331c2ec321e53662519cc428eb6)), closes [#179](https://github.com/adobe/helix-html-pipeline/issues/179)
+
 ## [3.6.2](https://github.com/adobe/helix-html-pipeline/compare/v3.6.1...v3.6.2) (2022-10-31)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-html-pipeline",
-  "version": "3.6.2",
+  "version": "3.6.3",
   "description": "Helix HTML Pipeline",
   "main": "src/index.js",
   "types": "src/index.d.ts",

package/src/json-pipe.js

@@ -9,6 +9,7 @@
  * OF ANY KIND, either express or implied. See the License for the specific language
  * governing permissions and limitations under the License.
  */
+import { cleanupHeaderValue } from '@adobe/helix-shared-utils';
 import fetchConfigAll from './steps/fetch-config-all.js';
 import setCustomResponseHeaders from './steps/set-custom-response-headers.js';
 import { PipelineResponse } from './PipelineResponse.js';
@@ -17,6 +18,7 @@ import { extractLastModified, updateLastModified } from './utils/last-modified.j
 import { authenticate } from './steps/authenticate.js';
 import fetchConfig from './steps/fetch-config.js';
 import { getPathInfo } from './utils/path.js';
+import { PipelineStatusError } from './PipelineStatusError.js';
 
 /**
  * Checks the fstab for folder mapping entries and then re-adjusts the path infos if needed.
@@ -74,48 +76,58 @@ export async function jsonPipe(state, req) {
     });
   }
 
-  // fetch config and apply the folder mapping
-  await fetchConfig(state, req);
-  await folderMapping(state);
+  try {
+    // fetch config and apply the folder mapping
+    await fetchConfig(state, req);
+    await folderMapping(state);
 
-  // fetch data from content bus
-  const { path } = state.info;
-  state.timer?.update('json-fetch');
-  let dataResponse = await s3Loader.getObject('helix-content-bus', `${contentBusId}/${partition}${path}`);
+    // fetch data from content bus
+    const { path } = state.info;
+    state.timer?.update('json-fetch');
+    let dataResponse = await s3Loader.getObject('helix-content-bus', `${contentBusId}/${partition}${path}`);
 
-  // if not found, fall back to code bus
-  if (dataResponse.status === 404) {
-    dataResponse = await s3Loader.getObject('helix-code-bus', `${owner}/${repo}/${ref}${path}`);
-  }
+    // if not found, fall back to code bus
+    if (dataResponse.status === 404) {
+      dataResponse = await s3Loader.getObject('helix-code-bus', `${owner}/${repo}/${ref}${path}`);
+    }
 
-  // if still not found, return status
-  if (dataResponse.status !== 200) {
-    if (dataResponse.status < 500) {
-      await fetchConfigAll(state, req, dataResponse);
-      await setCustomResponseHeaders(state, req, dataResponse);
+    // if still not found, return status
+    if (dataResponse.status !== 200) {
+      if (dataResponse.status < 500) {
+        await fetchConfigAll(state, req, dataResponse);
+        await setCustomResponseHeaders(state, req, dataResponse);
+      }
+      return dataResponse;
     }
-    return dataResponse;
-  }
-  const data = dataResponse.body;
+    const data = dataResponse.body;
 
-  // filter data
-  const response = jsonFilter(state, data, {
-    limit: limit ? Number.parseInt(limit, 10) : undefined,
-    offset: offset ? Number.parseInt(offset, 10) : undefined,
-    sheet,
-    raw: limit === undefined && offset === undefined && sheet === undefined,
-  });
+    // filter data
+    const response = jsonFilter(state, data, {
+      limit: limit ? Number.parseInt(limit, 10) : undefined,
+      offset: offset ? Number.parseInt(offset, 10) : undefined,
+      sheet,
+      raw: limit === undefined && offset === undefined && sheet === undefined,
+    });
 
-  // set last-modified
-  updateLastModified(state, response, extractLastModified(dataResponse.headers));
+    // set last-modified
+    updateLastModified(state, response, extractLastModified(dataResponse.headers));
 
-  // set surrogate key
-  response.headers.set('x-surrogate-key', `${contentBusId}${path}`.replace(/\//g, '_'));
+    // set surrogate key
+    response.headers.set('x-surrogate-key', `${contentBusId}${path}`.replace(/\//g, '_'));
 
-  // Load config-all and set response headers
-  await fetchConfigAll(state, req, response);
-  await authenticate(state, req, response);
-  await setCustomResponseHeaders(state, req, response);
+    // Load config-all and set response headers
+    await fetchConfigAll(state, req, response);
+    await authenticate(state, req, response);
+    await setCustomResponseHeaders(state, req, response);
 
-  return response;
+    return response;
+  } catch (e) {
+    const res = new PipelineResponse('', {
+      status: e instanceof PipelineStatusError ? e.code : 500,
+    });
+    const level = res.status >= 500 ? 'error' : 'info';
+    log[level](`pipeline status: ${res.status} ${e.message}`, e);
+    res.headers.set('x-error', cleanupHeaderValue(e.message));
+    return res;
+  }
 }

package/src/steps/authenticate.js

@@ -72,7 +72,8 @@ export async function authenticate(state, req, res) {
     res.error = 'forbidden.';
   }
 
-  // set some response headers
+  // set some response headers for deferred edge authentication
+  // AdobePatentID="P11443-US"
   res.headers.set('x-hlx-auth-allow', allows.join(','));
   if (authInfo.profile) {
     res.headers.set('x-hlx-auth-iss', authInfo.profile.iss);

package/test/StaticS3Loader.js

@@ -34,6 +34,11 @@ export class StaticS3Loader {
       body: '',
       headers: new Map(),
     };
+    if (response instanceof Error) {
+      // eslint-disable-next-line no-console
+      console.log(`StaticS3Loader: failing ${bucketId}/${key} -> ${response.message}`);
+      throw response;
+    }
     // eslint-disable-next-line no-console
     console.log(`StaticS3Loader: loading ${bucketId}/${key} -> ${response.status}`);
     return response;