@adobe/helix-deploy 9.0.1 → 9.0.3

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [9.0.3](https://github.com/adobe/helix-deploy/compare/v9.0.2...v9.0.3) (2023-02-02)
+
+
+### Bug Fixes
+
+* wait for close ([#499](https://github.com/adobe/helix-deploy/issues/499)) ([676a04e](https://github.com/adobe/helix-deploy/commit/676a04ec19d494b80f029720a7280c0f20f38b3f))
+
+## [9.0.2](https://github.com/adobe/helix-deploy/compare/v9.0.1...v9.0.2) (2023-02-02)
+
+
+### Bug Fixes
+
+* close clients on destroy ([#498](https://github.com/adobe/helix-deploy/issues/498)) ([b30404d](https://github.com/adobe/helix-deploy/commit/b30404de570783f0aae8af8ee0bebdecfacda20b))
+
 ## [9.0.1](https://github.com/adobe/helix-deploy/compare/v9.0.0...v9.0.1) (2023-01-31)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adobe/helix-deploy",
-  "version": "9.0.1",
+  "version": "9.0.3",
   "description": "Library and Commandline Tools to build and deploy OpenWhisk Actions",
   "license": "Apache-2.0",
   "homepage": "https://github.com/adobe/helix-deploy#readme",

package/src/ActionBuilder.js

@@ -356,9 +356,9 @@ export default class ActionBuilder {
     return this.execute('cleanup', '');
   }
 
-  close() {
+  async close() {
     if (this.validated) {
-      Object.values(this._deployers).forEach((dep) => dep.close());
+      await Promise.allSettled(Object.values(this._deployers).map((dep) => dep.close()));
     }
   }
 
@@ -366,7 +366,7 @@ export default class ActionBuilder {
     try {
       return await this._run();
     } finally {
-      this.close();
+      await this.close();
     }
   }
 

package/src/deploy/AWSDeployer.js

@@ -155,12 +155,18 @@ export default class AWSDeployer extends BaseDeployer {
   }
 
   async initAccountId() {
-    const sts = new STSClient({
-      region: this._cfg.region,
-    });
-    const ret = await sts.send(new GetCallerIdentityCommand());
-    this._accountId = ret.Account;
-    this.log.info(chalk`{green ok:} initialized AWS deployer for account {yellow ${ret.Account}}`);
+    let sts;
+
+    try {
+      sts = new STSClient({
+        region: this._cfg.region,
+      });
+      const ret = await sts.send(new GetCallerIdentityCommand());
+      this._accountId = ret.Account;
+      this.log.info(chalk`{green ok:} initialized AWS deployer for account {yellow ${ret.Account}}`);
+    } finally {
+      sts.destroy();
+    }
   }
 
   async uploadZIP() {
@@ -874,6 +880,16 @@ export default class AWSDeployer extends BaseDeployer {
       throw err;
     }
   }
+
+  async close() {
+    this._s3?.destroy();
+    this._lambda?.destroy();
+    this._api?.destroy();
+    this._ssm?.destroy();
+    this._sm?.destroy();
+
+    await super.close();
+  }
 }
 
 AWSDeployer.Config = AWSConfig;

package/src/deploy/BaseDeployer.js

@@ -55,8 +55,8 @@ export default class BaseDeployer {
     }
   }
 
-  close() {
-    this.resetFetchContext();
+  async close() {
+    await this.resetFetchContext();
   }
 
   get fetch() {